s3: libsmbclient: Finish unifing bad iconv behavior across CORE NT1 SMB2 protocols.

On bad name conversion, exit the directory listing with an error, but leave the
connection intact. We were already checking for finfo->name == NULL here,
but were ignoring it and not reporting an error.

Remove the knownfail.d/bad_iconv file as we now
behave the same across CORE/NT1/SMB2.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14374

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue May 12 21:32:44 UTC 2020 on sn-devel-184

diff --git a/selftest/knownfail.d/bad_iconv b/selftest/knownfail.d/bad_iconv
deleted file mode 100644 (file)
index c45022f..0000000
--- a/selftest/knownfail.d/bad_iconv
+++ /dev/null
@@ -1,2 +0,0 @@
-samba3.blackbox.smbclient_iconv.NT1
-

diff --git a/source3/libsmb/clilist.c b/source3/libsmb/clilist.c
index 28449dec81c7912806a1733232f1d5472f283151..f9444bc401c89ff6093600b046c8ec900cf6c7e8 100644 (file)
--- a/source3/libsmb/clilist.c
+++ b/source3/libsmb/clilist.c
@@ -794,8 +794,9 @@ static void cli_list_trans_done(struct tevent_req *subreq)
                if (finfo->name == NULL) {
                        DEBUG(1, ("cli_list: Error: unable to parse name from "
                                  "info level %d\n", state->info_level));
-                       ff_eos = true;
-                       break;
+                       tevent_req_nterror(req,
+                               NT_STATUS_INVALID_NETWORK_RESPONSE);
+                       return;
                }
 
                status = is_bad_finfo_name(state->cli, finfo);