s4:drsuapi: avoid a ldb_dn_copy() and use talloc_move() instead
authorStefan Metzmacher <metze@samba.org>
Tue, 18 Dec 2012 11:44:43 +0000 (12:44 +0100)
committerStefan Metzmacher <metze@samba.org>
Tue, 1 Jan 2013 18:28:07 +0000 (19:28 +0100)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/rpc_server/drsuapi/getncchanges.c

index b7b488c2e3bcb37d959b9f99a938253e21e73e19..7ed47f13cab7d2245fbf2113400920ef750696ed 100644 (file)
@@ -1889,11 +1889,11 @@ allowed:
                *currentObject = obj;
                currentObject = &obj->next_object;
 
-               talloc_free(getnc_state->last_dn);
-               getnc_state->last_dn = ldb_dn_copy(getnc_state, msg->dn);
-
                DEBUG(8,(__location__ ": replicating object %s\n", ldb_dn_get_linearized(msg->dn)));
 
+               talloc_free(getnc_state->last_dn);
+               getnc_state->last_dn = talloc_move(getnc_state, &msg->dn);
+
                talloc_free(msg_res);
                talloc_free(msg_dn);
        }