s3-printing: Fix double free of cups request.
authorGünther Deschner <gd@samba.org>
Tue, 10 May 2011 13:49:05 +0000 (15:49 +0200)
committerGünther Deschner <gd@samba.org>
Tue, 10 May 2011 15:32:58 +0000 (17:32 +0200)
We never free the request in our cups api usage except for here. The reason is
probably htis (from the cupsDoConnect API docs):

"This function sends the IPP request to the specified server, retrying and
authenticating as necessary. The request is freed with ippDelete() after
receiving a valid IPP response."

Revert "Fix a memory leak in cups_pull_comment_location"

This reverts commit fee2664dad37536b05ce8bdae3e74d45b257f632.

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue May 10 17:32:58 CEST 2011 on sn-devel-104

source3/printing/print_cups.c

index 5ef44647fd3e5ccb417698b25f3122d346bef802..ea2fc1d7c4983397fb934994b8e5c31d21b3ee5d 100644 (file)
@@ -1731,10 +1731,6 @@ bool cups_pull_comment_location(TALLOC_CTX *mem_ctx,
        if (response)
                ippDelete(response);
 
-       if (request) {
-               ippDelete(request);
-       }
-
        if (language)
                cupsLangFree(language);