s4 dsdb: fix use after free in samldb_rename_search_base_callback
authorGary Lockyer <gary@catalyst.net.nz>
Tue, 14 May 2019 01:10:22 +0000 (13:10 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 14 May 2019 06:07:25 +0000 (06:07 +0000)
commitb0cc6d217485c317b2138347216fac5d74684328
tree0dd2a8b9a67ba3fd2d3d761d5fd58ccc7757a0dc
parentc75fbeaa96108cd4dc193ef5f4170977804e5104
s4 dsdb: fix use after free in samldb_rename_search_base_callback

Fix use after free detected by AddressSanitizer

AddressSanitizer: heap-use-after-free on address 0x60f0002b2738
                  at pc 0x7f89b1a213b5 bp 0x7ffce9528810 sp 0x7ffce9528800
                  READ of size 8 at 0x60f0002b2738 thread T0
    #0 0x7f89b1a213b4 in samldb_rename_search_base_callback
        ../../source4/dsdb/samdb/ldb_modules/samldb.c:4203
    #1 0x7f89d3a0db4a in ldb_module_send_entry
        ../../lib/ldb/common/ldb_modules.c:793
    #2 0x7f89b6f27356 in es_callback
        ../../source4/dsdb/samdb/ldb_modules/encrypted_secrets.c:1418

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13942

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/dsdb/samdb/ldb_modules/samldb.c