wafsamba/symbols: always split Popen output by bytes
authorJoe Guo <joeg@catalyst.net.nz>
Thu, 14 Feb 2019 22:23:17 +0000 (11:23 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Mon, 18 Feb 2019 08:25:21 +0000 (09:25 +0100)
commit4843a27bbc2f2017314ad9508d61ac4c44330e77
tree9d2255d4a031095b618b61661eb1893bec624520
parent8fc04d2ce314bd246eeac1b8aad2fa1c98049c37
wafsamba/symbols: always split Popen output by bytes

In py3, `wafsamba.duplicate_symbols` test may fail:

    ...
    elfpipe = subprocess.Popen(['readelf', '--dynamic', binname], stdout=subprocess.PIPE).stdout
    ...

    File "./buildtools/wafsamba/symbols.py", line 153, in get_libs
        rpath.extend(m.group(1).split(":"))
    TypeError: a bytes-like object is required, not 'str'

Because Popen will always return bytestr even in py3, and ":" is a
unicode str in py3.  Change ":" to b":" to fix.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
buildtools/wafsamba/symbols.py