group_audit: Ensure we still log membership changes (with an error) where status...
authorAndrew Bartlett <abartlet@samba.org>
Fri, 21 Dec 2018 01:51:54 +0000 (14:51 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Sat, 22 Dec 2018 00:58:48 +0000 (01:58 +0100)
commit42dde0bdd3af8aaa6350fec36fb99b98ab501aa1
tree80d56cae7d6dcbcbc15ac654b7793d9a3d12cb56
parent27273a55dd0634db9324c74a73b80a1989a64372
group_audit: Ensure we still log membership changes (with an error) where status != LDB_SUCCESS

This restores the previous behaviour.  It causes (only) the event ID
to be omitted if status != LDB_SUCCESS or there was a problem getting
the group type.

Errors at this stage are exceedingly rare, because the values have
already been checked by the repl_meta_data module, but this is
cosistent with the rest of the module again.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Dec 22 01:58:48 CET 2018 on sn-devel-144
source4/dsdb/samdb/ldb_modules/group_audit.c