s4:libcli: Fix error in smbcli_deltree()
authorTim Beale <timbeale@catalyst.net.nz>
Thu, 6 Dec 2018 03:03:23 +0000 (16:03 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Wed, 12 Dec 2018 03:38:13 +0000 (04:38 +0100)
commit31d4f692ad94cc5dfb82433cf6e3bd82ff805a4a
treed5759a568c0d478062b6c3124fc5bd8b13057dec
parentda30c824b8240e92ad4bcdcd174d56c39235412e
s4:libcli: Fix error in smbcli_deltree()

Commit 094afe614b6282 fixed an uninitialized variable, which meant we
tried to delete the file twice. The 2nd time fails, so the function
returns an error, instead of success (even though the file is now gone).

Note we want to be using the source3 SMB library code going forward.
However, fixing this bug makes it easier to write tests against the
(currently s4) SMB python bindings.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/libcli/clideltree.c