s4-torture: ran minimal_includes.pl over source4/torture
[gd/samba-autobuild/.git] / source4 / torture / libnet / libnet_BecomeDC.c
index 5338d480bcfe26d97e5b01cd82c0e32514d5ab93..e1c4b751af1d1ae7297ab5518859d81c72faf62d 100644 (file)
 
 #include "includes.h"
 #include "lib/cmdline/popt_common.h"
-#include "torture/torture.h"
 #include "torture/rpc/rpc.h"
 #include "libnet/libnet.h"
-#include "lib/events/events.h"
 #include "dsdb/samdb/samdb.h"
-#include "lib/util/dlinklist.h"
-#include "lib/ldb/include/ldb.h"
-#include "lib/ldb/include/ldb_errors.h"
-#include "librpc/ndr/libndr.h"
+#include "../lib/util/dlinklist.h"
 #include "librpc/gen_ndr/ndr_drsuapi.h"
 #include "librpc/gen_ndr/ndr_drsblobs.h"
-#include "librpc/gen_ndr/ndr_misc.h"
 #include "system/time.h"
+#include "lib/ldb_wrap.h"
 #include "auth/auth.h"
-#include "lib/db_wrap.h"
-#include "lib/appweb/ejs/ejs.h"
-#include "lib/appweb/ejs/ejsInternal.h"
-#include "scripting/ejs/smbcalls.h"
-
-static EjsId eid;
-static int ejs_error;
-
-static void test_ejs_exception(const char *reason)
-{
-       Ejs *ep = ejsPtr(eid);
-       ejsSetErrorMsg(eid, "%s", reason);
-       fprintf(stderr, "%s", ep->error);
-       ejs_error = 127;
-}
-
-static int test_run_ejs(char *script)
-{
-       EjsHandle handle = 0;
-       MprVar result;
-       char *emsg;
-       TALLOC_CTX *mem_ctx = talloc_new(NULL);
-       struct MprVar *return_var;
-
-       mprSetCtx(mem_ctx);
-
-       if (ejsOpen(NULL, NULL, NULL) != 0) {
-               d_printf("ejsOpen(): unable to initialise EJS subsystem\n");
-               ejs_error = 127;
-               goto failed;
-       }
-
-       smb_setup_ejs_functions(test_ejs_exception);
-
-       if ((eid = ejsOpenEngine(handle, 0)) == (EjsId)-1) {
-               d_printf("smbscript: ejsOpenEngine(): unable to initialise an EJS engine\n");
-               ejs_error = 127;
-               goto failed;
-       }
-
-       mprSetVar(ejsGetGlobalObject(eid), "ARGV", mprList("ARGV", NULL));
-
-       /* run the script */
-       if (ejsEvalScript(eid, script, &result, &emsg) == -1) {
-               d_printf("smbscript: ejsEvalScript(): %s\n", emsg);
-               if (ejs_error == 0) ejs_error = 127;
-               goto failed;
-       }
-
-       return_var = ejsGetReturnValue(eid);
-       ejs_error = mprVarToNumber(return_var);
-
-failed:
-       ejsClose();
-       talloc_free(mem_ctx);
-       return ejs_error;
-}
+#include "param/param.h"
+#include "param/provision.h"
 
 struct test_become_dc_state {
        struct libnet_context *ctx;
+       struct torture_context *tctx;
        const char *netbios_name;
        struct test_join *tj;
        struct cli_credentials *machine_account;
@@ -109,16 +50,43 @@ struct test_become_dc_state {
                struct drsuapi_DsReplicaObjectListItemEx *last_object;
        } schema_part;
 
-       struct {
-               const char *samdb_ldb;
-               const char *domaindn_ldb;
-               const char *configdn_ldb;
-               const char *schemadn_ldb;
-               const char *secrets_ldb;
-               const char *secrets_keytab;
-       } path;
+       const char *targetdir;
+
+       struct loadparm_context *lp_ctx;
 };
 
+static NTSTATUS test_become_dc_prepare_db(void *private_data,
+                                             const struct libnet_BecomeDC_PrepareDB *p)
+{
+       struct test_become_dc_state *s = talloc_get_type(private_data, struct test_become_dc_state);
+       struct provision_settings settings;
+       struct provision_result result;
+       NTSTATUS status;
+
+       settings.site_name = p->dest_dsa->site_name;
+       settings.root_dn_str = p->forest->root_dn_str;
+       settings.domain_dn_str = p->domain->dn_str;
+       settings.config_dn_str = p->forest->config_dn_str;
+       settings.schema_dn_str = p->forest->schema_dn_str;
+       settings.server_dn_str = torture_join_server_dn_str(s->tj);
+       settings.invocation_id = &p->dest_dsa->invocation_id;
+       settings.netbios_name = p->dest_dsa->netbios_name;
+       settings.host_ip = NULL;
+       settings.realm = torture_join_dom_dns_name(s->tj);
+       settings.domain = torture_join_dom_netbios_name(s->tj);
+       settings.ntds_dn_str = p->dest_dsa->ntds_dn_str;
+       settings.machine_password = cli_credentials_get_password(s->machine_account);
+       settings.targetdir = s->targetdir;
+
+       status = provision_bare(s, s->lp_ctx, &settings, &result);
+       
+       s->ldb = result.samdb;
+       s->lp_ctx = result.lp_ctx;
+        return NT_STATUS_OK;
+
+
+}
+
 static NTSTATUS test_become_dc_check_options(void *private_data,
                                             const struct libnet_BecomeDC_CheckOptions *o)
 {
@@ -143,148 +111,11 @@ static NTSTATUS test_become_dc_check_options(void *private_data,
        return NT_STATUS_OK;
 }
 
-static NTSTATUS test_become_dc_prepare_db(void *private_data,
-                                         const struct libnet_BecomeDC_PrepareDB *p)
-{
-       struct test_become_dc_state *s = talloc_get_type(private_data, struct test_become_dc_state);
-       char *ejs;
-       int ret;
-       bool ok;
-
-       DEBUG(0,("New Server[%s] in Site[%s]\n",
-               p->dest_dsa->dns_name, p->dest_dsa->site_name));
-
-       DEBUG(0,("DSA Instance [%s]\n"
-               "\tobjectGUID[%s]\n"
-               "\tinvocationId[%s]\n",
-               p->dest_dsa->ntds_dn_str,
-               GUID_string(s, &p->dest_dsa->ntds_guid),
-               GUID_string(s, &p->dest_dsa->invocation_id)));
-
-       DEBUG(0,("Pathes under PRIVATEDIR[%s]\n"
-                "SAMDB[%s] SECRETS[%s] KEYTAB[%s]\n",
-               lp_private_dir(global_loadparm),
-               s->path.samdb_ldb,
-               s->path.secrets_ldb,
-               s->path.secrets_keytab));
-
-       DEBUG(0,("Schema Partition[%s => %s]\n",
-               p->forest->schema_dn_str, s->path.schemadn_ldb));
-
-       DEBUG(0,("Config Partition[%s => %s]\n",
-               p->forest->config_dn_str, s->path.configdn_ldb));
-
-       DEBUG(0,("Domain Partition[%s => %s]\n",
-               p->domain->dn_str, s->path.domaindn_ldb));
-
-       ejs = talloc_asprintf(s,
-               "libinclude(\"base.js\");\n"
-               "libinclude(\"provision.js\");\n"
-               "\n"
-               "function message() { print(vsprintf(arguments)); }\n"
-               "\n"
-               "var subobj = provision_guess();\n"
-               "subobj.ROOTDN       = \"%s\";\n"
-               "subobj.DOMAINDN     = \"%s\";\n"
-               "subobj.DOMAINDN_LDB = \"%s\";\n"
-               "subobj.CONFIGDN     = \"%s\";\n"
-               "subobj.CONFIGDN_LDB = \"%s\";\n"
-               "subobj.SCHEMADN     = \"%s\";\n"
-               "subobj.SCHEMADN_LDB = \"%s\";\n"
-               "subobj.HOSTNAME     = \"%s\";\n"
-               "subobj.DNSNAME      = \"%s\";\n"
-               "subobj.DEFAULTSITE  = \"%s\";\n"
-               "\n"
-               "modules_list        = new Array(\"rootdse\",\n"
-               "                                \"kludge_acl\",\n"
-               "                                \"paged_results\",\n"
-               "                                \"server_sort\",\n"
-               "                                \"extended_dn\",\n"
-               "                                \"asq\",\n"
-               "                                \"samldb\",\n"
-               "                                \"operational\",\n"
-               "                                \"objectclass\",\n"
-               "                                \"rdn_name\",\n"
-               "                                \"show_deleted\",\n"
-               "                                \"partition\");\n"
-               "subobj.MODULES_LIST = join(\",\", modules_list);\n"
-               "subobj.DOMAINDN_MOD = \"pdc_fsmo,password_hash,repl_meta_data\";\n"
-               "subobj.CONFIGDN_MOD = \"naming_fsmo,repl_meta_data\";\n"
-               "subobj.SCHEMADN_MOD = \"schema_fsmo,repl_meta_data\";\n"
-               "\n"
-               "subobj.KRBTGTPASS   = \"_NOT_USED_\";\n"
-               "subobj.MACHINEPASS  = \"%s\";\n"
-               "subobj.ADMINPASS    = \"_NOT_USED_\";\n"
-               "\n"
-               "var paths = provision_default_paths(subobj);\n"
-               "paths.samdb = \"%s\";\n"
-               "paths.secrets = \"%s\";\n"
-               "paths.keytab = \"%s\";\n"
-               "\n"
-               "var system_session = system_session();\n"
-               "\n"
-               "var ok = provision_become_dc(subobj, message, true, paths, system_session);\n"
-               "assert(ok);\n"
-               "\n"
-               "return 0;\n",
-               p->forest->root_dn_str,         /* subobj.ROOTDN */
-               p->domain->dn_str,              /* subobj.DOMAINDN */
-               s->path.domaindn_ldb,           /* subobj.DOMAINDN_LDB */
-               p->forest->config_dn_str,       /* subobj.CONFIGDN */
-               s->path.configdn_ldb,           /* subobj.CONFIGDN_LDB */
-               p->forest->schema_dn_str,       /* subobj.SCHEMADN */
-               s->path.schemadn_ldb,           /* subobj.SCHEMADN_LDB */
-               p->dest_dsa->netbios_name,      /* subobj.HOSTNAME */
-               p->dest_dsa->dns_name,          /* subobj.DNSNAME */
-               p->dest_dsa->site_name,         /* subobj.DEFAULTSITE */
-               cli_credentials_get_password(s->machine_account),/* subobj.MACHINEPASS */
-               s->path.samdb_ldb,              /* paths.samdb */
-               s->path.secrets_ldb,            /* paths.secrets */
-               s->path.secrets_keytab);        /* paths.keytab */
-       NT_STATUS_HAVE_NO_MEMORY(ejs);
-
-       ret = test_run_ejs(ejs);
-       if (ret != 0) {
-               DEBUG(0,("Failed to run ejs script: %d:\n%s",
-                       ret, ejs));
-               talloc_free(ejs);
-               return NT_STATUS_FOOBAR;
-       }
-       talloc_free(ejs);
-
-       talloc_free(s->ldb);
-
-       DEBUG(0,("Open the SAM LDB with system credentials: %s\n", s->path.samdb_ldb));
-
-       s->ldb = ldb_wrap_connect(s, s->path.samdb_ldb,
-                                 system_session(s),
-                                 NULL, 0, NULL);
-       if (!s->ldb) {
-               DEBUG(0,("Failed to open '%s'\n",
-                       s->path.samdb_ldb));
-               return NT_STATUS_INTERNAL_DB_ERROR;
-       }
-
-       ok = samdb_set_ntds_invocation_id(s->ldb, &p->dest_dsa->invocation_id);
-       if (!ok) {
-               DEBUG(0,("Failed to set cached ntds invocationId\n"));
-               return NT_STATUS_FOOBAR;
-       }
-       ok = samdb_set_ntds_objectGUID(s->ldb, &p->dest_dsa->ntds_guid);
-       if (!ok) {
-               DEBUG(0,("Failed to set cached ntds objectGUID\n"));
-               return NT_STATUS_FOOBAR;
-       }
-
-       return NT_STATUS_OK;
-}
-
 static NTSTATUS test_apply_schema(struct test_become_dc_state *s,
                                  const struct libnet_BecomeDC_StoreChunk *c)
 {
        WERROR status;
        const struct drsuapi_DsReplicaOIDMapping_Ctr *mapping_ctr;
-       uint32_t total_object_count;
        uint32_t object_count;
        struct drsuapi_DsReplicaObjectListItemEx *first_object;
        struct drsuapi_DsReplicaObjectListItemEx *cur;
@@ -298,9 +129,11 @@ static NTSTATUS test_apply_schema(struct test_become_dc_state *s,
        struct ldb_val prefixMap_val;
        struct ldb_message_element *prefixMap_el;
        struct ldb_val schemaInfo_val;
+       char *sam_ldb_path;
        uint32_t i;
        int ret;
        bool ok;
+       uint64_t seq_num;
 
        DEBUG(0,("Analyze and apply schema objects\n"));
 
@@ -312,7 +145,6 @@ static NTSTATUS test_apply_schema(struct test_become_dc_state *s,
        switch (c->ctr_level) {
        case 1:
                mapping_ctr                     = &c->ctr1->mapping_ctr;
-               total_object_count              = c->ctr1->total_object_count;
                object_count                    = s->schema_part.object_count;
                first_object                    = s->schema_part.first_object;
                linked_attributes_count         = 0;
@@ -324,7 +156,6 @@ static NTSTATUS test_apply_schema(struct test_become_dc_state *s,
                break;
        case 6:
                mapping_ctr                     = &c->ctr6->mapping_ctr;
-               total_object_count              = c->ctr6->total_object_count;
                object_count                    = s->schema_part.object_count;
                first_object                    = s->schema_part.first_object;
                linked_attributes_count         = 0; /* TODO: ! */
@@ -394,7 +225,7 @@ static NTSTATUS test_apply_schema(struct test_become_dc_state *s,
                        sa = talloc_zero(s->self_made_schema, struct dsdb_attribute);
                        NT_STATUS_HAVE_NO_MEMORY(sa);
 
-                       status = dsdb_attribute_from_drsuapi(s->self_made_schema, &cur->object, s, sa);
+                       status = dsdb_attribute_from_drsuapi(s->ldb, s->self_made_schema, &cur->object, s, sa);
                        if (!W_ERROR_IS_OK(status)) {
                                return werror_to_ntstatus(status);
                        }
@@ -436,13 +267,13 @@ static NTSTATUS test_apply_schema(struct test_become_dc_state *s,
                                                         s_dsa,
                                                         uptodateness_vector,
                                                         c->gensec_skey,
-                                                        s, &objs);
+                                                        s, &objs, &seq_num);
        if (!W_ERROR_IS_OK(status)) {
                DEBUG(0,("Failed to commit objects: %s\n", win_errstr(status)));
                return werror_to_ntstatus(status);
        }
 
-       if (lp_parm_bool(NULL, "become dc", "dump objects", false)) {
+       if (lp_parm_bool(s->tctx->lp_ctx, NULL, "become dc", "dump objects", false)) {
                for (i=0; i < objs->num_objects; i++) {
                        struct ldb_ldif ldif;
                        fprintf(stdout, "#\n");
@@ -483,13 +314,14 @@ static NTSTATUS test_apply_schema(struct test_become_dc_state *s,
        talloc_free(s->ldb); /* this also free's the s->schema, because dsdb_set_schema() steals it */
        s->schema = NULL;
 
-       DEBUG(0,("Reopen the SAM LDB with system credentials and a already stored schema: %s\n", s->path.samdb_ldb));
-       s->ldb = ldb_wrap_connect(s, s->path.samdb_ldb,
-                                 system_session(s),
+       sam_ldb_path = talloc_asprintf(s, "%s/%s", s->targetdir, "private/sam.ldb");
+       DEBUG(0,("Reopen the SAM LDB with system credentials and a already stored schema: %s\n", sam_ldb_path));
+       s->ldb = ldb_wrap_connect(s, s->tctx->ev, s->tctx->lp_ctx, sam_ldb_path,
+                                 system_session(s, s->tctx->lp_ctx),
                                  NULL, 0, NULL);
        if (!s->ldb) {
                DEBUG(0,("Failed to open '%s'\n",
-                       s->path.samdb_ldb));
+                       sam_ldb_path));
                return NT_STATUS_INTERNAL_DB_ERROR;
        }
 
@@ -519,38 +351,46 @@ static NTSTATUS test_become_dc_schema_chunk(void *private_data,
        struct test_become_dc_state *s = talloc_get_type(private_data, struct test_become_dc_state);
        WERROR status;
        const struct drsuapi_DsReplicaOIDMapping_Ctr *mapping_ctr;
-       uint32_t total_object_count;
+       uint32_t nc_object_count;
        uint32_t object_count;
        struct drsuapi_DsReplicaObjectListItemEx *first_object;
        struct drsuapi_DsReplicaObjectListItemEx *cur;
+       uint32_t nc_linked_attributes_count;
+       uint32_t linked_attributes_count;
 
        switch (c->ctr_level) {
        case 1:
-               mapping_ctr             = &c->ctr1->mapping_ctr;
-               total_object_count      = c->ctr1->total_object_count;
-               object_count            = c->ctr1->object_count;
-               first_object            = c->ctr1->first_object;
+               mapping_ctr                     = &c->ctr1->mapping_ctr;
+               nc_object_count                 = c->ctr1->extended_ret; /* maybe w2k send this unexpected? */
+               object_count                    = c->ctr1->object_count;
+               first_object                    = c->ctr1->first_object;
+               nc_linked_attributes_count      = 0;
+               linked_attributes_count         = 0;
                break;
        case 6:
-               mapping_ctr             = &c->ctr6->mapping_ctr;
-               total_object_count      = c->ctr6->total_object_count;
-               object_count            = c->ctr6->object_count;
-               first_object            = c->ctr6->first_object;
+               mapping_ctr                     = &c->ctr6->mapping_ctr;
+               nc_object_count                 = c->ctr6->nc_object_count;
+               object_count                    = c->ctr6->object_count;
+               first_object                    = c->ctr6->first_object;
+               nc_linked_attributes_count      = c->ctr6->nc_linked_attributes_count;
+               linked_attributes_count         = c->ctr6->linked_attributes_count;
                break;
        default:
                return NT_STATUS_INVALID_PARAMETER;
        }
 
-       if (total_object_count) {
-               DEBUG(0,("Schema-DN[%s] objects[%u/%u]\n",
-                       c->partition->nc.dn, object_count, total_object_count));
+       if (nc_object_count) {
+               DEBUG(0,("Schema-DN[%s] objects[%u/%u] linked_values[%u/%u]\n",
+                       c->partition->nc.dn, object_count, nc_object_count,
+                       linked_attributes_count, nc_linked_attributes_count));
        } else {
-               DEBUG(0,("Schema-DN[%s] objects[%u]\n",
-               c->partition->nc.dn, object_count));
+               DEBUG(0,("Schema-DN[%s] objects[%u] linked_values[%u\n",
+               c->partition->nc.dn, object_count, linked_attributes_count));
        }
 
        if (!s->schema) {
-               s->self_made_schema = talloc_zero(s, struct dsdb_schema);
+               s->self_made_schema = dsdb_new_schema(s, lp_iconv_convenience(s->lp_ctx));
+
                NT_STATUS_HAVE_NO_MEMORY(s->self_made_schema);
 
                status = dsdb_load_oid_mappings_drsuapi(s->self_made_schema, mapping_ctr);
@@ -577,7 +417,7 @@ static NTSTATUS test_become_dc_schema_chunk(void *private_data,
        for (cur = first_object; cur->next_object; cur = cur->next_object) {}
        s->schema_part.last_object = cur;
 
-       if (c->partition->highwatermark.tmp_highest_usn == c->partition->highwatermark.highest_usn) {
+       if (!c->partition->more_data) {
                return test_apply_schema(s, c);
        }
 
@@ -590,9 +430,10 @@ static NTSTATUS test_become_dc_store_chunk(void *private_data,
        struct test_become_dc_state *s = talloc_get_type(private_data, struct test_become_dc_state);
        WERROR status;
        const struct drsuapi_DsReplicaOIDMapping_Ctr *mapping_ctr;
-       uint32_t total_object_count;
+       uint32_t nc_object_count;
        uint32_t object_count;
        struct drsuapi_DsReplicaObjectListItemEx *first_object;
+       uint32_t nc_linked_attributes_count;
        uint32_t linked_attributes_count;
        struct drsuapi_DsReplicaLinkedAttribute *linked_attributes;
        const struct drsuapi_DsReplicaCursor2CtrEx *uptodateness_vector;
@@ -600,6 +441,7 @@ static NTSTATUS test_become_dc_store_chunk(void *private_data,
        struct repsFromTo1 *s_dsa;
        char *tmp_dns_name;
        uint32_t i;
+       uint64_t seq_num;
 
        s_dsa                   = talloc_zero(s, struct repsFromTo1);
        NT_STATUS_HAVE_NO_MEMORY(s_dsa);
@@ -609,9 +451,10 @@ static NTSTATUS test_become_dc_store_chunk(void *private_data,
        switch (c->ctr_level) {
        case 1:
                mapping_ctr                     = &c->ctr1->mapping_ctr;
-               total_object_count              = c->ctr1->total_object_count;
+               nc_object_count                 = c->ctr1->extended_ret; /* maybe w2k send this unexpected? */
                object_count                    = c->ctr1->object_count;
                first_object                    = c->ctr1->first_object;
+               nc_linked_attributes_count      = 0;
                linked_attributes_count         = 0;
                linked_attributes               = NULL;
                s_dsa->highwatermark            = c->ctr1->new_highwatermark;
@@ -621,9 +464,10 @@ static NTSTATUS test_become_dc_store_chunk(void *private_data,
                break;
        case 6:
                mapping_ctr                     = &c->ctr6->mapping_ctr;
-               total_object_count              = c->ctr6->total_object_count;
+               nc_object_count                 = c->ctr6->nc_object_count;
                object_count                    = c->ctr6->object_count;
                first_object                    = c->ctr6->first_object;
+               nc_linked_attributes_count      = c->ctr6->nc_linked_attributes_count;
                linked_attributes_count         = c->ctr6->linked_attributes_count;
                linked_attributes               = c->ctr6->linked_attributes;
                s_dsa->highwatermark            = c->ctr6->new_highwatermark;
@@ -646,12 +490,13 @@ static NTSTATUS test_become_dc_store_chunk(void *private_data,
        NT_STATUS_HAVE_NO_MEMORY(tmp_dns_name);
        s_dsa->other_info->dns_name = tmp_dns_name;
 
-       if (total_object_count) {
-               DEBUG(0,("Partition[%s] objects[%u/%u]\n",
-                       c->partition->nc.dn, object_count, total_object_count));
+       if (nc_object_count) {
+               DEBUG(0,("Partition[%s] objects[%u/%u] linked_values[%u/%u]\n",
+                       c->partition->nc.dn, object_count, nc_object_count,
+                       linked_attributes_count, nc_linked_attributes_count));
        } else {
-               DEBUG(0,("Partition[%s] objects[%u]\n",
-               c->partition->nc.dn, object_count));
+               DEBUG(0,("Partition[%s] objects[%u] linked_values[%u\n",
+               c->partition->nc.dn, object_count, linked_attributes_count));
        }
 
        status = dsdb_extended_replicated_objects_commit(s->ldb,
@@ -664,13 +509,13 @@ static NTSTATUS test_become_dc_store_chunk(void *private_data,
                                                         s_dsa,
                                                         uptodateness_vector,
                                                         c->gensec_skey,
-                                                        s, &objs);
+                                                        s, &objs, &seq_num);
        if (!W_ERROR_IS_OK(status)) {
                DEBUG(0,("Failed to commit objects: %s\n", win_errstr(status)));
                return werror_to_ntstatus(status);
        }
 
-       if (lp_parm_bool(NULL, "become dc", "dump objects", false)) {
+       if (lp_parm_bool(s->tctx->lp_ctx, NULL, "become dc", "dump objects", false)) {
                for (i=0; i < objs->num_objects; i++) {
                        struct ldb_ldif ldif;
                        fprintf(stdout, "#\n");
@@ -700,7 +545,7 @@ static NTSTATUS test_become_dc_store_chunk(void *private_data,
                        return NT_STATUS_FOOBAR;
                }
 
-               if (lp_parm_bool(NULL, "become dc", "dump objects", false)) {
+               if (lp_parm_bool(s->tctx->lp_ctx, NULL, "become dc", "dump objects", false)) {
                        DEBUG(0,("# %s\n", sa->lDAPDisplayName));
                        NDR_PRINT_DEBUG(drsuapi_DsReplicaLinkedAttribute, &linked_attributes[i]);
                        dump_data(0,
@@ -712,9 +557,9 @@ static NTSTATUS test_become_dc_store_chunk(void *private_data,
        return NT_STATUS_OK;
 }
 
-BOOL torture_net_become_dc(struct torture_context *torture)
+bool torture_net_become_dc(struct torture_context *torture)
 {
-       BOOL ret = True;
+       bool ret = true;
        NTSTATUS status;
        struct libnet_BecomeDC b;
        struct libnet_UnbecomeDC u;
@@ -722,42 +567,39 @@ BOOL torture_net_become_dc(struct torture_context *torture)
        struct ldb_message *msg;
        int ldb_ret;
        uint32_t i;
+       char *sam_ldb_path;
+
+       char *location = NULL;
+       torture_assert_ntstatus_ok(torture, torture_temp_dir(torture, "libnet_BecomeDC", &location), 
+                                  "torture_temp_dir should return NT_STATUS_OK" );
 
        s = talloc_zero(torture, struct test_become_dc_state);
-       if (!s) return False;
+       if (!s) return false;
+
+       s->tctx = torture;
+       s->lp_ctx = torture->lp_ctx;
 
-       s->netbios_name = lp_parm_string(NULL, "become dc", "smbtorture dc");
+       s->netbios_name = lp_parm_string(torture->lp_ctx, NULL, "become dc", "smbtorture dc");
        if (!s->netbios_name || !s->netbios_name[0]) {
                s->netbios_name = "smbtorturedc";
        }
 
-       s->path.samdb_ldb       = talloc_asprintf(s, "%s_samdb.ldb", s->netbios_name);
-       if (!s->path.samdb_ldb) return false;
-       s->path.domaindn_ldb    = talloc_asprintf(s, "%s_domain.ldb", s->netbios_name);
-       if (!s->path.domaindn_ldb) return false;
-       s->path.configdn_ldb    = talloc_asprintf(s, "%s_config.ldb", s->netbios_name);
-       if (!s->path.configdn_ldb) return false;
-       s->path.schemadn_ldb    = talloc_asprintf(s, "%s_schema.ldb", s->netbios_name);
-       if (!s->path.schemadn_ldb) return false;
-       s->path.secrets_ldb     = talloc_asprintf(s, "%s_secrets.ldb", s->netbios_name);
-       if (!s->path.secrets_ldb) return false;
-       s->path.secrets_keytab  = talloc_asprintf(s, "%s_secrets.keytab", s->netbios_name);
-       if (!s->path.secrets_keytab) return false;
+       s->targetdir = location;
 
        /* Join domain as a member server. */
-       s->tj = torture_join_domain(s->netbios_name,
+       s->tj = torture_join_domain(torture, s->netbios_name,
                                 ACB_WSTRUST,
                                 &s->machine_account);
        if (!s->tj) {
                DEBUG(0, ("%s failed to join domain as workstation\n",
                          s->netbios_name));
-               return False;
+               return false;
        }
 
-       s->ctx = libnet_context_init(torture->ev);
+       s->ctx = libnet_context_init(torture->ev, torture->lp_ctx);
        s->ctx->cred = cmdline_credentials;
 
-       s->ldb = ldb_init(s);
+       s->ldb = ldb_init(s, torture->ev);
 
        ZERO_STRUCT(b);
        b.in.domain_dns_name            = torture_join_dom_dns_name(s->tj);
@@ -768,7 +610,7 @@ BOOL torture_net_become_dc(struct torture_context *torture)
 
        b.in.callbacks.private_data     = s;
        b.in.callbacks.check_options    = test_become_dc_check_options;
-       b.in.callbacks.prepare_db       = test_become_dc_prepare_db;
+       b.in.callbacks.prepare_db = test_become_dc_prepare_db;
        b.in.callbacks.schema_chunk     = test_become_dc_schema_chunk;
        b.in.callbacks.config_chunk     = test_become_dc_store_chunk;
        b.in.callbacks.domain_chunk     = test_become_dc_store_chunk;
@@ -776,27 +618,27 @@ BOOL torture_net_become_dc(struct torture_context *torture)
        status = libnet_BecomeDC(s->ctx, s, &b);
        if (!NT_STATUS_IS_OK(status)) {
                printf("libnet_BecomeDC() failed - %s\n", nt_errstr(status));
-               ret = False;
+               ret = false;
                goto cleanup;
        }
 
        msg = ldb_msg_new(s);
        if (!msg) {
                printf("ldb_msg_new() failed\n");
-               ret = False;
+               ret = false;
                goto cleanup;
        }
-       msg->dn = ldb_dn_new(msg, s->ldb, "cn=ROOTDSE");
+       msg->dn = ldb_dn_new(msg, s->ldb, "@ROOTDSE");
        if (!msg->dn) {
-               printf("ldb_msg_new(cn=ROOTDSE) failed\n");
-               ret = False;
+               printf("ldb_msg_new(@ROOTDSE) failed\n");
+               ret = false;
                goto cleanup;
        }
 
        ldb_ret = ldb_msg_add_string(msg, "isSynchronized", "TRUE");
        if (ldb_ret != LDB_SUCCESS) {
                printf("ldb_msg_add_string(msg, isSynchronized, TRUE) failed: %d\n", ldb_ret);
-               ret = False;
+               ret = false;
                goto cleanup;
        }
 
@@ -808,7 +650,7 @@ BOOL torture_net_become_dc(struct torture_context *torture)
        ldb_ret = ldb_modify(s->ldb, msg);
        if (ldb_ret != LDB_SUCCESS) {
                printf("ldb_modify() failed: %d\n", ldb_ret);
-               ret = False;
+               ret = false;
                goto cleanup;
        }
        
@@ -816,25 +658,27 @@ BOOL torture_net_become_dc(struct torture_context *torture)
        talloc_free(s->ldb); /* this also free's the s->schema, because dsdb_set_schema() steals it */
        s->schema = NULL;
 
-       DEBUG(0,("Reopen the SAM LDB with system credentials and all replicated data: %s\n", s->path.samdb_ldb));
-       s->ldb = ldb_wrap_connect(s, s->path.samdb_ldb,
-                                 system_session(s),
+       sam_ldb_path = talloc_asprintf(s, "%s/%s", s->targetdir, "private/sam.ldb");
+       DEBUG(0,("Reopen the SAM LDB with system credentials and all replicated data: %s\n", sam_ldb_path));
+       s->ldb = ldb_wrap_connect(s, s->tctx->ev, s->lp_ctx, sam_ldb_path,
+                                 system_session(s, s->lp_ctx),
                                  NULL, 0, NULL);
        if (!s->ldb) {
                DEBUG(0,("Failed to open '%s'\n",
-                       s->path.samdb_ldb));
-               ret = False;
+                       sam_ldb_path));
+               ret = false;
                goto cleanup;
        }
 
        s->schema = dsdb_get_schema(s->ldb);
        if (!s->schema) {
                DEBUG(0,("Failed to get loaded dsdb_schema\n"));
-               ret = False;
+               ret = false;
                goto cleanup;
        }
 
-       if (lp_parm_bool(NULL, "become dc", "do not unjoin", false)) {
+       /* Make sure we get this from the command line */
+       if (lp_parm_bool(torture->lp_ctx, NULL, "become dc", "do not unjoin", false)) {
                talloc_free(s);
                return ret;
        }
@@ -849,11 +693,11 @@ cleanup:
        status = libnet_UnbecomeDC(s->ctx, s, &u);
        if (!NT_STATUS_IS_OK(status)) {
                printf("libnet_UnbecomeDC() failed - %s\n", nt_errstr(status));
-               ret = False;
+               ret = false;
        }
 
        /* Leave domain. */                          
-       torture_leave_domain(s->tj);
+       torture_leave_domain(torture, s->tj);
 
        talloc_free(s);
        return ret;