trying to get HEAD building again. If you want the code
[gd/samba-autobuild/.git] / source3 / rpcclient / rpcclient.c
index 47a36b6ddac23c3faa8e55f8baed2f7ae1529b38..af021962f5d40bb1012605792c4b194168794640 100644 (file)
@@ -3,6 +3,7 @@
    RPC pipe client
 
    Copyright (C) Tim Potter 2000-2001
+   Copyright (C) Martin Pool 2003
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
 
 DOM_SID domain_sid;
 
-/* List to hold groups of commands */
+
+/* List to hold groups of commands.
+ *
+ * Commands are defined in a list of arrays: arrays are easy to
+ * statically declare, and lists are easier to dynamically extend.
+ */
 
 static struct cmd_list {
        struct cmd_list *prev, *next;
        struct cmd_set *cmd_set;
 } *cmd_list;
 
+/*****************************************************************************
+ stubb functions
+****************************************************************************/
+
+void become_root( void )
+{
+        return;
+}
+
+void unbecome_root( void )
+{
+        return;
+}
+
+
 /****************************************************************************
 handle completion of commands for readline
 ****************************************************************************/
@@ -67,7 +88,10 @@ static char **completion_fn(char *text, int start, int end)
                for (i=0; commands->cmd_set[i].name; i++)
                {
                        if ((strncmp(text, commands->cmd_set[i].name, strlen(text)) == 0) &&
-                               commands->cmd_set[i].fn) 
+                               (( commands->cmd_set[i].returntype == RPC_RTYPE_NTSTATUS &&
+                        commands->cmd_set[i].ntfn ) || 
+                      ( commands->cmd_set[i].returntype == RPC_RTYPE_WERROR &&
+                        commands->cmd_set[i].wfn)))
                        {
                                matches[count] = strdup(commands->cmd_set[i].name);
                                if (!matches[count]) 
@@ -88,70 +112,6 @@ static char **completion_fn(char *text, int start, int end)
        return matches;
 }
 
-/***********************************************************************
- * read in username/password credentials from a file
- */
-static void read_authfile (
-       char *filename, 
-       char* username, 
-       char* password, 
-       char* domain
-)
-{
-       FILE *auth;
-        fstring buf;
-        uint16 len = 0;
-       char *ptr, *val, *param;
-                               
-       if ((auth=sys_fopen(filename, "r")) == NULL)
-       {
-               printf ("ERROR: Unable to open credentials file!\n");
-               return;
-       }
-                                
-       while (!feof(auth))
-       {  
-               /* get a line from the file */
-               if (!fgets (buf, sizeof(buf), auth))
-                       continue;
-               
-               len = strlen(buf);
-               
-               /* skip empty lines */                  
-               if ((len) && (buf[len-1]=='\n'))
-               {
-                       buf[len-1] = '\0';
-                       len--;
-               }       
-               if (len == 0)
-                       continue;
-                                       
-               /* break up the line into parameter & value.
-                  will need to eat a little whitespace possibly */
-               param = buf;
-               if (!(ptr = strchr_m(buf, '=')))
-                       continue;
-               val = ptr+1;
-               *ptr = '\0';
-                                       
-               /* eat leading white space */
-               while ((*val!='\0') && ((*val==' ') || (*val=='\t')))
-                       val++;
-                                       
-               if (strwicmp("password", param) == 0)
-                       fstrcpy (password, val);
-               else if (strwicmp("username", param) == 0)
-                       fstrcpy (username, val);
-               else if (strwicmp("domain", param) == 0)
-                       fstrcpy (domain, val);
-                                               
-               memset(buf, 0, sizeof(buf));
-       }
-       fclose(auth);
-       
-       return;
-}
-
 static char* next_command (char** cmdstr)
 {
        static pstring          command;
@@ -164,29 +124,17 @@ static char* next_command (char** cmdstr)
        if (p)
                *p = '\0';
        pstrcpy(command, *cmdstr);
-       *cmdstr = p;
+       if (p)
+               *cmdstr = p + 1;
+       else
+               *cmdstr = NULL;
        
        return command;
 }
 
-static void get_username (char *username)
-{
-        if (getenv("USER"))
-                pstrcpy(username,getenv("USER"));
-        if (*username == 0 && getenv("LOGNAME"))
-                pstrcpy(username,getenv("LOGNAME"));
-        if (*username == 0) {
-                pstrcpy(username,"GUEST");
-        }
-
-       return;
-}
-
 /* Fetch the SID for this computer */
 
-void fetch_machine_sid(struct cli_state *cli)
+static void fetch_machine_sid(struct cli_state *cli)
 {
        POLICY_HND pol;
        NTSTATUS result = NT_STATUS_OK;
@@ -197,14 +145,14 @@ void fetch_machine_sid(struct cli_state *cli)
 
        if (got_domain_sid) return;
 
-       if (!(mem_ctx=talloc_init()))
+       if (!(mem_ctx=talloc_init("fetch_machine_sid")))
        {
-               DEBUG(0,("fetch_domain_sid: talloc_init returned NULL!\n"));
+               DEBUG(0,("fetch_machine_sid: talloc_init returned NULL!\n"));
                goto error;
        }
 
 
-       if (!cli_nt_session_open (cli, PIPE_LSARPC)) {
+       if (!cli_nt_session_open (cli, PI_LSARPC)) {
                fprintf(stderr, "could not initialise lsa pipe\n");
                goto error;
        }
@@ -234,17 +182,61 @@ void fetch_machine_sid(struct cli_state *cli)
        fprintf(stderr, "could not obtain sid for domain %s\n", cli->domain);
 
        if (!NT_STATUS_IS_OK(result)) {
-               fprintf(stderr, "error: %s\n", get_nt_error_msg(result));
+               fprintf(stderr, "error: %s\n", nt_errstr(result));
        }
 
        exit(1);
 }
 
+/* List the available commands on a given pipe */
+
+static NTSTATUS cmd_listcommands(struct cli_state *cli, TALLOC_CTX *mem_ctx,
+                                int argc, const char **argv)
+{
+       struct cmd_list *tmp;
+        struct cmd_set *tmp_set;
+       int i;
+
+        /* Usage */
+
+        if (argc != 2) {
+                printf("Usage: %s <pipe>\n", argv[0]);
+                return NT_STATUS_OK;
+        }
+
+        /* Help on one command */
+
+       for (tmp = cmd_list; tmp; tmp = tmp->next) 
+       {
+               tmp_set = tmp->cmd_set;
+               
+               if (!StrCaseCmp(argv[1], tmp_set->name))
+               {
+                       printf("Available commands on the %s pipe:\n\n", tmp_set->name);
+
+                       i = 0;
+                       tmp_set++;
+                       while(tmp_set->name) {
+                               printf("%20s", tmp_set->name);
+                                tmp_set++;
+                               i++;
+                               if (i%4 == 0)
+                                       printf("\n");
+                       }
+                       
+                       /* drop out of the loop */
+                       break;
+               }
+        }
+       printf("\n\n");
+
+       return NT_STATUS_OK;
+}
 
 /* Display help on commands */
 
 static NTSTATUS cmd_help(struct cli_state *cli, TALLOC_CTX *mem_ctx,
-                         int argc, char **argv)
+                         int argc, const char **argv)
 {
        struct cmd_list *tmp;
         struct cmd_set *tmp_set;
@@ -304,7 +296,7 @@ static NTSTATUS cmd_help(struct cli_state *cli, TALLOC_CTX *mem_ctx,
 /* Change the debug level */
 
 static NTSTATUS cmd_debuglevel(struct cli_state *cli, TALLOC_CTX *mem_ctx,
-                               int argc, char **argv)
+                               int argc, const char **argv)
 {
        if (argc > 2) {
                printf("Usage: %s [debuglevel]\n", argv[0]);
@@ -321,29 +313,147 @@ static NTSTATUS cmd_debuglevel(struct cli_state *cli, TALLOC_CTX *mem_ctx,
 }
 
 static NTSTATUS cmd_quit(struct cli_state *cli, TALLOC_CTX *mem_ctx,
-                         int argc, char **argv)
+                         int argc, const char **argv)
 {
        exit(0);
        return NT_STATUS_OK; /* NOTREACHED */
 }
 
-/* Build in rpcclient commands */
+static NTSTATUS cmd_sign(struct cli_state *cli, TALLOC_CTX *mem_ctx,
+                         int argc, const char **argv)
+{
+       if (cli->pipe_auth_flags == (AUTH_PIPE_NTLMSSP|AUTH_PIPE_SIGN)) {
+               return NT_STATUS_OK;
+       } else {
+               /* still have session, just need to use it again */
+               cli->pipe_auth_flags = AUTH_PIPE_NTLMSSP;
+               cli->pipe_auth_flags |= AUTH_PIPE_SIGN;
+               if (cli->nt_pipe_fnum != 0)
+                       cli_nt_session_close(cli);
+       }
+
+       return NT_STATUS_OK; 
+}
+
+static NTSTATUS cmd_seal(struct cli_state *cli, TALLOC_CTX *mem_ctx,
+                         int argc, const char **argv)
+{
+       if (cli->pipe_auth_flags == (AUTH_PIPE_NTLMSSP|AUTH_PIPE_SIGN|AUTH_PIPE_SEAL)) {
+               return NT_STATUS_OK;
+       } else {
+               /* still have session, just need to use it again */
+               cli->pipe_auth_flags = AUTH_PIPE_NTLMSSP;
+               cli->pipe_auth_flags |= AUTH_PIPE_SIGN;
+               cli->pipe_auth_flags |= AUTH_PIPE_SEAL;
+               if (cli->nt_pipe_fnum != 0)
+                       cli_nt_session_close(cli);
+       }
+       return NT_STATUS_OK; 
+}
+
+static NTSTATUS cmd_none(struct cli_state *cli, TALLOC_CTX *mem_ctx,
+                         int argc, const char **argv)
+{
+       if (cli->pipe_auth_flags == 0) {
+               return NT_STATUS_OK;
+       } else {
+               /* still have session, just need to use it again */
+               cli->pipe_auth_flags = 0;
+               if (cli->nt_pipe_fnum != 0)
+                       cli_nt_session_close(cli);
+       }
+       cli->pipe_auth_flags = 0;
+
+       return NT_STATUS_OK; 
+}
+
+static NTSTATUS cmd_schannel(struct cli_state *cli, TALLOC_CTX *mem_ctx,
+                            int argc, const char **argv)
+{
+       uchar trust_password[16];
+       uint32 sec_channel_type;
+       uint32 neg_flags = 0x000001ff;
+       NTSTATUS result;
+       static uchar zeros[16];
+
+       /* Cleanup */
+
+       if ((memcmp(cli->auth_info.sess_key, zeros, sizeof(cli->auth_info.sess_key)) != 0) 
+           && (cli->saved_netlogon_pipe_fnum != 0)) {
+               if (cli->pipe_auth_flags == (AUTH_PIPE_NETSEC|AUTH_PIPE_SIGN|AUTH_PIPE_SEAL)) {
+                       return NT_STATUS_OK;
+               } else {
+                       /* still have session, just need to use it again */
+                       cli->pipe_auth_flags = AUTH_PIPE_NETSEC;
+                       cli->pipe_auth_flags |= AUTH_PIPE_SIGN;
+                       cli->pipe_auth_flags |= AUTH_PIPE_SEAL;
+                       if (cli->nt_pipe_fnum != 0)
+                               cli_nt_session_close(cli);
+               }
+       }
+       
+       if (cli->nt_pipe_fnum != 0)
+               cli_nt_session_close(cli);
+
+       cli->pipe_auth_flags = 0;
+       
+       if (!secrets_fetch_trust_account_password(lp_workgroup(),
+                                                 trust_password,
+                                                 NULL, &sec_channel_type)) {
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+       
+       if (!cli_nt_session_open(cli, PI_NETLOGON)) {
+               DEBUG(0, ("Could not initialise %s\n",
+                         get_pipe_name_from_index(PI_NETLOGON)));
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       neg_flags |= NETLOGON_NEG_SCHANNEL;
+
+       result = cli_nt_setup_creds(cli, sec_channel_type, trust_password,
+                                   &neg_flags, 2);
+
+       if (!NT_STATUS_IS_OK(result)) {
+               ZERO_STRUCT(cli->auth_info.sess_key);
+               cli->pipe_auth_flags = 0;
+               return result;
+       }
+
+       memcpy(cli->auth_info.sess_key, cli->sess_key,
+              sizeof(cli->auth_info.sess_key));
+
+       cli->saved_netlogon_pipe_fnum = cli->nt_pipe_fnum;
+
+       cli->pipe_auth_flags = AUTH_PIPE_NETSEC;
+       cli->pipe_auth_flags |= AUTH_PIPE_SIGN;
+       cli->pipe_auth_flags |= AUTH_PIPE_SEAL;
+
+       return NT_STATUS_OK; 
+}
+
+/* Built in rpcclient commands */
 
 static struct cmd_set rpcclient_commands[] = {
 
        { "GENERAL OPTIONS" },
 
-       { "help",       cmd_help,       NULL,   "Get help on commands", "[command]" },
-       { "?",          cmd_help,       NULL,   "Get help on commands", "[command]" },
-       { "debuglevel", cmd_debuglevel, NULL,   "Set debug level", "level" },
-       { "exit",       cmd_quit,       NULL,   "Exit program", "" },
-       { "quit",       cmd_quit,       NULL,   "Exit program", "" },
+       { "help", RPC_RTYPE_NTSTATUS, cmd_help, NULL,     -1,   "Get help on commands", "[command]" },
+       { "?",  RPC_RTYPE_NTSTATUS, cmd_help, NULL,       -1,   "Get help on commands", "[command]" },
+       { "debuglevel", RPC_RTYPE_NTSTATUS, cmd_debuglevel, NULL,   -1, "Set debug level", "level" },
+       { "list",       RPC_RTYPE_NTSTATUS, cmd_listcommands, NULL, -1, "List available commands on <pipe>", "pipe" },
+       { "exit", RPC_RTYPE_NTSTATUS, cmd_quit, NULL,   -1,     "Exit program", "" },
+       { "quit", RPC_RTYPE_NTSTATUS, cmd_quit, NULL,     -1,   "Exit program", "" },
+       { "sign", RPC_RTYPE_NTSTATUS, cmd_sign, NULL,     -1,   "Force RPC pipe connections to be signed", "" },
+       { "seal", RPC_RTYPE_NTSTATUS, cmd_seal, NULL,     -1,   "Force RPC pipe connections to be sealed", "" },
+       { "schannel", RPC_RTYPE_NTSTATUS, cmd_schannel, NULL,     -1,   "Force RPC pipe connections to be sealed with 'schannel' (NETSEC).  Assumes valid machine account to this domain controller.", "" },
+       { "none", RPC_RTYPE_NTSTATUS, cmd_none, NULL,     -1,   "Force RPC pipe connections to have no special properties", "" },
 
        { NULL }
 };
 
 static struct cmd_set separator_command[] = {
-       { "---------------", NULL,      NULL,   "----------------------" },
+       { "---------------", MAX_RPC_RETURN_TYPE, NULL, NULL,   -1,     "----------------------" },
        { NULL }
 };
 
@@ -357,16 +467,20 @@ extern struct cmd_set netlogon_commands[];
 extern struct cmd_set srvsvc_commands[];
 extern struct cmd_set dfs_commands[];
 extern struct cmd_set reg_commands[];
+extern struct cmd_set ds_commands[];
+extern struct cmd_set echo_commands[];
 
 static struct cmd_set *rpcclient_command_list[] = {
        rpcclient_commands,
        lsarpc_commands,
+       ds_commands,
        samr_commands,
        spoolss_commands,
        netlogon_commands,
        srvsvc_commands,
        dfs_commands,
        reg_commands,
+       echo_commands,
        NULL
 };
 
@@ -385,313 +499,256 @@ static void add_command_set(struct cmd_set *cmd_set)
        DLIST_ADD(cmd_list, entry);
 }
 
-static NTSTATUS do_cmd(struct cli_state *cli, struct cmd_set *cmd_entry, 
-                       char *cmd)
-{
-       char *p = cmd, **argv = NULL;
-       NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
-       pstring buf;
-       int argc = 0, i;
-
-       /* Count number of arguments first time through the loop then
-          allocate memory and strdup them. */
-
- again:
-       while(next_token(&p, buf, " ", sizeof(buf))) {
-               if (argv) {
-                       argv[argc] = strdup(buf);
-               }
-               
-               argc++;
-       }
-                               
-       if (!argv) {
 
-               /* Create argument list */
+/**
+ * Call an rpcclient function, passing an argv array.
+ *
+ * @param cmd Command to run, as a single string.
+ **/
+static NTSTATUS do_cmd(struct cli_state *cli,
+                      struct cmd_set *cmd_entry,
+                      int argc, char **argv)
+{
+       NTSTATUS ntresult;
+       WERROR wresult;
+       uchar trust_password[16];
+       
+       TALLOC_CTX *mem_ctx;
 
-               argv = (char **)malloc(sizeof(char *) * argc);
-                memset(argv, 0, sizeof(char *) * argc);
+       /* Create mem_ctx */
 
-               if (!argv) {
-                       fprintf(stderr, "out of memory\n");
-                       result = NT_STATUS_NO_MEMORY;
-                        goto done;
-               }
-                                       
-               p = cmd;
-               argc = 0;
-                                       
-               goto again;
+       if (!(mem_ctx = talloc_init("do_cmd"))) {
+               DEBUG(0, ("talloc_init() failed\n"));
+               return NT_STATUS_NO_MEMORY;
        }
 
-       /* Call the function */
-
-       if (cmd_entry->fn) {
-                TALLOC_CTX *mem_ctx;
+       /* Open pipe */
 
-                /* Create mem_ctx */
-
-                if (!(mem_ctx = talloc_init())) {
-                        DEBUG(0, ("talloc_init() failed\n"));
-                        goto done;
-                }
-
-                /* Open pipe */
-
-                if (cmd_entry->pipe)
-                        if (!cli_nt_session_open(cli, cmd_entry->pipe)) {
-                                DEBUG(0, ("Could not initialise %s\n",
-                                          cmd_entry->pipe));
-                                goto done;
-                        }
-
-                /* Run command */
-
-                result = cmd_entry->fn(cli, mem_ctx, argc, argv);
-
-                /* Cleanup */
-
-                if (cmd_entry->pipe)
-                        cli_nt_session_close(cli);
+       if (cmd_entry->pipe_idx != -1
+           && cmd_entry->pipe_idx != cli->pipe_idx) {
+               if (cli->nt_pipe_fnum != 0)
+                       cli_nt_session_close(cli);
+               
+               if (!cli_nt_session_open(cli, cmd_entry->pipe_idx)) {
+                       DEBUG(0, ("Could not initialise %s\n",
+                                 get_pipe_name_from_index(cmd_entry->pipe_idx)));
+                       return NT_STATUS_UNSUCCESSFUL;
+               }
+       }
 
-                talloc_destroy(mem_ctx);
+       if ((cmd_entry->pipe_idx == PI_NETLOGON) && !(cli->pipe_auth_flags & AUTH_PIPE_NETSEC)) {
+               uint32 neg_flags = 0x000001ff;
+               uint32 sec_channel_type;
+       
+               if (!secrets_fetch_trust_account_password(lp_workgroup(),
+                                                         trust_password,
+                                                         NULL, &sec_channel_type)) {
+                       return NT_STATUS_UNSUCCESSFUL;
+               }
+               
+               ntresult = cli_nt_setup_creds(cli, sec_channel_type, 
+                                             trust_password,
+                                             &neg_flags, 2);
+               if (!NT_STATUS_IS_OK(ntresult)) {
+                       ZERO_STRUCT(cli->auth_info.sess_key);
+                       printf("nt_setup_creds failed with %s\n", nt_errstr(ntresult));
+                       return ntresult;
+               }
+               
+       }
 
-       } else {
-               fprintf (stderr, "Invalid command\n");
-                goto done;
-        }
+     /* Run command */
+
+     if ( cmd_entry->returntype == RPC_RTYPE_NTSTATUS ) {
+          ntresult = cmd_entry->ntfn(cli, mem_ctx, argc, (const char **) argv);
+          if (!NT_STATUS_IS_OK(ntresult)) {
+              printf("result was %s\n", nt_errstr(ntresult));
+          }
+     } else {
+          wresult = cmd_entry->wfn( cli, mem_ctx, argc, (const char **) argv);
+          /* print out the DOS error */
+          if (!W_ERROR_IS_OK(wresult)) {
+                  printf( "result was %s\n", dos_errstr(wresult));
+          }
+          ntresult = W_ERROR_IS_OK(wresult)?NT_STATUS_OK:NT_STATUS_UNSUCCESSFUL;
+     }
+            
 
- done:
-                                               
        /* Cleanup */
 
-        if (argv) {
-                for (i = 0; i < argc; i++)
-                        SAFE_FREE(argv[i]);
-       
-                SAFE_FREE(argv);
-        }
-       
-       return result;
+       talloc_destroy(mem_ctx);
+
+       return ntresult;
 }
 
-/* Process a command entered at the prompt or as part of -c */
 
+/**
+ * Process a command entered at the prompt or as part of -c
+ *
+ * @returns The NTSTATUS from running the command.
+ **/
 static NTSTATUS process_cmd(struct cli_state *cli, char *cmd)
 {
        struct cmd_list *temp_list;
-       BOOL found = False;
-       pstring buf;
-       char *p = cmd;
        NTSTATUS result = NT_STATUS_OK;
-       int len = 0;
-
-       if (cmd[strlen(cmd) - 1] == '\n')
-               cmd[strlen(cmd) - 1] = '\0';
+       int ret;
+       int argc;
+       char **argv = NULL;
 
-       if (!next_token(&p, buf, " ", sizeof(buf))) {
-               return NT_STATUS_OK;
+       if ((ret = poptParseArgvString(cmd, &argc, (const char ***) &argv)) != 0) {
+               fprintf(stderr, "rpcclient: %s\n", poptStrerror(ret));
+               return NT_STATUS_UNSUCCESSFUL;
        }
 
-        /* strip the trainly \n if it exsists */
-       len = strlen(buf);
-       if (buf[len-1] == '\n')
-               buf[len-1] = '\0';
-
-       /* Search for matching commands */
 
+       /* Walk through a dlist of arrays of commands. */
        for (temp_list = cmd_list; temp_list; temp_list = temp_list->next) {
                struct cmd_set *temp_set = temp_list->cmd_set;
 
-               while(temp_set->name) {
-                       if (strequal(buf, temp_set->name)) {
-                                found = True;
-                               result = do_cmd(cli, temp_set, cmd);
+               while (temp_set->name) {
+                       if (strequal(argv[0], temp_set->name)) {
+                               if (!(temp_set->returntype == RPC_RTYPE_NTSTATUS && temp_set->ntfn ) &&
+                         !(temp_set->returntype == RPC_RTYPE_WERROR && temp_set->wfn )) {
+                                       fprintf (stderr, "Invalid command\n");
+                                       goto out_free;
+                               }
+
+                               result = do_cmd(cli, temp_set, argc, argv);
 
-                               goto done;
+                               goto out_free;
                        }
                        temp_set++;
                }
        }
 
- done:
-       if (!found && buf[0]) {
-               printf("command not found: %s\n", buf);
-               return NT_STATUS_OK;
+       if (argv[0]) {
+               printf("command not found: %s\n", argv[0]);
        }
 
+out_free:
+/* moved to do_cmd()
        if (!NT_STATUS_IS_OK(result)) {
-               printf("result was %s\n", get_nt_error_msg(result));
+               printf("result was %s\n", nt_errstr(result));
        }
+*/
 
+       if (argv) {
+               /* NOTE: popt allocates the whole argv, including the
+                * strings, as a single block.  So a single free is
+                * enough to release it -- we don't free the
+                * individual strings.  rtfm. */
+               free(argv);
+       }
+       
        return result;
 }
 
 
-/* Print usage information */
-static void usage(void)
-{
-       printf("Usage: rpcclient server [options]\n");
-
-       printf("\t-A authfile           file containing user credentials\n");
-       printf("\t-c \"command string\"   execute semicolon separated cmds\n");
-       printf("\t-d debuglevel         set the debuglevel\n");
-       printf("\t-l logfile            name of logfile to use as opposed to stdout\n");
-       printf("\t-h                    Print this help message.\n");
-       printf("\t-N                    don't ask for a password\n");
-       printf("\t-s configfile         specify an alternative config file\n");
-       printf("\t-U username           set the network username\n");
-       printf("\t-W domain             set the domain name for user account\n");
-       printf("\n");
-}
-
 /* Main function */
 
  int main(int argc, char *argv[])
 {
-       extern char             *optarg;
-       extern int              optind;
-       extern pstring          global_myname;
-       BOOL                    got_pass = False;
        BOOL                    interactive = True;
        int                     opt;
-       int                     olddebug;
-       pstring                 cmdstr = "";
+       static char             *cmdstr = NULL;
+       const char *server;
        struct cli_state        *cli;
-       fstring                 password="",
-                               username="",
-                               domain="",
-                               server="";
-       pstring logfile;
-       struct cmd_set **cmd_set;
-       struct in_addr server_ip;
-       NTSTATUS nt_status;
+       static char             *opt_ipaddr=NULL;
+       struct cmd_set          **cmd_set;
+       struct in_addr          server_ip;
+       NTSTATUS                nt_status;
+
+       /* make sure the vars that get altered (4th field) are in
+          a fixed location or certain compilers complain */
+       poptContext pc;
+       struct poptOption long_options[] = {
+               POPT_AUTOHELP
+               {"command",     'c', POPT_ARG_STRING,   &cmdstr, 'c', "Execute semicolon separated cmds", "COMMANDS"},
+               {"dest-ip", 'I', POPT_ARG_STRING,   &opt_ipaddr, 'I', "Specify destination IP address", "IP"},
+               POPT_COMMON_SAMBA
+               POPT_COMMON_CONNECTION
+               POPT_COMMON_CREDENTIALS
+               POPT_TABLEEND
+       };
+
+       ZERO_STRUCT(server_ip);
 
        setlinebuf(stdout);
 
-       DEBUGLEVEL = 1;
-
-       while ((opt = getopt(argc, argv, "A:s:Nd:U:W:c:l:h")) != EOF) {
-               switch (opt) {
-               case 'A':
-                       /* only get the username, password, and domain from the file */
-                       read_authfile (optarg, username, password, domain);
-                       if (strlen (password))
-                               got_pass = True;
-                       break;
+       /* the following functions are part of the Samba debugging
+          facilities.  See lib/debug.c */
+       setup_logging("rpcclient", interactive);
+       if (!interactive) 
+               reopen_logs();
+       
+       /* Load smb.conf file */
 
-               case 'c':
-                       pstrcpy(cmdstr, optarg);
-                       break;
+       if (!lp_load(dyn_CONFIGFILE,True,False,False))
+               fprintf(stderr, "Can't load %s\n", dyn_CONFIGFILE);
 
-               case 'd':
-                       DEBUGLEVEL = atoi(optarg);
-                       break;
+       /* Parse options */
 
-               case 'l':
-                       slprintf(logfile, sizeof(logfile) - 1, "%s.client", optarg);
-                       lp_set_logfile(logfile);
-                       interactive = False;
-                       break;
+       pc = poptGetContext("rpcclient", argc, (const char **) argv,
+                           long_options, 0);
 
-               case 'N':
-                       got_pass = True;
-                       break;
-                       
-               case 's':
-                       pstrcpy(dyn_CONFIGFILE, optarg);
-                       break;
+       if (argc == 1) {
+               poptPrintHelp(pc, stderr, 0);
+               return 0;
+       }
+       
+       while((opt = poptGetNextOpt(pc)) != -1) {
+               switch (opt) {
 
-               case 'U': {
-                       char *lp;
-                       pstrcpy(username,optarg);
-                       if ((lp=strchr_m(username,'%'))) {
-                               *lp = 0;
-                               pstrcpy(password,lp+1);
-                               got_pass = True;
-                               memset(strchr_m(optarg,'%')+1,'X',strlen(password));
+               case 'I':
+                       if ( (server_ip.s_addr=inet_addr(opt_ipaddr)) == INADDR_NONE ) {
+                               fprintf(stderr, "%s not a valid IP address\n",
+                                       opt_ipaddr);
+                               return 1;
                        }
-                       break;
-               }
-               
-               case 'W':
-                       pstrcpy(domain, optarg);
-                       break;
-                       
-               case 'h':
-               default:
-                       usage();
-                       exit(1);
                }
        }
 
-       argv += optind;
-       argc -= optind;
-
-       /* Parse options */
-       if (argc == 0) {
-               usage();
-               return 0;
-       }
-       
-       if (strncmp("//", argv[0], 2) == 0 || strncmp("\\\\", argv[0], 2) == 0)
-               argv[0] += 2;
-
-       pstrcpy(server, argv[0]);
+       /* Get server as remaining unparsed argument.  Print usage if more
+          than one unparsed argument is present. */
 
-       /* the following functions are part of the Samba debugging
-          facilities.  See lib/debug.c */
-       setup_logging("rpcclient", interactive);
-       if (!interactive) 
-               reopen_logs();
+       server = poptGetArg(pc);
        
-       /* Load smb.conf file */
-       /* FIXME!  How to get this DEBUGLEVEL to last over lp_load()? */
-       olddebug = DEBUGLEVEL;
-       if (!lp_load(dyn_CONFIGFILE,True,False,False)) {
-               fprintf(stderr, "Can't load %s\n", dyn_CONFIGFILE);
+       if (!server || poptGetArg(pc)) {
+               poptPrintHelp(pc, stderr, 0);
+               return 1;
        }
-       DEBUGLEVEL = olddebug;
-
-       load_interfaces();
 
-       get_myname((*global_myname)?NULL:global_myname);
-       strupper(global_myname);
+       poptFreeContext(pc);
 
-       /* Resolve the IP address */
+       load_interfaces();
 
-       if (!resolve_name(server, &server_ip, 0x20))  {
-               DEBUG(1,("Unable to resolve %s\n", server));
+       if (!init_names())
                return 1;
-       }
-       
+
        /*
         * Get password
         * from stdin if necessary
         */
 
-       if (!got_pass) {
+       if (!cmdline_auth_info.got_pass) {
                char *pass = getpass("Password:");
                if (pass) {
-                       fstrcpy(password, pass);
+                       pstrcpy(cmdline_auth_info.password, pass);
                }
        }
        
-       if (!strlen(username) && !got_pass)
-               get_username(username);
-               
-       nt_status = cli_full_connection(&cli, global_myname, server, 
-                                       &server_ip, 0,
+       nt_status = cli_full_connection(&cli, global_myname(), server, 
+                                       opt_ipaddr ? &server_ip : NULL, 0,
                                        "IPC$", "IPC",  
-                                       username, domain,
-                                       password, strlen(password));
+                                       cmdline_auth_info.username, lp_workgroup(),
+                                       cmdline_auth_info.password, 0, NULL);
        
        if (!NT_STATUS_IS_OK(nt_status)) {
-               DEBUG(1,("Cannot connect to server.  Error was %s\n", get_nt_error_msg(nt_status)));
+               DEBUG(0,("Cannot connect to server.  Error was %s\n", nt_errstr(nt_status)));
                return 1;
        }
 
-       memset(password,'X',sizeof(password));
+       memset(cmdline_auth_info.password,'X',sizeof(cmdline_auth_info.password));
 
        /* Load command lists */
 
@@ -706,16 +763,18 @@ static void usage(void)
        fetch_machine_sid(cli);
  
        /* Do anything specified with -c */
-        if (cmdstr[0]) {
+        if (cmdstr && cmdstr[0]) {
                 char    *cmd;
                 char    *p = cmdstr;
+               int result = 0;
  
                 while((cmd=next_command(&p)) != NULL) {
-                        process_cmd(cli, cmd);
+                        NTSTATUS cmd_result = process_cmd(cli, cmd);
+                       result = NT_STATUS_IS_ERR(cmd_result);
                 }
                
                cli_shutdown(cli);
-                return 0;
+                return result;
         }
 
        /* Loop around accepting commands */