gd/nettle
5 years agoChangeLog for previous change.
Niels Möller [Sun, 25 Nov 2018 16:06:21 +0000 (17:06 +0100)]
ChangeLog for previous change.

5 years agoCatch bad private keys early on.
Simo Sorce [Thu, 8 Nov 2018 16:27:05 +0000 (11:27 -0500)]
Catch bad private keys early on.

5 years agoUse NETTLE_OCTET_SIZE_TO_LIMB_SIZE.
Niels Möller [Sun, 25 Nov 2018 15:58:38 +0000 (16:58 +0100)]
Use NETTLE_OCTET_SIZE_TO_LIMB_SIZE.

5 years agoChangeLog for previous change.
Niels Möller [Sun, 25 Nov 2018 15:57:27 +0000 (16:57 +0100)]
ChangeLog for previous change.

5 years agoUse side-channel silent pkcs1 in rsa_decrypt_tr
Simo Sorce [Mon, 12 Nov 2018 22:06:31 +0000 (17:06 -0500)]
Use side-channel silent pkcs1 in rsa_decrypt_tr

Signed-off-by: Simo Sorce <simo@redhat.com>
5 years agoChangeLog entry, and minor comment fixes
Niels Möller [Sun, 25 Nov 2018 15:47:23 +0000 (16:47 +0100)]
ChangeLog entry, and minor comment fixes

5 years agoAdd variable len pkcs1-sec decoding function
Simo Sorce [Mon, 12 Nov 2018 18:54:47 +0000 (13:54 -0500)]
Add variable len pkcs1-sec decoding function

add a side-channel silent pkcs1 decoding function for use in older
APIs.

Signed-off-by: Simo Sorce <simo@redhat.com>
5 years agoTweak valgrind marking is rsa_sec_decrypt tests.
Niels Möller [Sun, 25 Nov 2018 15:23:06 +0000 (16:23 +0100)]
Tweak valgrind marking is rsa_sec_decrypt tests.

* testsuite/rsa-sec-decrypt-test.c (rsa_decrypt_for_test): Tweak
valgrind marking, and document potential leakage of lowest and
highest bits of p and q.

5 years agoAvoid calls to mpz_sizeinbase on RSA private key.
Niels Möller [Sun, 25 Nov 2018 15:10:11 +0000 (16:10 +0100)]
Avoid calls to mpz_sizeinbase on RSA private key.

* rsa-sec-compute-root.c (_rsa_sec_compute_root): Avoid calls to
mpz_sizeinbase, since that potentially leaks most significant bits
of private key parameters a and b.

5 years agoChangeLog for previous change.
Niels Möller [Sun, 25 Nov 2018 15:05:40 +0000 (16:05 +0100)]
ChangeLog for previous change.

5 years agoUnit test for rsa_sec_decyrpt
Simo Sorce [Mon, 15 Oct 2018 20:01:52 +0000 (16:01 -0400)]
Unit test for rsa_sec_decyrpt

Signed-off-by: Simo Sorce <simo@redhat.com>
5 years agoChangeLog for previous change.
Niels Möller [Sun, 25 Nov 2018 10:14:26 +0000 (11:14 +0100)]
ChangeLog for previous change.

5 years agoAdd rsa_sec_decrypt as side-channel silent variant
Simo Sorce [Wed, 10 Oct 2018 20:15:49 +0000 (16:15 -0400)]
Add rsa_sec_decrypt as side-channel silent variant

Use side-channel silent RSA root function as well as PKCS1 padding
functions.
This variant accepts only a fixed length message, and returns error
if the pkcs1 padding returns a different length message.
The buffer is always left unchanged on error so that a TLS
implementation can pre-initialize it with a random key to use on
decoding error.

Signed-off-by: Simo Sorce <simo@redhat.com>
5 years agopkcs1-sec-decrypt-test.c: Fix valgrind marking of return value.
Niels Möller [Sun, 25 Nov 2018 09:38:23 +0000 (10:38 +0100)]
pkcs1-sec-decrypt-test.c: Fix valgrind marking of return value.

5 years agoChangeLog for previous change.
Niels Möller [Sun, 25 Nov 2018 09:37:22 +0000 (10:37 +0100)]
ChangeLog for previous change.

5 years agoUnit test for pkcs1-sec-decrypt
Simo Sorce [Tue, 23 Oct 2018 22:14:30 +0000 (18:14 -0400)]
Unit test for pkcs1-sec-decrypt

Signed-off-by: Simo Sorce <simo@redhat.com>
5 years agoChangeLog for previous change.
Niels Möller [Sun, 25 Nov 2018 09:29:02 +0000 (10:29 +0100)]
ChangeLog for previous change.

5 years agoAdd mpn_get_base256
Simo Sorce [Mon, 12 Nov 2018 18:59:06 +0000 (13:59 -0500)]
Add mpn_get_base256

Converts limbs to uint8_t buffer without conditional jumps.

Signed-off-by: Simo Sorce <simo@redhat.com>
5 years agoChangeLog for previous change.
Niels Möller [Sun, 25 Nov 2018 09:22:38 +0000 (10:22 +0100)]
ChangeLog for previous change.

5 years agoAdd side-channel silent pkcs1 decoding function
Simo Sorce [Thu, 8 Nov 2018 19:38:12 +0000 (14:38 -0500)]
Add side-channel silent pkcs1 decoding function

Signed-off-by: Simo Sorce <simo@redhat.com>
5 years agoChangeLog for previous change.
Niels Möller [Sat, 24 Nov 2018 10:44:01 +0000 (11:44 +0100)]
ChangeLog for previous change.

5 years agoAdd a side-channel silent conditional memcpy
Simo Sorce [Mon, 15 Oct 2018 19:02:50 +0000 (15:02 -0400)]
Add a side-channel silent conditional memcpy

Originally from Niels, with minor changes to avoid compiler warnings.

5 years agoChangeLog entries, minor comment and spacing fixes
Niels Möller [Sat, 24 Nov 2018 10:27:39 +0000 (11:27 +0100)]
ChangeLog entries, minor comment and spacing fixes

5 years agoUse side-channel silent root for rsa signatures
Simo Sorce [Thu, 8 Nov 2018 16:59:48 +0000 (11:59 -0500)]
Use side-channel silent root for rsa signatures

Signed-off-by: Simo Sorce <simo@redhat.com>
5 years agoChangeLog entry and comment fixes.
Niels Möller [Sat, 24 Nov 2018 09:43:35 +0000 (10:43 +0100)]
ChangeLog entry and comment fixes.

5 years agoAdd side-channel silent RSA root function
Simo Sorce [Thu, 8 Nov 2018 16:15:59 +0000 (11:15 -0500)]
Add side-channel silent RSA root function

Signed-off-by: Simo Sorce <simo@redhat.com>
5 years agoChangeLog for previous change.
Niels Möller [Sat, 24 Nov 2018 09:28:42 +0000 (10:28 +0100)]
ChangeLog for previous change.

5 years agoAdd convenience macro for size calculation
Simo Sorce [Thu, 8 Nov 2018 19:47:13 +0000 (14:47 -0500)]
Add convenience macro for size calculation

Returns number of limbs needed to contain N bytes long number.

Signed-off-by: Simo Sorce <simo@redhat.com>
5 years agoInitial NEWS entries for nettle-3.4.1.
Niels Möller [Sat, 24 Nov 2018 09:11:39 +0000 (10:11 +0100)]
Initial NEWS entries for nettle-3.4.1.

5 years agoBump version numbers for nettle-3.4.1.
Niels Möller [Sat, 24 Nov 2018 09:09:31 +0000 (10:09 +0100)]
Bump version numbers for nettle-3.4.1.

* configure.ac: Bump package version to 3.4.1.
(LIBNETTLE_MINOR): Bump library version to 6.5.
(LIBHOGWEED_MINOR): Bump library version to 4.5.

5 years agoAdd "fall through" comment.
Niels Möller [Tue, 16 Jan 2018 21:50:28 +0000 (22:50 +0100)]
Add "fall through" comment.

(cherry picked from commit c4a814d77d475c474182e3e7051e4ac304e3c9e8)

5 years agoCopy .gitlab-ci.yml from master branch
Niels Möller [Mon, 19 Nov 2018 20:24:29 +0000 (21:24 +0100)]
Copy .gitlab-ci.yml from master branch

5 years agoFix quoting in autoconf ifunc test
Dmitry Eremin-Solenikov [Wed, 13 Jun 2018 09:41:40 +0000 (12:41 +0300)]
Fix quoting in autoconf ifunc test

* aclocal.m4 (NETTLE_CHECK_IFUNC): fix quoting so that
  AC_LINK_IFELSE/AC_TRY_LINK is defined outside of this test.

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
(cherry picked from commit e07e5605b3da65e07c7fe5fcf1ce3b050595d1b5)

5 years agotestsuite/symbols-test: Exclude ____chkstk_darwin symbols.
Dominyk Tiller [Sun, 17 Jun 2018 17:20:09 +0000 (19:20 +0200)]
testsuite/symbols-test: Exclude ____chkstk_darwin symbols.

These are produced by Apple's Xcode 10 compiler.

(cherry picked from commit f3e2607fce0c6da41eb1d9ee89b9535d4abec7be)

5 years agoFix link failure for pss-mgf1-test, in non-hogweed builds.
Niels Möller [Sun, 18 Feb 2018 09:18:00 +0000 (10:18 +0100)]
Fix link failure for pss-mgf1-test, in non-hogweed builds.

(cherry picked from commit c5fc9131b13d53b07b7aa371f30df8621cf2abb8)

5 years agotools/pkcs1-conv.c: Add missing break statements.
Niels Möller [Tue, 16 Jan 2018 21:49:37 +0000 (22:49 +0100)]
tools/pkcs1-conv.c: Add missing break statements.

(cherry picked from commit 20c7ba59e2cb54f1bec7d679dbdbe00c42bdd190)

5 years agoAvoid cast between incompatible function types.
Niels Möller [Thu, 9 Aug 2018 18:54:18 +0000 (20:54 +0200)]
Avoid cast between incompatible function types.

(cherry picked from commit 71f68cc45a269b206fc996309ef026f39d5af3df)

5 years agoAdd missing includes of stdlib.h.
Niels Möller [Wed, 10 Oct 2018 17:16:40 +0000 (19:16 +0200)]
Add missing includes of stdlib.h.

(cherry picked from commit 7b4d6de8044e73849c2f24ce0322ae3fc48765a6)

5 years agodes-compat.c: Change length argument type from uint32_t to size_t.
Niels Möller [Thu, 9 Aug 2018 18:27:57 +0000 (20:27 +0200)]
des-compat.c: Change length argument type from uint32_t to size_t.

(cherry picked from commit f3bbc422efed4149b5661e064360ee678b23113a)

5 years agoAdd benchmarking of RSA signatures with blinding
Niels Möller [Sat, 17 Nov 2018 13:23:06 +0000 (14:23 +0100)]
Add benchmarking of RSA signatures with blinding

5 years agoctr16: fix encryption if src == dst
Dmitry Eremin-Solenikov [Wed, 10 Oct 2018 17:26:25 +0000 (19:26 +0200)]
ctr16: fix encryption if src == dst

5 years agoAdd missing includes of stdlib.h.
Niels Möller [Wed, 10 Oct 2018 17:16:40 +0000 (19:16 +0200)]
Add missing includes of stdlib.h.

5 years agorsa_generate_keypair: Delete unlikely and redundant check for p == q.
Niels Möller [Thu, 13 Sep 2018 06:18:16 +0000 (08:18 +0200)]
rsa_generate_keypair: Delete unlikely and redundant check for p == q.

5 years agoMerge branch 'attribute-deprecated'
Niels Möller [Thu, 13 Sep 2018 06:14:09 +0000 (08:14 +0200)]
Merge branch 'attribute-deprecated'

5 years agoFix mis-spelling spotted by Torbjörn Granlund.
Niels Möller [Fri, 7 Sep 2018 07:09:37 +0000 (09:09 +0200)]
Fix mis-spelling spotted by Torbjörn Granlund.

5 years agoMark obsolete helpers _rsa_blind and _rsa_unblind as deprecated.
Niels Möller [Thu, 9 Aug 2018 20:00:03 +0000 (22:00 +0200)]
Mark obsolete helpers _rsa_blind and _rsa_unblind as deprecated.

5 years agoDeprecate old AES interface.
Niels Möller [Thu, 9 Aug 2018 19:53:55 +0000 (21:53 +0200)]
Deprecate old AES interface.

Use new macro _NETTLE_ATTTRIBUTE_DEPRECATED.

5 years agoNew macro _NETTLE_ATTRIBUTE_PURE.
Niels Möller [Thu, 9 Aug 2018 19:09:11 +0000 (21:09 +0200)]
New macro _NETTLE_ATTRIBUTE_PURE.

5 years agoAvoid cast between incompatible function types.
Niels Möller [Thu, 9 Aug 2018 18:54:18 +0000 (20:54 +0200)]
Avoid cast between incompatible function types.

5 years agodes-compat.c: Change length argument type from uint32_t to size_t.
Niels Möller [Thu, 9 Aug 2018 18:27:57 +0000 (20:27 +0200)]
des-compat.c: Change length argument type from uint32_t to size_t.

5 years agonettle.texinfo: New section on ABI and API compatibility.
Niels Möller [Wed, 8 Aug 2018 20:31:01 +0000 (22:31 +0200)]
nettle.texinfo: New section on ABI and API compatibility.

5 years agoChangeLog entry for previous change.
Niels Möller [Mon, 30 Jul 2018 16:36:14 +0000 (18:36 +0200)]
ChangeLog entry for previous change.

5 years agoAdd benchmarking for HMAC functions
Dmitry Eremin-Solenikov [Wed, 25 Jul 2018 11:53:21 +0000 (14:53 +0300)]
Add benchmarking for HMAC functions

In preparation of changing internal HMAC interface add benchmarking for
HMAC functions.

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
5 years agoAdditional analogous assert in eratosthenese program.
Niels Möller [Fri, 13 Jul 2018 18:18:46 +0000 (20:18 +0200)]
Additional analogous assert in eratosthenese program.

5 years agoCheck for allocation overflow in eratosthenes program.
Niels Möller [Fri, 13 Jul 2018 17:38:59 +0000 (19:38 +0200)]
Check for allocation overflow in eratosthenes program.

5 years agoFix handling of eratosthenes -q.
Niels Möller [Thu, 12 Jul 2018 20:39:00 +0000 (22:39 +0200)]
Fix handling of eratosthenes -q.

5 years agoFix at-exit leak in eratosthenes program.
Niels Möller [Thu, 12 Jul 2018 20:37:36 +0000 (22:37 +0200)]
Fix at-exit leak in eratosthenes program.

5 years agoMake eccdata deallocate storage before exit.
Niels Möller [Thu, 12 Jul 2018 20:34:01 +0000 (22:34 +0200)]
Make eccdata deallocate storage before exit.

5 years agoFix memory leak in eccdata.
Niels Möller [Thu, 12 Jul 2018 20:32:59 +0000 (22:32 +0200)]
Fix memory leak in eccdata.

5 years ago.gitlab-ci.yml: added cross compilation and tests on mips/aarch64/arm
Nikos Mavrogiannopoulos [Tue, 10 Jul 2018 18:58:36 +0000 (20:58 +0200)]
.gitlab-ci.yml: added cross compilation and tests on mips/aarch64/arm

This utilizes the qemu-user system used by gnutls. This also
deprecates the previous aarch64 build.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
5 years agoFix arm fat setup for nettle_sha1_compress.
Niels Möller [Thu, 12 Jul 2018 08:24:00 +0000 (10:24 +0200)]
Fix arm fat setup for nettle_sha1_compress.

5 years ago.gitlab-ci.yml: updated build images to latest used by gnutls
Nikos Mavrogiannopoulos [Mon, 9 Jul 2018 06:44:09 +0000 (08:44 +0200)]
.gitlab-ci.yml: updated build images to latest used by gnutls

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>
5 years agoFix x86_64 fat setup for nettle_sha1_compress.
Niels Möller [Sun, 8 Jul 2018 07:57:04 +0000 (09:57 +0200)]
Fix x86_64 fat setup for nettle_sha1_compress.

5 years ago.gitlab-ci.yml: link with shared library on x86-64 build
Nikos Mavrogiannopoulos [Tue, 12 Jun 2018 11:26:00 +0000 (13:26 +0200)]
.gitlab-ci.yml: link with shared library on x86-64 build

This allows testing whether exported symbols are sufficient for the
included test suite.

5 years agoAdd two missing includes of the new internal headers.
Niels Möller [Sat, 7 Jul 2018 20:10:41 +0000 (22:10 +0200)]
Add two missing includes of the new internal headers.

5 years agoChangeLog for previous change.
Niels Möller [Sat, 7 Jul 2018 20:10:03 +0000 (22:10 +0200)]
ChangeLog for previous change.

5 years agoabi: explicitly export intended symbols and hide others
Nikos Mavrogiannopoulos [Wed, 6 Jun 2018 13:17:00 +0000 (15:17 +0200)]
abi: explicitly export intended symbols and hide others

This adds all exported symbols in the map files explicitly under
the following rules:
 - Symbols mentioned in internal headers go in a section which is
   valid only for testing, and linking with these symbols will break
   in library updates.
 - Symbols mentioned in installed headers go in the exported sections
   and are considered part of the ABI.
 - All internal symbols move to internal headers.
 - The _nettle_md5_compress and _nettle_sha1_compress become exported
   without the _nettle prefix, due to existing usage.

5 years agoComment fix.
Niels Möller [Sat, 7 Jul 2018 19:24:26 +0000 (21:24 +0200)]
Comment fix.

5 years agoChangeLog entry for previous change.
Niels Möller [Sun, 17 Jun 2018 17:29:12 +0000 (19:29 +0200)]
ChangeLog entry for previous change.

5 years agoFix quoting in autoconf ifunc test
Dmitry Eremin-Solenikov [Wed, 13 Jun 2018 09:41:40 +0000 (12:41 +0300)]
Fix quoting in autoconf ifunc test

* aclocal.m4 (NETTLE_CHECK_IFUNC): fix quoting so that
  AC_LINK_IFELSE/AC_TRY_LINK is defined outside of this test.

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
5 years agotestsuite/symbols-test: Exclude ____chkstk_darwin symbols.
Dominyk Tiller [Sun, 17 Jun 2018 17:20:09 +0000 (19:20 +0200)]
testsuite/symbols-test: Exclude ____chkstk_darwin symbols.

These are produced by Apple's Xcode 10 compiler.

6 years agoMerge branch 'rename-data-symbols' into master-updates
Niels Möller [Tue, 27 Mar 2018 21:07:50 +0000 (23:07 +0200)]
Merge branch 'rename-data-symbols' into master-updates

6 years agoUpdate NEWS file.
Niels Möller [Sun, 25 Mar 2018 20:29:25 +0000 (22:29 +0200)]
Update NEWS file.

6 years agoChangeLog entries for ARM big-endian changes.
Niels Möller [Sun, 25 Mar 2018 09:42:48 +0000 (11:42 +0200)]
ChangeLog entries for ARM big-endian changes.

6 years agoDocument arm endianness considerations
Michael Weiser [Tue, 13 Feb 2018 21:13:14 +0000 (22:13 +0100)]
Document arm endianness considerations

Extend arm/README to provide some background on considerations to be taken into
account when writing assembly routines supposed to work in big and little memory
endianness.

6 years agoSupport big-endian arm in assembly code
Michael Weiser [Tue, 13 Feb 2018 21:13:13 +0000 (22:13 +0100)]
Support big-endian arm in assembly code

Adjust sha1-compress, sha256-compress, umac-nh, chacha-core-internal,
salsa20-core-internal and memxor for arm to work in big-endian mode.

6 years agoAdd arm endianness-aware assembly infrastructure
Michael Weiser [Tue, 13 Feb 2018 21:13:12 +0000 (22:13 +0100)]
Add arm endianness-aware assembly infrastructure

Introduce m4 macros to conditionally handle differences of little- and
big-endian arm in assembler code.

6 years agoAdd leading underscore to data symbols.
Niels Möller [Sat, 17 Mar 2018 16:25:03 +0000 (17:25 +0100)]
Add leading underscore to data symbols.

6 years agoUpdate NEWS file.
Niels Möller [Wed, 14 Mar 2018 21:12:32 +0000 (22:12 +0100)]
Update NEWS file.

6 years agoMerge branch 'ecc-params-tweak' into master-updates
Niels Möller [Wed, 14 Mar 2018 18:25:42 +0000 (19:25 +0100)]
Merge branch 'ecc-params-tweak' into master-updates

6 years agoMerge branch 'x86_64-sha_ni-sha256'
Niels Möller [Wed, 14 Mar 2018 18:21:33 +0000 (19:21 +0100)]
Merge branch 'x86_64-sha_ni-sha256'

6 years agoSupport sha_ni sha256_compress in x86_64 fat builds.
Niels Möller [Sun, 11 Mar 2018 21:23:59 +0000 (22:23 +0100)]
Support sha_ni sha256_compress in x86_64 fat builds.

6 years agoTweak parameters for ecc tables.
Niels Möller [Sat, 10 Mar 2018 17:12:42 +0000 (18:12 +0100)]
Tweak parameters for ecc tables.

6 years agoMake eccdata warn about poor parameters.
Niels Möller [Sat, 10 Mar 2018 15:44:43 +0000 (16:44 +0100)]
Make eccdata warn about poor parameters.

6 years agoNew program eccparams.
Niels Möller [Sat, 10 Mar 2018 14:50:34 +0000 (15:50 +0100)]
New program eccparams.

6 years agoMerge branch 'cmac-support'
Niels Möller [Wed, 21 Feb 2018 22:07:31 +0000 (23:07 +0100)]
Merge branch 'cmac-support'

6 years agoNew sha256 implementation using sha_ni instructions.
Niels Möller [Wed, 21 Feb 2018 22:04:44 +0000 (23:04 +0100)]
New sha256 implementation using sha_ni instructions.

6 years agoUpdate CBC and CFB tests to use aes256_ctx, not the deprecated aes_ctx.
Niels Möller [Tue, 20 Feb 2018 21:48:15 +0000 (22:48 +0100)]
Update CBC and CFB tests to use aes256_ctx, not the deprecated aes_ctx.

6 years ago(test_cmac_hash): Deallocate ctx properly.
Niels Möller [Tue, 20 Feb 2018 21:41:37 +0000 (22:41 +0100)]
(test_cmac_hash): Deallocate ctx properly.

6 years agoUpdate RSA examples to use aes256_ctx, not the deprecated aes_ctx.
Niels Möller [Tue, 20 Feb 2018 18:31:41 +0000 (19:31 +0100)]
Update RSA examples to use aes256_ctx, not the deprecated aes_ctx.

6 years agoDelete unused struct process_ctx.
Niels Möller [Tue, 20 Feb 2018 18:20:34 +0000 (19:20 +0100)]
Delete unused struct process_ctx.

6 years agoMostly aesthetic changes to CMAC.
Niels Möller [Mon, 19 Feb 2018 21:25:18 +0000 (22:25 +0100)]
Mostly aesthetic changes to CMAC.

6 years agoAdd ChangeLog entries for CMAC.
Niels Möller [Mon, 19 Feb 2018 21:07:59 +0000 (22:07 +0100)]
Add ChangeLog entries for CMAC.

6 years agoReindent CMAC code to GNU standard, white space changes only.
Niels Möller [Mon, 19 Feb 2018 20:42:39 +0000 (21:42 +0100)]
Reindent CMAC code to GNU standard, white space changes only.

6 years agoAdded support for CMAC
Nikos Mavrogiannopoulos [Wed, 10 Jan 2018 08:29:17 +0000 (09:29 +0100)]
Added support for CMAC

That adds support for CMAC as a generic framework for
128-bit block and key ciphers, as well as API for AES-128-CMAC,
and AES-256-CMAC.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>
6 years agoNew macros TMP_DECL_ALIGN and TMP_ALLOC_ALIGN.
Niels Möller [Mon, 19 Feb 2018 18:23:40 +0000 (19:23 +0100)]
New macros TMP_DECL_ALIGN and TMP_ALLOC_ALIGN.

6 years agoFix link failure for pss-mgf1-test, in non-hogweed builds.
Niels Möller [Sun, 18 Feb 2018 09:18:00 +0000 (10:18 +0100)]
Fix link failure for pss-mgf1-test, in non-hogweed builds.

6 years agoChangeLog for previous change.
Niels Möller [Sun, 18 Feb 2018 09:17:09 +0000 (10:17 +0100)]
ChangeLog for previous change.

6 years agoMove expressions with side effects out of asserts
Dmitry Eremin-Solenikov [Sat, 17 Feb 2018 09:57:12 +0000 (12:57 +0300)]
Move expressions with side effects out of asserts

It is wrong to use expressions with side-effects in asserts, they can
easily be compiled away. Move them out of assert() macro and just
compare the result.

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
6 years agoChangeLog for previous changes.
Niels Möller [Sat, 17 Feb 2018 09:22:12 +0000 (10:22 +0100)]
ChangeLog for previous changes.