garming/samba-autobuild/.git
7 months agos3:smbd: don't use async dosmode if per-thread cwd is not available
Ralph Boehme [Mon, 7 Jan 2019 20:10:19 +0000 (21:10 +0100)]
s3:smbd: don't use async dosmode if per-thread cwd is not available

The additional overhead for the async processing should be avoided when
we know the lower level has to fallback to sync processing anyway.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agos3:smbd: use passed in ev in smbd_smb2_query_directory_send()
Ralph Boehme [Fri, 28 Dec 2018 12:25:57 +0000 (13:25 +0100)]
s3:smbd: use passed in ev in smbd_smb2_query_directory_send()

The ev argument is also a raw ev.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "vfs_glusterfs: explain that/why we use the raw tevent_context in init_gluster...
Ralph Boehme [Thu, 27 Dec 2018 14:26:08 +0000 (15:26 +0100)]
Revert "vfs_glusterfs: explain that/why we use the raw tevent_context in init_gluster_aio()"

This reverts commit b0af5715b0a7592a9728e0b76f653b9ab6228708.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "smbd: explain that/why we use the raw tevent_context for update_write_time_ha...
Ralph Boehme [Thu, 27 Dec 2018 14:26:03 +0000 (15:26 +0100)]
Revert "smbd: explain that/why we use the raw tevent_context for update_write_time_handler()"

This reverts commit 7cfafaf190643eb28fc95d21a02a4e5e529e16d1.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "smbd: explain that/why we use the raw tevent_context for lease_timeout_handler()"
Ralph Boehme [Thu, 27 Dec 2018 14:24:37 +0000 (15:24 +0100)]
Revert "smbd: explain that/why we use the raw tevent_context for lease_timeout_handler()"

This reverts commit 52f098d38da72d6eff3c4cac61487da897a8651c.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "smbd: explain that/why we use the raw tevent_context for oplock_timeout_handl...
Ralph Boehme [Thu, 27 Dec 2018 14:23:52 +0000 (15:23 +0100)]
Revert "smbd: explain that/why we use the raw tevent_context for oplock_timeout_handler()"

This reverts commit e73eaa3c8004d3d8aff316cdb26b0bef85eceaca.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "smbd: explain that/why we use the raw tevent_context for do_break_to_none()"
Ralph Boehme [Thu, 27 Dec 2018 14:23:43 +0000 (15:23 +0100)]
Revert "smbd: explain that/why we use the raw tevent_context for do_break_to_none()"

This reverts commit 1d5210b615035e46b90758ac7aa4ceec9174bee5.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "smbd: explain that/why we use the raw tevent_context for linux_oplock_signal_...
Ralph Boehme [Thu, 27 Dec 2018 14:21:06 +0000 (15:21 +0100)]
Revert "smbd: explain that/why we use the raw tevent_context for linux_oplock_signal_handler()"

This reverts commit dc517b20f60a156d73fdd551557eb1d4366dfdeb.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "smbd: use raw_ev_ctx to clear the MSG_SMB_CONF_UPDATED registration"
Ralph Boehme [Thu, 27 Dec 2018 14:21:04 +0000 (15:21 +0100)]
Revert "smbd: use raw_ev_ctx to clear the MSG_SMB_CONF_UPDATED registration"

This reverts commit f5f9b719741465c7be3de20a6a69ec106ecc4568.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "smbd: add smbd_server_connection->{root,guest}_ev_ctx pointer"
Ralph Boehme [Thu, 27 Dec 2018 14:21:01 +0000 (15:21 +0100)]
Revert "smbd: add smbd_server_connection->{root,guest}_ev_ctx pointer"

This reverts commit 146938217ed1ab9a7a9f38c055fec5513cbd5c4d.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "smbd: use sconn->root_ev_ctx for brl_timeout_fn()"
Ralph Boehme [Thu, 27 Dec 2018 14:20:58 +0000 (15:20 +0100)]
Revert "smbd: use sconn->root_ev_ctx for brl_timeout_fn()"

This reverts commit 182991c26c8149c79b13a277b9822efc49fd1df0.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "smbd: use sconn->root_ev_ctx for smbd_sig_{term,hup}_handler()"
Ralph Boehme [Thu, 27 Dec 2018 14:20:54 +0000 (15:20 +0100)]
Revert "smbd: use sconn->root_ev_ctx for smbd_sig_{term,hup}_handler()"

This reverts commit c835ffa72ddfd2431d22909148913b50f0d829d1.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "smbd: add an effective connection_struct->user_ev_ctx that holds the event...
Ralph Boehme [Thu, 27 Dec 2018 14:19:20 +0000 (15:19 +0100)]
Revert "smbd: add an effective connection_struct->user_ev_ctx that holds the event context used for the current user"

This reverts commit f2df8be16be9dccd3d10ec060f1efbe5007a28c6.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "smbd: add an effective {smb,smbd_smb2}_request->ev_ctx that holds the event...
Ralph Boehme [Thu, 27 Dec 2018 14:18:55 +0000 (15:18 +0100)]
Revert "smbd: add an effective {smb,smbd_smb2}_request->ev_ctx that holds the event context used for the request processing"

This reverts commit 894e5001c747ce765dad5517778dda55d7d1f4d9.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "smbd: remove unused smbd_server_connection->ev_ctx"
Ralph Boehme [Thu, 27 Dec 2018 14:17:22 +0000 (15:17 +0100)]
Revert "smbd: remove unused smbd_server_connection->ev_ctx"

This reverts commit 721fbbfa7001b2788602106101f0407483894322.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "s3:messages: protect against usage of wrapper tevent_context objects for...
Ralph Boehme [Thu, 27 Dec 2018 11:48:30 +0000 (12:48 +0100)]
Revert "s3:messages: protect against usage of wrapper tevent_context objects for messaging"

This reverts commit 7f2afc20e1b6397c364a98d1be006377c95e4665.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "s3:messages: allow messaging_{dgm,ctdb}_register_tevent_context() to use...
Ralph Boehme [Thu, 27 Dec 2018 11:45:42 +0000 (12:45 +0100)]
Revert "s3:messages: allow messaging_{dgm,ctdb}_register_tevent_context() to use wrapper tevent_context"

This reverts commit 660cf86639753edaa7a7a21a5b5ae207ae7d4260.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "s3:messages: allow messaging_dgm_ref() to use wrapper tevent_context"
Ralph Boehme [Thu, 27 Dec 2018 11:45:28 +0000 (12:45 +0100)]
Revert "s3:messages: allow messaging_dgm_ref() to use wrapper tevent_context"

This reverts commit 9dc332060cf5f249ea887dbc60ec7a39b6f91120.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "s3:messages: allow messaging_filtered_read_send() to use wrapper tevent_context"
Ralph Boehme [Thu, 27 Dec 2018 11:45:15 +0000 (12:45 +0100)]
Revert "s3:messages: allow messaging_filtered_read_send() to use wrapper tevent_context"

This reverts commit 2b05f1098187e00166649c8ea7c63e6901b9d242.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "s4:messaging: make sure only imessaging_client_init() can be used with a...
Ralph Boehme [Thu, 27 Dec 2018 11:41:25 +0000 (12:41 +0100)]
Revert "s4:messaging: make sure only imessaging_client_init() can be used with a wrapper tevent_context wrapper"

This reverts commit e186d6a06b1b300256a2cb4138f0532d518d0597.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "smbd: add [un]become_guest() helper functions"
Ralph Boehme [Thu, 27 Dec 2018 10:42:45 +0000 (11:42 +0100)]
Revert "smbd: add [un]become_guest() helper functions"

This reverts commit 7b5a47b84696e8e5c26207bd398742b883e598c2.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "smbd: add smbd_impersonate_debug_create() helper"
Ralph Boehme [Thu, 27 Dec 2018 10:41:57 +0000 (11:41 +0100)]
Revert "smbd: add smbd_impersonate_debug_create() helper"

This reverts commit 23319ef5a2eff4811b685d4ab54179efc49bac99.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "smbd: add simple noop smbd_impersonate_{conn_vuid,conn_sess,root,guest}_creat...
Ralph Boehme [Thu, 27 Dec 2018 10:38:36 +0000 (11:38 +0100)]
Revert "smbd: add simple noop smbd_impersonate_{conn_vuid,conn_sess,root,guest}_create() wrappers"

This reverts commit 5285966e67cbee8519015df12a15e938e85e6ee7.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "smbd: make use of smbd_impersonate_{conn_vuid,conn_sess,root,guest}_create...
Ralph Boehme [Thu, 27 Dec 2018 10:38:34 +0000 (11:38 +0100)]
Revert "smbd: make use of smbd_impersonate_{conn_vuid,conn_sess,root,guest}_create() wrappers"

This reverts commit 0dcaa0707bad67f7bfaa10ccaf167bfefbe87a0c.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "smbd: implement smbd_impersonate_{conn_vuid,conn_sess,root,guest}_create...
Ralph Boehme [Thu, 27 Dec 2018 10:38:27 +0000 (11:38 +0100)]
Revert "smbd: implement smbd_impersonate_{conn_vuid,conn_sess,root,guest}_create() wrappers"

This reverts commit 1b804f7ae23f54a6c1004e5ff17b9df1376b5adb.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "smbd: avoid explicit change_to_user() in defer_rename_done() already done...
Ralph Boehme [Thu, 27 Dec 2018 10:37:16 +0000 (11:37 +0100)]
Revert "smbd: avoid explicit change_to_user() in defer_rename_done() already done by impersonation"

This reverts commit e37e41b3cac52e3623f0c79f83733a51edb35c10.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "smbd: remove unused change_to_root_user() from smbd_sig_hup_handler()"
Ralph Boehme [Thu, 27 Dec 2018 10:37:03 +0000 (11:37 +0100)]
Revert "smbd: remove unused change_to_root_user() from smbd_sig_hup_handler()"

This reverts commit d0b1f96f086bdd613644f64b3f75ee8c4388f674.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "smbd: remove unused change_to_root_user() from brl_timeout_fn()"
Ralph Boehme [Thu, 27 Dec 2018 10:36:43 +0000 (11:36 +0100)]
Revert "smbd: remove unused change_to_root_user() from brl_timeout_fn()"

This reverts commit c310647e560abc2343ef2ff0ab15daab0fba2650.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "pthreadpool: split out pthreadpool_tevent_job from pthreadpool_tevent_job_state"
Ralph Boehme [Fri, 28 Dec 2018 08:03:45 +0000 (09:03 +0100)]
Revert "pthreadpool: split out pthreadpool_tevent_job from pthreadpool_tevent_job_state"

This reverts commit 245d684d28dab630f3d47ff61006a1fe3e5eeefa.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "pthreadpool: add pthreadpool_tevent_job_cancel()"
Ralph Boehme [Fri, 28 Dec 2018 08:03:34 +0000 (09:03 +0100)]
Revert "pthreadpool: add pthreadpool_tevent_job_cancel()"

This reverts commit 791c05144ee9296024cc0fdebe4afeaaf67e26bc.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "pthreadpool: maintain a global list of orphaned pthreadpool_tevent_jobs"
Ralph Boehme [Fri, 28 Dec 2018 08:02:54 +0000 (09:02 +0100)]
Revert "pthreadpool: maintain a global list of orphaned pthreadpool_tevent_jobs"

This reverts commit 25756425aaf5465e56ea809cd415b6a387848919.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "pthreadpool: add some lockless coordination between the main and job threads"
Ralph Boehme [Sun, 23 Dec 2018 08:46:13 +0000 (09:46 +0100)]
Revert "pthreadpool: add some lockless coordination between the main and job threads"

This reverts commit 9656b8d8ee11ee351870286f16ea8fbe49112292.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "pthreadpool: add helgrind magic to PTHREAD_TEVENT_JOB_THREAD_FENCE_*()"
Ralph Boehme [Sun, 23 Dec 2018 08:44:49 +0000 (09:44 +0100)]
Revert "pthreadpool: add helgrind magic to PTHREAD_TEVENT_JOB_THREAD_FENCE_*()"

This reverts commit 9b73fda926eb8493e80012794483039be66d4e6c.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "pthreadpool: maintain a list of job_states on each pthreadpool_tevent_glue"
Ralph Boehme [Sun, 23 Dec 2018 08:44:32 +0000 (09:44 +0100)]
Revert "pthreadpool: maintain a list of job_states on each pthreadpool_tevent_glue"

This reverts commit aa9b64eccfd037941512bad108c4e3946714a502.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "pthreadpool: add a comment about a further optimization in pthreadpool_tevent...
Ralph Boehme [Sun, 23 Dec 2018 08:44:22 +0000 (09:44 +0100)]
Revert "pthreadpool: add a comment about a further optimization in pthreadpool_tevent_job_destructor()"

This reverts commit f23cac39b36b026650e0922c78fe0fd3fe567e35.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "pthreadpool: test cancelling and freeing pending pthreadpool_tevent jobs...
Ralph Boehme [Sun, 23 Dec 2018 08:44:07 +0000 (09:44 +0100)]
Revert "pthreadpool: test cancelling and freeing pending pthreadpool_tevent jobs/pools"

This reverts commit 40d15260d24d0071732f47873f395fce29b8a6f4.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "pthreadpool: add pthreadpool_tevent_[current_job_]per_thread_cwd()"
Ralph Boehme [Mon, 7 Jan 2019 20:27:19 +0000 (21:27 +0100)]
Revert "pthreadpool: add pthreadpool_tevent_[current_job_]per_thread_cwd()"

This reverts commit 12a45ee1a66379ba7562729b835ce0e2e4bfb3b3.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "pthreadpool: add tests for pthreadpool_tevent_[current_job_]per_thread_cwd()"
Ralph Boehme [Sun, 23 Dec 2018 08:43:25 +0000 (09:43 +0100)]
Revert "pthreadpool: add tests for pthreadpool_tevent_[current_job_]per_thread_cwd()"

This reverts commit fbafdc99ef2cef11a1a28e795ffe965cb53ef7fa.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "pthreadpool: call unshare(CLONE_FS) if available"
Ralph Boehme [Mon, 7 Jan 2019 17:35:27 +0000 (18:35 +0100)]
Revert "pthreadpool: call unshare(CLONE_FS) if available"

This reverts commit 65e4742d168454df6507d9e74993749063435dd6.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "pthreadpool: add pthreadpool_restart_check[_monitor_{fd,drain}]()"
Ralph Boehme [Sun, 23 Dec 2018 08:43:07 +0000 (09:43 +0100)]
Revert "pthreadpool: add pthreadpool_restart_check[_monitor_{fd,drain}]()"

This reverts commit 3c4cdb290723432b00ff9ff88b892cb4e66e76cd.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "pthreadpool: implement pthreadpool_tevent_wrapper_create() infrastructure"
Ralph Boehme [Sun, 23 Dec 2018 08:42:53 +0000 (09:42 +0100)]
Revert "pthreadpool: implement pthreadpool_tevent_wrapper_create() infrastructure"

This reverts commit f9745d8b5234091c38e93ed57a255120b61f3ad7.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "pthreadpool: test cancelling and freeing jobs of a wrapped pthreadpool_tevent"
Ralph Boehme [Sun, 23 Dec 2018 08:42:37 +0000 (09:42 +0100)]
Revert "pthreadpool: test cancelling and freeing jobs of a wrapped pthreadpool_tevent"

This reverts commit fb6b6cf3e43165ced4b1039f2683d19f277c0792.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agosmbd: rename sconn->raw_thread_pool to sconn->pool
Ralph Boehme [Sun, 23 Dec 2018 08:34:20 +0000 (09:34 +0100)]
smbd: rename sconn->raw_thread_pool to sconn->pool

This is basically a revert of commit
2be7518ae5a3c046f5fca04ecc83f9f7044eac74.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "smbd: introduce sconn->sync_thread_pool"
Ralph Boehme [Sun, 23 Dec 2018 08:34:00 +0000 (09:34 +0100)]
Revert "smbd: introduce sconn->sync_thread_pool"

This reverts commit 0c97226356f2ba5f01a58d361371055caf11e2a7.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "s3: vfs: add smb_vfs_ev_glue"
Ralph Boehme [Fri, 28 Dec 2018 12:08:14 +0000 (13:08 +0100)]
Revert "s3: vfs: add smb_vfs_ev_glue"

This reverts commit 1251a536df4b1df58d9ddacab03d3ebe6f4e5b60.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "s3: vfs: add user_vfs_evg to connection_struct"
Ralph Boehme [Sun, 23 Dec 2018 08:25:32 +0000 (09:25 +0100)]
Revert "s3: vfs: add user_vfs_evg to connection_struct"

This reverts commit 2dd95c1c38b9e1ce32d3d1081b6ec177910087a4.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "vfs_aio_pthread: use event context and threadpool from user_vfs_evg"
Ralph Boehme [Sun, 23 Dec 2018 08:24:51 +0000 (09:24 +0100)]
Revert "vfs_aio_pthread: use event context and threadpool from user_vfs_evg"

This reverts commit cd37badc02b3e56f974168b28447444cd54ee541.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "pthreadpool: we need to use pthreadpool_tevent_per_thread_cwd() on the caller...
Ralph Boehme [Sun, 23 Dec 2018 08:23:48 +0000 (09:23 +0100)]
Revert "pthreadpool: we need to use pthreadpool_tevent_per_thread_cwd() on the callers pool"

This reverts commit ff863f2d98ac5e12073af824b794404c3d7198c5.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "pthreadpool: ignore the return value of poll(NULL, 0UL, 1)"
Ralph Boehme [Sun, 23 Dec 2018 08:12:34 +0000 (09:12 +0100)]
Revert "pthreadpool: ignore the return value of poll(NULL, 0UL, 1)"

This reverts commit 6da0d68f49bbd82f5a08427779c9f5ebd6f755aa.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoRevert "pthreadpool: reset monitor_fd after calling tevent_fd_set_auto_close()"
Ralph Boehme [Sun, 23 Dec 2018 08:12:10 +0000 (09:12 +0100)]
Revert "pthreadpool: reset monitor_fd after calling tevent_fd_set_auto_close()"

This reverts commit f68b5ee75f002ed542a8423070fb01e3b0e83f65.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agos3:smbd: pass (raw) ev to fetch_dos_mode_send instead of smb_vfs_ev_glue
Ralph Boehme [Fri, 28 Dec 2018 11:19:08 +0000 (12:19 +0100)]
s3:smbd: pass (raw) ev to fetch_dos_mode_send instead of smb_vfs_ev_glue

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agos3:smbd: pass (raw) ev to dos_mode_at_send() instead of smb_vfs_ev_glue
Ralph Boehme [Fri, 28 Dec 2018 11:16:27 +0000 (12:16 +0100)]
s3:smbd: pass (raw) ev to dos_mode_at_send() instead of smb_vfs_ev_glue

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agos3:smbd: pass (raw) ev to SMB_VFS_GET_DOS_ATTRIBUTES_SEND() instead of smb_vfs_ev_glue
Ralph Boehme [Fri, 28 Dec 2018 11:12:20 +0000 (12:12 +0100)]
s3:smbd: pass (raw) ev to SMB_VFS_GET_DOS_ATTRIBUTES_SEND() instead of smb_vfs_ev_glue

This also removes smb_vfs_ev_glue_[push|pop]_use() as the only caller
got removed.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agos3:smbd: let SMB_VFS_GETXATTRAT_SEND() do explicit impersonation
Ralph Boehme [Thu, 27 Dec 2018 15:32:46 +0000 (16:32 +0100)]
s3:smbd: let SMB_VFS_GETXATTRAT_SEND() do explicit impersonation

SMB_VFS_GETXATTRAT_SEND() gets passed a raw event context and the
default implementation uses that as well a raw threadpool. Impersonation
is done explicitly instead of by the tevent and pthreadpool wrappers.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agos3:torture: call per_thread_cwd_check() in vfstest.c main()
Stefan Metzmacher [Fri, 11 Jan 2019 12:15:58 +0000 (13:15 +0100)]
s3:torture: call per_thread_cwd_check() in vfstest.c main()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
7 months agos3:smbd: prepare the usage of per_thread_cwd_*() functions
Stefan Metzmacher [Fri, 11 Jan 2019 12:13:04 +0000 (13:13 +0100)]
s3:smbd: prepare the usage of per_thread_cwd_*() functions

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
7 months agos3:lib: add per_thread_cwd_{check,supported,disable,activate}() helper functions
Stefan Metzmacher [Fri, 11 Jan 2019 11:47:40 +0000 (12:47 +0100)]
s3:lib: add per_thread_cwd_{check,supported,disable,activate}() helper functions

Only Linux it's possible to have a per thread current working directory
using unshare(CLONE_FS).

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
7 months agos3:lib: add root_unix_token()
Ralph Boehme [Fri, 16 Mar 2018 18:01:20 +0000 (19:01 +0100)]
s3:lib: add root_unix_token()

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoselftest: Improve an error message
Volker Lendecke [Fri, 7 Dec 2018 14:14:46 +0000 (15:14 +0100)]
selftest: Improve an error message

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Fri Jan 11 06:01:01 CET 2019 on sn-devel-144

7 months agodns: changing onelevel search for wildcard to subtree
Aaron Haslett [Wed, 9 Jan 2019 03:22:40 +0000 (16:22 +1300)]
dns: changing onelevel search for wildcard to subtree

SCOPE_ONELEVEL is used on wildcard dns searches, but onelevel searches
currently have a performance problem related to GUID indexing, so this
patch changes the search scope to SCOPE_SUBTREE.
In this case, as the onelevel and subtree sets of records are roughly
the same, and the query is matching against the DN itself, we don't
believe there's any benefit in using SCOPE_ONELEVEL over SCOPE_SUBTREE.

The onelevel performance problem will be fixed separately later, but in
the meantime this solves the DNS performance problem.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13738

Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
7 months agostatvfs: rename linux_statvfs to posix_statvfs
Björn Jacke [Wed, 9 Jan 2019 11:03:53 +0000 (12:03 +0100)]
statvfs: rename linux_statvfs to posix_statvfs

the statvfs call is posix standard and not Linux specific

Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Björn Jacke <bjacke@samba.org>
Autobuild-Date(master): Fri Jan 11 02:53:57 CET 2019 on sn-devel-144

7 months agowaf:lib/replace: fix a build error with non-gcc compilers
Björn Jacke [Sun, 6 Jan 2019 19:41:32 +0000 (20:41 +0100)]
waf:lib/replace: fix a build error with non-gcc compilers

3a175830e579ab10231439657b23733338cd5634 added that variable which should have
been an empty initialization here. -Wno-format-zero-length (which might be
unsupported by the compiler) should not be set if we really only want to
initialize the cflags.

Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agos3/smbd: fix utmp hostname logging on Solaris
Björn Jacke [Sun, 6 Jan 2019 20:35:14 +0000 (21:35 +0100)]
s3/smbd: fix utmp hostname logging on Solaris

BUG: https://bugzilla.samba.org/show_bug.cgi?id=2489

Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agowaf: check for utmpx struct member ut_host
Björn Jacke [Sun, 6 Jan 2019 19:46:20 +0000 (20:46 +0100)]
waf: check for utmpx struct member ut_host

BUG: https://bugzilla.samba.org/show_bug.cgi?id=2489

Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agonetcmd: Fix broken samba-tool gpo commands
Tim Beale [Thu, 10 Jan 2019 03:34:27 +0000 (16:34 +1300)]
netcmd: Fix broken samba-tool gpo commands

samba-tool gpo create|fetch|backup commands throw exceptions due to a
missing Python import:

ERROR(<class 'NameError'>): uncaught exception - name 'tempfile' is not
defined
  File "bin/python/samba/netcmd/__init__.py", line 184, in _run
    return self.run(*args, **kwargs)
  File "bin/python/samba/netcmd/gpo.py", line 980, in run
    tmpdir, gpodir = self.construct_tmpdir(tmpdir, gpo)
  File "bin/python/samba/netcmd/gpo.py", line 386, in construct_tmpdir
    tmpdir = tempfile.mkdtemp()

Introduced by commit e3320b6d3df7a0c7b refactor.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Thu Jan 10 16:21:23 CET 2019 on sn-devel-144

7 months agostatvfs: fix bsize and frsize mixup
Björn Jacke [Tue, 8 Jan 2019 09:38:06 +0000 (10:38 +0100)]
statvfs: fix bsize and frsize mixup

the block size (the real one) is the "fundamental file system block size" and
that is the frsize struct member in the statvfs struct. The bsize struct member
of the statvfs struct is *different* from the same named one of the statfs
struct.

See also http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_statvfs.h.html

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11810

Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Jan 10 09:40:06 CET 2019 on sn-devel-144

7 months agolib: replace: snprintf: Whitespace clean up
Ladislav Michl via samba-technical [Fri, 7 Dec 2018 08:35:25 +0000 (09:35 +0100)]
lib: replace: snprintf: Whitespace clean up

Remove spaces before tab, spaces at the end of line and white
chars on blank line.

Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
Reviewed-by: Björn Jacke <bjacke@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
7 months agoFix typo and remove the sun and the clouds
Swen Schillig [Mon, 7 Jan 2019 14:10:25 +0000 (15:10 +0100)]
Fix typo and remove the sun and the clouds

Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke@SerNet.DE>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Jan 10 06:14:27 CET 2019 on sn-devel-144

7 months agoFix typos and ban the rams from samba tdb-1.3.17
Swen Schillig [Mon, 7 Jan 2019 14:07:22 +0000 (15:07 +0100)]
Fix typos and ban the rams from samba

Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke@SerNet.DE>
7 months agoselftest: Remove duplicate dependency definition
Volker Lendecke [Wed, 2 Jan 2019 15:33:14 +0000 (16:33 +0100)]
selftest: Remove duplicate dependency definition

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
7 months agodsdb: Print strerror in addition to errno
Volker Lendecke [Thu, 14 Jun 2018 15:42:56 +0000 (17:42 +0200)]
dsdb: Print strerror in addition to errno

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
7 months agodns: Do NULL checks in dns_sign_tsig
Volker Lendecke [Wed, 6 Jun 2018 16:00:22 +0000 (18:00 +0200)]
dns: Do NULL checks in dns_sign_tsig

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
7 months agos3:libsmb: cli_smb2_list() can sometimes fail initially on a connection
Tim Beale [Mon, 7 Jan 2019 02:28:12 +0000 (15:28 +1300)]
s3:libsmb: cli_smb2_list() can sometimes fail initially on a connection

cli_smb2_list() appears to be a slightly unique SMB operation in that it
specifies the max transaction size for the response buffer size. The
Python bindings highlighted a problem where if cli_smb2_list() were one
of the first operations performed on the SMBv2 connection, it would fail
due to insufficient credits. Because the response buffer size is
(potentially) so much larger, it requires more credits (128) compared
with other SMB operations.

When talking to a samba DC, the connection credits seem to start off at
1, then increase by 32 for every SMB reply we receive back from the
server. After cli_full_connection(), the connection has 65 credits. The
cli_smb2_create_fnum() in cli_smb2_list() adds another 32 credits, but
this is still less than the 128 that smb2cli_query_directory() requires.

This problem doesn't happen for smbclient because the cli_cm_open() API
it uses ends up sending more messages, and so the connection has more
credits.

This patch changes cli_smb2_list(), so it requests a smaller response
buffer size if it doesn't have enough credits available for the max
transaction size. smb2cli_query_directory() is already in a loop, so it
can span multiple SMB messages if for some reason the transaction size
isn't big enough for the listings.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13736

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu Jan 10 02:40:16 CET 2019 on sn-devel-144

7 months agolibcli: Add error log if insufficient SMB2 credits
Tim Beale [Sun, 6 Jan 2019 23:06:15 +0000 (12:06 +1300)]
libcli: Add error log if insufficient SMB2 credits

Although it's unusual to hit this case, I was seeing it happen while
working on the SMB python bindings. Even with debug level 10, there was
nothing coming out to help pin down the source of the
NT_STATUS_INTERNAL_ERROR.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13736

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agos3:utils:net: Print debug message about Netbios
Justin Stephenson [Mon, 17 Dec 2018 20:17:24 +0000 (15:17 -0500)]
s3:utils:net: Print debug message about Netbios

With a preceding patch, cli_connect_nb() will return
NT_STATUS_NOT_SUPPORTED when 'disable netbios' is set in smb.conf.

Print an informative error message to indicate Netbios is disabled
if this occurs.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13727

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Noel Power <nopower@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Wed Jan  9 22:38:21 CET 2019 on sn-devel-144

7 months agos3:smbpasswd: Print debug message about Netbios
Justin Stephenson [Mon, 17 Dec 2018 19:57:59 +0000 (14:57 -0500)]
s3:smbpasswd: Print debug message about Netbios

With a preceding patch, cli_connect_nb() will return
NT_STATUS_NOT_SUPPORTED when 'disable netbios' is set in smb.conf.

Print an informative error message to indicate Netbios is disabled
if this occurs.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13727

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Noel Power <nopower@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
7 months agos3:libsmb: Print debug message about Netbios
Justin Stephenson [Mon, 17 Dec 2018 19:40:33 +0000 (14:40 -0500)]
s3:libsmb: Print debug message about Netbios

With a preceding patch, cli_connect_nb() will return
NT_STATUS_NOT_SUPPORTED when 'disable netbios' is set in smb.conf.

Print an informative error message to indicate Netbios is disabled
if this occurs.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13727

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Noel Power <nopower@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
7 months agos3:libsmb: Check disable_netbios in socket connect
Justin Stephenson [Thu, 3 Jan 2019 17:07:01 +0000 (12:07 -0500)]
s3:libsmb: Check disable_netbios in socket connect

If the disable_netbios option is set then return NT_STATUS_NOT_SUPPORTED
for a port 139 connection in the low level socket connection code.

Signed-off-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Noel Power <nopower@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
7 months agos3:libsmb: Revert SMB Py bindings name back to libsmb_samba_internal
Tim Beale [Tue, 8 Jan 2019 21:15:49 +0000 (10:15 +1300)]
s3:libsmb: Revert SMB Py bindings name back to libsmb_samba_internal

In order to make it clear that the APIs in these Python bindings are
unstable and should not be used by external consumers, this patch
changes the name of the Python bindings back to libsmb_samba_internal.

To make the Python code that uses these bindings (i.e. samba-tool, etc)
look a little cleaner, we can just change the module name as we import
it, e.g.

  from samba.samba3 import libsmb_samba_internal as libsmb

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Jan  9 14:30:31 CET 2019 on sn-devel-144

7 months agonetcmd/user: python[3]-gpgme unsupported and replaced by python[3]-gpg
Joe Guo [Thu, 20 Dec 2018 03:47:00 +0000 (16:47 +1300)]
netcmd/user: python[3]-gpgme unsupported and replaced by python[3]-gpg

python[3]-gpgme is deprecated since ubuntu 1804 and debian 9.
use python[3]-gpg instead, and adapt the API.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13728

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
7 months agoxml_docs: update traffic script documentation
Douglas Bagnall [Fri, 4 Jan 2019 02:14:58 +0000 (15:14 +1300)]
xml_docs: update traffic script documentation

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Tim Beale <timbeale@samba.org>
Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Wed Jan  9 03:53:58 CET 2019 on sn-devel-144

7 months agotraffic_replay: use packets per second as primary scale
Douglas Bagnall [Wed, 7 Nov 2018 00:31:31 +0000 (13:31 +1300)]
traffic_replay: use packets per second as primary scale

The old -S/--scale-traffic is relative to the original model, which made
its relationship to true traffic volumes quite opaque

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 months agotraffic: assert json equality in learner test
Douglas Bagnall [Mon, 3 Dec 2018 00:58:56 +0000 (13:58 +1300)]
traffic: assert json equality in learner test

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 months agotraffic tests: use TestCaseInTempdir.mktemp()
Douglas Bagnall [Thu, 25 Oct 2018 00:37:02 +0000 (13:37 +1300)]
traffic tests: use TestCaseInTempdir.mktemp()

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 months agopython/tests: add TestCaseInTempdir.mktemp()
Douglas Bagnall [Thu, 25 Oct 2018 00:33:02 +0000 (13:33 +1300)]
python/tests: add TestCaseInTempdir.mktemp()

This gives you a name of a temporary file within the test case's tempdir.
Use it like this:

  with self.mktemp() as filename:
     self.check_run("samba-tool foo --output %s" % filename)
     self.assertStringsEqual(open(filename).read(), expected)

and filename will flick out of existence when the with block ends.

This is based on an idea used in the traffic_runner tests, which will
soon be adapted to use this method.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 months agotraffic_replay: --old-scale to mimic the old traffic_replay
Douglas Bagnall [Mon, 22 Oct 2018 21:30:46 +0000 (10:30 +1300)]
traffic_replay: --old-scale to mimic the old traffic_replay

traffic_replay had a broken sense of traffic scale. That is fixed, but
in order to compare old and new tests, it helps to be able to
approximate the old behaviour.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 months agotraffic: add option to reanimate dying conversations
Douglas Bagnall [Mon, 22 Oct 2018 22:58:52 +0000 (11:58 +1300)]
traffic: add option to reanimate dying conversations

The traffic model is generated from a window in time, which makes
conversations appear to start and stop unnaturally at the window
boundaries. When the window is short compared to the traffic replay
time and the true expected conversation length, this has a significant
distorting effect, leading to more conversations than would be
expected to generate a given number of packets.

To offset this slightly we add the --conversation-persistence option
which tries to convert apparent death into a longish wait.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 months agotraffic_model: don't report generation errors as parse errors
Douglas Bagnall [Mon, 22 Oct 2018 22:00:20 +0000 (11:00 +1300)]
traffic_model: don't report generation errors as parse errors

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 months agotraffic: improve debug messages in traffic_replay
Douglas Bagnall [Fri, 19 Oct 2018 03:26:19 +0000 (16:26 +1300)]
traffic: improve debug messages in traffic_replay

tracebacks and less nonsense at higher debug levels.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 months agotraffic: Conversation.add_short_packet is discerning about packets
Douglas Bagnall [Fri, 19 Oct 2018 04:24:53 +0000 (17:24 +1300)]
traffic: Conversation.add_short_packet is discerning about packets

If the packets really wouldn't do anything, we might as well not add them.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 months agotraffic: remove useless branch in stats report
Douglas Bagnall [Thu, 22 Nov 2018 02:09:00 +0000 (15:09 +1300)]
traffic: remove useless branch in stats report

This completes the work of 68c64c634ad7576b2ab5ef838c203320afd90f44,
but differs from that in that it makes no actual change because isatty
was not being called so was always evaluated as true.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 months agotraffic: generate more statistics in replay
Douglas Bagnall [Fri, 19 Oct 2018 04:21:56 +0000 (17:21 +1300)]
traffic: generate more statistics in replay

Add more "header" values indicating the progress of the run as a
whole.

The new fields are:

Max sleep miss            - the longest sleep() oversleep. Indicates client load.
Maximum lag               - the longest gap between a planned packet
                            time and its actual time.
Start lag                 - the longest gap between intended and actual
                            conversation start.
Planned conversations     - how many conversations we meant to have.
Planned packets           - how many "packets" we thought we were making. Not
                            all "packets" result in actual operations or packets.
Unfinished conversations  - how many conversations had not finished
                            when they were killed.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 months agotraffic: avoid bare except: clauses
Douglas Bagnall [Fri, 19 Oct 2018 04:19:29 +0000 (17:19 +1300)]
traffic: avoid bare except: clauses

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 months agotraffic: simplify tests for badpassword_frequency
Douglas Bagnall [Fri, 19 Oct 2018 04:19:09 +0000 (17:19 +1300)]
traffic: simplify tests for badpassword_frequency

x <= 0 will fail one or both of the other test clauses.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 months agotraffic: assign context domain at start
Douglas Bagnall [Fri, 19 Oct 2018 04:15:30 +0000 (17:15 +1300)]
traffic: assign context domain at start

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 months agotraffic: traffic_replay --latency-timeout to control final wait
Douglas Bagnall [Mon, 22 Oct 2018 21:31:53 +0000 (10:31 +1300)]
traffic: traffic_replay --latency-timeout to control final wait

Conversations that haven't finished within some acceptable margin of
on-time can be said to have failed. This is where you specify that
margin.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 months agotraffic_replay: --stop-on-any-error option to not ignore client trouble
Douglas Bagnall [Fri, 19 Oct 2018 03:27:17 +0000 (16:27 +1300)]
traffic_replay: --stop-on-any-error option to not ignore client trouble

Sometimes you want to know if any client is crashing for any reason.
In those times use --stop-on-any-error for an early exit.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 months agotraffic: evoke OS error codes by name, not number
Douglas Bagnall [Thu, 22 Nov 2018 00:00:04 +0000 (13:00 +1300)]
traffic: evoke OS error codes by name, not number

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 months agotraffic: reinitialise RNG in each child
Douglas Bagnall [Wed, 21 Nov 2018 23:19:46 +0000 (12:19 +1300)]
traffic: reinitialise RNG in each child

Otherwise they all replay using the same random sequence.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
7 months agotraffic: avoid generating conversations without packets
Douglas Bagnall [Wed, 24 Oct 2018 01:02:01 +0000 (14:02 +1300)]
traffic: avoid generating conversations without packets

Some "packets" don't generate any actual traffic. If we have a
conversation consisting only of those, we can avoid forking a client
for it.

This *slightly* increases the load over that which would be generated
otherwise for a given traffic rate, but that's OK.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>