garming/samba-autobuild/.git
12 years agowafsamba: Require public libraries to have a pc file specified, or explicitly specifi...
Jelmer Vernooij [Sun, 21 Aug 2011 00:09:14 +0000 (02:09 +0200)]
wafsamba: Require public libraries to have a pc file specified, or explicitly specified that they don't need one.

12 years agowbclient: Add pkg-config file.
Jelmer Vernooij [Sat, 20 Aug 2011 00:34:16 +0000 (02:34 +0200)]
wbclient: Add pkg-config file.

12 years agosamba-credentials: Add pkg-config file.
Jelmer Vernooij [Sat, 20 Aug 2011 00:32:58 +0000 (02:32 +0200)]
samba-credentials: Add pkg-config file.

12 years agoEnsure we never wait past absolute entime to do a get_cached_ldap_connect().
Jeremy Allison [Sat, 20 Aug 2011 16:37:04 +0000 (09:37 -0700)]
Ensure we never wait past absolute entime to do a get_cached_ldap_connect().

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Aug 20 20:09:37 CEST 2011 on sn-devel-104

12 years agoRemove the tortured logic in another_ldap_try() and turn it into
Jeremy Allison [Sat, 20 Aug 2011 04:40:54 +0000 (21:40 -0700)]
Remove the tortured logic in another_ldap_try() and turn it into
get_cached_ldap_connect(), which much better describes it's function.

Now we always break at the right places in the loop, we can replace
the while (another_ldap_try(ldap_state, &rc, &attempts, abs_endtime))
construct with simply while (1).

12 years agoFactor out the ldap_get_option calls into a function.
Jeremy Allison [Sat, 20 Aug 2011 04:30:04 +0000 (21:30 -0700)]
Factor out the ldap_get_option calls into a function.

12 years agoSimplify the logic on the another_ldap_try() loops by breaking
Jeremy Allison [Sat, 20 Aug 2011 04:27:18 +0000 (21:27 -0700)]
Simplify the logic on the another_ldap_try() loops by breaking
early out of the loop on success.

12 years agoMove the alarm setup/teardown out of another_ldap_try() and into separate
Jeremy Allison [Sat, 20 Aug 2011 04:19:28 +0000 (21:19 -0700)]
Move the alarm setup/teardown out of another_ldap_try() and into separate
functions that bracket the another_ldap_try() loop. We now never leave a
dangling alarm pending on success.

12 years agoAllow the timeout pointer to ldap_search_ext_s() to be NULL if lp_ldap_timeout()...
Jeremy Allison [Sat, 20 Aug 2011 04:08:10 +0000 (21:08 -0700)]
Allow the timeout pointer to ldap_search_ext_s() to be NULL if lp_ldap_timeout() == 0.

12 years agoMake it clear the time here is an absolute endtime. Don't set the alarm if the LDAP...
Jeremy Allison [Sat, 20 Aug 2011 04:01:49 +0000 (21:01 -0700)]
Make it clear the time here is an absolute endtime. Don't set the alarm if the LDAP timeout is zero.

12 years agoAlways remove the alarm before changing the handler, not the other way around.
Jeremy Allison [Sat, 20 Aug 2011 03:55:41 +0000 (20:55 -0700)]
Always remove the alarm before changing the handler, not the other way around.

12 years agoRemove old_handler as alarms can't be nested. Use SIG_IGN instead.
Jeremy Allison [Sat, 20 Aug 2011 03:54:41 +0000 (20:54 -0700)]
Remove old_handler as alarms can't be nested. Use SIG_IGN instead.

12 years agoChange got_alarm from bool to the correct type of SIG_ATOMIC_T.
Jeremy Allison [Sat, 20 Aug 2011 03:53:49 +0000 (20:53 -0700)]
Change got_alarm from bool to the correct type of SIG_ATOMIC_T.

12 years agoIf "ldap timeout" is non-zero, set the local search timeout to
Jeremy Allison [Sat, 20 Aug 2011 01:43:51 +0000 (18:43 -0700)]
If "ldap timeout" is non-zero, set the local search timeout to
be one second longer than the remote search timeout (which is
set to the "ldap timeout" value). This allows the remote search
timeout to fire in preference.

Allow lp_ldap_timeout() to be zero. Don't set the any local alarm
if so.

12 years agoRe-arrange the optimization to reduce tdb fcntl calls if smbd is not
Ira Cooper [Fri, 19 Aug 2011 17:32:29 +0000 (10:32 -0700)]
Re-arrange the optimization to reduce tdb fcntl calls if smbd is not
clustered. procid_is_me() is much cheaper to test and can optimize
up to 50% of the calls to serverid_exists(). Volker please check.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Aug 20 01:15:07 CEST 2011 on sn-devel-104

12 years agos3:passdb/py_passdb.c - restore Python >= 2.4 compatibility
Matthias Dieter Wallnöfer [Fri, 19 Aug 2011 17:27:32 +0000 (19:27 +0200)]
s3:passdb/py_passdb.c - restore Python >= 2.4 compatibility

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Aug 19 21:03:44 CEST 2011 on sn-devel-104

12 years agoldb:ldb_controls.c - cosmetic indentation fix
Matthias Dieter Wallnöfer [Wed, 22 Jun 2011 12:46:09 +0000 (14:46 +0200)]
ldb:ldb_controls.c - cosmetic indentation fix

12 years agoldb - two cosmetic fixes
Matthias Dieter Wallnöfer [Tue, 21 Jun 2011 09:32:02 +0000 (11:32 +0200)]
ldb - two cosmetic fixes

@ldb.h: Removes an invalid comment line
@pyldb.c: Fixes indentation

12 years agoRevert "s3-messaging: IDMAP_ messages belongs to the Winbind range"
Simo Sorce [Fri, 19 Aug 2011 12:07:30 +0000 (08:07 -0400)]
Revert "s3-messaging: IDMAP_ messages belongs to the Winbind range"

This reverts commit 102f39ae3e7df26faf81595c8e0120b2e2a45bbd.

These messages are handled by smbd not winbind, and could potentially be of
general interest.

Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Fri Aug 19 16:16:05 CEST 2011 on sn-devel-104

12 years agos3-passdb pdb_samba4 handles PDB_PWHISTORY already
Andrew Bartlett [Mon, 15 Aug 2011 08:07:09 +0000 (18:07 +1000)]
s3-passdb pdb_samba4 handles PDB_PWHISTORY already

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Aug 19 10:40:16 CEST 2011 on sn-devel-104

12 years agos3_upgrade: Set the administrator password on upgrade
Amitay Isaacs [Fri, 19 Aug 2011 05:53:28 +0000 (15:53 +1000)]
s3_upgrade: Set the administrator password on upgrade

In the upgrade process, set the administrator password from the
existing root or administrator account.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agos3-passdb: Fix the get/set routines for pw_history for samu
Amitay Isaacs [Fri, 19 Aug 2011 05:50:49 +0000 (15:50 +1000)]
s3-passdb: Fix the get/set routines for pw_history for samu

Return pw_history with current string length (which is a multiple
of PW_HISTORY_ENTRY_LEN) and same thing for setting the pw_history.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agos3_upgrade: Do not add administrator and root accounts from s3 to s4
Amitay Isaacs [Fri, 19 Aug 2011 02:33:15 +0000 (12:33 +1000)]
s3_upgrade: Do not add administrator and root accounts from s3 to s4

Need to copy the password from s3 for administrator/root to s4.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agopython-samba3: Secrets file loaded from private dir, not lib dir
Amitay Isaacs [Fri, 19 Aug 2011 02:30:19 +0000 (12:30 +1000)]
python-samba3: Secrets file loaded from private dir, not lib dir

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agos3-passdb: Display username when reporting error on add_sam_account.
Amitay Isaacs [Fri, 19 Aug 2011 02:27:42 +0000 (12:27 +1000)]
s3-passdb: Display username when reporting error on add_sam_account.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agos3-passdb: Use pdb_get_nt_passwd() to get nt passwd.
Amitay Isaacs [Fri, 19 Aug 2011 02:26:53 +0000 (12:26 +1000)]
s3-passdb: Use pdb_get_nt_passwd() to get nt passwd.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agos3upgrade: Add idmap migration, users/groups import
Amitay Isaacs [Thu, 18 Aug 2011 05:21:32 +0000 (15:21 +1000)]
s3upgrade: Add idmap migration, users/groups import

Added users/groups import from s3 using python wrapper for passdb.
Fix idmap entries for users/groups when migrating from s3 idmap.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agoprovision: Add idmap database handle to the result of provision
Amitay Isaacs [Thu, 18 Aug 2011 05:17:40 +0000 (15:17 +1000)]
provision: Add idmap database handle to the result of provision

It is required in s3_upgrade script to migrate idmap database from s3 to s4.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agosamba3-python: Add methods to get any entry (user/group) and its sid from idmap
Amitay Isaacs [Thu, 18 Aug 2011 05:15:20 +0000 (15:15 +1000)]
samba3-python: Add methods to get any entry (user/group) and its sid from idmap

This is required in upgrade_s3 script to migrate idmap database from s3 to s4

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agopy_security: Fix comparison between two dom_sid objects
Amitay Isaacs [Thu, 18 Aug 2011 05:11:20 +0000 (15:11 +1000)]
py_security: Fix comparison between two dom_sid objects

dom_sid_compare() function can return values other than -1, 0, 1.
Python requires compare function to return value from [-1, 0, 1].

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agos3-passdb: Fix call for search_aliases(). It returns bool and not NTSTATUS.
Amitay Isaacs [Thu, 18 Aug 2011 05:08:22 +0000 (15:08 +1000)]
s3-passdb: Fix call for search_aliases(). It returns bool and not NTSTATUS.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agos3-passdb: Return list of sids from python wrapper enum_group_members
Amitay Isaacs [Thu, 18 Aug 2011 05:07:06 +0000 (15:07 +1000)]
s3-passdb: Return list of sids from python wrapper enum_group_members

Instead of returning rids as the C api does, return sids, so it is
similar to enum_aliasmem and can be used easily in s3_upgrade.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agos3-passdb: Make arguments for python wrapper enum_group_mapping() optional
Amitay Isaacs [Thu, 18 Aug 2011 05:05:18 +0000 (15:05 +1000)]
s3-passdb: Make arguments for python wrapper enum_group_mapping() optional

Set the defaults, if no arguments are provided.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agos3-passdb: Added python wrapper for passdb methods
Amitay Isaacs [Thu, 18 Aug 2011 05:02:22 +0000 (15:02 +1000)]
s3-passdb: Added python wrapper for passdb methods

Added following methods
 - uid_to_sid, gid_to_sid, sid_to_id, new_rid
 - get_trusteddom_pw, set_trusteddom_pw, del_trusteddom_pw, enum_trusteddoms
 - get_trusted_domain, get_trusted_domain_by_sid, set_trusted_domain,
   del_trusted_domain, enum_trusted_domains
 - get_secret, set_secret, delete_secret

Updated documentation for all methods

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agos3-passdb: Python wrapper for passdb
Amitay Isaacs [Mon, 15 Aug 2011 07:21:38 +0000 (17:21 +1000)]
s3-passdb: Python wrapper for passdb

- Added Groupmap python wrapper
- Added passdb methods

   getgrsid, getgrgid, getgrnam
   create_dom_group, delete_dom_group
   add_group_mapping_entry, update_group_mapping_entry, delete_group_mapping_entry
   enum_group_mapping, enum_group_members
   add_groupmem, del_groupmem
   create_alias, delete_alias
   get_aliasinfo, set_aliasinfo
   add_aliasmem, del_aliasmem, enum_aliasmem
   get_account_policy, set_account_policy
   search_groups, search_aliases

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agos3-passdb: Replace SMB_MALLOC_ARRAY()/SAFE_FREE() with talloc equivalents.
Amitay Isaacs [Mon, 15 Aug 2011 07:12:46 +0000 (17:12 +1000)]
s3-passdb: Replace SMB_MALLOC_ARRAY()/SAFE_FREE() with talloc equivalents.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agoFix bug #8370 - vfs_chown_fsp broken -- returns in the wrong directory
Jeremy Allison [Thu, 18 Aug 2011 21:11:45 +0000 (14:11 -0700)]
Fix bug #8370 - vfs_chown_fsp broken -- returns in the wrong directory

Ensure we always use vfs_ChDir() to keep the singleton cache coherent.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Aug 19 00:43:05 CEST 2011 on sn-devel-104

12 years agocredentials: Rename library to samba-credentials to avoid name clashes.
Jelmer Vernooij [Thu, 18 Aug 2011 18:43:00 +0000 (20:43 +0200)]
credentials: Rename library to samba-credentials to avoid name clashes.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Thu Aug 18 22:16:38 CEST 2011 on sn-devel-104

12 years agosmb_common: Fix include paths.
Jelmer Vernooij [Thu, 18 Aug 2011 13:21:02 +0000 (15:21 +0200)]
smb_common: Fix include paths.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Thu Aug 18 16:54:01 CEST 2011 on sn-devel-104

12 years agocli-raw: Add public libsmbclient-raw library.
Jelmer Vernooij [Thu, 18 Aug 2011 12:19:18 +0000 (14:19 +0200)]
cli-raw: Add public libsmbclient-raw library.

12 years agolibcliraw: Install more header files.
Jelmer Vernooij [Thu, 18 Aug 2011 12:01:12 +0000 (14:01 +0200)]
libcliraw: Install more header files.

12 years agosmb_common: Install some more headers.
Jelmer Vernooij [Thu, 18 Aug 2011 11:43:42 +0000 (13:43 +0200)]
smb_common: Install some more headers.

12 years agolibcliraw: Install request.h and signing.h.
Jelmer Vernooij [Thu, 18 Aug 2011 11:31:03 +0000 (13:31 +0200)]
libcliraw: Install request.h and signing.h.

12 years agosmb_composite: Remove unnecessary include of signing header.
Jelmer Vernooij [Thu, 18 Aug 2011 11:08:34 +0000 (13:08 +0200)]
smb_composite: Remove unnecessary include of signing header.

12 years agosmb_composite: Integrate prototypes in header file.
Jelmer Vernooij [Thu, 18 Aug 2011 10:59:25 +0000 (12:59 +0200)]
smb_composite: Integrate prototypes in header file.

12 years agoUse public pytalloc header file.
Jelmer Vernooij [Sun, 14 Aug 2011 13:34:08 +0000 (15:34 +0200)]
Use public pytalloc header file.

12 years agos3/ldap: don't continue if we couldn't get the domain info on startup
Björn Jacke [Mon, 15 Aug 2011 12:46:12 +0000 (14:46 +0200)]
s3/ldap: don't continue if we couldn't get the domain info on startup

while some things work without the domain info, some important things don't,
which is highly irritating. As even calls like EnumTrustDom fail and
thus clients' domain logins fail we are sufficiently broken to refuse to go on.

Autobuild-User: Björn Jacke <bj@sernet.de>
Autobuild-Date: Thu Aug 18 12:48:37 CEST 2011 on sn-devel-104

12 years agos4-test: use dbcheck on more of our selftest databases
Andrew Tridgell [Mon, 15 Aug 2011 05:58:27 +0000 (15:58 +1000)]
s4-test: use dbcheck on more of our selftest databases

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Aug 18 02:58:55 CEST 2011 on sn-devel-104

12 years agos4-test: only check one database in quickcheck
Andrew Tridgell [Mon, 15 Aug 2011 06:20:21 +0000 (16:20 +1000)]
s4-test: only check one database in quickcheck

12 years agos4-dsdb: fixed deletion of backlinks for fl2000 DCs
Andrew Tridgell [Mon, 15 Aug 2011 06:03:11 +0000 (16:03 +1000)]
s4-dsdb: fixed deletion of backlinks for fl2000 DCs

when in FL 2000 we were not correctly deleting backlinks as we uses
dsdb_find_dn_by_guid() which doesn't find deleted objects. Modules
should use dsdb_module_dn_by_guid() which prevents going to the top
level, and finds deleted objects

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

12 years agos4-dsdb: added comments and fixed backlink check in repl_meta_data
Andrew Tridgell [Mon, 15 Aug 2011 06:01:39 +0000 (16:01 +1000)]
s4-dsdb: added comments and fixed backlink check in repl_meta_data

added comments explaining the backlink deletion code, plus fix a use
of a bitwise operation in a boolean expression, and avoid calling
dsdb_functional_level() inside a loop

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

12 years agos4-dirsync: use dsdb_module_dn_by_guid() not dsdb_find_dn_by_guid() in modules
Andrew Tridgell [Mon, 15 Aug 2011 05:59:23 +0000 (15:59 +1000)]
s4-dirsync: use dsdb_module_dn_by_guid() not dsdb_find_dn_by_guid() in modules

this prevents us going to the top level of the module stack

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

12 years agosamba-tool: changed samba-tool user delete to use samdb instead of Net()
Andrew Tridgell [Mon, 15 Aug 2011 02:07:50 +0000 (12:07 +1000)]
samba-tool: changed samba-tool user delete to use samdb instead of Net()

this makes it possible to use with -H, so you can delete users on
remote DCs or against local databases

12 years agos4-samdb: added deleteuser() to samdb
Andrew Tridgell [Mon, 15 Aug 2011 02:06:59 +0000 (12:06 +1000)]
s4-samdb: added deleteuser() to samdb

This is similar to deletegroup()

12 years agos4-test: prevent the utable test from crashing
Andrew Tridgell [Sun, 14 Aug 2011 23:53:45 +0000 (09:53 +1000)]
s4-test: prevent the utable test from crashing

12 years agoAdapt del_sid_from_array to Samba coding style
Volker Lendecke [Wed, 17 Aug 2011 12:10:15 +0000 (14:10 +0200)]
Adapt del_sid_from_array to Samba coding style

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Aug 17 16:46:24 CEST 2011 on sn-devel-104

12 years agoFix a typo
Volker Lendecke [Wed, 17 Aug 2011 12:09:10 +0000 (14:09 +0200)]
Fix a typo

12 years agos3: Next step to fix MIT trusts
Volker Lendecke [Wed, 17 Aug 2011 10:05:26 +0000 (12:05 +0200)]
s3: Next step to fix MIT trusts

aa3f10c was not complete in the sense that it did not fully cover some
conditions that led to invalid domains in the winbind parent

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Aug 17 13:59:06 CEST 2011 on sn-devel-104

12 years agos3: Increase a debug level in ads_find_dc
Volker Lendecke [Wed, 17 Aug 2011 09:58:57 +0000 (11:58 +0200)]
s3: Increase a debug level in ads_find_dc

This message can happen with AD trusts that winbind can not cope with. The
message is not really clear and not worth spamming syslog always.

12 years agoRemove unused "sid_equal"
Volker Lendecke [Wed, 17 Aug 2011 10:20:30 +0000 (12:20 +0200)]
Remove unused "sid_equal"

12 years agoReplace calls to sid_equal with calls to dom_sid_equal
Volker Lendecke [Wed, 17 Aug 2011 10:18:14 +0000 (12:18 +0200)]
Replace calls to sid_equal with calls to dom_sid_equal

12 years agos3-messaging: IDMAP_ messages belongs to the Winbind range
Simo Sorce [Tue, 16 Aug 2011 14:46:17 +0000 (10:46 -0400)]
s3-messaging: IDMAP_ messages belongs to the Winbind range

Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Tue Aug 16 22:27:05 CEST 2011 on sn-devel-104

12 years agos3: Use ZERO_STRUCT where appropriate
Volker Lendecke [Tue, 16 Aug 2011 10:30:58 +0000 (12:30 +0200)]
s3: Use ZERO_STRUCT where appropriate

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Aug 16 13:59:55 CEST 2011 on sn-devel-104

12 years agotdb: increment sequence number in tdb_wipe_all().
Rusty Russell [Tue, 16 Aug 2011 07:17:03 +0000 (16:47 +0930)]
tdb: increment sequence number in tdb_wipe_all().

TDB2 testing revealed that tdb1 doesn't do this.  It's minor, but fix it.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Tue Aug 16 10:47:41 CEST 2011 on sn-devel-104

12 years agos3:registry: enhance debugging of deletekey_recursive
Michael Adam [Sun, 14 Aug 2011 21:48:41 +0000 (23:48 +0200)]
s3:registry: enhance debugging of deletekey_recursive

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Mon Aug 15 19:34:44 CEST 2011 on sn-devel-104

12 years agos3:dbwrap_ctdb: improve transaction start/commit/cancel debugging
Michael Adam [Sun, 14 Aug 2011 21:47:47 +0000 (23:47 +0200)]
s3:dbwrap_ctdb: improve transaction start/commit/cancel debugging

* also log nesting transaction start/commit/cancel
* unify transaction log messages slightly

12 years agos3:lib: fix a comment in tdb_unpack()
Michael Adam [Mon, 15 Aug 2011 11:34:42 +0000 (13:34 +0200)]
s3:lib: fix a comment in tdb_unpack()

12 years agos3:registry: fix regdb_key_exists: the record has to contain at least the 4-byte...
Michael Adam [Sun, 14 Aug 2011 23:30:32 +0000 (01:30 +0200)]
s3:registry: fix regdb_key_exists: the record has to contain at least the 4-byte subkey counter

More precisley, we return false if the record does not match the required
structure of a leading 4-byte subkey counter followed by the corresponding
number zero-terminated strings.

12 years agos3: avoid reading past the end of buffer in tdb_unpack 'f' if zero termination is...
Gregor Beck [Tue, 5 Jul 2011 09:55:34 +0000 (11:55 +0200)]
s3: avoid reading past the end of buffer in tdb_unpack 'f' if zero termination is missing

Signed-off-by: Michael Adam <obnox@samba.org>
12 years agos3: avoid reading past the end of buffer in tdb_unpack 'P' if zero termination is...
Gregor Beck [Tue, 5 Jul 2011 09:54:58 +0000 (11:54 +0200)]
s3: avoid reading past the end of buffer in tdb_unpack 'P' if zero termination is missing

Signed-off-by: Michael Adam <obnox@samba.org>
12 years agobuild: link pys3param against pytalloc-util not pytalloc
Andrew Bartlett [Mon, 15 Aug 2011 06:20:35 +0000 (16:20 +1000)]
build: link pys3param against pytalloc-util not pytalloc

pytalloc is the python module, pytalloc-util is the library that we can depend on

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Aug 15 09:54:02 CEST 2011 on sn-devel-104

12 years agos3-passdb Use supplied pdb_methods in default passdb search handlers
Andrew Bartlett [Mon, 15 Aug 2011 01:47:36 +0000 (11:47 +1000)]
s3-passdb Use supplied pdb_methods in default passdb search handlers

12 years agos3-prefork: Do not use mmap/mremap/munmap directly
Simo Sorce [Sun, 14 Aug 2011 22:11:18 +0000 (18:11 -0400)]
s3-prefork: Do not use mmap/mremap/munmap directly

Use the wrappers in util.h as they deal with trying to do the best they can on
platfroms that do not support mmap extensions.

Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Mon Aug 15 04:13:51 CEST 2011 on sn-devel-104

12 years agoutil: add function to extend anonymous shared memory
Simo Sorce [Sun, 14 Aug 2011 22:10:53 +0000 (18:10 -0400)]
util: add function to extend anonymous shared memory

12 years agoreplace: Check if we have mremap() available
Simo Sorce [Sun, 14 Aug 2011 22:05:27 +0000 (18:05 -0400)]
replace: Check if we have mremap() available

12 years agoUse public pytalloc header file.
Jelmer Vernooij [Sun, 14 Aug 2011 13:34:08 +0000 (15:34 +0200)]
Use public pytalloc header file.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Aug 14 17:18:46 CEST 2011 on sn-devel-104

12 years agos3: Fix bug 8360
Volker Lendecke [Thu, 11 Aug 2011 14:52:22 +0000 (16:52 +0200)]
s3: Fix bug 8360

OS/2 sends an unexpected write&x/read&x chain

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Aug 14 08:48:58 CEST 2011 on sn-devel-104

12 years agos3-passdb: Fix python < 2.6 build errors in passdb python wrapper
Andrew Bartlett [Sun, 14 Aug 2011 00:05:42 +0000 (10:05 +1000)]
s3-passdb: Fix python < 2.6 build errors in passdb python wrapper

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sun Aug 14 03:59:48 CEST 2011 on sn-devel-104

12 years agos4:misc: remove last usage of legacy event_ fn names
Simo Sorce [Tue, 25 May 2010 19:29:14 +0000 (15:29 -0400)]
s4:misc: remove last usage of legacy event_ fn names

Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Sun Aug 14 00:38:13 CEST 2011 on sn-devel-104

12 years agos4:lib: use tevent_ fns names instead of legcay event_ ones
Simo Sorce [Tue, 25 May 2010 19:28:35 +0000 (15:28 -0400)]
s4:lib: use tevent_ fns names instead of legcay event_ ones

12 years agos4:smbd: use tevent_ fn names instead of leagcy event_ ones
Simo Sorce [Tue, 25 May 2010 19:28:10 +0000 (15:28 -0400)]
s4:smbd: use tevent_ fn names instead of leagcy event_ ones

12 years agos4:ntvfs: use tevent_ fn names instead of legacy event_ ones
Simo Sorce [Tue, 25 May 2010 19:27:41 +0000 (15:27 -0400)]
s4:ntvfs: use tevent_ fn names instead of legacy event_ ones

12 years agos4:librpc: use tevent_ fn names instead of legacy event_ ones
Simo Sorce [Tue, 25 May 2010 19:27:11 +0000 (15:27 -0400)]
s4:librpc: use tevent_ fn names instead of legacy event_ ones

12 years agos4:libcli: use tevent_ fn names instead of legacy event_ ones
Simo Sorce [Tue, 25 May 2010 19:26:42 +0000 (15:26 -0400)]
s4:libcli: use tevent_ fn names instead of legacy event_ ones

12 years agos4:dsdb: use tevent_ fn names instaed of legacy event_ ones
Simo Sorce [Tue, 25 May 2010 19:26:00 +0000 (15:26 -0400)]
s4:dsdb: use tevent_ fn names instaed of legacy event_ ones

12 years agos4:messaging: use tevent_ function names instead of legacy event_ ones
Simo Sorce [Tue, 25 May 2010 19:25:26 +0000 (15:25 -0400)]
s4:messaging: use tevent_ function names instead of legacy event_ ones

12 years agotorture: use tevent_ functions names instead of the legacy event_ ones
Simo Sorce [Tue, 25 May 2010 19:23:55 +0000 (15:23 -0400)]
torture: use tevent_ functions names instead of the legacy event_ ones

12 years agoldb: Remove use after free in error case
Andrew Bartlett [Sat, 13 Aug 2011 03:42:04 +0000 (13:42 +1000)]
ldb: Remove use after free in error case

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sat Aug 13 13:49:44 CEST 2011 on sn-devel-104

12 years agos4-provision Add support for fixing the DC rid to a particular value
Andrew Bartlett [Sat, 13 Aug 2011 03:32:18 +0000 (13:32 +1000)]
s4-provision Add support for fixing the DC rid to a particular value

This will allow an upgraded DC to keep its SID, while being upgraded
to AD.  We also watch for the highest RID in the existing DB to set
next_rid for other additional users.

Andrew Bartlett

12 years agos3-smbd Avoid races creating 'ncaclrpc dir' with epmd in a child process
Andrew Bartlett [Sat, 13 Aug 2011 03:30:16 +0000 (13:30 +1000)]
s3-smbd Avoid races creating 'ncaclrpc dir' with epmd in a child process

12 years agos4-param Set szConfigFile even for s3 loadparm contexts
Andrew Bartlett [Fri, 12 Aug 2011 12:17:26 +0000 (22:17 +1000)]
s4-param Set szConfigFile even for s3 loadparm contexts

12 years agoupgrade: Add missing bits for the s3 to s4 upgrade script
Amitay Isaacs [Fri, 12 Aug 2011 01:37:57 +0000 (11:37 +1000)]
upgrade: Add missing bits for the s3 to s4 upgrade script

Use passdb backend to import/export users

Remove unused options for upgrade_from_s3 command (--blank) and credentials options
Config file is specified with -s/--configfile option and no need to specify as an argument.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

12 years agotests: Update test for s3 to s4 upgrade with two cases
Amitay Isaacs [Fri, 12 Aug 2011 07:47:49 +0000 (17:47 +1000)]
tests: Update test for s3 to s4 upgrade with two cases

S3-member to S4-member and S3-dc to S4-dc

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

12 years agos3-passdb: Added python method to get_global_sam_sid
Amitay Isaacs [Fri, 12 Aug 2011 07:10:17 +0000 (17:10 +1000)]
s3-passdb: Added python method to get_global_sam_sid

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

12 years agos3-passdb: Return dom_sid and guid with correct python types.
Amitay Isaacs [Fri, 12 Aug 2011 07:09:19 +0000 (17:09 +1000)]
s3-passdb: Return dom_sid and guid with correct python types.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

12 years agopassdb: Move python wrapper for passdb in samba3 python package
Amitay Isaacs [Fri, 12 Aug 2011 06:20:11 +0000 (16:20 +1000)]
passdb: Move python wrapper for passdb in samba3 python package

12 years agopy-samba3: Create samba3 python package to hold other modules
Amitay Isaacs [Fri, 12 Aug 2011 06:19:06 +0000 (16:19 +1000)]
py-samba3: Create samba3 python package to hold other modules

This will include passdb and param.

12 years agos3-param: Add python wrapper for s3 parameters
Amitay Isaacs [Fri, 12 Aug 2011 05:48:03 +0000 (15:48 +1000)]
s3-param: Add python wrapper for s3 parameters

This provids a get_context() method to return s3 context as s4 context type.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

12 years agos3-passdb: Connect to specified samdb if location is provided, otherwise use default
Amitay Isaacs [Fri, 12 Aug 2011 05:45:43 +0000 (15:45 +1000)]
s3-passdb: Connect to specified samdb if location is provided, otherwise use default

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

12 years agos3-passdb: Fix the error messages and return correct NTSTATUS
Amitay Isaacs [Fri, 12 Aug 2011 05:44:39 +0000 (15:44 +1000)]
s3-passdb: Fix the error messages and return correct NTSTATUS

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>