winbind: Fix "wbint_Principals" definition
authorVolker Lendecke <vl@samba.org>
Fri, 23 Nov 2018 08:03:13 +0000 (09:03 +0100)
committerRalph Boehme <slow@samba.org>
Tue, 27 Nov 2018 06:13:14 +0000 (07:13 +0100)
A signed integer does not make any sense for an IDL array length

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
librpc/idl/winbind.idl
source3/winbindd/wb_query_user_list.c
source3/winbindd/winbindd_lookuprids.c

index f5e3507bff528dfd21a3e46c4abb77320f0336a0..258dd284ad599bfebc5907a388aefdf1a03eb993 100644 (file)
@@ -120,7 +120,7 @@ interface winbind
     } wbint_Principal;
 
     typedef [public] struct {
-       int num_principals;
+       uint32 num_principals;
        [size_is(num_principals)] wbint_Principal principals[];
     } wbint_Principals;
 
index 6d699875e9b145eeef6db1fc48746e81304acb66..5e80aae8469a45c42a339dcfb61cd21913d3fbbf 100644 (file)
@@ -93,7 +93,7 @@ static void wb_query_user_list_done(struct tevent_req *subreq)
        struct wb_query_user_list_state *state = tevent_req_data(
                req, struct wb_query_user_list_state);
        NTSTATUS status, result;
-       int i;
+       uint32_t i;
 
        status = dcerpc_wbint_LookupRids_recv(subreq, state, &result);
        TALLOC_FREE(subreq);
index 6d0c0efd4291acdbbd29faf168ce9c459fdea5d3..ed5d951e7de973fc159086070cc53bf695471214 100644 (file)
@@ -117,7 +117,7 @@ NTSTATUS winbindd_lookuprids_recv(struct tevent_req *req,
                req, struct winbindd_lookuprids_state);
        NTSTATUS status;
        char *result;
-       int i;
+       uint32_t i;
 
        if (tevent_req_is_nterror(req, &status)) {
                DEBUG(5, ("Lookuprids failed: %s\n",nt_errstr(status)));