s4/web_server: fix panic from wrong type extracted from conn
authorNoel Power <noel.power@suse.com>
Wed, 19 Sep 2018 08:20:02 +0000 (10:20 +0200)
committerAndrew Bartlett <abartlet@samba.org>
Fri, 28 Sep 2018 01:57:47 +0000 (03:57 +0200)
enabling
  server services = +web

and we get a panic

web_server.c:251: Type mismatch: name[struct web_server_data] expected[struct task_server]
smb_panic_default: PANIC (pid 29137): ../source4/web_server/web_server.c:251: Type mismatch: name[struct web_server_data] expected[struct task_server]

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Sep 28 03:57:47 CEST 2018 on sn-devel-144

source4/web_server/web_server.c

index c3516890eb72b6cfca4617c3349994b92242b10f..9c4da2c23c9f8e008750e0dbf36b54ed82e7ef3d 100644 (file)
@@ -248,8 +248,7 @@ static void websrv_send(struct stream_connection *conn, uint16_t flags)
 */
 static void websrv_accept(struct stream_connection *conn)
 {
-       struct task_server *task = talloc_get_type_abort(conn->private_data, struct task_server);
-       struct web_server_data *wdata = talloc_get_type_abort(task->private_data, struct web_server_data);
+       struct web_server_data *wdata = talloc_get_type_abort(conn->private_data, struct web_server_data);
        struct websrv_context *web;
        struct socket_context *tls_socket;