auth/spnego: add more error checking to gensec_spnego_create_negTokenInit()
authorStefan Metzmacher <metze@samba.org>
Thu, 13 Jul 2017 14:16:35 +0000 (16:16 +0200)
committerAndreas Schneider <asn@cryptomilk.org>
Tue, 25 Jul 2017 11:51:10 +0000 (13:51 +0200)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
auth/gensec/spnego.c

index 6d0337050376481868ea79cf1730929e3d7a419b..c91ae3833d0603a55d50b8f491082c682c5f61f8 100644 (file)
@@ -224,11 +224,20 @@ static NTSTATUS gensec_spnego_create_negTokenInit(struct gensec_security *gensec
 
        mechTypes = gensec_security_oids(gensec_security, 
                                         out_mem_ctx, GENSEC_OID_SPNEGO);
+       if (mechTypes == NULL) {
+               DBG_WARNING("gensec_security_oids() failed\n");
+               return NT_STATUS_NO_MEMORY;
+       }
 
        all_sec = gensec_security_by_oid_list(gensec_security, 
                                              out_mem_ctx, 
                                              mechTypes,
                                              GENSEC_OID_SPNEGO);
+       if (all_sec == NULL) {
+               DBG_WARNING("gensec_security_by_oid_list() failed\n");
+               return NT_STATUS_NO_MEMORY;
+       }
+
        for (i=0; all_sec && all_sec[i].op; i++) {
                const char *next = NULL;
                const char *principal = NULL;
@@ -308,6 +317,10 @@ reply:
 
        send_mech_types = gensec_security_oids_from_ops_wrapped(out_mem_ctx,
                                                                &all_sec[i]);
+       if (send_mech_types == NULL) {
+               DBG_WARNING("gensec_security_oids_from_ops_wrapped() failed\n");
+               return NT_STATUS_NO_MEMORY;
+       }
 
        ok = spnego_write_mech_types(spnego_state,
                                     send_mech_types,