pyldb: remove ldb.open, which was never survivable

There was no way to call ldb.open without evoking signal 11, so it is
unlikely anyone was using it.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

diff --git a/lib/ldb/pyldb.c b/lib/ldb/pyldb.c
index 77d34d63987bc6de625f4840052cb193b45d9796..13d7c962d1e48c873a516631768e531d54433945 100644 (file)
--- a/lib/ldb/pyldb.c
+++ b/lib/ldb/pyldb.c
@@ -4267,10 +4267,6 @@ static PyMethodDef py_ldb_global_methods[] = {
        { "valid_attr_name", py_valid_attr_name, METH_VARARGS,
                "S.valid_attr_name(name) -> bool\n\nn"
                "Check whether the supplied name is a valid attribute name." },
-       { "open", PY_DISCARD_FUNC_SIG(PyCFunction,py_ldb_new),
-               METH_VARARGS|METH_KEYWORDS,
-               "S.open() -> Ldb\n\n"
-               "Open a new LDB context." },
        { "binary_encode", py_binary_encode, METH_VARARGS,
                "S.binary_encode(string) -> string\n\n"
                "Perform a RFC2254 binary encoding on a string" },

diff --git a/python/samba/tests/segfault.py b/python/samba/tests/segfault.py
index 5fecffb5bfc34f24e68c8065184accae42a2e21d..145c2495a8ec121dc3eb6daf445842dfb4533308 100644 (file)
--- a/python/samba/tests/segfault.py
+++ b/python/samba/tests/segfault.py
@@ -138,11 +138,3 @@ class SegfaultTests(samba.tests.TestCase):
     @segfault_detector
     def test_ldb_register_module(self):
         ldb.register_module('')
-
-    @segfault_detector
-    def test_ldb_open_0(self):
-        ldb.open()
-
-    @segfault_detector
-    def test_ldb_open_1(self):
-        ldb.open('')

diff --git a/selftest/knownfail.d/python-segfaults b/selftest/knownfail.d/python-segfaults
index 25875657381fda3df9febe9ab18b95aeb31d7797..e5821538b6ed3df1d3fb0cc74d10f2524565eda7 100644 (file)
--- a/selftest/knownfail.d/python-segfaults
+++ b/selftest/knownfail.d/python-segfaults
@@ -1,7 +1,5 @@
 samba.tests.segfault.samba.tests.segfault.SegfaultTests.test_encrypt_netr_crypt_password
 samba.tests.segfault.samba.tests.segfault.SegfaultTests.test_hive_open_ldb
-samba.tests.segfault.samba.tests.segfault.SegfaultTests.test_ldb_open_0
-samba.tests.segfault.samba.tests.segfault.SegfaultTests.test_ldb_open_1
 samba.tests.segfault.samba.tests.segfault.SegfaultTests.test_ldb_register_module
 samba.tests.segfault.samba.tests.segfault.SegfaultTests.test_net_replicate_chunk_1
 samba.tests.segfault.samba.tests.segfault.SegfaultTests.test_net_replicate_init__3