pyldb: avoid segfault when adding an element with no name origin/HEAD origin/master
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Fri, 12 Apr 2019 03:00:20 +0000 (15:00 +1200)
committerNoel Power <npower@samba.org>
Tue, 23 Apr 2019 19:03:35 +0000 (19:03 +0000)
commit76967b33ebb93a7ef5daa94b123ef9bfdce59ece
treecf339e9a56d1e7d4bebaef130eebe0b30ef2f0e7
parent1d7dee5815d1eaf43f841231767e19d110551aa3
pyldb: avoid segfault when adding an element with no name

We don't want to see this:

python3 -c "import sys
sys.path.insert(0, 'bin/python')
import ldb
m = ldb.Message()
e = ldb.MessageElement('q')
try:
    m.add(e)
except ldb.LdbError:
    pass
print(m)
"
Segmentation fault (core dumped)

instead we want this:

Traceback (most recent call last):
File "<string>", line 7, in <module>
ValueError: The element has no name

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Tue Apr 23 19:03:35 UTC 2019 on sn-devel-144
lib/ldb/pyldb.c
selftest/knownfail.d/python-segfaults