build:wafsamba: Remove ambiguous 'if x in conf.env' constructs
authorThomas Nagy <tnagy@waf.io>
Sat, 26 Mar 2016 13:35:52 +0000 (14:35 +0100)
committerUri Simchoni <uri@samba.org>
Tue, 21 Feb 2017 12:47:07 +0000 (13:47 +0100)
commite36e1f7b12291ac818206cadc2b3081a02f62f84
tree2857090e9064794584d341ee12ce78e8c0a67ca9
parentf73c6bd2698ccd6e52b0782407c1c6c6fe78d60d
build:wafsamba: Remove ambiguous 'if x in conf.env' constructs

Configuration values such as HAVE_STDDEF_H can be set to 0
to indicate a test failure. Waf 1.5 has a few bugs that
prevent configuration tests from setting such values
consistently on failures.

Consequently, conditions such as 'if conf.env.VARNAME' must be
used to indicate that config test successes are expected.
Note that conf.env.VARNAME always returns an empty list (False value)
when no variable is defined so there are no risk of raising
AttributeError/KeyError exceptions.

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
Autobuild-User(master): Uri Simchoni <uri@samba.org>
Autobuild-Date(master): Tue Feb 21 13:47:07 CET 2017 on sn-devel-144
buildtools/wafsamba/wscript
source3/wscript
source4/lib/tls/wscript