Revert "smbd: remove unused smbd_server_connection->ev_ctx"
[garming/samba-autobuild/.git] / source3 / smbd / msdfs.c
index fcf7b9c3dda02f1f3d0dcdfd7258f4f86135549b..c523abb3158c81173ace34014fc8cee3473b49d1 100644 (file)
@@ -28,6 +28,7 @@
 #include "smbd/globals.h"
 #include "msdfs.h"
 #include "auth.h"
+#include "../auth/auth_util.h"
 #include "lib/param/loadparm.h"
 #include "libcli/security/security.h"
 #include "librpc/gen_ndr/ndr_dfsblobs.h"
@@ -240,7 +241,6 @@ static NTSTATUS parse_dfs_path(connection_struct *conn,
 *********************************************************/
 
 static NTSTATUS create_conn_struct_as_root(TALLOC_CTX *ctx,
-                           struct tevent_context *ev,
                            struct messaging_context *msg,
                            connection_struct **pconn,
                            int snum,
@@ -258,7 +258,15 @@ static NTSTATUS create_conn_struct_as_root(TALLOC_CTX *ctx,
                return NT_STATUS_NO_MEMORY;
        }
 
-       sconn->ev_ctx = ev;
+       sconn->raw_ev_ctx = samba_tevent_context_init(sconn);
+       if (sconn->raw_ev_ctx == NULL) {
+               TALLOC_FREE(sconn);
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       sconn->ev_ctx = sconn->raw_ev_ctx;
+       sconn->root_ev_ctx = sconn->raw_ev_ctx;
+       sconn->guest_ev_ctx = sconn->raw_ev_ctx;
        sconn->msg_ctx = msg;
 
        conn = conn_new(sconn);
@@ -301,12 +309,19 @@ static NTSTATUS create_conn_struct_as_root(TALLOC_CTX *ctx,
                        TALLOC_FREE(conn);
                        return NT_STATUS_NO_MEMORY;
                }
-               vfs_user = conn->session_info->unix_info->unix_name;
+               /* unix_info could be NULL in session_info */
+               if (conn->session_info->unix_info != NULL) {
+                       vfs_user = conn->session_info->unix_info->unix_name;
+               } else {
+                       vfs_user = get_current_username();
+               }
        } else {
                /* use current authenticated user in absence of session_info */
                vfs_user = get_current_username();
        }
 
+       conn->user_ev_ctx = sconn->raw_ev_ctx;
+
        set_conn_connectpath(conn, connpath);
 
        /*
@@ -353,97 +368,16 @@ static NTSTATUS create_conn_struct_as_root(TALLOC_CTX *ctx,
                return NT_STATUS_UNSUCCESSFUL;
        }
 
-       conn->fs_capabilities = SMB_VFS_FS_CAPABILITIES(conn, &conn->ts_res);
-       *pconn = conn;
-
-       return NT_STATUS_OK;
-}
-
-/********************************************************
- Fake up a connection struct for the VFS layer, for use in
- applications (such as the python bindings), that do not want the
- global working directory changed under them.
-
- SMB_VFS_CONNECT requires root privileges.
-*********************************************************/
-
-NTSTATUS create_conn_struct(TALLOC_CTX *ctx,
-                           struct tevent_context *ev,
-                           struct messaging_context *msg,
-                           connection_struct **pconn,
-                           int snum,
-                           const char *path,
-                           const struct auth_session_info *session_info)
-{
-       NTSTATUS status;
-       become_root();
-       status = create_conn_struct_as_root(ctx, ev,
-                                           msg, pconn,
-                                           snum, path,
-                                           session_info);
-       unbecome_root();
-
-       return status;
-}
-
-/********************************************************
- Fake up a connection struct for the VFS layer.
- Note: this performs a vfs connect and CHANGES CWD !!!! JRA.
-
- The old working directory is returned on *poldcwd, allocated on ctx.
-*********************************************************/
-
-NTSTATUS create_conn_struct_cwd(TALLOC_CTX *ctx,
-                               struct tevent_context *ev,
-                               struct messaging_context *msg,
-                               connection_struct **pconn,
-                               int snum,
-                               const char *path,
-                               const struct auth_session_info *session_info,
-                               struct smb_filename **poldcwd_fname)
-{
-       connection_struct *conn;
-       struct smb_filename *oldcwd_fname = NULL;
-       struct smb_filename smb_fname_connectpath = {0};
-
-       NTSTATUS status = create_conn_struct(ctx, ev,
-                                            msg, &conn,
-                                            snum, path,
-                                            session_info);
-       if (!NT_STATUS_IS_OK(status)) {
-               return status;
-       }
-
-       /*
-        * Windows seems to insist on doing trans2getdfsreferral() calls on
-        * the IPC$ share as the anonymous user. If we try to chdir as that
-        * user we will fail.... WTF ? JRA.
-        */
-
-       oldcwd_fname = vfs_GetWd(ctx, conn);
-       if (oldcwd_fname == NULL) {
-               status = map_nt_error_from_unix(errno);
-               DEBUG(3, ("vfs_GetWd failed: %s\n", strerror(errno)));
-               conn_free(conn);
-               return status;
-       }
-
-       smb_fname_connectpath = (struct smb_filename) {
-               .base_name = conn->connectpath
-       };
-
-       if (vfs_ChDir(conn, &smb_fname_connectpath) != 0) {
-               status = map_nt_error_from_unix(errno);
-               DEBUG(3,("create_conn_struct: Can't ChDir to new conn path %s. "
-                       "Error was %s\n",
-                       conn->connectpath, strerror(errno) ));
-               TALLOC_FREE(oldcwd_fname);
+       talloc_free(conn->origpath);
+       conn->origpath = talloc_strdup(conn, conn->connectpath);
+       if (conn->origpath == NULL) {
                conn_free(conn);
-               return status;
+               return NT_STATUS_NO_MEMORY;
        }
 
-       *pconn = conn;
-       *poldcwd_fname = oldcwd_fname;
+       conn->fs_capabilities = SMB_VFS_FS_CAPABILITIES(conn, &conn->ts_res);
+       conn->tcon_done = true;
+       *pconn = talloc_move(ctx, &conn);
 
        return NT_STATUS_OK;
 }
@@ -476,7 +410,6 @@ NTSTATUS create_conn_struct_tos(struct messaging_context *msg,
                                struct conn_struct_tos **_c)
 {
        struct conn_struct_tos *c = NULL;
-       struct tevent_context *ev = NULL;
        NTSTATUS status;
 
        *_c = NULL;
@@ -486,24 +419,18 @@ NTSTATUS create_conn_struct_tos(struct messaging_context *msg,
                return NT_STATUS_NO_MEMORY;
        }
 
-       ev = samba_tevent_context_init(c);
-       if (ev == NULL) {
-               TALLOC_FREE(c);
-               return NT_STATUS_NO_MEMORY;
-       }
-
-       status = create_conn_struct(c,
-                                   ev,
-                                   msg,
-                                   &c->conn,
-                                   snum,
-                                   path,
-                                   session_info);
+       become_root();
+       status = create_conn_struct_as_root(c,
+                                           msg,
+                                           &c->conn,
+                                           snum,
+                                           path,
+                                           session_info);
+       unbecome_root();
        if (!NT_STATUS_IS_OK(status)) {
                TALLOC_FREE(c);
                return status;
        }
-       talloc_steal(c, c->conn);
 
        talloc_set_destructor(c, conn_struct_tos_destructor);
 
@@ -1185,7 +1112,7 @@ NTSTATUS get_referred_path(TALLOC_CTX *ctx,
                return NT_STATUS_OK;
        }
 
-       status = create_conn_struct_tos_cwd(server_messaging_context(),
+       status = create_conn_struct_tos_cwd(global_messaging_context(),
                                            snum,
                                            lp_path(frame, snum),
                                            NULL,
@@ -1399,7 +1326,7 @@ static bool junction_to_local_path_tos(const struct junction_map *jucn,
        if(snum < 0) {
                return False;
        }
-       status = create_conn_struct_tos_cwd(server_messaging_context(),
+       status = create_conn_struct_tos_cwd(global_messaging_context(),
                                            snum,
                                            lp_path(talloc_tos(), snum),
                                            NULL,
@@ -1555,9 +1482,9 @@ static int count_dfs_links(TALLOC_CTX *ctx, int snum)
        char *talloced = NULL;
        const char *connect_path = lp_path(frame, snum);
        const char *msdfs_proxy = lp_msdfs_proxy(frame, snum);
-       connection_struct *conn;
+       struct conn_struct_tos *c = NULL;
+       connection_struct *conn = NULL;
        NTSTATUS status;
-       struct smb_filename *cwd_fname = NULL;
        struct smb_filename *smb_fname = NULL;
 
        if(*connect_path == '\0') {
@@ -1569,20 +1496,18 @@ static int count_dfs_links(TALLOC_CTX *ctx, int snum)
         * Fake up a connection struct for the VFS layer.
         */
 
-       status = create_conn_struct_cwd(frame,
-                                       server_event_context(),
-                                       server_messaging_context(),
-                                       &conn,
-                                       snum,
-                                       connect_path,
-                                       NULL,
-                                       &cwd_fname);
+       status = create_conn_struct_tos_cwd(global_messaging_context(),
+                                           snum,
+                                           connect_path,
+                                           NULL,
+                                           &c);
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(3, ("create_conn_struct failed: %s\n",
                          nt_errstr(status)));
                TALLOC_FREE(frame);
                return 0;
        }
+       conn = c->conn;
 
        /* Count a link for the msdfs root - convention */
        cnt = 1;
@@ -1628,9 +1553,6 @@ static int count_dfs_links(TALLOC_CTX *ctx, int snum)
        SMB_VFS_CLOSEDIR(conn,dirp);
 
 out:
-       vfs_ChDir(conn, cwd_fname);
-       SMB_VFS_DISCONNECT(conn);
-       conn_free(conn);
        TALLOC_FREE(frame);
        return cnt;
 }
@@ -1651,9 +1573,9 @@ static int form_junctions(TALLOC_CTX *ctx,
        const char *connect_path = lp_path(frame, snum);
        char *service_name = lp_servicename(frame, snum);
        const char *msdfs_proxy = lp_msdfs_proxy(frame, snum);
-       connection_struct *conn;
+       struct conn_struct_tos *c = NULL;
+       connection_struct *conn = NULL;
        struct referral *ref = NULL;
-       struct smb_filename *cwd_fname = NULL;
        struct smb_filename *smb_fname = NULL;
        NTSTATUS status;
 
@@ -1671,20 +1593,18 @@ static int form_junctions(TALLOC_CTX *ctx,
         * Fake up a connection struct for the VFS layer.
         */
 
-       status = create_conn_struct_cwd(frame,
-                                       server_event_context(),
-                                       server_messaging_context(),
-                                       &conn,
-                                       snum,
-                                       connect_path,
-                                       NULL,
-                                       &cwd_fname);
+       status = create_conn_struct_tos_cwd(global_messaging_context(),
+                                           snum,
+                                           connect_path,
+                                           NULL,
+                                           &c);
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(3, ("create_conn_struct failed: %s\n",
                          nt_errstr(status)));
                TALLOC_FREE(frame);
                return 0;
        }
+       conn = c->conn;
 
        /* form a junction for the msdfs root - convention
           DO NOT REMOVE THIS: NT clients will not work with us
@@ -1792,8 +1712,6 @@ out:
                SMB_VFS_CLOSEDIR(conn,dirp);
        }
 
-       vfs_ChDir(conn, cwd_fname);
-       conn_free(conn);
        TALLOC_FREE(frame);
        return cnt;
 }