bbaumbach/samba-autobuild/.git
16 years agor19399: Now Guenther discovered one crash dereferencing domain->backends,
Jeremy Allison [Wed, 18 Oct 2006 21:24:20 +0000 (21:24 +0000)]
r19399: Now Guenther discovered one crash dereferencing domain->backends,
get paranoid. I don't think this can really happen, but let's be
sure.
Jeremy.
(This used to be commit be4709984b8548abf10a5e9fabba21d53440c42a)

16 years agor19394: When we fail to get the list of trusted domains, make sure to return
Günther Deschner [Wed, 18 Oct 2006 16:09:42 +0000 (16:09 +0000)]
r19394: When we fail to get the list of trusted domains, make sure to return
WINBINDD_ERROR.

Guenther
(This used to be commit 6089b3007bf92904ca4562d21958d7922143dbcb)

16 years agor19391: Fix crash bug within the winbind caching method.
Günther Deschner [Wed, 18 Oct 2006 14:22:08 +0000 (14:22 +0000)]
r19391: Fix crash bug within the winbind caching method.

That one was hard to find: when coming from offline mode and switching
to online, a refresh sequence number call (using the default MS-RPC
mechanism) may reset domain->backend to NULL (by the set_domain_online
event). We need to make sure to reidentify the remote domain in that
case.

Guenther
(This used to be commit 4d6503d1377a262ba8b87f344be7daf04e011ef2)

16 years agor19390: Add some tests that are known failing against samba3.
Jelmer Vernooij [Wed, 18 Oct 2006 12:23:58 +0000 (12:23 +0000)]
r19390: Add some tests that are known failing against samba3.
(This used to be commit 6ff2ad4246a7e6c51ac8764c417fffc57c6d49df)

16 years agor19386: Limit the size of the connection bitmap to <64K entries.
James Peach [Wed, 18 Oct 2006 03:34:31 +0000 (03:34 +0000)]
r19386: Limit the size of the connection bitmap to <64K entries.
(This used to be commit 9f0518e0b0d4add7cceac6d4d797edddb0080aaa)

16 years agor19385: These replaced symbols should have a rep_ prefix.
James Peach [Wed, 18 Oct 2006 03:26:58 +0000 (03:26 +0000)]
r19385: These replaced symbols should have a rep_ prefix.
(This used to be commit decdb46a3f7445d589c23e0ad554453ae79cd292)

16 years agor19374: fix the build with heimdal
Stefan Metzmacher [Tue, 17 Oct 2006 15:57:00 +0000 (15:57 +0000)]
r19374: fix the build with heimdal

metze
(This used to be commit a813c7595541e31dfa77915d80235de4402bfeca)

16 years agor19371: Add two missing refresh_sequence_number calls where they are missing
Günther Deschner [Tue, 17 Oct 2006 12:41:24 +0000 (12:41 +0000)]
r19371: Add two missing refresh_sequence_number calls where they are missing
just before writing to the winbind cache tdb.

Guenther
(This used to be commit bd8548998b06a84c2e66acbcb68542a4b5d8b8df)

16 years agor19368: Use WINBINDD_CACHE_TDB_DEFAULT_HASH_SIZE whereever the winbindd tdb is
Günther Deschner [Tue, 17 Oct 2006 12:06:17 +0000 (12:06 +0000)]
r19368: Use WINBINDD_CACHE_TDB_DEFAULT_HASH_SIZE whereever the winbindd tdb is
opened.

Guenther
(This used to be commit 49e9e1a3e7f6ac1a9cf584c88f3c640ca9d15554)

16 years agor19355: Add getdispenumindex2 wrapper for rpcclient.
Günther Deschner [Mon, 16 Oct 2006 23:42:15 +0000 (23:42 +0000)]
r19355: Add getdispenumindex2 wrapper for rpcclient.

Guenther
(This used to be commit 27c35848ebc6d72fd4fccbb6597b63787230f80c)

16 years agor19354: adjust usage printf for rpcclient's timeout command.
Günther Deschner [Mon, 16 Oct 2006 23:28:48 +0000 (23:28 +0000)]
r19354: adjust usage printf for rpcclient's timeout command.

Guenther
(This used to be commit fb21c9c58b3867ee2f0831342427b0cd0aa1fd6c)

16 years agor19353: Add "timeout" command for rpcclient.
Günther Deschner [Mon, 16 Oct 2006 23:27:38 +0000 (23:27 +0000)]
r19353: Add "timeout" command for rpcclient.

Guenther
(This used to be commit 4106a56d3f4edb2e07e876204743a1cb028c950a)

16 years agor19351: Also export the info3 profilepath via the PAM_WINBIND_PROFILEPATH data
Günther Deschner [Mon, 16 Oct 2006 23:13:56 +0000 (23:13 +0000)]
r19351: Also export the info3 profilepath via the PAM_WINBIND_PROFILEPATH data
field.

Guenther
(This used to be commit 66b92f27fa4edec180b8c8eee929ec8f31ef6a08)

16 years agor19349: Fix invalid free on the PAM_WINBIND_PWD_LAST_SET data.
Günther Deschner [Mon, 16 Oct 2006 23:06:48 +0000 (23:06 +0000)]
r19349: Fix invalid free on the PAM_WINBIND_PWD_LAST_SET data.

Guenther
(This used to be commit a4d17ee9c960abdf21b9af1601bd1042e0cd7636)

16 years agor19348: Fix uninitialized dictionary handle, found by valgrind.
Günther Deschner [Mon, 16 Oct 2006 22:41:24 +0000 (22:41 +0000)]
r19348: Fix uninitialized dictionary handle, found by valgrind.

Guenther
(This used to be commit 9621bb420a13e634badcc922c73c8bfb30aa6120)

16 years agor19345: Allow better rootdse searches.
Günther Deschner [Mon, 16 Oct 2006 20:27:08 +0000 (20:27 +0000)]
r19345: Allow better rootdse searches.

Guenther
(This used to be commit 27fbd85300c810cd06f4df514b6a762f8eac84d5)

16 years agor19342: we only have one BASE-LOCK test in samba4's smbtorture now
Stefan Metzmacher [Mon, 16 Oct 2006 19:59:32 +0000 (19:59 +0000)]
r19342: we only have one BASE-LOCK test in samba4's smbtorture now

metze
(This used to be commit a2c20811d6ef2a20326bcc2d4c2bb2cbb49f6394)

16 years agor19340: Wait longer then 10 seconds for a samr_query_groupmem lookup to succeed.
Günther Deschner [Mon, 16 Oct 2006 14:29:14 +0000 (14:29 +0000)]
r19340: Wait longer then 10 seconds for a samr_query_groupmem lookup to succeed.

Guenther
(This used to be commit 37dd019e21cab2f0df314b0b741f79422fc10d1b)

16 years agor19302: Use TALLOC_ZERO_P not TALLOC_P to ensure unused
Jeremy Allison [Mon, 16 Oct 2006 00:12:00 +0000 (00:12 +0000)]
r19302: Use TALLOC_ZERO_P not TALLOC_P to ensure unused
fields are initialized to zero.
Jeremy.
(This used to be commit 8a0ff70e8e562db17b8d90dbde7aeb0314d270da)

16 years agor19301: Correct debug statement.
Jeremy Allison [Mon, 16 Oct 2006 00:08:19 +0000 (00:08 +0000)]
r19301: Correct debug statement.
(This used to be commit 3ea8399bc9ae9de0a6eb0efe0f5b96f923b62082)

16 years agor19300: Fix null deref in debug statement.
Jeremy Allison [Mon, 16 Oct 2006 00:00:32 +0000 (00:00 +0000)]
r19300: Fix null deref in debug statement.
Jeremy.
(This used to be commit c55b9111f60debe4c5a7765273fc86ac3829f31c)

16 years agor19292: Avoid some potential segfaults: In winreg_EnumValue all pointers are unique
Volker Lendecke [Sun, 15 Oct 2006 16:06:10 +0000 (16:06 +0000)]
r19292: Avoid some potential segfaults: In winreg_EnumValue all pointers are unique
pointers and can thus be independently NULL.

Thanks,

Volker
(This used to be commit d48ac0726a931a7200c47a87f771b74826ab9c96)

16 years agor19291: this should fix the build on heimdal systems
Stefan Metzmacher [Sun, 15 Oct 2006 15:14:04 +0000 (15:14 +0000)]
r19291: this should fix the build on heimdal systems

metze
(This used to be commit 785ab128c4d630819f141ede8bcf5fc0c705aebb)

16 years agor19290: regedit running on nt4 will cut off the last character from a enumkey without
Volker Lendecke [Sun, 15 Oct 2006 14:47:25 +0000 (14:47 +0000)]
r19290: regedit running on nt4 will cut off the last character from a enumkey without
this patch. Jerry, Jelmer, can you please check this?

Thanks,

Volker
(This used to be commit ed95fe3c63d48de9504d43f90e72f11ec0617064)

16 years agor19288: tdb_prs_store is right now used to store printer and share security
Volker Lendecke [Sun, 15 Oct 2006 09:16:41 +0000 (09:16 +0000)]
r19288: tdb_prs_store is right now used to store printer and share security
descriptors. Both databases are long-lived and not frequently written, so I
think storing it deserves a tdb transaction.

Volker
(This used to be commit 2d4b5f5727104f87b8282fc0e94675b0dc4cd9d8)

16 years agor19287: As requested by Bjoern Jacke <bjoern@j3e.de>: Check in the NetBSD winbind...
Volker Lendecke [Sun, 15 Oct 2006 08:32:25 +0000 (08:32 +0000)]
r19287: As requested by Bjoern Jacke <bjoern@j3e.de>: Check in the NetBSD winbind module by Luke
Mewburn.

Volker
(This used to be commit 104f5e9ec9aea71950308b8b73479f06bf3c66a2)

16 years agor19286: Remove dependency on Fink. If we really *need* anything from Fink,
James Peach [Sun, 15 Oct 2006 04:49:22 +0000 (04:49 +0000)]
r19286: Remove dependency on Fink. If we really *need* anything from Fink,
this shold be a strong dependency. If stuff from Fink is an optional
extra, there should be a --with-stuff-from-fink argument. It's just
too easy to unexpectedly end up with binaries that depend on
/sw/{lib,include}.
(This used to be commit d0166e117216b5196b27a7caef776007641072f2)

16 years agor19272: Ensure we return 1 member in the optimized case.
Jeremy Allison [Sat, 14 Oct 2006 01:57:59 +0000 (01:57 +0000)]
r19272: Ensure we return 1 member in the optimized case.
(This used to be commit cc6cdabf19e9a610be064e26fdf3a9d2a3c76c2c)

16 years agor19271: Test the "hack" for "Domain Users" as agreed with
Jeremy Allison [Sat, 14 Oct 2006 00:33:03 +0000 (00:33 +0000)]
r19271: Test the "hack" for "Domain Users" as agreed with
Jerry.
If "enum users" is set to false, and the group being looked
up is the Domain Users SID: S-1-5-domain-513, then for the
list of members check if the querying user is in that group,
and if so only return that user as the gr_mem array.
We can change this to a different parameter than "enum users"
if neccessaey, or parameterize the group list we do this for.
Jeremy.
(This used to be commit 91b40e25cc38ed6e8df9e448da975d3e202d919f)

16 years agor19270: Stop depending on internal MIT symbols. These are private on MacOS
James Peach [Fri, 13 Oct 2006 23:43:27 +0000 (23:43 +0000)]
r19270: Stop depending on internal MIT symbols. These are private on MacOS
x, so we can't get at them even if we wanted to.

Kerberos experts, please take a look to make sure I've done the
right thing!
(This used to be commit 9b8e179fcc1fb877e8601bfd242ee1fd615b554c)

16 years agor19263: Be more accurate in telling what the sitename problem is in this DEBUG
Günther Deschner [Fri, 13 Oct 2006 09:44:54 +0000 (09:44 +0000)]
r19263: Be more accurate in telling what the sitename problem is in this DEBUG
statement.

Guenther
(This used to be commit 62928734b820f512f940c1ed79048e14b322d060)

16 years agor19260: Fix for bug #3524 from tiamat@komi.mts.ru - Solaris quotas.
Jeremy Allison [Fri, 13 Oct 2006 05:22:36 +0000 (05:22 +0000)]
r19260: Fix for bug #3524 from tiamat@komi.mts.ru - Solaris quotas.
Jeremy.
(This used to be commit ac510a90f3adf72b64a8e2a764b0500dcd223b3f)

16 years agor19257: Janitor for Guenther - as well as a little massaging to make
Jeremy Allison [Thu, 12 Oct 2006 21:03:28 +0000 (21:03 +0000)]
r19257: Janitor for Guenther - as well as a little massaging to make
his patch fit SAMBA_3_0. (This is guenthers code). Make
site support work correctly in net ads join.
Jeremy.
(This used to be commit 47352b5398e67eb8f4f383dafce31c922626ae99)

16 years agor19255: Add blacklist of accounts when NSS initgroups calls are coming in and
Günther Deschner [Thu, 12 Oct 2006 13:29:01 +0000 (13:29 +0000)]
r19255: Add blacklist of accounts when NSS initgroups calls are coming in and
"winbind use default domain" is set. Defaults to "root, nobody, lp"
currently.

Guenther
(This used to be commit b5b42196a6f2869deefc700dc98060f5ab832e40)

16 years agor19254: Make sure to also wait 35 seconds to receive a Netlogon GETDC reply
Günther Deschner [Thu, 12 Oct 2006 11:25:37 +0000 (11:25 +0000)]
r19254: Make sure to also wait 35 seconds to receive a Netlogon GETDC reply
here in winbindd_getdcname().

Guenther
(This used to be commit 58a181edc5ea8e87e9978f11a5a729ad4dc60091)

16 years agor19250: Fixes bug 4156.
Derrell Lipman [Wed, 11 Oct 2006 19:51:52 +0000 (19:51 +0000)]
r19250: Fixes bug 4156.

The protocol negotiation string "LANMAN2.1" was not listed in the set of
negotiatiable possibilities, so non-optimal negotiation was taking place.
(This used to be commit a0dfa60fc5146ea6af0b88d91e030a4ec3d7f01e)

16 years agor19249: Attempt to fix a site lookup bug found by Guenther.
Jeremy Allison [Wed, 11 Oct 2006 18:54:40 +0000 (18:54 +0000)]
r19249: Attempt to fix a site lookup bug found by Guenther.

- "The problem is, with a fresh system, we don't know our sitename,
therefor we do a stupid DNS query for all DCs. The reply we get is a
round-robin list of all 21 DCs, we just pick the first, contact that
and safe that INET.COM#1C query in the name cache for later use...
What we need to do if we don't yet know our sitename, is to contact to
any DC, get the CLDAP reply to tell us in which site we are, then flush
the namecache and requery DNS including the sitename"

Implement the flushing of the #1C entries for a given NetBIOS name/realm
when looking up the site value.

Jeremy.
(This used to be commit b2d1e44f59d32c91b1d48eacd1a158ba7b65762d)

16 years agor19248: Activate RPC-SAMBA3-WKSSVC
Volker Lendecke [Wed, 11 Oct 2006 15:27:21 +0000 (15:27 +0000)]
r19248: Activate RPC-SAMBA3-WKSSVC
(This used to be commit ed6070b7a053e162a9ac5809ff54181c04267f00)

16 years agor19246: merge from samba4 rev 18207 and 18208:
Stefan Metzmacher [Wed, 11 Oct 2006 13:59:03 +0000 (13:59 +0000)]
r19246: merge from samba4 rev 18207 and 18208:

readline fixes for mac os 10

metze
(This used to be commit 976b97ecbf9bde400a6f92cad9d9709d56e73058)

16 years agor19244: fix the build on systems with broken krb5
Stefan Metzmacher [Wed, 11 Oct 2006 13:31:00 +0000 (13:31 +0000)]
r19244: fix the build on systems with broken krb5
we need to make sure

HAVE_GSSAPI

HAVE_KRB5_H
HAVE_GSSAPI_H
HAVE_GSSAPI_GSSAPI_GENERIC_H
HAVE_GSSAPI_GSSAPI_H

are not in config.h

this adds 2 new macros to libreplace
AC_REMOVE_DEFINE(), AC_REMOVE_INCLUDE()

metze
(This used to be commit eb1f0b49cf0e84385a62f9dfcb2167fea2e8fd8b)

16 years agor19243: Fix debug statement.
Günther Deschner [Wed, 11 Oct 2006 12:29:04 +0000 (12:29 +0000)]
r19243: Fix debug statement.

Guenther
(This used to be commit 4b9d79147ae81fb701abf02dc046076f606443b6)

16 years agor19241: compile xattr wrappers on mac os 10
Stefan Metzmacher [Wed, 11 Oct 2006 11:41:39 +0000 (11:41 +0000)]
r19241: compile xattr wrappers on mac os 10

patch from Bjoern Jacke and it fixes bug 3698

metze
(This used to be commit e54302b9163cfe726c30a8efdc779250e076d493)

16 years agor19240: move the NO_CONFIG_H check to libreplace
Stefan Metzmacher [Wed, 11 Oct 2006 11:38:40 +0000 (11:38 +0000)]
r19240: move the NO_CONFIG_H check to libreplace

this fixes the quota detection configure and maybe more
configure tests

metze
(This used to be commit a3a082c42ccb21cb16d2e53991808ef3224efc6c)

16 years agor19239: make the acl configure check more readable...
Stefan Metzmacher [Wed, 11 Oct 2006 10:57:33 +0000 (10:57 +0000)]
r19239: make the acl configure check more readable...

metze
(This used to be commit 0882f0c9d671cd466668f65433ee33a71f127a95)

16 years agor19238: Let the comfigure check find that some krb5 functions
Stefan Metzmacher [Wed, 11 Oct 2006 09:46:19 +0000 (09:46 +0000)]
r19238: Let the comfigure check find that some krb5 functions
are missing! Bailing out at compile time is ugly.

Hopefully this fixes the Mac OS 10 boxes in the build-farm
there're some missing function. Fixing that is a different
problem...

metze
(This used to be commit e00a83a0b65f4685b946aa9a4d225645f67a6df6)

16 years agor19237: fix typo
Stefan Metzmacher [Wed, 11 Oct 2006 09:15:11 +0000 (09:15 +0000)]
r19237: fix typo

metze
(This used to be commit d91041d4b6973fd9779d355cd6f9634e207b7653)

16 years agor19236: prepare for --with-pam=auto as default
Stefan Metzmacher [Wed, 11 Oct 2006 08:47:56 +0000 (08:47 +0000)]
r19236: prepare for --with-pam=auto as default
but still leave --with-pam=no the default for now
and wait for discussion on samba-technical

metze
(This used to be commit b045d5afcf2e352ebb797132bd6b7c02f3b685a0)

16 years agor19235: merge from samba4:
Stefan Metzmacher [Wed, 11 Oct 2006 07:22:33 +0000 (07:22 +0000)]
r19235: merge from samba4:

fix configure test for net/if.h on some platforms

AC_LANG_SOURCE() adds the content of confdefs.h in front
of the compiled file

metze
(This used to be commit 7cbdc06ad9b68544c8eeaa68fdd7b03f71c0b739)

16 years agor19233: remove unused --with-spinlocks option
Stefan Metzmacher [Wed, 11 Oct 2006 05:36:52 +0000 (05:36 +0000)]
r19233: remove unused --with-spinlocks option

the defines are not used anywhere in the tree.
(grep -R SPINLOCKS . in the topdir)

metze
(This used to be commit 1697686d9da7dd1ac707c7af9c145c0fc6204108)

16 years agor19232: merge from samba4:
Stefan Metzmacher [Wed, 11 Oct 2006 05:18:20 +0000 (05:18 +0000)]
r19232: merge from samba4:

- machine/sys/getppdp.h workaround for HPUX 11.23
- more verbose check for net/if.h

metze
(This used to be commit 9b5c5bc3f3912776af6a8c9b13a9cb8dd2eff8f8)

16 years agor19231: I encountered a WinXP/Home system which, acting as the master browser for its
Derrell Lipman [Wed, 11 Oct 2006 00:33:48 +0000 (00:33 +0000)]
r19231: I encountered a WinXP/Home system which, acting as the master browser for its
workgroup, decided periodically to stop sending recognized responses to a
NetServerEnum2 request for the workgroup.  Instead of returning the list of
servers (only itself; nothing else in the workgroup), it returns a status code
of 8 which is unsupported by samba3, samba4, and ethereal.

The code for this request assumed that if an unexpected status code was
received, the connection had a problem, i.e. that cli_errno() would show a
problem.  That turns out not to be the case.

This patch changes the behavior so tha any time a response is received and
cli_errno() == 0, we continue processing the reply and base our response on
the returned count (zero).  The pre-existing code then converts this count=0
into an ENOENT errno which can be properly handled by the application (whereas
an error return with errno=0 can't be).

This packet dump has only 2 frames.  Sorry about the text version but it's
most easily attached to this log message.  I also have it saved as .pcap if
anyone wants it.

Derrell

No.     Time            Source                Destination           Protocol Info
      1 14:31:59.802668 192.168.1.106         192.168.1.100         LANMAN   NetServerEnum2 Request, Server, SQL Server, Domain Controller, Backup Controller, Time Source, Apple Server, Novell Server, Domain Member Server, Print Queue Server, Dialin Server, Xenix Server, NT Workstation, Windows for Workgroups, Unknown server type:14, NT Server

Frame 1 (196 bytes on wire, 196 bytes captured)
    Arrival Time: Oct 10, 2006 14:31:59.802668000
    Time delta from previous packet: 0.000000000 seconds
    Time since reference or first frame: 0.000000000 seconds
    Frame Number: 1
    Packet Length: 196 bytes
    Capture Length: 196 bytes
    Protocols in frame: eth:ip:tcp:nbss:smb
Ethernet II, Src: IntelCor_4a:47:bb (00:13:20:4a:47:bb), Dst: Micro-St_74:16:e7 (00:0c:76:74:16:e7)
    Destination: Micro-St_74:16:e7 (00:0c:76:74:16:e7)
    Source: IntelCor_4a:47:bb (00:13:20:4a:47:bb)
    Type: IP (0x0800)
Internet Protocol, Src: 192.168.1.106 (192.168.1.106), Dst: 192.168.1.100 (192.168.1.100)
    Version: 4
    Header length: 20 bytes
    Differentiated Services Field: 0x00 (DSCP 0x00: Default; ECN: 0x00)
        0000 00.. = Differentiated Services Codepoint: Default (0x00)
        .... ..0. = ECN-Capable Transport (ECT): 0
        .... ...0 = ECN-CE: 0
    Total Length: 182
    Identification: 0xb838 (47160)
    Flags: 0x04 (Don't Fragment)
        0... = Reserved bit: Not set
        .1.. = Don't fragment: Set
        ..0. = More fragments: Not set
    Fragment offset: 0
    Time to live: 64
    Protocol: TCP (0x06)
    Header checksum: 0xfdea [correct]
        Good: True
        Bad : False
    Source: 192.168.1.106 (192.168.1.106)
    Destination: 192.168.1.100 (192.168.1.100)
Transmission Control Protocol, Src Port: 44932 (44932), Dst Port: netbios-ssn (139), Seq: 851982066, Ack: 1274726157, Len: 130
    Source port: 44932 (44932)
    Destination port: netbios-ssn (139)
    Sequence number: 851982066
    Next sequence number: 851982196
    Acknowledgement number: 1274726157
    Header length: 32 bytes
    Flags: 0x0018 (PSH, ACK)
        0... .... = Congestion Window Reduced (CWR): Not set
        .0.. .... = ECN-Echo: Not set
        ..0. .... = Urgent: Not set
        ...1 .... = Acknowledgment: Set
        .... 1... = Push: Set
        .... .0.. = Reset: Not set
        .... ..0. = Syn: Not set
        .... ...0 = Fin: Not set
    Window size: 6432
    Checksum: 0xb4e0 [correct]
    Options: (12 bytes)
        NOP
        NOP
        Time stamp: tsval 1184074739, tsecr 11576161
NetBIOS Session Service
    Message Type: Session message
    Flags: 0x00
        .... ...0 = Add 0 to length
    Length: 126
SMB (Server Message Block Protocol)
    SMB Header
        Server Component: SMB
        Response in: 2
        SMB Command: Trans (0x25)
        NT Status: STATUS_SUCCESS (0x00000000)
        Flags: 0x08
            0... .... = Request/Response: Message is a request to the server
            .0.. .... = Notify: Notify client only on open
            ..0. .... = Oplocks: OpLock not requested/granted
            ...0 .... = Canonicalized Pathnames: Pathnames are not canonicalized
            .... 1... = Case Sensitivity: Path names are caseless
            .... ..0. = Receive Buffer Posted: Receive buffer has not been posted
            .... ...0 = Lock and Read: Lock&Read, Write&Unlock are not supported
        Flags2: 0xc801
            1... .... .... .... = Unicode Strings: Strings are Unicode
            .1.. .... .... .... = Error Code Type: Error codes are NT error codes
            ..0. .... .... .... = Execute-only Reads: Don't permit reads if execute-only
            ...0 .... .... .... = Dfs: Don't resolve pathnames with Dfs
            .... 1... .... .... = Extended Security Negotiation: Extended security negotiation is supported
            .... .... .0.. .... = Long Names Used: Path names in request are not long file names
            .... .... .... .0.. = Security Signatures: Security signatures are not supported
            .... .... .... ..0. = Extended Attributes: Extended attributes are not supported
            .... .... .... ...1 = Long Names Allowed: Long file names are allowed in the response
        Process ID High: 0
        Signature: 0000000000000000
        Reserved: 0000
        Tree ID: 2048
        Process ID: 12967
        User ID: 2048
        Multiplex ID: 6
    Trans Request (0x25)
        Word Count (WCT): 14
        Total Parameter Count: 36
        Total Data Count: 0
        Max Parameter Count: 8
        Max Data Count: 65535
        Max Setup Count: 0
        Reserved: 00
        Flags: 0x0000
            .... .... .... ..0. = One Way Transaction: Two way transaction
            .... .... .... ...0 = Disconnect TID: Do NOT disconnect TID
        Timeout: Return immediately (0)
        Reserved: 0000
        Parameter Count: 36
        Parameter Offset: 90
        Data Count: 0
        Data Offset: 126
        Setup Count: 0
        Reserved: 00
        Byte Count (BCC): 63
        Transaction Name: \PIPE\LANMAN
SMB Pipe Protocol
Microsoft Windows Lanman Remote API Protocol
    Function Code: NetServerEnum2 (104)
    Parameter Descriptor: WrLehDz
    Return Descriptor: B16BBDz
    Detail Level: 1
    Receive Buffer Length: 65535
    Server Type: 0x0000fffe
        .... .... .... .... .... .... .... ...0 = Workstation: This is NOT a Workstation
        .... .... .... .... .... .... .... ..1. = Server: This is a Server
        .... .... .... .... .... .... .... .1.. = SQL: This is an SQL server
        .... .... .... .... .... .... .... 1... = Domain Controller: This is a Domain Controller
        .... .... .... .... .... .... ...1 .... = Backup Controller: This is a Backup Controller
        .... .... .... .... .... .... ..1. .... = Time Source: This is a Time Source
        .... .... .... .... .... .... .1.. .... = Apple: This is an Apple host
        .... .... .... .... .... .... 1... .... = Novell: This is a Novell server
        .... .... .... .... .... ...1 .... .... = Member: This is a Domain Member server
        .... .... .... .... .... ..1. .... .... = Print: This is a Print Queue server
        .... .... .... .... .... .1.. .... .... = Dialin: This is a Dialin server
        .... .... .... .... .... 1... .... .... = Xenix: This is a Xenix server
        .... .... .... .... ...1 .... .... .... = NT Workstation: This is an NT Workstation
        .... .... .... .... ..1. .... .... .... = WfW: This is a WfW host
        .... .... .... .... 1... .... .... .... = NT Server: This is an NT Server
        .... .... .... ...0 .... .... .... .... = Potential Browser: This is NOT a Potential Browser
        .... .... .... ..0. .... .... .... .... = Backup Browser: This is NOT a Backup Browser
        .... .... .... .0.. .... .... .... .... = Master Browser: This is NOT a Master Browser
        .... .... .... 0... .... .... .... .... = Domain Master Browser: This is NOT a Domain Master Browser
        .... .... ...0 .... .... .... .... .... = OSF: This is NOT an OSF host
        .... .... ..0. .... .... .... .... .... = VMS: This is NOT a VMS host
        .... .... .0.. .... .... .... .... .... = Windows 95+: This is NOT a Windows 95 or above host
        .0.. .... .... .... .... .... .... .... = Local: This is NOT a local list only request
        0... .... .... .... .... .... .... .... = Domain Enum: This is NOT a Domain Enum request
    Enumeration Domain: WORKGROUP

No.     Time            Source                Destination           Protocol Info
      2 14:31:59.803918 192.168.1.100         192.168.1.106         LANMAN   NetServerEnum2 Response

Frame 2 (134 bytes on wire, 134 bytes captured)
    Arrival Time: Oct 10, 2006 14:31:59.803918000
    Time delta from previous packet: 0.001250000 seconds
    Time since reference or first frame: 0.001250000 seconds
    Frame Number: 2
    Packet Length: 134 bytes
    Capture Length: 134 bytes
    Protocols in frame: eth:ip:tcp:nbss:smb
Ethernet II, Src: Micro-St_74:16:e7 (00:0c:76:74:16:e7), Dst: IntelCor_4a:47:bb (00:13:20:4a:47:bb)
    Destination: IntelCor_4a:47:bb (00:13:20:4a:47:bb)
    Source: Micro-St_74:16:e7 (00:0c:76:74:16:e7)
    Type: IP (0x0800)
Internet Protocol, Src: 192.168.1.100 (192.168.1.100), Dst: 192.168.1.106 (192.168.1.106)
    Version: 4
    Header length: 20 bytes
    Differentiated Services Field: 0x00 (DSCP 0x00: Default; ECN: 0x00)
        0000 00.. = Differentiated Services Codepoint: Default (0x00)
        .... ..0. = ECN-Capable Transport (ECT): 0
        .... ...0 = ECN-CE: 0
    Total Length: 120
    Identification: 0xea10 (59920)
    Flags: 0x04 (Don't Fragment)
        0... = Reserved bit: Not set
        .1.. = Don't fragment: Set
        ..0. = More fragments: Not set
    Fragment offset: 0
    Time to live: 128
    Protocol: TCP (0x06)
    Header checksum: 0x8c50 [correct]
        Good: True
        Bad : False
    Source: 192.168.1.100 (192.168.1.100)
    Destination: 192.168.1.106 (192.168.1.106)
Transmission Control Protocol, Src Port: netbios-ssn (139), Dst Port: 44932 (44932), Seq: 1274726157, Ack: 851982196, Len: 68
    Source port: netbios-ssn (139)
    Destination port: 44932 (44932)
    Sequence number: 1274726157
    Next sequence number: 1274726225
    Acknowledgement number: 851982196
    Header length: 32 bytes
    Flags: 0x0018 (PSH, ACK)
        0... .... = Congestion Window Reduced (CWR): Not set
        .0.. .... = ECN-Echo: Not set
        ..0. .... = Urgent: Not set
        ...1 .... = Acknowledgment: Set
        .... 1... = Push: Set
        .... .0.. = Reset: Not set
        .... ..0. = Syn: Not set
        .... ...0 = Fin: Not set
    Window size: 64606
    Checksum: 0x1e0d [correct]
    Options: (12 bytes)
        NOP
        NOP
        Time stamp: tsval 11576161, tsecr 1184074739
NetBIOS Session Service
    Message Type: Session message
    Flags: 0x00
        .... ...0 = Add 0 to length
    Length: 64
SMB (Server Message Block Protocol)
    SMB Header
        Server Component: SMB
        Response to: 1
        Time from request: 0.001250000 seconds
        SMB Command: Trans (0x25)
        NT Status: STATUS_SUCCESS (0x00000000)
        Flags: 0x88
            1... .... = Request/Response: Message is a response to the client/redirector
            .0.. .... = Notify: Notify client only on open
            ..0. .... = Oplocks: OpLock not requested/granted
            ...0 .... = Canonicalized Pathnames: Pathnames are not canonicalized
            .... 1... = Case Sensitivity: Path names are caseless
            .... ..0. = Receive Buffer Posted: Receive buffer has not been posted
            .... ...0 = Lock and Read: Lock&Read, Write&Unlock are not supported
        Flags2: 0xc801
            1... .... .... .... = Unicode Strings: Strings are Unicode
            .1.. .... .... .... = Error Code Type: Error codes are NT error codes
            ..0. .... .... .... = Execute-only Reads: Don't permit reads if execute-only
            ...0 .... .... .... = Dfs: Don't resolve pathnames with Dfs
            .... 1... .... .... = Extended Security Negotiation: Extended security negotiation is supported
            .... .... .0.. .... = Long Names Used: Path names in request are not long file names
            .... .... .... .0.. = Security Signatures: Security signatures are not supported
            .... .... .... ..0. = Extended Attributes: Extended attributes are not supported
            .... .... .... ...1 = Long Names Allowed: Long file names are allowed in the response
        Process ID High: 0
        Signature: 0000000000000000
        Reserved: 0000
        Tree ID: 2048
        Process ID: 12967
        User ID: 2048
        Multiplex ID: 6
    Trans Response (0x25)
        Word Count (WCT): 10
        Total Parameter Count: 8
        Total Data Count: 0
        Reserved: 0000
        Parameter Count: 8
        Parameter Offset: 56
        Parameter Displacement: 0
        Data Count: 0
        Data Offset: 64
        Data Displacement: 0
        Setup Count: 0
        Reserved: 00
        Byte Count (BCC): 9
        Padding: 00
SMB Pipe Protocol
Microsoft Windows Lanman Remote API Protocol
    Function Code: NetServerEnum2 (104)
    Status: Unknown (8)
    Convert: 0
    Entry Count: 0
    Available Entries: 0
(This used to be commit 88fa5ac7347cbae92abe17da8d3af00e85110c43)

16 years agor19230: Doh ! Fix obvious crash bug.....
Jeremy Allison [Tue, 10 Oct 2006 16:15:01 +0000 (16:15 +0000)]
r19230: Doh ! Fix obvious crash bug.....
(This used to be commit e6560270499365ca42517f6a7cf40845ee80edfb)

16 years agor19224: Add setting the rng_fault_state to the already converted pipes.
Volker Lendecke [Tue, 10 Oct 2006 08:39:11 +0000 (08:39 +0000)]
r19224: Add setting the rng_fault_state to the already converted pipes.

Convert the low-hanging fruit of the LSA server. This provides a sample how
the server calls can be converted one by one, see the "proxy_lsa_call"
function.

Volker
(This used to be commit 99e54a213ad3561ea6e8dc44c483847c18c5681e)

16 years agor19221: Monster-Checkin after "make idl"
Volker Lendecke [Tue, 10 Oct 2006 07:55:46 +0000 (07:55 +0000)]
r19221: Monster-Checkin after "make idl"
(This used to be commit 416466a16f58ac644baacaa2522c4e98176d0e70)

16 years agor19220: Check if a backend has set rng_fault_state and send a dce-level fault pdu.
Volker Lendecke [Tue, 10 Oct 2006 07:53:41 +0000 (07:53 +0000)]
r19220: Check if a backend has set rng_fault_state and send a dce-level fault pdu.

Volker
(This used to be commit 21c08e7ef460ae7eaf1f441e8aadcfe0502fa1ad)

16 years agor19218: With the new RPC server infrastructure all backend functions are filled, at
Volker Lendecke [Tue, 10 Oct 2006 07:37:03 +0000 (07:37 +0000)]
r19218: With the new RPC server infrastructure all backend functions are filled, at
least with dummy routines. We need a way to indicate that we do not support a
call, so that srv_pipe_hnd.c can return the DCE level RNG_ERROR.

This flag can be set in the backend routines for this one. I'll change pidl to
generate code to "return False" in srv_lsa.c if this flag is set.

Volker
(This used to be commit 5260657664caf9546d324a81c392f0d9e8532d58)

16 years agor19212: Make sure domains marked internal don't do
Jeremy Allison [Tue, 10 Oct 2006 04:00:42 +0000 (04:00 +0000)]
r19212: Make sure domains marked internal don't do
network queries.
Jeremy.
(This used to be commit e4d5e1d90b40fee1edc5cf0134b276645eea63bf)

16 years agor19209: Ensure we don't make mistakes by sending online/offline
Jeremy Allison [Tue, 10 Oct 2006 00:50:41 +0000 (00:50 +0000)]
r19209: Ensure we don't make mistakes by sending online/offline
messages to internal domains, or to domains not being
serviced by a winbindd child. Ensure the child online
offline requests are domain specific.
Jeremy.
(This used to be commit 81a9dc4b9fbd4a9bb67f55aa744bf609d6aba1c2)

16 years agor19207: Properly canonicalize incoming names to the
Jeremy Allison [Mon, 9 Oct 2006 19:20:21 +0000 (19:20 +0000)]
r19207: Properly canonicalize incoming names to the
NSS protocols auth, chauthtok, logoff, ccache_ntlm_auth.
That way we ensure winbindd only deals with fully
qualified names internally. The NSS protocols
auth_crap and chng_pswd_auth_crap should be fixed
to do the same thing.
Jeremy.
(This used to be commit dbd2454d3337f64cddbdaf39e9efd6505e6b2590)

16 years agor19206: Jeremy, for some reason storing a value-less entry in TDB does not work
Günther Deschner [Mon, 9 Oct 2006 15:11:37 +0000 (15:11 +0000)]
r19206: Jeremy, for some reason storing a value-less entry in TDB does not work
anymore in 3_0. I'm just adding a time(NULL) as value for the
WINBINDD_OFFLINE key.

Guenther
(This used to be commit 2bdf9f140f76d6eb73b34148c47f7d3447e2e563)

16 years agor19203: Part two of returning our real name. This code is a bit ancient... :-)
Volker Lendecke [Mon, 9 Oct 2006 13:26:29 +0000 (13:26 +0000)]
r19203: Part two of returning our real name. This code is a bit ancient... :-)
(This used to be commit 370c24ba2ad3bce29929886f96d626e698da0238)

16 years agor19193: merge from samba4:
Stefan Metzmacher [Mon, 9 Oct 2006 08:32:51 +0000 (08:32 +0000)]
r19193: merge from samba4:

fixed another checker warning and a possible error on allocation
failure

metze
(This used to be commit d64583a763ffcff27f0bd6761196f7d554d44849)

16 years agor19192: merge from samba4:
Stefan Metzmacher [Mon, 9 Oct 2006 08:26:58 +0000 (08:26 +0000)]
r19192: merge from samba4:

ensure that data values from ldap libs are null terminated, to allow
ldb_msg_find_attr_as_string() to work correctly.

Thanks to Jim Myers for spotting this!

metze
(This used to be commit a5ea82bb05fb9d5c1842f9a105f6a10e39141c89)

16 years agor19191: merge from samba4:
Stefan Metzmacher [Mon, 9 Oct 2006 08:25:27 +0000 (08:25 +0000)]
r19191: merge from samba4:

fix checker warnings

metze
(This used to be commit 93a0fe093b4614a18e99d0c3a71c5c8af2e57e4f)

16 years agor19190: merge from samba4:
Stefan Metzmacher [Mon, 9 Oct 2006 08:22:59 +0000 (08:22 +0000)]
r19190: merge from samba4:

remove wrong check and statement.
to manipulate rootDSE we use ldb_dn_new() as base and that has 0 elements.

metze
(This used to be commit b81cae4180452d2a14c445392fd828032e6eddec)

16 years agor19189: No display name is normal for some GPOs.
Günther Deschner [Mon, 9 Oct 2006 08:11:35 +0000 (08:11 +0000)]
r19189: No display name is normal for some GPOs.

Guenther
(This used to be commit 1ec1c5dd17c498d5a8a9804ad2ef114fb7603c31)

16 years agor19185: merge comment from samba4
Stefan Metzmacher [Mon, 9 Oct 2006 07:24:00 +0000 (07:24 +0000)]
r19185: merge comment from samba4

metze
(This used to be commit 256b83820168d14df2b15a75d8681be5f418ddf8)

16 years agor19184: W2k3 returns its name for the GetServerInfo RAP call. Do the same.
Volker Lendecke [Mon, 9 Oct 2006 07:17:37 +0000 (07:17 +0000)]
r19184: W2k3 returns its name for the GetServerInfo RAP call. Do the same.

Implement 'net rap server name'.

Volker
(This used to be commit 919385ed2a2a07e848bc0baaac9ed3d1964d4386)

16 years agor19183: merge from samba4:
Stefan Metzmacher [Mon, 9 Oct 2006 07:15:27 +0000 (07:15 +0000)]
r19183: merge from samba4:

don't crash on invalid utf8 chars

metze
(This used to be commit 71e1f8550f96eaaae7e4fc4d02eb36f1d894abc8)

16 years agor19182: merge from samba4:
Stefan Metzmacher [Mon, 9 Oct 2006 07:05:08 +0000 (07:05 +0000)]
r19182: merge from samba4:

add ldb_set_create_perms() function to set the create_perms after
ldb_init() and before ldb_connect()

metze
(This used to be commit dd9d469eef337954b6aee4c86ac0691f52812456)

16 years agor19181: merge from samba4:
Stefan Metzmacher [Mon, 9 Oct 2006 06:48:55 +0000 (06:48 +0000)]
r19181: merge from samba4:

with "export MAKE_TEST_KEEP_PCAP=yes" make test
doesn't delete the generated pcap files

metze
(This used to be commit 74212c30563826e2248c1cb16e4c953a28a25488)

16 years agor19179: remove difference with samba4
Stefan Metzmacher [Sun, 8 Oct 2006 21:54:19 +0000 (21:54 +0000)]
r19179: remove difference with samba4

metze
(This used to be commit e97e1ffea8e124c8001cf33ecac7500ae875f42f)

16 years agor19177: merge from samba4:
Stefan Metzmacher [Sun, 8 Oct 2006 21:50:22 +0000 (21:50 +0000)]
r19177: merge from samba4:

fix the standalone build of socket_wrapper by not using
samba's DLIST_ macros

metze
(This used to be commit bc7b2e8db8fb34d6f321cd6b13b74e58945d7124)

16 years agor19172: merge from samba4:
Stefan Metzmacher [Sun, 8 Oct 2006 20:49:05 +0000 (20:49 +0000)]
r19172: merge from samba4:

change the socket wrapper license to
what heimdal uses...

metze
(This used to be commit d19c19ae4be3f3ad349b72ba3181051bb4da335e)

16 years agor19170: use a very clever trick to pass the binary name to the
Stefan Metzmacher [Sun, 8 Oct 2006 20:38:25 +0000 (20:38 +0000)]
r19170: use a very clever trick to pass the binary name to the
gdb_backtrace script, I never noticed that %$(envvar)
exists...

Thanks to Bjoern Jacke for the suggestion!

metze
(This used to be commit 12a37bab3eafdabeb4f0dc23254bdec41860cd87)

16 years agor19169: port the trick to only display the smbd and nmbd log output
Stefan Metzmacher [Sun, 8 Oct 2006 20:30:09 +0000 (20:30 +0000)]
r19169: port the trick to only display the smbd and nmbd log output
of the current test

metze
(This used to be commit f668d4839de0ec98fcacf2efb6a69970757bebdd)

16 years agor19168: use the correct configuration
Stefan Metzmacher [Sun, 8 Oct 2006 20:17:55 +0000 (20:17 +0000)]
r19168: use the correct configuration

metze
(This used to be commit bf90ac567fc809bb8949b066e822a88170b73ac5)

16 years agor19164: merge the gdb_backtrace script from samba4
Stefan Metzmacher [Sat, 7 Oct 2006 10:33:33 +0000 (10:33 +0000)]
r19164: merge the gdb_backtrace script from samba4

this more portable and try to make use of ladebug on Tru64,
but that only works when the binary is passed as 2nd arg to gdb_backtrace
as Tru64 doesn't know /proc/${PID}/exe

we need to find a way to pass the progname in 'panic action'
in samba3

metze
(This used to be commit 2f55fd82ff5db82974f91648cc386daa423e38be)

16 years agor19163: pass always a mem_ctx to functions and a ldb_context where needed
Stefan Metzmacher [Sat, 7 Oct 2006 10:24:16 +0000 (10:24 +0000)]
r19163: pass always a mem_ctx to functions and a ldb_context where needed

It would be nice if someone can merge that to samba4,
otherwise I'll merge that to samba4 on monday

metze
(This used to be commit 6bc42f31ce294f2bd50ffbd536e1ee42607ef799)

16 years agor19161: Add NET_GETANYDCNAME (getdcname only gives the PDC while getanydcname
Günther Deschner [Sat, 7 Oct 2006 05:26:21 +0000 (05:26 +0000)]
r19161: Add NET_GETANYDCNAME (getdcname only gives the PDC while getanydcname
gives just any DC), also make sure to set timeouts in rpcclient
accordingly so that we actually get the DC's reply.

Guenther
(This used to be commit 6091c8152a3998d2503cb0911a217ee904509633)

16 years agor19160: Add new WERR codes seen by working with NETLOGON getdcname.
Günther Deschner [Sat, 7 Oct 2006 05:23:56 +0000 (05:23 +0000)]
r19160: Add new WERR codes seen by working with NETLOGON getdcname.

Guenther
(This used to be commit 78b0124a6e7051da2df3157f02593f06f7f31a1b)

16 years agor19159: The getdc call can take a long time. Allow for timeouts.
Jeremy Allison [Fri, 6 Oct 2006 21:35:26 +0000 (21:35 +0000)]
r19159: The getdc call can take a long time. Allow for timeouts.
Jeremy.
(This used to be commit 99bebb65273c78d9867254c47438577bb21af4ee)

16 years agor19158: Remove root and nobody users from ldif, from Björn Jacke
Jim McDonough [Fri, 6 Oct 2006 20:09:10 +0000 (20:09 +0000)]
r19158: Remove root and nobody users from ldif, from Björn Jacke
(This used to be commit 17880d6cadbb0b1b428430c26bb4b4545eb834ff)

16 years agor19157: Fix the build
Volker Lendecke [Fri, 6 Oct 2006 19:49:16 +0000 (19:49 +0000)]
r19157: Fix the build
(This used to be commit 3fc328dadeb5b4b35c6d58ba26c3ac9d1fcf4015)

16 years agor19156: Make enumprinters use the share iterators.
Volker Lendecke [Fri, 6 Oct 2006 19:32:52 +0000 (19:32 +0000)]
r19156: Make enumprinters use the share iterators.

Volker
(This used to be commit 9b1759617ce7841a78d9f792254a9e4fa814858f)

16 years agor19155: Fix debug message.
Jeremy Allison [Fri, 6 Oct 2006 19:10:32 +0000 (19:10 +0000)]
r19155: Fix debug message.
Jeremy.
(This used to be commit 42e5481ce4bebc65040d466b49e3c45cd4e79f5d)

16 years agor19154: Trivial logic simplification: Get rid of two indentation levels. Survives the
Volker Lendecke [Fri, 6 Oct 2006 19:07:23 +0000 (19:07 +0000)]
r19154: Trivial logic simplification: Get rid of two indentation levels. Survives the
consistency checks just checked into Samba4.

Volker
(This used to be commit c48bb4b37b32fac9d01d243290532641d3701ec7)

16 years agor19151: Create some dummy printers in the build farm
Volker Lendecke [Fri, 6 Oct 2006 18:49:29 +0000 (18:49 +0000)]
r19151: Create some dummy printers in the build farm
(This used to be commit c26a20e6d5ac36be137fa63f477155a9613f050f)

16 years agor19148: Finish last nights patch - make offline
Jeremy Allison [Fri, 6 Oct 2006 17:33:57 +0000 (17:33 +0000)]
r19148: Finish last nights patch - make offline
work again. Still under test.
Jeremy.
(This used to be commit 40a455db78f805daa6bfeb9e78fb78dcc12fd9a7)

16 years agor19147: This is WRONG, but the way the VFS works this is the only fix to get rid of
Volker Lendecke [Fri, 6 Oct 2006 17:28:52 +0000 (17:28 +0000)]
r19147: This is WRONG, but the way the VFS works this is the only fix to get rid of
this type-punned warning.

Volker
(This used to be commit d815b1a7e9609a760f93433bf022826f58f256db)

16 years agor19145: talloc_reference() can fail!
Stefan Metzmacher [Fri, 6 Oct 2006 16:14:41 +0000 (16:14 +0000)]
r19145: talloc_reference() can fail!

metze
(This used to be commit e4f2183684da90a67bc6a635d008b72a6dd3d0dd)

16 years agor19143: getdcname on the NETLOGON pipe returns WERROR, not NTSTATUS.
Günther Deschner [Fri, 6 Oct 2006 16:13:10 +0000 (16:13 +0000)]
r19143: getdcname on the NETLOGON pipe returns WERROR, not NTSTATUS.

Guenther
(This used to be commit 44e228ac796fca2db8509915067511ed705032bf)

16 years agor19137: that looks nicer:-)
Stefan Metzmacher [Fri, 6 Oct 2006 15:17:02 +0000 (15:17 +0000)]
r19137: that looks nicer:-)

metze
(This used to be commit db40552d9471f4a8ce2c5c724319a4eb242ed24a)

16 years agor19135: fix bugs...
Stefan Metzmacher [Fri, 6 Oct 2006 15:06:54 +0000 (15:06 +0000)]
r19135: fix bugs...

- passing mem_ctx as ldb_context is a bad idea!
- naming a static function talloc_ is also bad and misleading

metze
(This used to be commit 0523ad249335c6094854bc9cefb46e2095f4c0ba)

16 years agor19133: More C++ warnings -- Merge across?
Volker Lendecke [Fri, 6 Oct 2006 14:50:07 +0000 (14:50 +0000)]
r19133: More C++ warnings -- Merge across?
(This used to be commit c879ed3d1edffeda629dc1e05031dca91c1a1e30)

16 years agor19132: Fix some C++ warnings. Is there interest to have them in Samba4 as well?
Volker Lendecke [Fri, 6 Oct 2006 14:39:47 +0000 (14:39 +0000)]
r19132: Fix some C++ warnings. Is there interest to have them in Samba4 as well?

I have some problems resolving the last 3 ones in attrib_handlers.c. In line
251 the function ldb_dn_explode_casefold is called with mem_ctx as the first
argument. Looking at ldb_dn_explode_casefold I see that the first argument it
expects is a struct ldb_context. I could certainly add a cast to (struct
ldb_context *) to that call, but I would assume that this is the wrong fix. Is
it possible that attrib_handlers.c:251 and :254 should have ldb and not
mem_ctx as the first argument?

Can anybody from Samba4 clarify this for me and apply the correct fix?

Thanks a lot.

Volker
(This used to be commit 26f2cb71ebf00b2c6f356da5f32384f7fa083521)

16 years agor19130: fix the logic for the AC_PROG_CC_C99 check
Stefan Metzmacher [Fri, 6 Oct 2006 14:02:44 +0000 (14:02 +0000)]
r19130: fix the logic for the AC_PROG_CC_C99 check

metze
(This used to be commit 21516dc5ac95e7e5d6a7d7f890d42742b36f2454)

16 years agor19127: Fix bug 4152
Volker Lendecke [Fri, 6 Oct 2006 12:19:46 +0000 (12:19 +0000)]
r19127: Fix bug 4152
(This used to be commit 70038e8f7b3042c2732e7f8267cab0499972a819)

16 years agor19126: Fix some uninitialized variable warnings
Volker Lendecke [Fri, 6 Oct 2006 12:18:59 +0000 (12:18 +0000)]
r19126: Fix some uninitialized variable warnings
(This used to be commit 90bfa3461038f5d179525dec0cf5b3f137e927e0)

16 years agor19125: merge from samba4
Andrew Tridgell [Fri, 6 Oct 2006 12:00:23 +0000 (12:00 +0000)]
r19125: merge from samba4
(This used to be commit 65e1500ae6b5ca6334a63f4a18272568202bc048)