12 years agor12336: A couple of fixes and enhancements for (espc. to debug
Günther Deschner [Mon, 19 Dec 2005 02:15:13 +0000 (02:15 +0000)]
r12336: A couple of fixes and enhancements for (espc. to debug

sid2string fix from Michael James <>.

(This used to be commit 9424b65c70bd24ba8f5b6c729dc1440a4dbf5647)

12 years agor12313: Introduce yet another copy of the string_sub function:
Volker Lendecke [Sun, 18 Dec 2005 18:06:15 +0000 (18:06 +0000)]
r12313: Introduce yet another copy of the string_sub function:
talloc_string_sub. Someone with time on his hands could convert all the
callers of all_string_sub to this.

realloc_string_sub is *only* called from within substitute.c, it could be
moved there I think.

(This used to be commit be6c9012da174d5d5116e5172a53bbe6486d6c38)

12 years agor12312: Reformatting and a trivial change: is_share_read_only_for_user only uses
Volker Lendecke [Sun, 18 Dec 2005 14:23:23 +0000 (14:23 +0000)]
r12312: Reformatting and a trivial change: is_share_read_only_for_user only uses
conn->service, so there's no point in passing down the whole conn struct.

(This used to be commit 39041297c771795efaa4292bc6e8020c1a047f32)

12 years agor12311: Reformatting
Volker Lendecke [Sun, 18 Dec 2005 13:54:53 +0000 (13:54 +0000)]
r12311: Reformatting
(This used to be commit 23f5be1dcbb9e5a1e7f24813c67009056b07d59c)

12 years agor12308: Reformatting
Volker Lendecke [Sat, 17 Dec 2005 17:19:21 +0000 (17:19 +0000)]
r12308: Reformatting
(This used to be commit 97acfa12e52e889c97d0f7ce72c1a7f863cb0665)

12 years agor12307: Reformatting plus a trivial if/else simplification. There's no point in doing
Volker Lendecke [Sat, 17 Dec 2005 17:13:45 +0000 (17:13 +0000)]
r12307: Reformatting plus a trivial if/else simplification. There's no point in doing
an else branch that only returns NULL.

(This used to be commit ef4d9d96de3f1a242d26ae2f8033103bbdb7a2dc)

12 years agor12306: Reformatting
Volker Lendecke [Sat, 17 Dec 2005 16:56:24 +0000 (16:56 +0000)]
r12306: Reformatting
(This used to be commit 3f1dad5fdbd104dc0c03a6a9488bd619b8915c83)

12 years agor12305: Reformatting
Volker Lendecke [Sat, 17 Dec 2005 16:31:04 +0000 (16:31 +0000)]
r12305: Reformatting
(This used to be commit f574e980aac5bae5e1e3cc23ec648b69a87eb04a)

12 years agor12303: Move split_domain_and_name to util_getent.c and make it static there.
Volker Lendecke [Sat, 17 Dec 2005 15:38:41 +0000 (15:38 +0000)]
r12303: Move split_domain_and_name to util_getent.c and make it static there.

(This used to be commit e7f348fcf871e8559ecf4e3e597627a78187d1da)

12 years agor12291: Make getgroups_user static.
Volker Lendecke [Fri, 16 Dec 2005 16:16:52 +0000 (16:16 +0000)]
r12291: Make getgroups_user static.

Jeremy, there's a #ifdef'ed 0 call to this in your usershare code. We need to
talk about what exactly what you intend to do here and in what scenarios.

(This used to be commit 95094ef758089cfc62700509d45b53bc0980654d)

12 years agor12290: Typo
Volker Lendecke [Fri, 16 Dec 2005 15:58:31 +0000 (15:58 +0000)]
r12290: Typo
(This used to be commit de839cc1658b6394e153a1f027c29524b301625b)

12 years agor12281: adding a note about WINS and NetLogon not being remotely manageable
Gerald Carter [Fri, 16 Dec 2005 01:41:25 +0000 (01:41 +0000)]
r12281: adding a note about WINS and NetLogon not being remotely manageable
(This used to be commit b86528865abae7380e80a8a18f9fb53ac77d6472)

12 years agor12279: unix_mask_match has been broken for *ever*... (How).
Jeremy Allison [Fri, 16 Dec 2005 01:41:12 +0000 (01:41 +0000)]
r12279: unix_mask_match has been broken for *ever*... (How).
Ensure it returns a BOOL.
Jerry (and anyone else) please check this, I think
all uses are now correct but could do with another
set of eyes. Essential for 3.0.21 release.
(This used to be commit 0c7b8a7637e760fcb6629092f36b610b8c71f5c9)

12 years agor12275: Fix memory leak found by Mikhail Kshevetskiy <>
Jeremy Allison [Fri, 16 Dec 2005 00:10:59 +0000 (00:10 +0000)]
r12275: Fix memory leak found by Mikhail Kshevetskiy <>
and followed up by
(This used to be commit 5cab88f1444177129bb5521ccc4afd8869e9bf25)

12 years agor12273: Fix copy paste error.
Günther Deschner [Fri, 16 Dec 2005 00:01:15 +0000 (00:01 +0000)]
r12273: Fix copy paste error.

(This used to be commit 266f5fc9af6a07bc1f1432e716e6c528e9048533)

12 years agor12262: * patch from Brian Moran to fix segv in eventlogadm when not eventlogs
Gerald Carter [Thu, 15 Dec 2005 18:39:28 +0000 (18:39 +0000)]
r12262: * patch from Brian Moran to fix segv in eventlogadm when not eventlogs
  are listed in smb.conf
* initialize the local group description in set_alias_info()
(This used to be commit 58f8b42069a69c0b61da2609e5706a6c0d512e09)

12 years agor12250: Patch from Martin Koeppe <> for #3287
Jeremy Allison [Wed, 14 Dec 2005 23:52:58 +0000 (23:52 +0000)]
r12250: Patch from Martin Koeppe <> for #3287
to make the dev/inode numbers match what SFU expects.
If we're using 8 byte inodes we'll lose the top 4 bytes
and replace them with a dev_t instead, but this seem
reasonable to ensure uniqueness.
(This used to be commit e53574d0b43e5525029c89e56331701399013d91)

12 years agor12245: eDirectory returns LDAP_UNWILLING_TO_PERFORM if the
Jeremy Allison [Wed, 14 Dec 2005 20:39:42 +0000 (20:39 +0000)]
r12245: eDirectory returns LDAP_UNWILLING_TO_PERFORM if the
account is disabled. If we get this we can't check
the password so have to tell the client the account
was disabled.
(This used to be commit 43c2d545ab98fef341c7e22d3b82c98bd0afebc2)

12 years agor12236: r11740@cabra: derrell | 2005-12-14 13:16:58 -0500
Derrell Lipman [Wed, 14 Dec 2005 18:17:05 +0000 (18:17 +0000)]
r12236:  r11740@cabra:  derrell | 2005-12-14 13:16:58 -0500
 check in the DEBUG message referenced in the previous commit
(This used to be commit 6c04a8f9adfcd40fb0f1e1fcd4e22056ee463046)

12 years agor12235: r11738@cabra: derrell | 2005-12-14 13:15:14 -0500
Derrell Lipman [Wed, 14 Dec 2005 18:15:54 +0000 (18:15 +0000)]
r12235:  r11738@cabra:  derrell | 2005-12-14 13:15:14 -0500
 Ensure that when libsmbclient copies a cli, it prevents the cli from later
 being freed, by turning off the 'allocated' flag.

 Change a DEBUG message in pipe_open code from level 0 to level 1 since
 libsmbclient is now regularly attempting to open a pipe for share enumeration,
 and falling back to RAP if RPC is unavailable (e.g. win98).  We don't want
 the debug message to display when the pipe open fails, under these normal
(This used to be commit 965025c057d9e00fb68ea0819e675fcf9ad2f819)

12 years agor12234: Reduce the race condition for renames by holding the lock
Jeremy Allison [Wed, 14 Dec 2005 17:46:29 +0000 (17:46 +0000)]
r12234: Reduce the race condition for renames by holding the lock
longer. Instigated by complaints on the fix for #3303 from
SATOH Fumiyasu <>.
(This used to be commit 855f5f8c32aa530dbad244805a40200824724618)

12 years agor12225: r11729@cabra: derrell | 2005-12-13 22:59:45 -0500
Derrell Lipman [Wed, 14 Dec 2005 04:00:58 +0000 (04:00 +0000)]
r12225:  r11729@cabra:  derrell | 2005-12-13 22:59:45 -0500
 1. Fix a crash bug which should have reared its ugly head ages ago, but for
    some reason, remained dormant until recently.  The bug pertained to
    libsmbclient doing a structure assignment of a cli after having opened a
    pipe.  The pipe open code makes a copy of the cli pointer that was passed
    to it.  If the cli is later copied (and that cli pointer that was saved
    is no longer valid), the pipe code will cause a crash during shutdown or
    when the copied cli is closed.

 2. The 'type' field in enumerated shares was not being set correctly with
    the new RPC-based mechanism for enumerating shares.
(This used to be commit 62a02b8f2a1fcb66881a9c9636e0b27e3049c5a1)

12 years agor12224: adding more characters to the invalid share name string
Gerald Carter [Wed, 14 Dec 2005 01:09:46 +0000 (01:09 +0000)]
r12224: adding more characters to the invalid share name string
(This used to be commit e461143639889da78cd4de47df40ac59a5a758a4)

12 years agor12221: Fix error code paths that can potentially leave a dangling lock.
Jeremy Allison [Wed, 14 Dec 2005 00:42:40 +0000 (00:42 +0000)]
r12221: Fix error code paths that can potentially leave a dangling lock.
(This used to be commit 123135ed1ddd84cc0a5e8e5ca06a0703d1944e37)

12 years agor12214: Fix compile if SYNC_DNS is set.
Jeremy Allison [Tue, 13 Dec 2005 19:37:05 +0000 (19:37 +0000)]
r12214: Fix compile if SYNC_DNS is set.
(This used to be commit 7c545e1e77c3e235b21eb11d5ced91c603da491d)

12 years agor12213: Final fix for #3303 - send rename messages to smbd's
Jeremy Allison [Tue, 13 Dec 2005 18:11:50 +0000 (18:11 +0000)]
r12213: Final fix for #3303 - send rename messages to smbd's
that have open file handles to allow them to correctly
implement delete on close. There is a further correctness
fix I'm intending to add to this to cope with different share
paths, but not right now...
(This used to be commit 932e337db8788e75344e1c7cf1ef009d090cb039)

12 years agor12203: Add the share path into the sharemode db. This involves
Jeremy Allison [Mon, 12 Dec 2005 22:07:36 +0000 (22:07 +0000)]
r12203: Add the share path into the sharemode db. This involves
revving the minor version number for libsmbsharemodes (we
now have a new _ex interface that takes the share path
as well as the filename). Needed for #3303. Some code written
by SATOH Fumiyasu <> included in the changes
to locking/locking.c. The smbstatus output is a bit of a mess
and needs overhauling...
(This used to be commit 9d93af713f8520ca506730dd32aa2b994937eaba)

12 years agor12196: patch from Krishna Ganugapati <>
Gerald Carter [Mon, 12 Dec 2005 18:55:54 +0000 (18:55 +0000)]
r12196: patch from Krishna Ganugapati <>

Use the subtree delete ldap control when running 'net ads leave'
to ensure that the machine account is actually deleted.
(This used to be commit e96000c16cd182b2e2cbdc1a287002306d2965e6)

12 years agor12194: Ensure that when we set a connection path we've canonicalized
Jeremy Allison [Mon, 12 Dec 2005 18:21:59 +0000 (18:21 +0000)]
r12194: Ensure that when we set a connection path we've canonicalized
the name (must be abolute - start with /, must not end in /,
must have ./ and ../ removed). Of course for realpath resolved
paths this won't be the case but for others we need this name
to be canonicalized. This name is going into the sharemode db
for #3303 so needs to be in a normalized format.
(This used to be commit 22e3300911809692b595f49e87d91e3111923e6a)

12 years agor12193: Fix some typos.
Günther Deschner [Mon, 12 Dec 2005 14:08:42 +0000 (14:08 +0000)]
r12193: Fix some typos.

(This used to be commit 499224f02a8722eea0d4644ca81ca55da0e9a86b)

12 years agor12185: Cosmetic cleanup
Volker Lendecke [Sun, 11 Dec 2005 21:59:58 +0000 (21:59 +0000)]
r12185: Cosmetic cleanup
(This used to be commit d1e8f9afffecf986a428bfac29b22dcbce610016)

12 years agor12182: Cosmetic cleanup
Volker Lendecke [Sun, 11 Dec 2005 16:55:28 +0000 (16:55 +0000)]
r12182: Cosmetic cleanup
(This used to be commit 81c358b511457fbc6304845acb4bfbf1b4adf062)

12 years agor12177: last of outstanding patches in my queue to deal with MMC.
Gerald Carter [Sun, 11 Dec 2005 05:06:35 +0000 (05:06 +0000)]
r12177: last of outstanding patches in my queue to deal with MMC.
Validate the share name and fail when trying to creating
a share with bad characters.
(This used to be commit 174fe494f9cbec3386ed687007e137fa7064373d)

12 years agor12176: fix type mismatch after rpc structure change in rpc_svcctl.h
Gerald Carter [Sun, 11 Dec 2005 04:41:54 +0000 (04:41 +0000)]
r12176: fix type mismatch after rpc structure change in rpc_svcctl.h
(This used to be commit ba67d3ae0430abc196d245218556c23002e52076)

12 years agor12174: Simple patch to work around the current lack of BUILTIN
Gerald Carter [Sun, 11 Dec 2005 04:39:33 +0000 (04:39 +0000)]
r12174: Simple patch to work around the current lack of BUILTIN
nested group support.  Always add the BUILTIN\Administrators
SID to a Domain Admins token.

This solves the extra steps of establishing a group map for
the local Administrators SID in order to control services.
Windows also tends to expect the Administrators group to be
usable when setting up security permissions on shares.

Volker's work will probably fix this long term, but this
gets us past some of the setup hurdles for 3.0.21.
(This used to be commit 170b6a68bcbd66bae322c5b1b8c8501ca96acab2)

12 years agor12173: doing some service control work
Gerald Carter [Sun, 11 Dec 2005 04:21:34 +0000 (04:21 +0000)]
r12173: doing some service control work

* Add a few new error codes for disabled services
* dump some more details about service status in 'net rpc service'
* disable the WINS and NetLogon services if not configured in smb.conf

Still trying to figure out how to disable the start button
on the NetLogon and WINS services.
(This used to be commit c0f54eeebc84ec9fab63c5b105511762bcc136be)

12 years agor12170: Fix a segfault -- this is post-3.0.21 code
Volker Lendecke [Sat, 10 Dec 2005 23:56:42 +0000 (23:56 +0000)]
r12170: Fix a segfault -- this is post-3.0.21 code
(This used to be commit 8b30cf8e09944cd97e4ab959f730bf81591c2541)

12 years agor12169: Remove an unused function
Volker Lendecke [Sat, 10 Dec 2005 23:29:39 +0000 (23:29 +0000)]
r12169: Remove an unused function
(This used to be commit 209e4f8793fe9375fc6af1aedb5bd1fe57193bbc)

12 years agor12163: Change lookup_sid and lookup_name to return const char * instead of char *,
Volker Lendecke [Sat, 10 Dec 2005 11:22:01 +0000 (11:22 +0000)]
r12163: Change lookup_sid and lookup_name to return const char * instead of char *,
use a temporary talloc_ctx for clarity.

(This used to be commit b15815c804bf3e558ed6357b5e9a6e3e0fac777f)

12 years agor12160: The filename parameter to get_share_mode_lock is going
Jeremy Allison [Sat, 10 Dec 2005 01:33:58 +0000 (01:33 +0000)]
r12160: The filename parameter to get_share_mode_lock is going
to become very important as we fix #3303, so make sure
we don't accidently set it here.
(This used to be commit d1a9d0587cd9a391f0193ca76cb319803c6e019f)

12 years agor12133: Fix an uninitialized variable in new code in rpc_server/srv_samr_nt.c.
Volker Lendecke [Thu, 8 Dec 2005 19:34:22 +0000 (19:34 +0000)]
r12133: Fix an uninitialized variable in new code in rpc_server/srv_samr_nt.c.

Fix winbind_lookup_name for the local domain, ie for aliases on a member

(This used to be commit 4ba50c823e8d61f87ab5627f15e826e73e45ffcc)

12 years agor12131: Fix it really, this time :)
Günther Deschner [Thu, 8 Dec 2005 16:34:57 +0000 (16:34 +0000)]
r12131: Fix it really, this time :)

(This used to be commit 4a506dbc3c63b965044aa16374f46531375cc920)

12 years agor12130: display domain GUID.
Günther Deschner [Thu, 8 Dec 2005 16:25:33 +0000 (16:25 +0000)]
r12130: display domain GUID.

(This used to be commit 8e63da03665651ab0315d76d27a4ea4375b2acd0)

12 years agor12129: Fix uninitialized variables.
Volker Lendecke [Thu, 8 Dec 2005 15:34:38 +0000 (15:34 +0000)]
r12129: Fix uninitialized variables.

(This used to be commit 8a7d6eb2c081c0d74b62aa76dc243946df62ced2)

12 years agor12119: r10812@cabra: derrell | 2005-12-07 22:44:26 -0500
Derrell Lipman [Thu, 8 Dec 2005 03:44:40 +0000 (03:44 +0000)]
r12119:  r10812@cabra:  derrell | 2005-12-07 22:44:26 -0500
 sync to repository didn't work correctly...???
(This used to be commit 86ab4cf42b3bfe78239ee0b367bff9cfc5484107)

12 years agor12118: r10805@cabra: derrell | 2005-12-07 22:34:55 -0500
Derrell Lipman [Thu, 8 Dec 2005 03:41:19 +0000 (03:41 +0000)]
r12118:  r10805@cabra:  derrell | 2005-12-07 22:34:55 -0500
 first go at supporting long file names.  seeems to work; requires more testing
(This used to be commit 99fbe44ac569f218bd1b4d1026c18cc72f0a1f0e)

12 years agor12111: Fix the "everything" build by re-adding debug2html. Oops.
Jeremy Allison [Tue, 6 Dec 2005 23:31:33 +0000 (23:31 +0000)]
r12111: Fix the "everything" build by re-adding debug2html. Oops.
(This used to be commit d270b809edfdeb680d7e243e53f6de9e2493f56e)

12 years agor12110: We're using a tdb-based wins backend now. Thanks to the
Jeremy Allison [Tue, 6 Dec 2005 23:09:01 +0000 (23:09 +0000)]
r12110: We're using a tdb-based wins backend now. Thanks to the
ubiqx code, which has served us well for many a year..
"Well done, thou good and faithful servant".
(This used to be commit 32380002e44766669b28621e62a0b74652b1798f)

12 years agor12107: Move to a tdb-based wins database. At the moment we still
Jeremy Allison [Tue, 6 Dec 2005 23:06:38 +0000 (23:06 +0000)]
r12107: Move to a tdb-based wins database. At the moment we still
use it as though it were an in-memory db and dump out to
a flat file every 2 mins, but that can now change.
(This used to be commit a342681792724c1ae8561ba8d352c4ee6e2a5332)

12 years agor12106: Fix return value
Günther Deschner [Tue, 6 Dec 2005 20:22:51 +0000 (20:22 +0000)]
r12106: Fix return value

(This used to be commit 1fa8039397175331d9f5e8b5e3897e9bba14484a)

12 years agor12098: r10797@cabra: derrell | 2005-12-06 12:09:00 -0500
Derrell Lipman [Tue, 6 Dec 2005 17:09:44 +0000 (17:09 +0000)]
r12098:  r10797@cabra:  derrell | 2005-12-06 12:09:00 -0500
 fixed another memory leak and reverted an (incorrect) fix from yesterday
(This used to be commit 8a86d7bddc291da094d060fbe185f071ffdbddd8)

12 years agor12096: Change uint32_t to uint32. Jerry, please pick this change up for
Jeremy Allison [Tue, 6 Dec 2005 16:25:27 +0000 (16:25 +0000)]
r12096: Change uint32_t to uint32. Jerry, please pick this change up for
3.0.21 final.
(This used to be commit 2b17e08d290dd7c629145d87c72f7fbd7f47b67d)

12 years agor12081: r10674@cabra: derrell | 2005-12-05 13:31:28 -0500
Derrell Lipman [Mon, 5 Dec 2005 23:30:45 +0000 (23:30 +0000)]
r12081:  r10674@cabra:  derrell | 2005-12-05 13:31:28 -0500
 get rid of temporary #if 0 blocks
(This used to be commit 376445c90b05c36206c87c974c13e5f9297f35eb)

12 years agor12080: r10673@cabra: derrell | 2005-12-05 13:22:34 -0500
Derrell Lipman [Mon, 5 Dec 2005 23:30:40 +0000 (23:30 +0000)]
r12080:  r10673@cabra:  derrell | 2005-12-05 13:22:34 -0500
 Correct some memory and file descriptor leaks.

 This should fix bugs 3257, 3267 and 3273.
(This used to be commit c5781c9cf5f1f8297e084fbe2c4a22257420a447)

12 years agor12077: Add configure switch to disable libmsrpc build. Add new Makefile target
Lars Müller [Mon, 5 Dec 2005 21:02:23 +0000 (21:02 +0000)]
r12077: Add configure switch to disable libmsrpc build.  Add new Makefile target
installlibmsrpc.  This works the same way as we're already doing it for
libsmbclient.  Default is to build it.

Add a soname to libmsrpc as we do it for libsmbclient.  We already had
the MAJOR and MINOR variable in the Makefile.
(This used to be commit 6794d440996946da0f77a83904a713dd298ba8c0)

12 years agor12076: Ensure setmntent() returns with != NULL in the disk_quotas() Linux
Lars Müller [Mon, 5 Dec 2005 16:51:19 +0000 (16:51 +0000)]
r12076: Ensure setmntent() returns with != NULL in the disk_quotas() Linux

The IRIX 6.2 version is still without this check as I'm not sure if
setmntent() is implemented in the same way.
(This used to be commit 519ed7ca0ecffbc341c7516758a678af59f98586)

12 years agor12055: More cruft
Volker Lendecke [Sat, 3 Dec 2005 20:28:18 +0000 (20:28 +0000)]
r12055: More cruft
(This used to be commit 4d91f9501cd041ee42410eeace6a9acd9cc57d1c)

12 years agor12054: We only have one more warning at -O6. That will take
Jeremy Allison [Sat, 3 Dec 2005 20:18:43 +0000 (20:18 +0000)]
r12054: We only have one more warning at -O6. That will take
some more restructuring to fix.... Coming soon.
(This used to be commit 739c1c4d438ccf31bb0167e1fc509d072c149d45)

12 years agor12052: Remove unused typedefs
Volker Lendecke [Sat, 3 Dec 2005 20:18:20 +0000 (20:18 +0000)]
r12052: Remove unused typedefs
(This used to be commit 612ec4de75ad06f2b12176439f96f8e5662a7d77)

12 years agor12051: Merge across the lookup_name and lookup_sid work. Lets see how the build...
Volker Lendecke [Sat, 3 Dec 2005 18:34:13 +0000 (18:34 +0000)]
r12051: Merge across the lookup_name and lookup_sid work. Lets see how the build farm
reacts :-)

(This used to be commit 9f99d04a54588cd9d1a1ab163ebb304437f932f7)

12 years agor12046: Fix typo
Volker Lendecke [Sat, 3 Dec 2005 10:15:03 +0000 (10:15 +0000)]
r12046: Fix typo
(This used to be commit b9d1a659109daeeb625f3e6caf7ec706ccdde230)

12 years agor12045: More warning fixes... Just a few more to go.
Jeremy Allison [Sat, 3 Dec 2005 06:58:54 +0000 (06:58 +0000)]
r12045: More warning fixes... Just a few more to go.
(This used to be commit cd192ed79a531c6775cdbfb35f0eb2e0fa230ce9)

12 years agor12043: It's amazing the warnings you find when compiling on a 64-bit
Jeremy Allison [Sat, 3 Dec 2005 06:46:46 +0000 (06:46 +0000)]
r12043: It's amazing the warnings you find when compiling on a 64-bit
box with gcc4 and -O6...
Fix a bunch of C99 dereferencing type-punned pointer will break
strict-aliasing rules errors. Also added prs_int32 (not uint32...)
as it's needed in one place. Find places where prs_uint32 was being
used to marshall/unmarshall a time_t (a big no no on 64-bits).
More warning fixes to come.
Thanks to Volker for nudging me to compile like this.
(This used to be commit c65b752604f8f58abc4e7ae8514dc2c7f086271c)

12 years agor12040: merging packaging fixes from release branch
Gerald Carter [Sat, 3 Dec 2005 01:03:16 +0000 (01:03 +0000)]
r12040: merging packaging fixes from release branch
(This used to be commit 47a9f2c3d6039a07a6970ac181aeb2888d47a353)

12 years agor12038: This file is no longer used, and no one noticed....
Jeremy Allison [Sat, 3 Dec 2005 00:51:23 +0000 (00:51 +0000)]
r12038: This file is no longer used, and no one noticed....
(This used to be commit 6ec0312090dc3107e3c92099536858a22046ccfe)

12 years agor12031: Added net idmap to common help list.
John Terpstra [Fri, 2 Dec 2005 20:46:15 +0000 (20:46 +0000)]
r12031: Added net idmap to common help list.
(This used to be commit 3f11401335c0257d0f00678f80c992b5fca5e180)

12 years agor12027: changing version to 3.0.22pre1 since 3.0.21 is frozen now
Gerald Carter [Fri, 2 Dec 2005 19:30:01 +0000 (19:30 +0000)]
r12027: changing version to 3.0.22pre1 since 3.0.21 is frozen now
(This used to be commit 608f8c3da8c708ec291fdb5faa3ea14303f59750)

12 years agor12015: When smbspool tries to connect to a printer shared on a standalone
Günther Deschner [Fri, 2 Dec 2005 10:26:29 +0000 (10:26 +0000)]
r12015: When smbspool tries to connect to a printer shared on a standalone
Windows XP box, smbspool has to mimic smbclient behaviour and also send
a password-less NTLMSSP session setup.

(This used to be commit 1136862e6d6058df4ed027b75dbae40374712bac)

12 years agor12002: patch from marcin to allow for the creation of a File value in the eventlog...
Gerald Carter [Thu, 1 Dec 2005 23:10:27 +0000 (23:10 +0000)]
r12002: patch from marcin to allow for the creation of a File value in the eventlog registry keys so that file properties can be displayed
(This used to be commit 270fef5175559ba6345bb2c3e264c527a6a084c5)

12 years agor11999: Re-add "passdb expand explicit".
Volker Lendecke [Thu, 1 Dec 2005 14:46:56 +0000 (14:46 +0000)]
r11999: Re-add "passdb expand explicit".

We came to the conclusion that changing the default is something that has to
wait one or two more releases, but it will happen one way or the other.

(This used to be commit 30fcdf84d8943e630af78a96320607c42e4d15aa)

12 years agor11998: Add lookupname to rpcclient query_user as a fallback, we now accept both rid
Volker Lendecke [Thu, 1 Dec 2005 12:52:35 +0000 (12:52 +0000)]
r11998: Add lookupname to rpcclient query_user as a fallback, we now accept both rid
and username.

(This used to be commit 8fefafcbb8dc774c7cee2062b13a2790bfc3e5c8)

12 years agor11985: Move to LGPL as per tridge's Samba4 change.
Jeremy Allison [Thu, 1 Dec 2005 00:43:34 +0000 (00:43 +0000)]
r11985: Move to LGPL as per tridge's Samba4 change.
(This used to be commit 3804c4ca3914788e3d3780817ef016421418e11f)

12 years agor11978: Volker's fix for #3292 (smbclient spins if server terminates
Jeremy Allison [Wed, 30 Nov 2005 17:56:50 +0000 (17:56 +0000)]
r11978: Volker's fix for #3292 (smbclient spins if server terminates
(This used to be commit 9b8602e0551500916a9d79c317589cd82d3da111)

12 years agor11976: (Slightly modified) Volker fix for #3293. Use SMBecho instead of
Jeremy Allison [Wed, 30 Nov 2005 17:53:21 +0000 (17:53 +0000)]
r11976: (Slightly modified) Volker fix for #3293. Use SMBecho instead of
chkpath to keep a connection alive.
(This used to be commit f1c88de7a28942b6aaa634551dde7a8af91f4de3)

12 years agor11975: Fix valgrind error -- bug 3291
Volker Lendecke [Wed, 30 Nov 2005 17:29:33 +0000 (17:29 +0000)]
r11975: Fix valgrind error -- bug 3291
(This used to be commit 9a6ce67fbf89ea7fc9eed72776dff4712ba67e2b)

12 years agor11966: fix the build\n\nGuenther
Günther Deschner [Wed, 30 Nov 2005 00:09:14 +0000 (00:09 +0000)]
r11966: fix the build\n\nGuenther
(This used to be commit 53f15a0881de489e809bb58217ecabccd6d77e2c)

12 years agor11964: rename flag to password_properties in SAM_UNK_INFO_1 because that's what
Günther Deschner [Tue, 29 Nov 2005 23:40:01 +0000 (23:40 +0000)]
r11964: rename flag to password_properties in SAM_UNK_INFO_1 because that's what
it is. (SAM_UNK_INFO_1 should get a better name as well).

(This used to be commit d94aaeb625c39b6205fe61c274aed57b1399bafc)

12 years agor11963: add rpccli_samr_chgpasswd3 from samba4.
Günther Deschner [Tue, 29 Nov 2005 23:23:02 +0000 (23:23 +0000)]
r11963: add rpccli_samr_chgpasswd3 from samba4.

(This used to be commit 0705fed566efdeab05d605dd239afe67ca5e9811)

12 years agor11962: Bring talloc up to date with Samba4, re-add the
Jeremy Allison [Tue, 29 Nov 2005 23:01:39 +0000 (23:01 +0000)]
r11962: Bring talloc up to date with Samba4, re-add the
talloc_describe_all() function. Fix smbcontrol <pid> pool-usage
as we desparately need it working in the field to track down
memory leaks. Seriously, when new functionality like the
Samba4 talloc is added, don't just disable working functionality
like "pool-usage", fix the damn thing first !
(This used to be commit 2e262a75cca4575edd00db3d24e7e35760943120)

12 years agor11960: add 'wbinfo --separator' to get the currently active winbind_separator.
Günther Deschner [Tue, 29 Nov 2005 22:46:16 +0000 (22:46 +0000)]
r11960: add 'wbinfo --separator' to get the currently active winbind_separator.
Needed for KDM/GDM login masks.

(This used to be commit abf761c8bf5e8cd3b0aba66abd5fd896035ea1ac)

12 years agor11950: If we got a connection oriented cancel pdu we would spin processing it.
Jeremy Allison [Tue, 29 Nov 2005 02:10:52 +0000 (02:10 +0000)]
r11950: If we got a connection oriented cancel pdu we would spin processing it.
Fix that, and also add in comments for all possible CL and CO PDU
types. Make sure we process them correctly.
(This used to be commit 672113a627aa9060795871bc2ea3a02e696d7d7d)

12 years agor11947: Back out passdb:expand_explicit until we find consensus. I'll file this as a
Volker Lendecke [Mon, 28 Nov 2005 20:42:18 +0000 (20:42 +0000)]
r11947: Back out passdb:expand_explicit until we find consensus. I'll file this as a
bugzilla entry.

(This used to be commit d228cb62a7be6ae128d3418aeb0ea466c7329802)

12 years agor11945: Make us follow the newly documented pathname processing rules:
Jeremy Allison [Mon, 28 Nov 2005 20:14:07 +0000 (20:14 +0000)]
r11945: Make us follow the newly documented pathname processing rules:
"As a special case for directories with large numbers of files, if the
case options are set as follows, "case sensitive = yes", "case
preserve = no", "short preserve case = no" then the "default case"
option will be applied and will modify all filenames sent from the client
when accessing this share."
This is needed as fixing the case preserve rules to only apply to
new filenames broke the large directory fix. Glad we caught this
before release. Thanks to jht for this one.
(This used to be commit abc21cc7322d695cf77b6fb18f4ecdb16288c19b)

12 years agor11943: Don't reset attrs to zero in EA get - we are adding
Jeremy Allison [Mon, 28 Nov 2005 17:03:50 +0000 (17:03 +0000)]
r11943: Don't reset attrs to zero in EA get - we are adding
to the attr list not resetting it.
(This used to be commit 8ee569626be7ebf3b6ebf71e1becdd091b9e893a)

12 years agor11942: patch from Marcin to fix the mkdir() in perfcount daemon
Gerald Carter [Mon, 28 Nov 2005 15:56:10 +0000 (15:56 +0000)]
r11942: patch from Marcin to fix the mkdir() in perfcount daemon
(This used to be commit 3e05e88bb6c0618ecc460045b72d86e82929af01)

12 years agor11938: Fix cifs to handle non-numeric uid and gid parameters and merge trunk and...
Steve French [Mon, 28 Nov 2005 05:43:21 +0000 (05:43 +0000)]
r11938: Fix cifs to handle non-numeric uid and gid parameters and merge trunk and SAMBA_3 versions of mount.cifs and cleanup cifs vfs help.

Modified version of patch from Olaf Kirch <okir at SuSE dot de> for
Novell Bug 120601
(This used to be commit 0981552deab9f73d2f784e5da52878ffdf845031)

12 years agor11936: Fix bug in returning remote time found by Thomas Bork <>.
Jeremy Allison [Sun, 27 Nov 2005 21:51:46 +0000 (21:51 +0000)]
r11936: Fix bug in returning remote time found by Thomas Bork <>.
get_time_zone() was overwriting static buffer returned by
gmtime(). Lars - this is a mandatory fix for the next patch...
(This used to be commit 68d03a7a74738ce62e7531127aa4533147217e6d)

12 years agor11927: No users or groups to return in BUILTIN domain.
Jeremy Allison [Sun, 27 Nov 2005 01:26:52 +0000 (01:26 +0000)]
r11927: No users or groups to return in BUILTIN domain.
(This used to be commit 908e671c75f78b87fe0ee9129f0aca004565c407)

12 years agor11924: Added Volkers's (C) to srv_samr_nt.c, removed separate "builtin"
Jeremy Allison [Sun, 27 Nov 2005 01:17:24 +0000 (01:17 +0000)]
r11924: Added Volkers's (C) to srv_samr_nt.c, removed separate "builtin"
search enumeration, fixed count of groups and users to return
zero if we're getting domain info on the builtin domain (need
to fix the enumgroup and enumuser calls also). Added count_sam_aliases
to return the correct alias count. Need to push the SID arg
down into the group mapping interface so we only return the
correct aliases. Upped passdb version numer for Volkers
changes. SAM-MYSQL guys - you will need to fix your backend
now. More tests needed.
(This used to be commit b53d5cd565b05b0595979efba6176d0cafc8cb03)

12 years agor11923: Add samr_lookup_rids for the builtin domain. Doing it this way feels a bit
Volker Lendecke [Sat, 26 Nov 2005 22:28:41 +0000 (22:28 +0000)]
r11923: Add samr_lookup_rids for the builtin domain. Doing it this way feels a bit
wrong, but so far we don't have proper multi-domain support in passdb yet...

(This used to be commit c917cfc320f0250d23fda3525a7632bc01643707)

12 years agor11922: Looks bigger than it is: There's no point in allocating arrays in
Volker Lendecke [Sat, 26 Nov 2005 22:04:28 +0000 (22:04 +0000)]
r11922: Looks bigger than it is: There's no point in allocating arrays in
samr_lookup_rids twice. It was done in the srv_samr_nt.c code as well as in
the pdb module. Remove the latter, this might happen more often.

(This used to be commit 57f0cf8cdd6928f4759036e5dd53d41736aa910d)

12 years agor11921: samr_open_domain can only open "our" domain and BUILTIN.
Volker Lendecke [Sat, 26 Nov 2005 21:35:43 +0000 (21:35 +0000)]
r11921: samr_open_domain can only open "our" domain and BUILTIN.

(This used to be commit 049920ce4f78723bc884c46b2ee4ef22f25c482c)

12 years agor11920: Rename local_lookup_rid to lookup_global_sam_rid, add lookup_builtin_rid.
Volker Lendecke [Sat, 26 Nov 2005 21:02:48 +0000 (21:02 +0000)]
r11920: Rename local_lookup_rid to lookup_global_sam_rid, add lookup_builtin_rid.

(This used to be commit bc8836d5d7361041ce935f65bf2d172e1eb43299)

12 years agor11919: The generic mappings in srv_samr_nt.c are only used there -- make them
Volker Lendecke [Sat, 26 Nov 2005 20:28:12 +0000 (20:28 +0000)]
r11919: The generic mappings in srv_samr_nt.c are only used there -- make them

One long overdue simplification: Change local_lookup_sid to local_lookup_rid
its responsible for "our" domain only, in fact it checked for it.

(This used to be commit 35ba5e083cddfa5ddba5ad84233262fadfbe87b2)

12 years agor11918: Remove two unused variables
Volker Lendecke [Sat, 26 Nov 2005 19:22:17 +0000 (19:22 +0000)]
r11918: Remove two unused variables
(This used to be commit 5524d662954165eef3fdd15986fe0b4de09180d7)

12 years agor11917: Move nt_token_to_group_list to srv_netlog_nt.c. srv_util.c is empty now.
Volker Lendecke [Sat, 26 Nov 2005 19:17:57 +0000 (19:17 +0000)]
r11917: Move nt_token_to_group_list to srv_netlog_nt.c. srv_util.c is empty now.

(This used to be commit ae4ffc1cfb745a756d047c35f947f80acf4b0e55)

12 years agor11916: auth_get_sam_account is only used in auth_rhosts.c -- move it there
Volker Lendecke [Sat, 26 Nov 2005 18:20:58 +0000 (18:20 +0000)]
r11916: auth_get_sam_account is only used in auth_rhosts.c -- move it there
(This used to be commit 8e5bea3f84c61ea312278cbbb70542664be7bd14)

12 years agor11915: Remove unused extern declarations
Volker Lendecke [Sat, 26 Nov 2005 17:54:24 +0000 (17:54 +0000)]
r11915: Remove unused extern declarations
(This used to be commit 3c35fb642a187b785816bb8cbb3573df9612a9f8)

12 years agor11914: After talking to Jeremy, implement passdb:expand_explicit with a default of
Volker Lendecke [Sat, 26 Nov 2005 09:50:54 +0000 (09:50 +0000)]
r11914: After talking to Jeremy, implement passdb:expand_explicit with a default of
no. This changes our default behaviour.

Sorry, Ingo, this *is* a bug that needs fixing.

Jerry, you might want to put a marker into the WHATSNEW.txt when this is due.

(This used to be commit 6622db97bb575b028b3c0bc016b91f62a8c561a2)

12 years agor11909: Implement 'reset on zero vc'. This kills other connections when a session
Volker Lendecke [Fri, 25 Nov 2005 12:31:40 +0000 (12:31 +0000)]
r11909: Implement 'reset on zero vc'. This kills other connections when a session
setup comes in with the vc (virtual connection) field set to zero. This is
done by Windows, probably you can tweak that by some registry key.

This boolean option controls whether an incoming session setup
should kill other connections coming from the same IP. This matches
        the default Windows 2003 behaviour.

Setting this parameter to yes becomes necessary when you have a flaky
network and windows decides to reconnect while the old connection
still has files with share modes open. These files become inaccessible
over the new connection.

The client sends a zero VC on the new connection, and Windows 2003
kills all other connections coming from the same IP. This way the
locked files are accessible again.

Please be aware that enabling this option will kill connections behind
a masquerading router.

(This used to be commit 5629ca16235f0aa21fea3afd9e414309e4e1374e)