13 years agor8384: merging clutter fixes from release branch
Gerald Carter [Tue, 12 Jul 2005 16:34:44 +0000 (16:34 +0000)]
r8384: merging clutter fixes from release branch
(This used to be commit cbe74c09109dcfe93aa4af085920999ccbff34df)

13 years agor8366: Root-level files don't have a slash, but acls need to be settable on
Volker Lendecke [Tue, 12 Jul 2005 09:18:50 +0000 (09:18 +0000)]
r8366: Root-level files don't have a slash, but acls need to be settable on
them. Thanks to Brent Trotter for reminding me to commit this :-)

(This used to be commit dfa9eef7b6892ceb0e67b0c4bfb56431ead1ac3d)

13 years agor8360: Some ioctl constants, found by Björn Jacke <> with
Volker Lendecke [Tue, 12 Jul 2005 08:05:15 +0000 (08:05 +0000)]
r8360: Some ioctl constants, found by Björn Jacke <> with


(This used to be commit 2d2c49518b7de63ebab2d52008eb726bde6681bc)

13 years agor8330: moving onto 3.0.20rc1-SVN
Gerald Carter [Mon, 11 Jul 2005 20:05:00 +0000 (20:05 +0000)]
r8330: moving onto 3.0.20rc1-SVN
(This used to be commit ea91ee68adb3bd6c07b2556f23a231786d53312d)

13 years agor8327: * don't use unitialized variables
Gerald Carter [Mon, 11 Jul 2005 19:18:15 +0000 (19:18 +0000)]
r8327: * don't use unitialized variables
(This used to be commit bd878197954cf4d259dfd01f2d4cb4a663b34121)

13 years agor8326: factor out the delete printer code to a delete_printer_hook() for reuse
Gerald Carter [Mon, 11 Jul 2005 18:59:54 +0000 (18:59 +0000)]
r8326: factor out the delete printer code to a delete_printer_hook() for reuse
(This used to be commit 0689851a90fbd91ff30f6e2afc05d141f6ce082d)

13 years agor8325: * punt....don't normalize the printer name in the RegCreateKey().
Gerald Carter [Mon, 11 Jul 2005 18:37:15 +0000 (18:37 +0000)]
r8325: * punt....don't normalize the printer name in the RegCreateKey().
  Print Migrator now works as long as the addprinter command can
  handle the name
(This used to be commit 61f14cdcbd3b183caf6172d5b60b0888fc4363f7)

13 years agor8324: * initial cut at creating printers via the registry API
Gerald Carter [Mon, 11 Jul 2005 18:27:22 +0000 (18:27 +0000)]
r8324: * initial cut at creating printers via the registry API
  Need to add delete_key support
(This used to be commit 9a27f7181adca10f60c47d342a51dec34321e12b)

13 years agor8323: * convert RegSetValue() calls immediately beneath the printer
Gerald Carter [Mon, 11 Jul 2005 17:17:50 +0000 (17:17 +0000)]
r8323: * convert RegSetValue() calls immediately beneath the printer
  key to PRINTER_INFO_2 fields.
(This used to be commit fadda2f240eb3c8eb08198c702a93e23b14f0fcc)

13 years agor8322: * get RegSetValue() working for printer subkey values
Gerald Carter [Mon, 11 Jul 2005 16:55:10 +0000 (16:55 +0000)]
r8322: * get RegSetValue() working for printer subkey values
  (not immediate values below the <printer name> key yet.
(This used to be commit a872ea5f0e29f7b585574a56b52a5eb44cb92278)

13 years agor8292: Tidy up function comments.
Jeremy Allison [Sun, 10 Jul 2005 16:40:06 +0000 (16:40 +0000)]
r8292: Tidy up function comments.
(This used to be commit 8de6b1592ad205f59c44ed30102a56594f65e555)

13 years agor8290: Fix for bug in SMBwriteBraw where we incorrectly
Jeremy Allison [Sun, 10 Jul 2005 16:37:32 +0000 (16:37 +0000)]
r8290: Fix for bug in SMBwriteBraw where we incorrectly
returned the number of bytes written. Patch from
Marcel Müller <>.
(This used to be commit 81e7a4a2cfd2d4764d757702f17635e5007e59de)

13 years agor8231: Patch from James Peach to fix the IRIX build.
Volker Lendecke [Fri, 8 Jul 2005 07:54:28 +0000 (07:54 +0000)]
r8231: Patch from James Peach to fix the IRIX build.


(This used to be commit 1ebb3aa0d5007c470862e3adca92d2941ffa294c)

13 years agor8219: Merge the new open code from HEAD to 3.0. Haven't yet run the torture
Jeremy Allison [Fri, 8 Jul 2005 04:51:27 +0000 (04:51 +0000)]
r8219: Merge the new open code from HEAD to 3.0. Haven't yet run the torture
tests on this as it's very late NY time (just wanted to get this work
into the tree). I'll test this over the weekend....
Jerry - in looking at the difference between the two trees there
seem to be some printing/ntprinting.c and registry changes we might
want to examine to try keep in sync.
(This used to be commit c7fe18761e2c753afbffd3a78abff46472a9b8eb)

13 years agor8207: Fix my NT_STATUS_IS_OK mismatch.
Günther Deschner [Thu, 7 Jul 2005 14:19:51 +0000 (14:19 +0000)]
r8207: Fix my NT_STATUS_IS_OK mismatch.

(This used to be commit 053e892e07936f6b71a6bb5e31be09c1d2a2c837)

13 years agor8205: try to improve readability of smbldap_search_domain_info()
Günther Deschner [Thu, 7 Jul 2005 13:42:09 +0000 (13:42 +0000)]
r8205: try to improve readability of smbldap_search_domain_info()

(This used to be commit ca9acd149a36ca36a9a4e2a35b97cae610b3b5ed)

13 years agor8189: commit vampire ldif patch, mostly from Don Watson ( Yes,
Jim McDonough [Wed, 6 Jul 2005 21:02:43 +0000 (21:02 +0000)]
r8189: commit vampire ldif patch, mostly from Don Watson (  Yes,
that's my copyright...that's just how we have to do things at big blue.

Adds subcommand to vampire to allow data to be put into an ldif file instead
of actually writing to the passdb.  See "net rpc help vampire" for usage
info.  This should be added to docs as well.
(This used to be commit cb5634a305256a70daa2fcbd85d9a5459b4aeaa3)

13 years agor8188: Update from Dave Collier-Brown.
John Terpstra [Wed, 6 Jul 2005 19:21:43 +0000 (19:21 +0000)]
r8188: Update from Dave Collier-Brown.
(This used to be commit 65cfa2a950e8a16b95715d555a5354cc81f431f1)

13 years agor8184: fix build issue on Solaris in smbclient
Gerald Carter [Wed, 6 Jul 2005 14:46:36 +0000 (14:46 +0000)]
r8184: fix build issue on Solaris in smbclient
(This used to be commit 137d270ee3bec297732380050bb53cf6b5487914)

13 years agor8155: ops, add missing function.
Günther Deschner [Mon, 4 Jul 2005 19:16:34 +0000 (19:16 +0000)]
r8155: ops, add missing function.

(This used to be commit f3da329fa89fad5b994e46251b43325fa4ea853e)

13 years agor8152: * remove commented out structure
Gerald Carter [Mon, 4 Jul 2005 16:52:29 +0000 (16:52 +0000)]
r8152: * remove commented out structure
* use SAMBA_PRINTER_PORT_NAME in registry values for builtin printer
(This used to be commit 63bc03536b6d0622005448f0f7be2739e06a432a)

13 years agor8151: Add support to create position independent executable (PIE) code if the
Lars Müller [Mon, 4 Jul 2005 16:39:11 +0000 (16:39 +0000)]
r8151: Add support to create position independent executable (PIE) code if the
compiler supports it.

We have to compile with -fPIE and not -fpie.  Else ppc and s390(x) will
fail (to small GOT).

It's possible to disable configure's PIE detection with --disable-pie
(This used to be commit 07845bb4c5a31cb29bf7b8ff6c50e5da84c329e4)

13 years agor8145: When inventing a new parameter for SFU-support, be aware of Volker's
Günther Deschner [Mon, 4 Jul 2005 13:57:54 +0000 (13:57 +0000)]
r8145: When inventing a new parameter for SFU-support, be aware of Volker's
upcoming changes for "unixinfo"-pipe.

Therefor (after speaking with Volker) replace "winbind sfu support" with
the list-parameter "winbind nss info" which defaults to "template". For
SFU-support set it to "winbind nss info = template sfu".

Note that nss_info_use() is just a dummy function at the moment.

(This used to be commit 91596330ea3c4ba0fb9ddc52ad9d4a7c8e5b2d3f)

13 years agor8144: remove unused parameter leftover.
Günther Deschner [Mon, 4 Jul 2005 13:51:17 +0000 (13:51 +0000)]
r8144: remove unused parameter leftover.

(This used to be commit e79e384eb307c6bbe05e07a87dcc6af42a0c0a32)

13 years agor8143: Fix
Günther Deschner [Mon, 4 Jul 2005 13:36:41 +0000 (13:36 +0000)]
r8143: Fix

* Correctly substitute "\" as default winbind separator.
* Use default testparm-location.

(This used to be commit ba0ca4c0c62d7f8801115bec54b9c550e3b1b1c6)

13 years agor8141: Update volker's valgrind fix in r8097. Same effect, just helps me
Gerald Carter [Mon, 4 Jul 2005 13:19:05 +0000 (13:19 +0000)]
r8141: Update volker's valgrind fix in r8097.  Same effect, just helps me
to remember what is going on here better.
(This used to be commit 4a8068ce632adc34e88c128c4a6cc4c690d082bf)

13 years agor8140: adding missing module
Gerald Carter [Mon, 4 Jul 2005 12:43:05 +0000 (12:43 +0000)]
r8140: adding missing module
(This used to be commit 79d03b1919cd7c01503c99e0a68bb1754adb1d76)

13 years agor8133: Got approval from Luke Howard (PADL) to change the company copyright to
Günther Deschner [Mon, 4 Jul 2005 09:56:27 +0000 (09:56 +0000)]
r8133: Got approval from Luke Howard (PADL) to change the company copyright to
to a personal one.

Thanks Luke!

(This used to be commit 892ef0bbc100e05ba3e683f4e08946f36627cc1a)

13 years agor8093: Next round. Now it compiles with --enable-socket-wrapper.
Volker Lendecke [Sun, 3 Jul 2005 12:05:07 +0000 (12:05 +0000)]
r8093: Next round. Now it compiles with --enable-socket-wrapper.

(This used to be commit 25cbcfba30f534f3fb31627ba43421c42ccd5b0f)

13 years agor8092: Attempt to fix the socket wrapper stuff for Samba 3.
Volker Lendecke [Sun, 3 Jul 2005 10:20:03 +0000 (10:20 +0000)]
r8092: Attempt to fix the socket wrapper stuff for Samba 3.

(This used to be commit 53c22c036588238d0d732f7dbf7329921f593191)

13 years agor8089: successfully delete printer subkeys via the for values
Gerald Carter [Sun, 3 Jul 2005 02:05:01 +0000 (02:05 +0000)]
r8089: successfully delete printer subkeys via the for values
(This used to be commit d3427960b0676c506c639b582a2544dc58990c9e)

13 years agor8085: Updating info.
John Terpstra [Sat, 2 Jul 2005 19:17:29 +0000 (19:17 +0000)]
r8085: Updating info.
(This used to be commit f20213227fa00a624fa8f0f88f7f9bbdc9d8ece1)

13 years agor8066: * had to modify the printer data storage slightly in ntprinters.tdb
Gerald Carter [Sat, 2 Jul 2005 01:23:21 +0000 (01:23 +0000)]
r8066: * had to modify the printer data storage slightly in ntprinters.tdb
  when packing values.  It is a compatible change though and will
  not require a tdb version upgrade
* Can successfully create new printer subkeys via winreg that
  are immediately available via spoolss calls.  Still cannot delete
  keys yet though.  That comes next.
(This used to be commit 00bce2b3bb78a44842a258b1737076281297d247)

13 years agor8064: * add the REG_XXX error codes to the pretty error messages
Gerald Carter [Fri, 1 Jul 2005 22:24:00 +0000 (22:24 +0000)]
r8064: * add the REG_XXX error codes to the pretty error messages
* more work on the store_values() functions for the Printers key
* add Control\Print\Monitors key to list for reg_db
(This used to be commit 89f17b41cee633838b8cbd0d1bf8119a4b8d707e)

13 years agor8062: Remove some unused code
Volker Lendecke [Fri, 1 Jul 2005 19:23:50 +0000 (19:23 +0000)]
r8062: Remove some unused code
(This used to be commit fa6cc0bdefe272ec538a71a2b6ba72a724411764)

13 years agor8061: * mostly cleanup and refactoring for better readability
Gerald Carter [Fri, 1 Jul 2005 19:15:07 +0000 (19:15 +0000)]
r8061: * mostly cleanup and refactoring for better readability
* move to registry.tdb for port listing (at least via the winreg ops)
  If no one opposes on the samba list, we'll move to a registry
  lookup for enumerating ports rather than the 'enumports command'.
  This means that there is a bit of a disconnect between EnumPorts() and
  RegEnumKey('hklm\software\microsoft\windows nt\currentversion\ports').
(This used to be commit 6f654c5741e98abf00c010c5dd38038092c0f7a3)

13 years agor8048: Replace "done" with "failed".
Günther Deschner [Fri, 1 Jul 2005 10:28:31 +0000 (10:28 +0000)]
r8048: Replace "done" with "failed".

(This used to be commit 7285edc4fe71f47ab648c31760c357fc2af29ce7)

13 years agor8047: "oid" is defined in a heimdal header. With my gcc this generates a ton of
Volker Lendecke [Fri, 1 Jul 2005 10:20:28 +0000 (10:20 +0000)]
r8047: "oid" is defined in a heimdal header. With my gcc this generates a ton of
shadowed variable warnings. Fix that.

(This used to be commit 3846c0afa1db96239b3aaf2e7ee2427b48f6e2f0)

13 years agor8031: Adding contributed mklogon scripts.
John Terpstra [Thu, 30 Jun 2005 23:44:18 +0000 (23:44 +0000)]
r8031: Adding contributed mklogon scripts.
(This used to be commit aaca9ea8a3ffdb9d5b1d25d414692db8927c2943)

13 years agor8029: Fix bug 2841. Thanks to Brett Trotter.
Volker Lendecke [Thu, 30 Jun 2005 21:25:41 +0000 (21:25 +0000)]
r8029: Fix bug 2841. Thanks to Brett Trotter.

(This used to be commit 2588dd7a272830bfda4e8ffa7d1114af506e36be)

13 years agor8027: driver information is now back via winreg
Gerald Carter [Thu, 30 Jun 2005 20:16:16 +0000 (20:16 +0000)]
r8027: driver information is now back via winreg
(This used to be commit f0a1c6b9cec28d5b4aa8a1a2f9b34d1f13113a6c)

13 years agor8026: * more fixes to the printing registry interface
Gerald Carter [Thu, 30 Jun 2005 19:43:53 +0000 (19:43 +0000)]
r8026: * more fixes to the printing registry interface
  (still not completely back to the read functionality
  we previously had but the cleanup is progressing)
(This used to be commit 04431372a698433b4936392047228908a64ff382)

13 years agor8025: *how* can this code have been around so long and
Gerald Carter [Thu, 30 Jun 2005 19:33:47 +0000 (19:33 +0000)]
r8025: *how* can this code have been around so long and
nver normalized the string used for printer and
sec_desc key lookups ?????

normalized sharename to lower case before storing/fetching
from tdb.

Need to look at drivers and forms tdb as well (perhaps).
(This used to be commit 4aec5dce5c2d0b5c686123a624b58097be9d911a)

13 years agor8022: * implement default actions rather than having to define functions
Gerald Carter [Thu, 30 Jun 2005 17:46:06 +0000 (17:46 +0000)]
r8022: * implement default actions rather than having to define functions
  for every fetch/store callback (some keys should never have a value)
(This used to be commit 7466351dd059b75c29bc0d2977c6c9d318a14dc6)

13 years agor8019: Better give a hint that we are failing share-manipulation due to missing
Günther Deschner [Thu, 30 Jun 2005 15:19:54 +0000 (15:19 +0000)]
r8019: Better give a hint that we are failing share-manipulation due to missing

(This used to be commit 1f17b4f45e966cba83f6ad48e5017cbaa5b58bdf)

13 years agor8008: * start adding logic for restricting subkey paths
Gerald Carter [Thu, 30 Jun 2005 03:29:48 +0000 (03:29 +0000)]
r8008: * start adding logic for restricting subkey paths
  e.g. 'hklm\software\microsoft\windows nt\currentversion\ports'
  should have no subkeys.  Return an error if a client tries
  to open a path below here
(This used to be commit 7a2ecb1aec2b84e6bc326be4a1191fb54526c430)

13 years agor8007: * cleanup unused structure from reg_objects.h
Gerald Carter [Thu, 30 Jun 2005 02:59:29 +0000 (02:59 +0000)]
r8007: * cleanup unused structure from reg_objects.h
* make regdb_store_XXX() and regdb_fetch_XXX() functions non-static
* use case sensitive string lookups in reg_dynamic.c since the
  keys have already been normalized
* move to new design for making printing related data available
  via the winreg pipe (with the intent of allowing writes)
(This used to be commit 28c7293ee9e68b913faf8d74d63f73e09087169b)

13 years agor7998: Fix usage message
Volker Lendecke [Wed, 29 Jun 2005 20:17:05 +0000 (20:17 +0000)]
r7998: Fix usage message
(This used to be commit 1e9a8854b1f3bd640096923dc79991654da7e845)

13 years agor7997: Pointers don't kill people, people with pointers kill people...
Gerald Carter [Wed, 29 Jun 2005 17:19:04 +0000 (17:19 +0000)]
r7997: Pointers don't kill people, people with pointers kill people...

"Honest office!  It was a mistake!  I thought the safety lock was on!"

* Fix problem setting registry values in in-memory objects

I now have printmig.exe successfully creating all of the printer
registry keys (in the tdb backend) which means that the top level
semantics are correct.
(This used to be commit 52899551070ddb8f185d53bd125ae06c192ef7b0)

13 years agor7995: * privileges are local except when they're *not*
Gerald Carter [Wed, 29 Jun 2005 16:35:32 +0000 (16:35 +0000)]
r7995: * privileges are local except when they're *not*
  printmig.exe assumes that the LUID of the SeBackupPrivlege
  on the target server matches the LUID of the privilege
  on the local client.  Even though an LUID is never guaranteed
  to be the same across reboots.  How *awful*!  My cat could
  write better code! (more on my cat later....)

* Set the privelege LUID in the global PRIVS[] array

* Rename RegCreateKey() to RegCreateKeyEx() to better match MSDN

* Rename the unknown field in RegCreateKeyEx() to disposition
  (guess according to MSDN)

* Add the capability to define REG_TDB_ONLY for using the reg_db.c
  functions and stress the RegXXX() rpc functions.
(This used to be commit 0d6352da4800aabc04dfd7c65a6afe6af7cd2d4b)

13 years agor7994: This adds support in Winbindd's "security = ads"-mode to retrieve the POSIX
Günther Deschner [Wed, 29 Jun 2005 14:03:53 +0000 (14:03 +0000)]
r7994: This adds support in Winbindd's "security = ads"-mode to retrieve the POSIX
homedirectory and the loginshell from Active Directory's "Services for Unix".

Enable it with:

        winbind sfu support = yes

User-Accounts without SFU-Unix-Attributes will be assigned template-based
Shells and Homedirs as before.

Note that it doesn't matter which version of Services for Unix you use (2.0,
2.2, 3.0 or 3.5). Samba should detect the correct attributes (msSFULoginShell,
msSFU30LoginShell, etc.) automatically.

If you also want to share the same uid/gid-space as SFU then also use PADL's

        idmap backend = ad

When using the idmap-plugin only those accounts will appear in Name Service
Switch that have those UNIX-attributes which avoids potential uid/gid-space
clashes between SFU-ids and automatically assigned idmap-ids.

(This used to be commit 28b59699425b1c954d191fc0e3bd357e4a4e4cd8)

13 years agor7992: Adding PADL's idmap_ad plugin (taken from the latest
Günther Deschner [Wed, 29 Jun 2005 13:49:29 +0000 (13:49 +0000)]
r7992: Adding PADL's idmap_ad plugin (taken from the latest

(This used to be commit 1d59841c9901b6a3aff72b6da1037495aa75f389)

13 years agor7987: map generic bits to specific bits in open requests
Gerald Carter [Tue, 28 Jun 2005 22:39:18 +0000 (22:39 +0000)]
r7987: map generic bits to specific bits in open requests
(This used to be commit 7764e8a6775ead942d8ceac89cbcb947136bf7fa)

13 years agor7985: Add "acl map full control", true by default, to allow people to change
Jeremy Allison [Tue, 28 Jun 2005 21:48:09 +0000 (21:48 +0000)]
r7985: Add "acl map full control", true by default, to allow people to change
mapping of rwx to full control or not. Requested feature at SambaXP.
(This used to be commit c870579f4cd91dc9e030134dd367109aed3e3469)

13 years agor7983: clean up some use of un-initialized variables found by valgrind
Gerald Carter [Tue, 28 Jun 2005 20:29:34 +0000 (20:29 +0000)]
r7983: clean up some use of un-initialized variables found by valgrind
(This used to be commit 5f4a3f61a354346d7dde11d6d7930abe007b9603)

13 years agor7981: MS-DFS tidyup patches from James Peach <>.
Jeremy Allison [Tue, 28 Jun 2005 19:25:48 +0000 (19:25 +0000)]
r7981: MS-DFS tidyup patches from  James Peach <>.
Looking forward to the day he can commit these himself :-).
(This used to be commit 12ff2978295a84fe6177af129c495a0021befacc)

13 years agor7976: Adding debugging info.
John Terpstra [Tue, 28 Jun 2005 01:50:18 +0000 (01:50 +0000)]
r7976: Adding debugging info.
(This used to be commit 97ee7c970c287737396f135336c56c945f639d85)

13 years agor7975: One more tidyup to ensure we're using "struct posix_lock".
Jeremy Allison [Tue, 28 Jun 2005 01:37:19 +0000 (01:37 +0000)]
r7975: One more tidyup to ensure we're using "struct posix_lock".
(This used to be commit 960a5d37d1cfa25e4f7491b175dab68ac9f37c43)

13 years agor7972: Tidy up the posix locking in memory db code whilst I'm waiting for jht
Jeremy Allison [Tue, 28 Jun 2005 01:05:59 +0000 (01:05 +0000)]
r7972: Tidy up the posix locking in memory db code whilst I'm waiting for jht
to get back to me with a backtrace.
(This used to be commit f2bcfdddc769a2939b03a1a6742fec86712c9097)

13 years agor7963: Add aio support to 3.0.
Jeremy Allison [Mon, 27 Jun 2005 22:53:56 +0000 (22:53 +0000)]
r7963: Add aio support to 3.0.
(This used to be commit 1de27da47051af08790317f5b48b02719d6b9934)

13 years agor7961: randomize reloading so that smbds do not pverload cupsd
Simo Sorce [Mon, 27 Jun 2005 22:44:57 +0000 (22:44 +0000)]
r7961: randomize reloading so that smbds do not pverload cupsd
by reloading printers all at the same time.
(This used to be commit da227d5f4311c84a12a4e2a9fd510328268af4b3)

13 years agor7960: Replace unknown SMB_XSTRDUP by known SMB_STRDUP macro.
Lars Müller [Mon, 27 Jun 2005 22:39:09 +0000 (22:39 +0000)]
r7960: Replace unknown SMB_XSTRDUP by known SMB_STRDUP macro.

I still don't know why the compile doesn't fail.
(This used to be commit 8cfa6873c2b57eb94b43a5aded38be7958922210)

13 years agor7959: Added aio structure and types.
Jeremy Allison [Mon, 27 Jun 2005 22:08:58 +0000 (22:08 +0000)]
r7959: Added aio structure and types.
(This used to be commit 095c5dbc188ca4b093c774c8f04d79f7d342a8a6)

13 years agor7957: Added aio configure support. Jerry told me to :-).
Jeremy Allison [Mon, 27 Jun 2005 22:06:41 +0000 (22:06 +0000)]
r7957: Added aio configure support. Jerry told me to :-).
(This used to be commit 5b5052c0422d88c9ca7d42f5ac7afec4d0e6b647)

13 years agor7956: Spelling mistake.
Jeremy Allison [Mon, 27 Jun 2005 22:06:18 +0000 (22:06 +0000)]
r7956: Spelling mistake.
(This used to be commit f318c371077f28ace52f7d2b1517df0d15a0f05a)

13 years agor7954: Fix from tridge from Samba4 (same code exists here) :
Jeremy Allison [Mon, 27 Jun 2005 18:53:38 +0000 (18:53 +0000)]
r7954: Fix from tridge from Samba4 (same code exists here) :
fixed handling of ASN.1 objects bigger than 64k
(This used to be commit 0da60e9954b84bac29bb219803f6175b7a30b591)

13 years agor7952: Fix for bug #2826 pointed out by Jiri Klouda <>.
Jeremy Allison [Mon, 27 Jun 2005 18:32:58 +0000 (18:32 +0000)]
r7952: Fix for bug #2826 pointed out by Jiri Klouda <>.
Wrong return val for symlink and readlink.
(This used to be commit f3c4d5a95746531b7bd548bbbfccfff197a2abf3)

13 years agor7949: Work around for broken Solaris header files.
Jeremy Allison [Mon, 27 Jun 2005 17:31:00 +0000 (17:31 +0000)]
r7949: Work around for broken Solaris header files.
(This used to be commit 4d5002931056d2a88d49ce060c10bc0fecf4ba50)

13 years agor7948: Ensure we call the vfs connection hook before doing a vfs stat.
Jeremy Allison [Mon, 27 Jun 2005 17:14:15 +0000 (17:14 +0000)]
r7948: Ensure we call the vfs connection hook before doing a vfs stat.
Allows database vfs backends to initialise with a working connection.
Bugid #2827
(This used to be commit 7ef6850056f7fbb380038f5ec5bcb29d27fbf254)

13 years agor7946: Minor C++ compatibility fix.
Jeremy Allison [Mon, 27 Jun 2005 16:54:31 +0000 (16:54 +0000)]
r7946: Minor C++ compatibility fix.
(This used to be commit 7eb7f8325762ca570d37cc91f40b46bf17a867ba)

13 years agor7944: BUG 2808: don't try to install manpages if they are not present
Gerald Carter [Mon, 27 Jun 2005 13:20:12 +0000 (13:20 +0000)]
r7944: BUG 2808: don't try to install manpages if they are not present
(This used to be commit 1ce5cc2a5f3da7ef6874cae5b433c139d68589c6)

13 years agor7938: * move the hardcoded registry value names from _reg_query_value()
Gerald Carter [Mon, 27 Jun 2005 03:40:03 +0000 (03:40 +0000)]
r7938: * move the hardcoded registry value names from _reg_query_value()
  to a thin layer in fetch_reg_values().  Not entirely efficient
  seeing as the the dynamic value paths are stored in an unsorted
  array but it is one strequal() per path.  If this was really big
  it should be worked into the reghook_cache().
(This used to be commit 63b81ad3cb484090a181fbd13e04922a5c17e7d9)

13 years agor7908: * change REGISTRY_HOOK api to use const (fix compiler warning
Gerald Carter [Sat, 25 Jun 2005 17:31:40 +0000 (17:31 +0000)]
r7908: * change REGISTRY_HOOK api to use const (fix compiler warning
  in init_registry_data()
* Add means of storing registry values in registry.tdb
* add builtin_registry_values[] array for REG_DWORD and REG_SZ
  values needed during startup
* Finish up RegDeleteValue() and RegSetValue()
* Finish up regdb_store_reg_values() and regdb_fetch_reg_values()

I can now create and retrieve values using regedit.exe on Win2k.

bin/net -S rain -U% rpc registry enumerate 'hklm\software\samba'
Valuename  = Version
Type       = REG_SZ
Data       = 3.0.20

Next is to do the virtual writes in reg_printing.c and I'll be
done with Print Migrator (yeah!  finally)
(This used to be commit 3d837e58db9ded64d6b85f047012c7d487be4627)

13 years agor7904: Fix a memleak in vfs_afsacl
Volker Lendecke [Sat, 25 Jun 2005 13:06:23 +0000 (13:06 +0000)]
r7904: Fix a memleak in vfs_afsacl
(This used to be commit 8fad08db742ea32a3cda3b3d9421454837e2d2a5)

13 years agor7903: Attempt to fix the AIX build
Volker Lendecke [Sat, 25 Jun 2005 10:13:07 +0000 (10:13 +0000)]
r7903: Attempt to fix the AIX build
(This used to be commit bb884b0bf96899bf3cf477bfe2220cdfc7aa596d)

13 years agor7902: Fix the build
Volker Lendecke [Sat, 25 Jun 2005 09:07:42 +0000 (09:07 +0000)]
r7902: Fix the build
(This used to be commit 6d431eb676e1df4cfdcbeaed5fa81adfbfc77325)

13 years agor7893: Add in the extra parameters to opendir() to fix the large directory/insane app
Jeremy Allison [Sat, 25 Jun 2005 03:03:44 +0000 (03:03 +0000)]
r7893: Add in the extra parameters to opendir() to fix the large directory/insane app
problem. Rev vfs version. Doesn't change the normal codepath.
(This used to be commit 0f03a6bdcdbdf60da81e0aeffa84ac6e48fc6a04)

13 years agor7890: * add Reg[SG]etKeySec() server stubs
Gerald Carter [Fri, 24 Jun 2005 22:34:40 +0000 (22:34 +0000)]
r7890: * add Reg[SG]etKeySec() server stubs
* merge a compile warning fix from trunk to SAMBA_3_0
(This used to be commit 71eb018a05c5012fbd42ba6817aabc0797d38ba1)

13 years agor7888: Fix use of "protected".
Jeremy Allison [Fri, 24 Jun 2005 21:43:36 +0000 (21:43 +0000)]
r7888: Fix use of "protected".
(This used to be commit af5fd615b37f555e5f2c7b9fef24299e99952a41)

13 years agor7887: 3.0.20pre2-SVN
Gerald Carter [Fri, 24 Jun 2005 21:40:56 +0000 (21:40 +0000)]
r7887: 3.0.20pre2-SVN
(This used to be commit 388ade15d38ba215a8294711142db59849c51bab)

13 years agor7886: Fix building with pam_smbpass.
Jeremy Allison [Fri, 24 Jun 2005 21:18:20 +0000 (21:18 +0000)]
r7886: Fix building with pam_smbpass.
(This used to be commit 22a796fe012e212f7744f0d63a8512e6942a5324)

13 years agor7882: Looks like a large patch - but what it actually does is make Samba
Jeremy Allison [Fri, 24 Jun 2005 20:25:18 +0000 (20:25 +0000)]
r7882: Looks like a large patch - but what it actually does is make Samba
safe for using our headers and linking with C++ modules. Stops us
from using C++ reserved keywords in our code.
(This used to be commit 9506b8e145982b1160a2f0aee5c9b7a54980940a)

13 years agor7880: fix a typo and memleak on failures cases (patch from marcin)
Gerald Carter [Fri, 24 Jun 2005 15:49:02 +0000 (15:49 +0000)]
r7880: fix a typo and memleak on failures cases (patch from marcin)
(This used to be commit 6ff0fa0b4385481f2212047d80ca17b55d996def)

13 years agor7879: fix compile issue caused by not statoc value for intializing cpp macros
Gerald Carter [Fri, 24 Jun 2005 15:13:25 +0000 (15:13 +0000)]
r7879: fix compile issue caused by not statoc value for intializing cpp macros
(This used to be commit 9af07b243005db76b6490856b4e0bbc4a8af0dba)

13 years agor7878: mostly just a rename of REG_INFO to REG_QUERY_VALUE for better clarity
Gerald Carter [Fri, 24 Jun 2005 14:55:09 +0000 (14:55 +0000)]
r7878: mostly just a rename of REG_INFO to REG_QUERY_VALUE for better clarity
(This used to be commit d50f0ba07e285728605c8e8aae9d9a251a525e78)

13 years agor7877: Attempt to fix a smb_panic reported by Pavel Rochnyack.
Volker Lendecke [Fri, 24 Jun 2005 14:25:18 +0000 (14:25 +0000)]
r7877: Attempt to fix a smb_panic reported by Pavel Rochnyack.

(This used to be commit 7d1b890fead61551465e2a972e4097d9c1a4d6fd)

13 years agor7876: Now that we have "net rpc share migrate security" completly remove the
Günther Deschner [Fri, 24 Jun 2005 14:15:31 +0000 (14:15 +0000)]
r7876: Now that we have "net rpc share migrate security" completly remove the
share-acl from "net rpc share migrate shares".

God, how ugly does this syntax get.

(This used to be commit 6f4d4acc868ee67f8434d904fa51c57d1b847135)

13 years agor7852: Correct fix from Lars for the argv issue.
Jeremy Allison [Thu, 23 Jun 2005 23:23:16 +0000 (23:23 +0000)]
r7852: Correct fix from Lars for the argv issue.
(This used to be commit a667d9e474302e888a0cc009a342da471318928c)

13 years agor7849: Dodgy fix - we shouldn't be assuming argc++ points to a valid argv.
Jeremy Allison [Thu, 23 Jun 2005 22:20:37 +0000 (22:20 +0000)]
r7849: Dodgy fix - we shouldn't be assuming argc++ points to a valid argv.
(This used to be commit 5fbabaef8cab894c6d349b0535a06c2c9d1437db)

13 years agor7846: Fix from Kevin Jamieson - typo
Jeremy Allison [Thu, 23 Jun 2005 17:00:11 +0000 (17:00 +0000)]
r7846: Fix from Kevin Jamieson - typo
in checking for .. in statcache. Bugid #2819.
(This used to be commit a5619d717954ad2a3ffaa549b11bfa738720e325)

13 years agor7842: With the patch I sent Steve yesterday this gives us complete POSIX pathnames.
Jeremy Allison [Wed, 22 Jun 2005 21:20:41 +0000 (21:20 +0000)]
r7842: With the patch I sent Steve yesterday this gives us complete POSIX pathnames.
ie. files containing : and \ can be accessed from Linux.
(This used to be commit e9b8d23d6138d909a65ea70b2e801881e8333b38)

13 years agor7839: remove C++ style comment
Gerald Carter [Wed, 22 Jun 2005 20:33:30 +0000 (20:33 +0000)]
r7839: remove C++ style comment
(This used to be commit e04fd56e0097dc8007394bf295b227b454e524b4)

13 years agor7838: lie about the printer status when doing the queryvalue() registry call. Note...
Gerald Carter [Wed, 22 Jun 2005 18:03:38 +0000 (18:03 +0000)]
r7838: lie about the printer status when doing the queryvalue() registry call.  Note that if you migrate a printer to a Windows server, the win spooler will remove any printers that have an invalid status value in the registry
(This used to be commit 0a22ea9eb7fd5aa8c57d2bf1ea2a171b377cab5a)

13 years agor7836: Fix the bug where users show up as trusting domains.
Volker Lendecke [Wed, 22 Jun 2005 14:16:10 +0000 (14:16 +0000)]
r7836: Fix the bug where users show up as trusting domains.

(This used to be commit 61585fa56b4f838f416815598f4a301aa9ee12d7)

13 years agor7835: Add the forgotten GPL header. This source code file is distributed with Samba
Volker Lendecke [Wed, 22 Jun 2005 07:00:26 +0000 (07:00 +0000)]
r7835: Add the forgotten GPL header. This source code file is distributed with Samba
and interfaces to the Linux kernel (both GPL programs), so it was always our
(Paal-Kr. Engstad and Volker Lendecke) intent that this program is covered by
the GPL.

(This used to be commit 72bc9de68646a8a9a4787d6681524f1a77cf2cdf)

13 years agor7830: fix directory typo with testprns manpage
Gerald Carter [Wed, 22 Jun 2005 03:05:54 +0000 (03:05 +0000)]
r7830: fix directory typo with testprns manpage
(This used to be commit c2d0c7edc0f1538296f18bd66af4c4b7bf9c81ea)

13 years agor7829: fix unitialized printer status field that was breaking migration of print...
Gerald Carter [Wed, 22 Jun 2005 02:51:22 +0000 (02:51 +0000)]
r7829: fix unitialized printer status field that was breaking migration of print queues
(This used to be commit ada1d326aeef4a2f33a360a8ea4a874e59fcfee6)

13 years agor7825: Fedora packaging fixes after docs change
Gerald Carter [Tue, 21 Jun 2005 22:46:34 +0000 (22:46 +0000)]
r7825: Fedora packaging fixes after docs change
(This used to be commit ebefc950b6c7a18ab80e145a4b5a5735502960c6)

13 years agor7822: fixing specfiles after removing testprns
Gerald Carter [Tue, 21 Jun 2005 22:13:58 +0000 (22:13 +0000)]
r7822: fixing specfiles after removing testprns
(This used to be commit 9ca00d6b5abba7ff3ecd3de88215129d8f4640e3)

13 years agor7821: Don't check permissions for setting POSIX pathname request.
Jeremy Allison [Tue, 21 Jun 2005 21:26:29 +0000 (21:26 +0000)]
r7821: Don't check permissions for setting POSIX pathname request.
(This used to be commit 06b40024f3784778a81ae7c69881a516d183a1c3)