13 years agor3323: more warning reductions
Andrew Tridgell [Thu, 28 Oct 2004 13:19:39 +0000 (13:19 +0000)]
r3323: more warning reductions
(This used to be commit 5921587ec26e4892efc678421277e4969417d7f5)

13 years agor3322: fixed a bunch of warnings in the build, including one case where it was a...
Andrew Tridgell [Thu, 28 Oct 2004 12:46:59 +0000 (12:46 +0000)]
r3322: fixed a bunch of warnings in the build, including one case where it was a real bug
(This used to be commit 02d5d0f685e44bd66aff4a007f0bf34c8f915574)

13 years agor3321: make the test suite test non-blocking on all rpc transports
Andrew Tridgell [Thu, 28 Oct 2004 11:59:48 +0000 (11:59 +0000)]
r3321: make the test suite test non-blocking on all rpc transports
this test now passes
(This used to be commit 3d270fd86caedd1023373160934d72d8cb065659)

13 years agor3320: fixed bugs in the rpc_server code in handling partial packet receives and...
Andrew Tridgell [Thu, 28 Oct 2004 11:59:03 +0000 (11:59 +0000)]
r3320: fixed bugs in the rpc_server code in handling partial packet receives and sends
it now passes the non-blocking test suite
(This used to be commit 6cdf485fb263c69d62ea2e98236d92ffbf6b7a3e)

13 years agor3319: fixed a bug in the client library found by the new non-block testing code
Andrew Tridgell [Thu, 28 Oct 2004 11:58:09 +0000 (11:58 +0000)]
r3319: fixed a bug in the client library found by the new non-block testing code
(This used to be commit 1e62aa262aac1c8e3676caac7b65086d21b7a01e)

13 years agor3318: generate random STATUS_MORE_ENTRIES errors (1 in 10 packets) as well
Andrew Tridgell [Thu, 28 Oct 2004 11:57:20 +0000 (11:57 +0000)]
r3318: generate random STATUS_MORE_ENTRIES errors (1 in 10 packets) as well
as randomly short recv/send when socket:testnonblock is enabled
(This used to be commit 718175a265d34bfdbcbf0cc6b55dbf6b389f3194)

13 years agor3317: Fix the build
Volker Lendecke [Thu, 28 Oct 2004 08:37:46 +0000 (08:37 +0000)]
r3317: Fix the build
(This used to be commit 5e8fd27d6ec7f44e6e802a2f29ec54e96fa78af0)

13 years agor3316: give the LDAP server a chance of operating correctly non-blocking (it
Andrew Tridgell [Thu, 28 Oct 2004 08:36:23 +0000 (08:36 +0000)]
r3316: give the LDAP server a chance of operating correctly non-blocking (it
didn't handle EINTR or EAGAIN)
(This used to be commit c35a8f92c2df354e972ced9371d33657ce99988e)

13 years agor3315: converted the libcli/raw/ code to use the generic socket library. This
Andrew Tridgell [Thu, 28 Oct 2004 08:15:12 +0000 (08:15 +0000)]
r3315: converted the libcli/raw/ code to use the generic socket library. This
allows me to test with the socket:testnonblock option. It passes.
(This used to be commit 7cb4bf8662825d507d8246647ffb10aa08bad794)

13 years agor3314: added a option "socket:testnonblock" to the generic socket code. If
Andrew Tridgell [Thu, 28 Oct 2004 07:55:33 +0000 (07:55 +0000)]
r3314: added a option "socket:testnonblock" to the generic socket code. If
you set this option (either on the command line using --option or in
smb.conf) then every socket recv or send will return short by random
amounts. This allows you to test that the non-blocking socket logic in
your code works correctly.

I also removed the flags argument to socket_accept(), and instead made
the new socket inherit the flags of the old socket, which makes more
sense to me.
(This used to be commit 406d356e698da01c84e8aa5b7894752b4403f63c)

13 years agor3313: in socket_accept() make the new socket non-blocking unless SOCKET_FLAG_BLOCK...
Andrew Tridgell [Thu, 28 Oct 2004 07:34:11 +0000 (07:34 +0000)]
r3313: in socket_accept() make the new socket non-blocking unless SOCKET_FLAG_BLOCK is set.
(This used to be commit a2d92aa431e0e9752387eebe741d9e6f376f74d7)

13 years agor3312: in the brlock code, we prevent lock stampedes by attempting to not
Andrew Tridgell [Thu, 28 Oct 2004 06:45:28 +0000 (06:45 +0000)]
r3312: in the brlock code, we prevent lock stampedes by attempting to not
wakeup all pending locks at once. This change means that we only
trigger this anti-stampede code for write locks, as for pending read
locks the correct behaviour is to stampede (as they will all succeed)
(This used to be commit 8021d1d74207db1204139309592b9d2f80f2bd0e)

13 years agor3311: Consistency updates for form name members.
Tim Potter [Thu, 28 Oct 2004 06:17:38 +0000 (06:17 +0000)]
r3311: Consistency updates for form name members.

Add tests for EnumForms, GetForm, AddForm, DeleteForm.
(This used to be commit 6c49ce976a5c6982fa83de4ea723cef5597c29ef)

13 years agor3310: Update dependencies for swig wrappers.
Tim Potter [Thu, 28 Oct 2004 06:16:32 +0000 (06:16 +0000)]
r3310: Update dependencies for swig wrappers.
(This used to be commit 5dcb300fca592cc62d325c47c857b046c90e7b42)

13 years agor3309: Add wrapper for dcerpc_server_name() function.
Tim Potter [Thu, 28 Oct 2004 06:14:10 +0000 (06:14 +0000)]
r3309: Add wrapper for dcerpc_server_name() function.
(This used to be commit 2d60a04f21da9dbe32c85b11afa98df74f5fd763)

13 years agor3308: Handle servers that don't have samr_Connect5.
Tim Potter [Thu, 28 Oct 2004 06:13:42 +0000 (06:13 +0000)]
r3308: Handle servers that don't have samr_Connect5.
(This used to be commit 52af866ffb427427d21daf11a4ca9a8b9881f1d5)

13 years agor3307: fixed the send side of the smb_server code to be non-blocking. This
Andrew Tridgell [Thu, 28 Oct 2004 05:09:42 +0000 (05:09 +0000)]
r3307: fixed the send side of the smb_server code to be non-blocking. This
means the whole of the SMB handling code is now non-blocking.
(This used to be commit 30acedb943f0170d30e7b08925280d0dffc7873e)

13 years agor3306: the main smb server code now handles non-blocking socket receives. I
Andrew Tridgell [Thu, 28 Oct 2004 04:36:12 +0000 (04:36 +0000)]
r3306: the main smb server code now handles non-blocking socket receives. I
haven't marked the socket non-blocking yet as I haven't checked that
the send path is OK for non-blocking.
(This used to be commit bda978cc2a921a888534054135b9325427425dd2)

13 years agor3305: added ncalrpc to the list of rpc transports tested by, so
Andrew Tridgell [Thu, 28 Oct 2004 04:01:45 +0000 (04:01 +0000)]
r3305: added ncalrpc to the list of rpc transports tested by, so
it gets regularly tested when I make changes.
(This used to be commit e4216da824c8186df956d05742d96da05393c719)

13 years agor3304: changed the API to lib/socket/ a little.
Andrew Tridgell [Thu, 28 Oct 2004 04:00:43 +0000 (04:00 +0000)]
r3304: changed the API to lib/socket/ a little.

The main change is to make socket_recv() take a pre-allocated buffer,
rather than allocating one itself. This allows non-blocking users of
this API to avoid a memcpy(). As a result our messaging code is now
about 10% faster, and the ncacn_ip_tcp and ncalrpc code is also

The second change was to remove the unused mem_ctx argument from
socket_send(). Having it there implied that memory could be allocated,
which meant the caller had to worry about freeing that memory (if for
example it is sending in a tight loop using the same memory
context). Removing that unused argument keeps life simpler for users.
(This used to be commit a16e4756cd68ca8aab4ffc59d4d9db0b6e44dbd1)

13 years agor3303: Call pull function for correct type instead of spoolss_PrinterInfo when
Tim Potter [Thu, 28 Oct 2004 03:58:17 +0000 (03:58 +0000)]
r3303: Call pull function for correct type instead of spoolss_PrinterInfo when
unmarshalling arrays.
(This used to be commit ee535b6801e553d0a180f18cc2c4b4438ee23de1)

13 years agor3302: The security descriptors in spoolss_PrinterInfo2 and spoolss_PrinterInfo3
Tim Potter [Thu, 28 Oct 2004 03:40:35 +0000 (03:40 +0000)]
r3302: The security descriptors in spoolss_PrinterInfo2 and spoolss_PrinterInfo3
need to be marked as subcontext(0).

GetPrinter tests now work for all info levels!
(This used to be commit 53bd02960e17f7517e0d6c4f489d27b8bdcc7582)

13 years agor3301: Simplify code
Jelmer Vernooij [Wed, 27 Oct 2004 22:41:14 +0000 (22:41 +0000)]
r3301: Simplify code
(This used to be commit dcdc6666d55c1ad006a5a4e58b337874478a66a4)

13 years agor3300: initialise *sendlen on failure, to allow for callers to check only for
Andrew Tridgell [Wed, 27 Oct 2004 21:29:55 +0000 (21:29 +0000)]
r3300: initialise *sendlen on failure, to allow for callers to check only for
(This used to be commit 80a109de8458420ac0b40c563f4b3bc51424d759)

13 years agor3295: Fix for SMB signing with 56-bit DES session keys. From Nalin Dahyabhai <nalin...
Jeremy Allison [Wed, 27 Oct 2004 17:40:41 +0000 (17:40 +0000)]
r3295: Fix for SMB signing with 56-bit DES session keys. From Nalin Dahyabhai <>.
(This used to be commit afed78f359a15809b2d9b7566e16ade294944fa9)

13 years agor3291: fix the build, thx to pipitas for finding this
Stefan Metzmacher [Wed, 27 Oct 2004 15:40:19 +0000 (15:40 +0000)]
r3291: fix the build, thx to pipitas for finding this

(This used to be commit d331a83f08b492ea463fb8781b4c46a71f80bf42)

13 years agor3290: allow SID_ANONYMOUS ( "S-1-5-7" ) to be the users sid
Stefan Metzmacher [Wed, 27 Oct 2004 13:38:30 +0000 (13:38 +0000)]
r3290: allow SID_ANONYMOUS ( "S-1-5-7" ) to be the users sid

(This used to be commit 177afd4855c66f46c82899b46f030803be63d52a)

13 years agor3289: Mr. L. and Mr. B.!
Stefan Metzmacher [Wed, 27 Oct 2004 12:59:41 +0000 (12:59 +0000)]
r3289: Mr. L. and Mr. B.!

can we decide to not break WinXP clients:-)

(This used to be commit 5eb0ff78d5e68f488a439545fdaec90c28ef877a)

13 years agor3288: - updated the path processing in pvfs to pass the RAW-CHKPATH test. This
Andrew Tridgell [Wed, 27 Oct 2004 08:36:51 +0000 (08:36 +0000)]
r3288: - updated the path processing in pvfs to pass the RAW-CHKPATH test. This
  rather extensive test reveals some really bizarre error code
  handling in w2k3.

- extended and simplified the RAW-CHKPATH test, making it easier to
  read (note that Samba3 fails the new tests - jra may wish to look)

- marked RAW-CHKPATH as pass for pvfs
(This used to be commit 32dccf91cfa5b57f84dd6307720b3f45faa10ae0)

13 years agor3287: The devicename and formname fields in a device mode are fixed length
Tim Potter [Wed, 27 Oct 2004 07:45:52 +0000 (07:45 +0000)]
r3287: The devicename and formname fields in a device mode are fixed length
strings.  Not sure how to write this as idl which maps to a char * but
at least devicemodes can be pulled off the wire sucessfully.
(This used to be commit dd20730a09935b0783b020a020ed9283ca1e4608)

13 years agor3286: filled in more missing SV_TYPE_* defines
Andrew Tridgell [Wed, 27 Oct 2004 05:30:29 +0000 (05:30 +0000)]
r3286: filled in more missing SV_TYPE_* defines
(This used to be commit 891d87a71203fcee504875976a4ee61b84579c83)

13 years agor3285: fixed another IDL typo
Andrew Tridgell [Wed, 27 Oct 2004 05:22:10 +0000 (05:22 +0000)]
r3285: fixed another IDL typo
(This used to be commit 4545ac9bfabf4af4b44cb72f30ed93273d9cdc37)

13 years agor3284: - don't use a enum for bit-fields. It isn't legal C (as C is limited to
Andrew Tridgell [Wed, 27 Oct 2004 05:20:00 +0000 (05:20 +0000)]
r3284: - don't use a enum for bit-fields. It isn't legal C (as C is limited to
  signed integer values for enum), and it is also very confusing to read.

  Also, please align defines nicely. The value of SV_TYPE_DOMAIN_ENUM
  was defined incorrectly, which became obvious when you align the
  defines, but wasn't at all obvious in the original code.

- removed redundent defines in smb.h
(This used to be commit fe042b8e5ca15dfd986bc0c05d464214a51cc0cf)

13 years agor3283: converted to quoted uuid() defines in all our IDL. This should help
Andrew Tridgell [Wed, 27 Oct 2004 04:48:41 +0000 (04:48 +0000)]
r3283: converted to quoted uuid() defines in all our IDL. This should help
the build on systems like solaris with the SunPRO compiler
(This used to be commit fe913ad11bf1c5e9fe04ed769a93b0ea16aa0a34)

13 years agor3282: some C pre-processors don't like expressions like
Andrew Tridgell [Wed, 27 Oct 2004 04:43:01 +0000 (04:43 +0000)]
r3282: some C pre-processors don't like expressions like
uuid(1ff70682-0a51-30e8-076d-740be8cee98b) so we now accept
uuid("1ff70682-0a51-30e8-076d-740be8cee98b") in pidl, and
automagically add quotes only if needed
(This used to be commit 4aab2cb210eb9678bb72aebb33dcf6fd499206c1)

13 years agor3281: some compilers can't handle empty structures, so for empty IDL
Andrew Tridgell [Wed, 27 Oct 2004 04:33:36 +0000 (04:33 +0000)]
r3281: some compilers can't handle empty structures, so for empty IDL
structures generate a single _empty_ element in the header
(This used to be commit 00ff1ca1d284bb698e98c773b18a29695e927605)

13 years agor3280: fixed byte order of rhs IP
Andrew Tridgell [Wed, 27 Oct 2004 03:50:52 +0000 (03:50 +0000)]
r3280: fixed byte order of rhs IP
(This used to be commit 29fab12d0b1649046ab2abb08b51f9845c8f8116)

13 years agor3279: Removed MSG_DONTWAIT flags as many platform don't have it.
Andrew Tridgell [Wed, 27 Oct 2004 03:45:35 +0000 (03:45 +0000)]
r3279: Removed MSG_DONTWAIT flags as many platform don't have it.

If a socket is non-blocking then adding MSG_DONTWAIT is pointless (it
does nothing), so all we lose is the ability to set non-blocking on a
packet-by-packet basis, which is not a very useful thing to have

if the socket is blocking then the code already adds MSG_WAITALL, so
MSG_DONTWAIT is also not needed in that case.
(This used to be commit b8a2afae67691a609b4a7a577fee3f9518adc9d2)

13 years agor3278: - rewrote the client side rpc connection code to use lib/socket/
Andrew Tridgell [Wed, 27 Oct 2004 03:15:42 +0000 (03:15 +0000)]
r3278: - rewrote the client side rpc connection code to use lib/socket/
  rather than doing everything itself. This greatly simplifies the
  code, although I really don't like the socket_recv() interface (it
  always allocates memory for you, which means an extra memcpy in this

- fixed several bugs in the socket_ipv4.c code, in particular client
  side code used a non-blocking connect but didn't handle EINPROGRESS,
  so it had no chance of working. Also fixed the error codes, using

- cleaned up and expanded map_nt_error_from_unix()

- changed interpret_addr2() to not take a mem_ctx. It makes absolutely
  no sense to allocate a fixed size 4 byte structure like this. Dozens
  of places in the code were also using interpret_addr2() incorrectly
  (precisely because the allocation made no sense)
(This used to be commit 7f2c771b0e0e98c5c9e5cf662592d64d34ff1205)

13 years agor3277: don't use the non-portable getaddrinfo() function, instead use
Andrew Tridgell [Wed, 27 Oct 2004 01:30:59 +0000 (01:30 +0000)]
r3277: don't use the non-portable getaddrinfo() function, instead use
interpret_addr() and if someone wants to add support to that function
for ipv6 then they are welcome to.
(This used to be commit 50377db11bb727b407744e0c50805c8f90810c16)

13 years agor3276: - allow for more than 256 open old style searches (limit currently set at...
Andrew Tridgell [Wed, 27 Oct 2004 01:11:44 +0000 (01:11 +0000)]
r3276: - allow for more than 256 open old style searches (limit currently set at an arbitrary 5000)

- auto-cleanup old searches that the client forgot to close (common with old searches)

- expanded the RAW-SEARCH test to test more than 256 old searches, and
  old search rewind (w2k3 fails this - it appears to not support rewind
  on old style searches)
(This used to be commit bc83d823b2140a10007490bf0101843a886f99a6)

13 years agor3271: use "struct messaging_context *" instead of "void *" in messaging API
Andrew Tridgell [Tue, 26 Oct 2004 22:45:33 +0000 (22:45 +0000)]
r3271: use "struct messaging_context *" instead of "void *" in messaging API
(This used to be commit cc93813e4a09c538ad485dc2b3cb4c9be34f3d18)

13 years agor3270: - added another unlink test
Andrew Tridgell [Tue, 26 Oct 2004 22:44:28 +0000 (22:44 +0000)]
r3270: - added another unlink test

- removed BASE-TRANS2 from the list of tests to be worked on (its
  already in the "passes" list)
(This used to be commit 8ba10229c3860b955de698c3e2660cf6d18e2f22)

13 years agor3269: fixed return value
Andrew Tridgell [Tue, 26 Oct 2004 22:42:43 +0000 (22:42 +0000)]
r3269: fixed return value
(This used to be commit bc392d88b1fa34edfc922f43e190da003160a7d2)

13 years agor3268: - fixed wildcard handling in new dirlist code
Andrew Tridgell [Tue, 26 Oct 2004 22:25:34 +0000 (22:25 +0000)]
r3268: - fixed wildcard handling in new dirlist code

- ensure that d_name from readdir is not used after closedir
(This used to be commit 5352613342c58192ae00618977041b98cd0ff7b6)

13 years agor3267: make LIBTDB depend on LIBREPLACE. This is needed for building the tdb tools...
Andrew Tridgell [Tue, 26 Oct 2004 21:43:34 +0000 (21:43 +0000)]
r3267: make LIBTDB depend on LIBREPLACE. This is needed for building the tdb tools on Solaris.
(This used to be commit c5d338d06137fe7464849df02671d8ab833e3b4e)

13 years agor3263: - pvfs now passes RAW-SEARCH
Andrew Tridgell [Tue, 26 Oct 2004 13:19:07 +0000 (13:19 +0000)]
r3263: - pvfs now passes RAW-SEARCH
(This used to be commit e5a0763655d8ccb929d2bf39bf099449b0dfcee7)

13 years agor3262: - new pvfs_dirlist code that reopens the directory between search
Andrew Tridgell [Tue, 26 Oct 2004 13:18:34 +0000 (13:18 +0000)]
r3262: - new pvfs_dirlist code that reopens the directory between search
  calls. This is needed to allow for "new files appear during a search"

- pvfs now passes RAW-SEARCH
(This used to be commit 0d98f7653a1d58510a6cd4c2ac6c5e05c541109c)

13 years agor3261: added seek to RAW-SEARCH test
Andrew Tridgell [Tue, 26 Oct 2004 13:16:50 +0000 (13:16 +0000)]
r3261: added seek to RAW-SEARCH test
(This used to be commit 05530bfb99011db8a00f5debcf8eec19b5e8a5d6)

13 years agor3260: redid the pvfs_dirlist() interface in preparation for a "keep
Andrew Tridgell [Tue, 26 Oct 2004 11:11:16 +0000 (11:11 +0000)]
r3260: redid the pvfs_dirlist() interface in preparation for a "keep
directory open" implementation, as opposed to the "load the whole
directory" interface used now. This will be needed to pass RAW-SEARCH
(This used to be commit 692623c6c0a2c6817fddfa77cd1c2525c27145c4)

13 years agor3259: expanded the RAW-SEARCH test some more
Andrew Tridgell [Tue, 26 Oct 2004 11:10:02 +0000 (11:10 +0000)]
r3259: expanded the RAW-SEARCH test some more
(This used to be commit cc58d249f973397bf800c9b56a5d4ab30fcda2b4)

13 years agor3258: fixed "don't change" attribute for RAW_SFILEINFO_BASIC_INFO
Andrew Tridgell [Tue, 26 Oct 2004 09:52:00 +0000 (09:52 +0000)]
r3258: fixed "don't change" attribute for RAW_SFILEINFO_BASIC_INFO
(This used to be commit 51f84800d50f44ec47a34e1c922c6197eb794558)

13 years agor3257: make the RAW-SEARCH test less sensitive to the servers directory ordering
Andrew Tridgell [Tue, 26 Oct 2004 09:50:13 +0000 (09:50 +0000)]
r3257: make the RAW-SEARCH test less sensitive to the servers directory ordering
(This used to be commit 097823bbde94da2a9d9d2afef3a4ed2715bb1f04)

13 years agor3256: get rid of the unused session_claim() and session_yield() calls
Andrew Tridgell [Tue, 26 Oct 2004 09:32:11 +0000 (09:32 +0000)]
r3256: get rid of the unused session_claim() and session_yield() calls
(This used to be commit f1c5be396b62203fb183431ea6218eed38976d0b)

13 years agor3255: - fixed 2 uninitialised data errors found with valgrind
Andrew Tridgell [Tue, 26 Oct 2004 09:31:11 +0000 (09:31 +0000)]
r3255: - fixed 2 uninitialised data errors found with valgrind

- fixed offset of setup words in nttrans reply
(This used to be commit 86b5118c2ae605560a196ee014b6134ec2928c5b)

13 years agor3254: - expanded the RAW-IOCTL test
Andrew Tridgell [Tue, 26 Oct 2004 08:41:12 +0000 (08:41 +0000)]
r3254: - expanded the RAW-IOCTL test

- fixed the old ioctl interface to not check handle before failing

- pvs now passes RAW-IOCTL
(This used to be commit 98f6dbdba46c907039951559ec5f526410fd0039)

13 years agor3253: - added rudimentary support for ntioctl in pvfs
Andrew Tridgell [Tue, 26 Oct 2004 08:35:29 +0000 (08:35 +0000)]
r3253: - added rudimentary support for ntioctl in pvfs

- catch the SIGXFSZ signal, which for some completely insane reason is
  generated in current Linux systems when you write before the maximum
  offset in a file (maximum is 2^41 on my box). Why wasn't errno good
  enough for this?

- give the right ntstatus code for large offset write failures
(This used to be commit 367f0c2af409e4292f727e8a865762a008fd7e67)

13 years agor3252: pvfs now passes BASE-TRANS2
Andrew Tridgell [Tue, 26 Oct 2004 08:33:04 +0000 (08:33 +0000)]
r3252: pvfs now passes BASE-TRANS2
(This used to be commit a024cef2d078e6bf0ebd2a9272faf2bd39e66ee7)

13 years agor3251: - move the openattr test code into basic/attr.c
Andrew Tridgell [Tue, 26 Oct 2004 08:32:16 +0000 (08:32 +0000)]
r3251: - move the openattr test code into basic/attr.c

- cleaned up the RAW-WRITE test so it passes against w2k3, and gives
  more useful error messages
(This used to be commit d4042c4364b571b9425e1706fc765376160c8a60)

13 years agor3250: Add idl for printer info level 0.
Tim Potter [Tue, 26 Oct 2004 07:17:23 +0000 (07:17 +0000)]
r3250: Add idl for printer info level 0.
(This used to be commit 68cd0b82e9a829dee0264523f2f2bdd37d479371)

13 years agor3249: - change_time is closer to ctime than mtime
Andrew Tridgell [Tue, 26 Oct 2004 07:11:49 +0000 (07:11 +0000)]
r3249: - change_time is closer to ctime than mtime

- pvfs now passes the RAW-CLOSE test
(This used to be commit 98aea91ce67a0c64a98537bfe244495f10672323)

13 years agor3248: don't stop searches on failed fill_search_info()
Andrew Tridgell [Tue, 26 Oct 2004 07:04:45 +0000 (07:04 +0000)]
r3248: don't stop searches on failed fill_search_info()
(This used to be commit 4cdd750b5cc9b26dbbaebe58b4f1c3984dac8d6c)

13 years agor3247: FILE_ATTRIBUTE_NORMAL is only a null-op for setattr and setattre, not basic_info
Andrew Tridgell [Tue, 26 Oct 2004 07:04:10 +0000 (07:04 +0000)]
r3247: FILE_ATTRIBUTE_NORMAL is only a null-op for setattr and setattre, not basic_info
(This used to be commit 36286e477c9bc7b6e268fffb123b565b6e897a44)

13 years agor3246: new files should get created with FILE_ATTRIBUTE_ARCHIVE
Andrew Tridgell [Tue, 26 Oct 2004 07:03:12 +0000 (07:03 +0000)]
r3246: new files should get created with FILE_ATTRIBUTE_ARCHIVE
(This used to be commit 090574c6982f703b124a5a123d2199be8f5b3968)

13 years agor3245: use __location__ in RAW-SEARCH
Andrew Tridgell [Tue, 26 Oct 2004 07:02:30 +0000 (07:02 +0000)]
r3245: use __location__ in RAW-SEARCH
(This used to be commit 3d5f7f4ac49227369eced4b7fe9fe3a8e5ecafbb)

13 years agor3244: pvfs now passes the RAW-UNLINK and RAW-READ tests
Andrew Tridgell [Tue, 26 Oct 2004 06:20:28 +0000 (06:20 +0000)]
r3244: pvfs now passes the RAW-UNLINK and RAW-READ tests
(This used to be commit 230ec4d980534631ff736d5319f3e94357680d85)

13 years agor3243: read the high offset count in SMBreadx in the server
Andrew Tridgell [Tue, 26 Oct 2004 06:19:50 +0000 (06:19 +0000)]
r3243: read the high offset count in SMBreadx in the server
(This used to be commit 977bc87d18d2ea8c6967bd8c1b953b09fff9b434)

13 years agor3242: make the RAW-READ test not exercise the 0-0 lock, which is not deterministic
Andrew Tridgell [Tue, 26 Oct 2004 06:18:56 +0000 (06:18 +0000)]
r3242: make the RAW-READ test not exercise the 0-0 lock, which is not deterministic
(This used to be commit ecd4e315b99a0f2aa021937308c7b93c33efbd93)

13 years agor3241: don't skip the read completely for a zero-length read, as it could give a...
Andrew Tridgell [Tue, 26 Oct 2004 06:17:52 +0000 (06:17 +0000)]
r3241: don't skip the read completely for a zero-length read, as it could give a lock conflict
(This used to be commit 7ce6139f984c72a6347c7a64d95d5278bcf3e868)

13 years agor3240: - update the rules for what error codes should be given on the
Andrew Tridgell [Tue, 26 Oct 2004 05:39:54 +0000 (05:39 +0000)]
r3240: - update the rules for what error codes should be given on the
  different type of unlink an seach mismatches

- wildcard directory listings that have attribute
  FILE_ATTRIBUTE_DIRECTORY and match "." or ".." should be failed.

- don't set the write_time on SMBclose unless it is non-zero

- added much better support for setfileinfo and setpathinfo in pvfs

- better (and more efficient) handling of .. and . components in filenames
(This used to be commit 9305b07af395a158cb9f0c1c9486f7122c79d357)

13 years agor3239: reads of more than UINT16_MAX bytes should return 0 bytes
Andrew Tridgell [Tue, 26 Oct 2004 05:36:14 +0000 (05:36 +0000)]
r3239: reads of more than UINT16_MAX bytes should return 0 bytes
(This used to be commit 16c7dd641707b6b8b3159290ca9fa08053a10692)

13 years agor3238: rename null_mtime() to the more accurate name "null_time()", and
Andrew Tridgell [Tue, 26 Oct 2004 05:35:26 +0000 (05:35 +0000)]
r3238: rename null_mtime() to the more accurate name "null_time()", and
expose it for use by the posix backend
(This used to be commit 687633b5d68c8f883a4d9cdd92c660dabc5d7cfa)

13 years agor3237: - allow for readx calls larger than 64k
Andrew Tridgell [Tue, 26 Oct 2004 05:34:35 +0000 (05:34 +0000)]
r3237: - allow for readx calls larger than 64k

- combine setattre and standard levels in setfileinfo, as they use the
  same structure
(This used to be commit e9aa1f789955533aca4fe43d5d74ffa1e8d1300b)

13 years agor3236: test a few more combinations in RAW-UNLINK
Andrew Tridgell [Tue, 26 Oct 2004 05:33:23 +0000 (05:33 +0000)]
r3236: test a few more combinations in RAW-UNLINK
(This used to be commit 5b239ad57be93fabd50760b12878e32df53e939d)

13 years agor3235: try readx beyond 64k in RAW-READ
Andrew Tridgell [Tue, 26 Oct 2004 05:32:57 +0000 (05:32 +0000)]
r3235: try readx beyond 64k in RAW-READ
(This used to be commit e07c557eca19c0dc17473090bde45c27953aaf65)

13 years agor3234: in SMBreadx, if the client asks for exactly 65535 bytes then don't try
Andrew Tridgell [Tue, 26 Oct 2004 05:32:11 +0000 (05:32 +0000)]
r3234: in SMBreadx, if the client asks for exactly 65535 bytes then don't try
to align the buffer, as that would make the read reply not fit
(This used to be commit 70be45de05993d386ceaf54325d1c3023008eaed)

13 years agor3227: added a per-share option "case insensitive filesystem", that tells the
Andrew Tridgell [Tue, 26 Oct 2004 00:59:06 +0000 (00:59 +0000)]
r3227: added a per-share option "case insensitive filesystem", that tells the
backend that the underlying filesystem is case insensitive, so it can
bypass the directory search if the name is not found.
(This used to be commit d84ade90ce7e03ec749d6ae8dcdcb41de85d836e)

13 years agor3224: add the LOCAL-* tests to
Andrew Tridgell [Mon, 25 Oct 2004 23:27:11 +0000 (23:27 +0000)]
r3224: add the LOCAL-* tests to
(This used to be commit b2bdde6d14e61f8ad9e7cbb28efb97ce1bc1ec67)

13 years agor3223: continue the effort on LIBREPLACE to try to get the ldb tools to
Andrew Tridgell [Mon, 25 Oct 2004 23:26:13 +0000 (23:26 +0000)]
r3223: continue the effort on LIBREPLACE to try to get the ldb tools to
compile on platforms like solaris without having to link to the whole
of the Samba4 lib directory.
(This used to be commit f6862bfc1cbc9278914b4b73365f63d3da0a08dd)

13 years agor3219: Hi, Andrew B.!
Volker Lendecke [Mon, 25 Oct 2004 17:23:21 +0000 (17:23 +0000)]
r3219: Hi, Andrew B.!

Not sure which Samba3 you mean, but *my* one bails out with

(This used to be commit d91659b0370a6bd5eebd5730d304b5a2cf496594)

13 years agor3218: Fix the build
Volker Lendecke [Mon, 25 Oct 2004 15:19:19 +0000 (15:19 +0000)]
r3218: Fix the build
(This used to be commit 478ba629158e8ce5e15467105b1013ba60f04ec1)

13 years agor3217: Start of a spoolss_GetPrinter test.
Tim Potter [Mon, 25 Oct 2004 13:06:31 +0000 (13:06 +0000)]
r3217: Start of a spoolss_GetPrinter test.
(This used to be commit 994fe92febe38f06d69f43b01c80e8350e902986)

13 years agor3216: Add tests for OpenPrinterEx and ClosePrinter.
Tim Potter [Mon, 25 Oct 2004 12:54:52 +0000 (12:54 +0000)]
r3216: Add tests for OpenPrinterEx and ClosePrinter.
(This used to be commit b7ff5f0deded4bcf6695dac0683fd9d271d9c255)

13 years agor3215: access_required -> access_mask for OpenPrinterEx
Tim Potter [Mon, 25 Oct 2004 12:44:53 +0000 (12:44 +0000)]
r3215: access_required -> access_mask for OpenPrinterEx
(This used to be commit 6a9e18528ca29c7f9bf093a6890e0c0e2a1c0f68)

13 years agor3214: Load the config file (required for ncacn_np:)
Jelmer Vernooij [Mon, 25 Oct 2004 11:55:13 +0000 (11:55 +0000)]
r3214: Load the config file (required for ncacn_np:)
(This used to be commit 636d209814d5b837af76acf88fa8ad5b449a0fdd)

13 years agor3213: Make credentials in a binding dialog optional
Jelmer Vernooij [Mon, 25 Oct 2004 11:47:29 +0000 (11:47 +0000)]
r3213: Make credentials in a binding dialog optional
Small fixes in gepdump
(This used to be commit a9473750f65d331c52acde58485aca66b16d1f75)

13 years agor3212: Never put a hostname in a ncalrpc binding string
Jelmer Vernooij [Mon, 25 Oct 2004 11:33:29 +0000 (11:33 +0000)]
r3212: Never put a hostname in a ncalrpc binding string
(This used to be commit 4808b2a2f749b2e4615620aa328d2d37e78e95ab)

13 years agor3211: Add a graphical endpoint mapper view tool
Jelmer Vernooij [Mon, 25 Oct 2004 11:28:09 +0000 (11:28 +0000)]
r3211: Add a graphical endpoint mapper view tool
(This used to be commit 71dfc27b8efb3057c4b7383feca0ba35ab5768a4)

13 years agor3210: split lib/replace.o into a separate build subsystem LIBREPLACE, and
Andrew Tridgell [Mon, 25 Oct 2004 10:25:25 +0000 (10:25 +0000)]
r3210: split lib/replace.o into a separate build subsystem LIBREPLACE, and
make the ldb tools depend on it. This should help the build of the ldb
tools on platforms without strnlen() or strndup()
(This used to be commit e6ddb9d8f3a218b22b0176a2525b5daaca7170e4)

13 years agor3209: - Create directory for ncalrpc with correct mode
Jelmer Vernooij [Mon, 25 Oct 2004 10:21:41 +0000 (10:21 +0000)]
r3209: - Create directory for ncalrpc with correct mode
- Support binding strings like :


(This used to be commit b53f4cd1697345065c7d979ba63237bf828dc07f)

13 years agor3208: fixed permissions of ncalrpc directory creation
Andrew Tridgell [Mon, 25 Oct 2004 09:41:24 +0000 (09:41 +0000)]
r3208: fixed permissions of ncalrpc directory creation
(This used to be commit adbfd206f4e077ed915a014e89a970470b43e125)

13 years agor3207: - reformat error msgs in BASE-DIR* tests
Andrew Tridgell [Mon, 25 Oct 2004 07:58:47 +0000 (07:58 +0000)]
r3207: - reformat error msgs in BASE-DIR* tests

- added support for mandatory attributes in old style directory search

- we now pass BASE-DIR1 and BASE-DIR2
(This used to be commit efaa0eaec49e952aa515c3448246d9048a484c26)

13 years agor3206: - added the reverse map for ERRbaduid to NT_STATUS_INVALID_HANDLE
Andrew Tridgell [Mon, 25 Oct 2004 07:56:48 +0000 (07:56 +0000)]
r3206: - added the reverse map for ERRbaduid to NT_STATUS_INVALID_HANDLE

- force disable spnego in the RAW-CONTEXT test (it breaks the test)
(This used to be commit 3f247ec21c59af92b420a3e550552b5a1f1f08e2)

13 years agor3205: Create ncalrpc directory if it didn't exist yet
Jelmer Vernooij [Mon, 25 Oct 2004 07:55:08 +0000 (07:55 +0000)]
r3205: Create ncalrpc directory if it didn't exist yet
(This used to be commit 1161c33794cdb16a3d09a66258f46e0020c4aeef)

13 years agor3204: Got unpacking of an array of PrinterInfo union elements working. Phew.
Tim Potter [Mon, 25 Oct 2004 07:31:59 +0000 (07:31 +0000)]
r3204: Got unpacking of an array of PrinterInfo union elements working.  Phew.
(This used to be commit f490cd719cc02589e73e26fa983aff90708d1926)

13 years agor3203: moved more test functions into torture/basic/*.c
Andrew Tridgell [Mon, 25 Oct 2004 07:24:46 +0000 (07:24 +0000)]
r3203: moved more test functions into torture/basic/*.c

the idea is that torture/torture.c should eventually be just the
harness code, which will make it easier to read
(This used to be commit eca85d26ed744563d1bbb8dd10a819d39fdc495b)

13 years agor3202: return a old DOS error code ERRSRV:ERRbaduid for a bad vuid. This means we...
Andrew Tridgell [Mon, 25 Oct 2004 07:11:12 +0000 (07:11 +0000)]
r3202: return a old DOS error code ERRSRV:ERRbaduid for a bad vuid. This means we now pass the BASE-VUID test.
(This used to be commit 560300c0025940d84c9be41447145f4b441e7105)

13 years agor3201: we now pass the BASE-OPEN test
Andrew Tridgell [Mon, 25 Oct 2004 07:04:03 +0000 (07:04 +0000)]
r3201: we now pass the BASE-OPEN test
(This used to be commit 3a150ab57e18ac5180d48c7edff8a5bc288c39c5)

13 years agor3200: - improved the accuracy of openx emulation. We now nearly pass the openx porti...
Andrew Tridgell [Mon, 25 Oct 2004 07:03:15 +0000 (07:03 +0000)]
r3200: - improved the accuracy of openx emulation. We now nearly pass the openx portion of RAW-OPEN

- fixed directory size reporting to make it consistent. we now pass
  the ntcreatex portion of RAW-OPEN
(This used to be commit 6282e5811b8d4f1c17152d86875ac60d1323779d)

13 years agor3199: added a couple more test paths to RAW-CHKPATH
Andrew Tridgell [Mon, 25 Oct 2004 07:01:45 +0000 (07:01 +0000)]
r3199: added a couple more test paths to RAW-CHKPATH
(This used to be commit 17f10a39c858a5a6e128f3f827d83687c5ba7d90)