bbaumbach/samba-autobuild/.git
3 weeks agos3-libads: use ldap_init_fd() to initialize a ldap session if possible master
Björn Baumbach [Wed, 3 Jun 2020 17:40:59 +0000 (19:40 +0200)]
s3-libads: use ldap_init_fd() to initialize a ldap session if possible

Use the known ip address of the ldap server to open the connection and
initialize the ldap session with ldap_init_fd().

This avoid unnecessary DNS lookups which might block or prevent the
successful connection.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13124

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
3 weeks agoRevert "s3:libsmb: add a cache for cli_session_creds_prepare_krb5()"
Andreas Schneider [Wed, 10 Jun 2020 07:47:51 +0000 (09:47 +0200)]
Revert "s3:libsmb: add a cache for cli_session_creds_prepare_krb5()"

This reverts commit b458f8fbb7febf3584fa648128b4e1dc764059f7.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Jun 10 10:10:16 UTC 2020 on sn-devel-184

3 weeks agoAdd docs build to CI
Andrew Bartlett [Wed, 3 Jun 2020 00:33:50 +0000 (12:33 +1200)]
Add docs build to CI

We did not check we could actually build the HTML of the
Samba Developers guide and HTML of the manpages previously.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Jun 10 07:11:59 UTC 2020 on sn-devel-184

3 weeks agodocs-xml: Remove GNU TexInfo build
Andrew Bartlett [Wed, 3 Jun 2020 00:21:50 +0000 (12:21 +1200)]
docs-xml: Remove GNU TexInfo build

This does not build and is not a common or required format for
documentation any more.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
3 weeks agodocs-xml: Remove references to inkscape (not used any more, no more SVG files)
Andrew Bartlett [Wed, 3 Jun 2020 00:14:38 +0000 (12:14 +1200)]
docs-xml: Remove references to inkscape (not used any more, no more SVG files)

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
3 weeks agodocs-xml: Remove final references to Samba3-HOWTO and Samba3-ByExample
Andrew Bartlett [Wed, 3 Jun 2020 00:09:33 +0000 (12:09 +1200)]
docs-xml: Remove final references to Samba3-HOWTO and Samba3-ByExample

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
3 weeks agodocs-xml: Remove references to building docs using Plucker
Andrew Bartlett [Wed, 3 Jun 2020 00:08:01 +0000 (12:08 +1200)]
docs-xml: Remove references to building docs using Plucker

This was for Palm OS based handheld devices, Windows Mobile devices, and other PDAs...

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
3 weeks agoRemove "undocumented" target mentioned in configure script
Andrew Bartlett [Tue, 2 Jun 2020 23:55:45 +0000 (11:55 +1200)]
Remove "undocumented" target mentioned in configure script

This was left over from 12aed897ec688d5bc379690208e8b85158b8227f

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
3 weeks agoutil: Reallocate larger buffer if getpwuid_r() returns ERANGE
Martin Schwenke [Fri, 5 Jun 2020 12:05:42 +0000 (22:05 +1000)]
util: Reallocate larger buffer if getpwuid_r() returns ERANGE

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Tue Jun  9 21:07:24 UTC 2020 on sn-devel-184

3 weeks agoutil: Fix build on FreeBSD by avoiding NSS_BUFLEN_PASSWD
Martin Schwenke [Fri, 5 Jun 2020 11:52:23 +0000 (21:52 +1000)]
util: Fix build on FreeBSD by avoiding NSS_BUFLEN_PASSWD

NSS_BUFLEN_PASSWD is not defined on FreeBSD.  Use
sysconf(_SC_GETPW_R_SIZE_MAX) instead, as per POSIX.

Use a dynamically allocated buffer instead of trying to cram all of
the logic into the declarations.  This will come in useful later
anyway.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agoutil: Simplify input validation
Martin Schwenke [Tue, 9 Jun 2020 01:52:50 +0000 (11:52 +1000)]
util: Simplify input validation

It appears that snprintf(3) is being used for input validation.
However, this seems like overkill because it causes szPath to be
copied an extra time.  The mostly likely protections being sought
here, according to https://cwe.mitre.org/data/definitions/20.html,
look to be DoS attacks involving CPU and memory usage.  A simpler
check that uses strnlen(3) can mitigate against both of these and is
simpler.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3:libads: remove unused "GSSAPI" support
Stefan Metzmacher [Fri, 8 Nov 2019 11:22:53 +0000 (12:22 +0100)]
s3:libads: remove unused "GSSAPI" support

All AD servers support "GSS-SPNEGO". So we better
remove code that doesn't use gensec.

If we ever need this back we could use the
"gssapi_krb5_sasl" gensec module explicit
or just pass the SASL mech list to gensec.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Jun  9 17:24:31 UTC 2020 on sn-devel-184

3 weeks agotalloc: Mark ptr of talloc_unlink() not as a tainted scalar
Andreas Schneider [Tue, 9 Jun 2020 15:00:24 +0000 (17:00 +0200)]
talloc: Mark ptr of talloc_unlink() not as a tainted scalar

This should address a lot of issues reported by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3:libsmb: add a cache for cli_session_creds_prepare_krb5()
Stefan Metzmacher [Wed, 7 Aug 2019 10:11:58 +0000 (12:11 +0200)]
s3:libsmb: add a cache for cli_session_creds_prepare_krb5()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos4:torture:smb2: use delete-on-close in test_rw_invalid()
Stefan Metzmacher [Tue, 2 Jun 2020 11:52:23 +0000 (13:52 +0200)]
s4:torture:smb2: use delete-on-close in test_rw_invalid()

We test the limits here and leave a 16TB file with zeros.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14361

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Jun  5 13:17:55 UTC 2020 on sn-devel-184

3 weeks agopysmbd: make sure that session unix info is filled
Björn Baumbach [Tue, 2 Jun 2020 13:33:36 +0000 (15:33 +0200)]
pysmbd: make sure that session unix info is filled

Bug: https://bugzilla.samba.org/show_bug.cgi?id=14400

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Fri Jun  5 11:54:06 UTC 2020 on sn-devel-184

3 weeks agotests/pysmbd: fill session unix info in ntacl tests
Björn Baumbach [Thu, 4 Jun 2020 11:51:30 +0000 (13:51 +0200)]
tests/pysmbd: fill session unix info in ntacl tests

Valid unix info is required.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=14400

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 weeks agopython/samba/provision: set unix session info for user session, used for sysvol acl...
Björn Baumbach [Thu, 4 Jun 2020 14:02:24 +0000 (16:02 +0200)]
python/samba/provision: set unix session info for user session, used for sysvol acl reset

The unix session info is required and expected by e.g. many vfs
modules. Missing unix session info leads to samba panic.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=14400

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 weeks agopyauth: add python binding for auth_session_info_set_unix()
Björn Baumbach [Thu, 4 Jun 2020 14:00:04 +0000 (16:00 +0200)]
pyauth: add python binding for auth_session_info_set_unix()

Bug: https://bugzilla.samba.org/show_bug.cgi?id=14400

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 weeks agos4-auth/unix_token: add new function auth_session_info_set_unix()
Björn Baumbach [Thu, 4 Jun 2020 13:41:34 +0000 (15:41 +0200)]
s4-auth/unix_token: add new function auth_session_info_set_unix()

Used to fill the unix info in a struct auth_session_info similar to
auth_session_info_fill_unix().

The new auth_session_info_set_unix() receives the uid and gid for
the unix token as an parameter. It does not query the unix token from
winbind (via security_token_to_unix_token()).
This is useful to fill a user session info manually if winbind is not
available.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=14400

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 weeks agos4-auth/unix_token: separate out filling the unix_info elements in a struct session_info
Björn Baumbach [Thu, 4 Jun 2020 13:39:02 +0000 (15:39 +0200)]
s4-auth/unix_token: separate out filling the unix_info elements in a struct session_info

Bug: https://bugzilla.samba.org/show_bug.cgi?id=14400

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 weeks agopython: fix slow's mail address
Björn Baumbach [Fri, 29 May 2020 14:05:10 +0000 (16:05 +0200)]
python: fix slow's mail address

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
3 weeks agolibsmb: Remove unused cli_smb2_qfileinfo_basic()
Volker Lendecke [Thu, 4 Jun 2020 13:29:48 +0000 (15:29 +0200)]
libsmb: Remove unused cli_smb2_qfileinfo_basic()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Jun  4 18:36:17 UTC 2020 on sn-devel-184

3 weeks agolibsmb: Use cli_qfileinfo_basic() in cli_smb2_qpathinfo2()
Volker Lendecke [Thu, 4 Jun 2020 13:26:31 +0000 (15:26 +0200)]
libsmb: Use cli_qfileinfo_basic() in cli_smb2_qpathinfo2()

Last user of cli_smb2_qfileinfo_basic().

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 weeks agotorture3: Fix a debug message
Volker Lendecke [Thu, 4 Jun 2020 13:25:14 +0000 (15:25 +0200)]
torture3: Fix a debug message

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 weeks agolibsmb: Remove unused cli_smb2_getattrE()
Volker Lendecke [Thu, 4 Jun 2020 13:23:45 +0000 (15:23 +0200)]
libsmb: Remove unused cli_smb2_getattrE()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 weeks agolibsmb: Use cli_qfileinfo_basic() in cli_smb2_getatr()
Volker Lendecke [Thu, 4 Jun 2020 13:22:04 +0000 (15:22 +0200)]
libsmb: Use cli_qfileinfo_basic() in cli_smb2_getatr()

This was the only remaining user of cli_smb2_getattrE(), and as
cli_qfileinfo_basic() now does all protocols, we can get rid of
cli_smb2_getattrE().

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 weeks agopylibsmb: Use cli_qfileinfo_basic_send() in py_smb_filesize()
Volker Lendecke [Thu, 4 Jun 2020 13:16:26 +0000 (15:16 +0200)]
pylibsmb: Use cli_qfileinfo_basic_send() in py_smb_filesize()

This now does all protocols asynchronously

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 weeks agolibsmb: Make qfileinfo_basic available for smb2 in async mode
Volker Lendecke [Thu, 4 Jun 2020 13:11:24 +0000 (15:11 +0200)]
libsmb: Make qfileinfo_basic available for smb2 in async mode

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 weeks agolibsmb: Remove unused sync version of cli_getattrE()
Volker Lendecke [Thu, 4 Jun 2020 06:45:37 +0000 (08:45 +0200)]
libsmb: Remove unused sync version of cli_getattrE()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 weeks agolibsmb: Remove cli_getattrE() fallback from cli_qfileinfo_basic() users
Volker Lendecke [Thu, 4 Jun 2020 06:43:49 +0000 (08:43 +0200)]
libsmb: Remove cli_getattrE() fallback from cli_qfileinfo_basic() users

cli_qfileinfo_basic() now takes care of this centrally

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 weeks agolibsmb: Use SMBgetattrE in cli_qfileinfo_basic_send() if necessary
Volker Lendecke [Thu, 4 Jun 2020 06:38:31 +0000 (08:38 +0200)]
libsmb: Use SMBgetattrE in cli_qfileinfo_basic_send() if necessary

This is a behaviour change: Before this patch, independent of the actual
protocol we tried to do the trans2 getinfo call. All the remaining callers just
do a direct fallback to SMBgetattrE when that fails without even looking at the
error code. Here we deterministically decide after the negotiated protocol
which flavour to use without a fallback.

It *might* be relevant for very old embedded systems that we don't know, but if
we break something we can easily fix it.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 weeks agonet: Align integer types, move variable closer to its use
Volker Lendecke [Tue, 2 Jun 2020 13:44:12 +0000 (15:44 +0200)]
net: Align integer types, move variable closer to its use

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 weeks agonet: Copy hires timestamps in net_copy_fileattr()
Volker Lendecke [Wed, 3 Jun 2020 15:56:53 +0000 (17:56 +0200)]
net: Copy hires timestamps in net_copy_fileattr()

In this routine we're using cli_ntcreate, so I would assume the hires
timestamp calls to be available. My goal is to reduce the use of the
second-resolution calls and potentially push their fallback use into
clifile.c.

Only tested manually.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 weeks agotorture3: Use cli_qfileinfo_basic() in run_posix_append()
Volker Lendecke [Thu, 28 May 2020 16:56:22 +0000 (18:56 +0200)]
torture3: Use cli_qfileinfo_basic() in run_posix_append()

Only Samba does the SMB1 posix extensions, and we do the "advanced"
trans-based call.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 weeks agolibsmb: Add async cli_qfileinfo_basic
Volker Lendecke [Thu, 28 May 2020 16:24:17 +0000 (18:24 +0200)]
libsmb: Add async cli_qfileinfo_basic

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 weeks agos3: client. Move to all 32-bit attributes in smbclient.
Jeremy Allison [Wed, 3 Jun 2020 21:25:50 +0000 (14:25 -0700)]
s3: client. Move to all 32-bit attributes in smbclient.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: torture: Add simple tests to samba3.base.attr to check INVALID_PARAMETER returned...
Jeremy Allison [Thu, 4 Jun 2020 04:23:21 +0000 (21:23 -0700)]
s3: torture: Add simple tests to samba3.base.attr to check INVALID_PARAMETER returned on SMB1 out-of-range attribute use.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: libsmb: cli_setatr() and async version. Don't allow attribtes > 16 bits on an...
Jeremy Allison [Thu, 4 Jun 2020 04:11:25 +0000 (21:11 -0700)]
s3: libsmb: cli_setatr() and async version. Don't allow attribtes > 16 bits on an old protocol send.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: libsmb: cli_unlink() and async version. Don't allow attribtes > 16 bits on an...
Jeremy Allison [Thu, 4 Jun 2020 04:07:33 +0000 (21:07 -0700)]
s3: libsmb: cli_unlink() and async version. Don't allow attribtes > 16 bits on an old protocol send.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: libsmb: Change cli_unlink() and async version to take a uint32_t attribute.
Jeremy Allison [Thu, 4 Jun 2020 04:03:39 +0000 (21:03 -0700)]
s3: libsmb: Change cli_unlink() and async version to take a uint32_t attribute.

Fix the callers.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: libsmb: Change cli_setfileinfo_ext() and async version to take a uint32_t attr.
Jeremy Allison [Thu, 4 Jun 2020 03:58:06 +0000 (20:58 -0700)]
s3: libsmb: Change cli_setfileinfo_ext() and async version to take a uint32_t attr.

Fix all callers.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: libsmb: Change cli_setpathinfo_ext() to take 32-bit attributes.
Jeremy Allison [Thu, 4 Jun 2020 03:48:23 +0000 (20:48 -0700)]
s3: libsmb: Change cli_setpathinfo_ext() to take 32-bit attributes.

Fix the callers. Note the special casing of mapping (uint16)-1 -> (uint32_t)-1
in SMBC_setatr() where we can't change the ABI.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: libsmb: Change cli_setatr() and async version to use 32-bit attributes.
Jeremy Allison [Wed, 3 Jun 2020 21:12:38 +0000 (14:12 -0700)]
s3: libsmb: Change cli_setatr() and async version to use 32-bit attributes.

Fix the callers. Only sets 16 bits on the wire for this level.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: libsmb: Make cli_list_trans() and cli_list take a 32-bit attribute.
Jeremy Allison [Wed, 3 Jun 2020 21:07:21 +0000 (14:07 -0700)]
s3: libsmb: Make cli_list_trans() and cli_list take a 32-bit attribute.

All sub-functions take 32-bits, and all callers now are
compatible with 32-bit attributes.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: libsmb: Make cli_list_old() take 32-bit attribute.
Jeremy Allison [Wed, 3 Jun 2020 20:56:37 +0000 (13:56 -0700)]
s3: libsmb: Make cli_list_old() take 32-bit attribute.

Only uses 16 on the wire. No change needed in callers.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: libsmb: Change cli_smb2_setatr() to use 32-bit attributes.
Jeremy Allison [Wed, 3 Jun 2020 20:50:57 +0000 (13:50 -0700)]
s3: libsmb: Change cli_smb2_setatr() to use 32-bit attributes.

The SMB_SET_FILE_BASIC_INFO info level this uses in SMB2
sets 32-bit attributes, so don't use SSVAL, use SIVAL.

No change needed in callers as implicit casts work fine.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: Fix dfs-reparse testing code to use 32-bit attributes. Change variable names...
Jeremy Allison [Wed, 3 Jun 2020 20:44:55 +0000 (13:44 -0700)]
s3: Fix dfs-reparse testing code to use 32-bit attributes. Change variable names mode -> attr.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: libsmb: Change cli_qpathinfo1() and async version to return a 32-bit attribute.
Jeremy Allison [Wed, 3 Jun 2020 20:42:58 +0000 (13:42 -0700)]
s3: libsmb: Change cli_qpathinfo1() and async version to return a 32-bit attribute.

Only used in torture.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: libsmb: Change cli_qpathinfo3() to return a 32-bit attribute.
Jeremy Allison [Wed, 3 Jun 2020 20:36:05 +0000 (13:36 -0700)]
s3: libsmb: Change cli_qpathinfo3() to return a 32-bit attribute.

Fix all callers.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: libsmb: Change cli_qpathinfo2() and async versions to return a 32-bit attribute.
Jeremy Allison [Wed, 3 Jun 2020 20:28:04 +0000 (13:28 -0700)]
s3: libsmb: Change cli_qpathinfo2() and async versions to return a 32-bit attribute.

Fix all callers.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: libsmb: Change cli_getatr() and async versions to return a 32-bit attribute.
Jeremy Allison [Wed, 3 Jun 2020 20:15:17 +0000 (13:15 -0700)]
s3: libsmb: Change cli_getatr() and async versions to return a 32-bit attribute.

Fix all callers.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: libsmb: Rename uint16_t attr -> sattr (short attributes).
Jeremy Allison [Wed, 3 Jun 2020 20:09:43 +0000 (13:09 -0700)]
s3: libsmb: Rename uint16_t attr -> sattr (short attributes).

This will make it easier to add 32-bit attr value later.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: libsmb: Change cli_getattrE() and async versions to return a 32-bit attribute.
Jeremy Allison [Wed, 3 Jun 2020 20:00:56 +0000 (13:00 -0700)]
s3: libsmb: Change cli_getattrE() and async versions to return a 32-bit attribute.

Fix all callers.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: libsmb: Change cli_qfileinfo_basic() to return 32-bit attributes.
Jeremy Allison [Wed, 3 Jun 2020 19:54:10 +0000 (12:54 -0700)]
s3: libsmb: Change cli_qfileinfo_basic() to return 32-bit attributes.

Fix all callers.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: libsmb: Change cli_smb2_qpathinfo2() to return a 32 bit attribute.
Jeremy Allison [Wed, 3 Jun 2020 19:17:30 +0000 (12:17 -0700)]
s3: libsmb: Change cli_smb2_qpathinfo2() to return a 32 bit attribute.

Fix all callers. All libsmb SMB2 calls now return 32 bit attributes.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: libsmb: Fix cli_smb2_getatr() to return a 32 bit attribute.
Jeremy Allison [Wed, 3 Jun 2020 19:13:33 +0000 (12:13 -0700)]
s3: libsmb: Fix cli_smb2_getatr() to return a 32 bit attribute.

Fix all callers.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: libsmb: Change cli_smb2_getattrE() to return 32 bit attributes.
Jeremy Allison [Wed, 3 Jun 2020 19:07:05 +0000 (12:07 -0700)]
s3: libsmb: Change cli_smb2_getattrE() to return 32 bit attributes.

Fix all callers.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: libsmb: Change cli_smb2_qfileinfo_basic() and all users to return a uint32_t...
Jeremy Allison [Wed, 3 Jun 2020 18:57:39 +0000 (11:57 -0700)]
s3: libsmb: Change cli_smb2_qfileinfo_basic() and all users to return a uint32_t attribute.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: smbclient: Rename mode parameter to attr.
Jeremy Allison [Wed, 3 Jun 2020 20:32:55 +0000 (13:32 -0700)]
s3: smbclient: Rename mode parameter to attr.

This is a DOS attribute, not a UNIX mode.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: libsmb: clifile.c: Rename all uint16_t *attr parameters to uint16_t *pattr.
Jeremy Allison [Wed, 3 Jun 2020 19:03:38 +0000 (12:03 -0700)]
s3: libsmb: clifile.c: Rename all uint16_t *attr parameters to uint16_t *pattr.

Will make it easier to move to 32 bit attributes later.

No logic changes, just a rename.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: libsmb: clirap. Rename all mode/ *mode parameters to attr and pattr.
Jeremy Allison [Wed, 3 Jun 2020 18:01:36 +0000 (11:01 -0700)]
s3: libsmb: clirap. Rename all mode/ *mode parameters to attr and pattr.

They are attributes, not unix modes.

Once they have the right name, we can start moving all uses to uint32_t.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: libsmb: cli_smb2_qfileinfo_basic()/cli_smb2_qpathinfo2(). Rename a parameter...
Jeremy Allison [Wed, 3 Jun 2020 17:52:49 +0000 (10:52 -0700)]
s3: libsmb: cli_smb2_qfileinfo_basic()/cli_smb2_qpathinfo2(). Rename a parameter from mode -> pattr.

Also rename attr pointers to pattr.

They are pointers to attributes.

Only parameter name changes, no logic changes.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: libsmb: Change size of finfo->attr to uint32_t.
Jeremy Allison [Wed, 3 Jun 2020 17:48:10 +0000 (10:48 -0700)]
s3: libsmb: Change size of finfo->attr to uint32_t.

That's what modern servers return.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: libsmb: SMBC_chmod_ctx(), rename mode -> attr when setting attributes.
Jeremy Allison [Thu, 4 Jun 2020 04:15:43 +0000 (21:15 -0700)]
s3: libsmb: SMBC_chmod_ctx(), rename mode -> attr when setting attributes.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: libsmb: Internally rename to use the name attr instead of mode for attributes.
Jeremy Allison [Wed, 3 Jun 2020 20:07:41 +0000 (13:07 -0700)]
s3: libsmb: Internally rename to use the name attr instead of mode for attributes.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: libsmb: Internally rename to use the name attr instead of mode for attributes.
Jeremy Allison [Wed, 3 Jun 2020 19:46:26 +0000 (12:46 -0700)]
s3: libsmb: Internally rename to use the name attr instead of mode for attributes.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agos3: libsmb: In struct file_info rename mode -> attr.
Jeremy Allison [Wed, 3 Jun 2020 17:41:27 +0000 (10:41 -0700)]
s3: libsmb: In struct file_info rename mode -> attr.

Cleanup.  It's never been a UNIX mode, always a DOS attribute field.
Make that explicit.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
3 weeks agoexamples: clifuse: Info level SMB_FIND_FILE_BOTH_DIRECTORY_INFO encodes attibutes...
Jeremy Allison [Wed, 3 Jun 2020 17:29:24 +0000 (10:29 -0700)]
examples: clifuse: Info level SMB_FIND_FILE_BOTH_DIRECTORY_INFO encodes attibutes as a uint32, not a uint8.

Cast to a uint16_t for now after pulling the information
as finfo->mode is currently only 16 bits.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
4 weeks agoUpdate SECURITY.md to point to security releases
Andrew Bartlett [Tue, 2 Jun 2020 21:46:30 +0000 (21:46 +0000)]
Update SECURITY.md to point to security releases

Signed-off-by: Andrew Bartlet <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Jun  3 15:55:10 UTC 2020 on sn-devel-184

4 weeks agos3: VFS: default. Ensure read_dfs_pathat() returns stat info.
Jeremy Allison [Sat, 30 May 2020 00:56:58 +0000 (17:56 -0700)]
s3: VFS: default. Ensure read_dfs_pathat() returns stat info.

Remove the knownfail.d/msdfs-attr file.

Everything now passes.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14391

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Jun  3 06:19:21 UTC 2020 on sn-devel-184

4 weeks agos3: VFS: shadow_copy2. Ensure read_dfs_pathat() returns stat info.
Jeremy Allison [Sat, 30 May 2020 00:52:51 +0000 (17:52 -0700)]
s3: VFS: shadow_copy2. Ensure read_dfs_pathat() returns stat info.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14391

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 weeks agos3: VFS: gluster. Ensure read_dfs_pathat() returns stat info.
Jeremy Allison [Sat, 30 May 2020 00:49:17 +0000 (17:49 -0700)]
s3: VFS: gluster. Ensure read_dfs_pathat() returns stat info.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14391

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 weeks agos3: VFS: ceph. Ensure read_dfs_pathat() returns stat info.
Jeremy Allison [Sat, 30 May 2020 00:35:06 +0000 (17:35 -0700)]
s3: VFS: ceph. Ensure read_dfs_pathat() returns stat info.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14391

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 weeks agos3: VFS: catia. Ensure read_dfs_pathat() returns stat info.
Jeremy Allison [Fri, 29 May 2020 23:38:53 +0000 (16:38 -0700)]
s3: VFS: catia. Ensure read_dfs_pathat() returns stat info.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14391

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 weeks agos3: VFS: cap. Ensure read_dfs_pathat() returns stat info.
Jeremy Allison [Fri, 29 May 2020 23:36:55 +0000 (16:36 -0700)]
s3: VFS: cap. Ensure read_dfs_pathat() returns stat info.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14391

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 weeks agos3: VFS: Change the function signature for SMB_VFS_READ_DFS_PATHAT() to take a non...
Jeremy Allison [Fri, 29 May 2020 23:32:12 +0000 (16:32 -0700)]
s3: VFS: Change the function signature for SMB_VFS_READ_DFS_PATHAT() to take a non-const smb_filename.

Otherwise there's no good way to return proper stat(2) information
for a DFS link without making assumptions it's a symlink store.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14391

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 weeks agos3: torture: Add test for getting attibutes on an MSDFS link.
Jeremy Allison [Mon, 1 Jun 2020 20:45:28 +0000 (13:45 -0700)]
s3: torture: Add test for getting attibutes on an MSDFS link.

Mark as knownfail for now.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14391

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 weeks agos3: torture: Add a MSDFS-ATTRIBUTE test.
Jeremy Allison [Mon, 1 Jun 2020 19:08:17 +0000 (12:08 -0700)]
s3: torture: Add a MSDFS-ATTRIBUTE test.

Framework to drive comes next.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14391

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 weeks agos3: libsmb: Info level SMB_FIND_EA_SIZE encodes attibutes as a uint16, not a uint8.
Jeremy Allison [Mon, 1 Jun 2020 18:33:13 +0000 (11:33 -0700)]
s3: libsmb: Info level SMB_FIND_EA_SIZE encodes attibutes as a uint16, not a uint8.

We will need this to detect FILE_ATTRIBUTE_REPARSE_POINT in a later commit.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14391

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 weeks agos3: libsmb: Info level SMB_FIND_INFO_STANDARD encodes attibutes as a uint16, not...
Jeremy Allison [Mon, 1 Jun 2020 19:01:13 +0000 (12:01 -0700)]
s3: libsmb: Info level SMB_FIND_INFO_STANDARD encodes attibutes as a uint16, not a uint8.

We will need this to detect FILE_ATTRIBUTE_REPARSE_POINT in a later commit.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14391

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 weeks agos3: libsmb: Info level SMB_FIND_FILE_BOTH_DIRECTORY_INFO encodes attibutes as a uint3...
Jeremy Allison [Mon, 1 Jun 2020 18:36:03 +0000 (11:36 -0700)]
s3: libsmb: Info level SMB_FIND_FILE_BOTH_DIRECTORY_INFO encodes attibutes as a uint32, not a uint8.

Cast to a uint16_t for now after pulling the information
as finfo->mode is currently only 16 bits.

We will need this to detect FILE_ATTRIBUTE_REPARSE_POINT in a later commit.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14391

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 weeks agos3: libsmb: Info level SMB2_FIND_ID_BOTH_DIRECTORY_INFO encodes attibutes as a uint32...
Jeremy Allison [Mon, 1 Jun 2020 20:55:10 +0000 (13:55 -0700)]
s3: libsmb: Info level SMB2_FIND_ID_BOTH_DIRECTORY_INFO encodes attibutes as a uint32, not a uint8.

Fix the SMB2 parsing code.

Cast to a uint16_t for now after pulling the information
as finfo->mode is currently only 16 bits.

We will need this to detect FILE_ATTRIBUTE_REPARSE_POINT in a later commit.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 weeks agos3/rpc_server: remove unnecessary srv_fss_agent.h header
David Disseldorp [Thu, 28 May 2020 16:40:26 +0000 (18:40 +0200)]
s3/rpc_server: remove unnecessary srv_fss_agent.h header

The srv_fssa_start() / _cleanup() functions are called via the
DCESRV_INTERFACE_FILESERVERVSSAGENT_INIT / SHUTDOWN_SERVER hooks,
so needn't be public.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Reviewed-by: Samuel Cabrero <scabrero@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Jun  3 03:57:12 UTC 2020 on sn-devel-184

4 weeks agosmbd: simplify uid_entry_in_group()
Ralph Boehme [Tue, 21 Jan 2020 11:05:59 +0000 (12:05 +0100)]
smbd: simplify uid_entry_in_group()

conn->session_info is always valid since
1fa05e5c76e718142326915f8671299217a093df and preceeding commits.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat May 30 02:40:22 UTC 2020 on sn-devel-184

4 weeks agolibcli: simplify an if condition
Ralph Boehme [Tue, 21 Jan 2020 10:56:18 +0000 (11:56 +0100)]
libcli: simplify an if condition

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 weeks agos3:auth: fill in info3 domain name in passwd_to_SamInfo3()
Ralph Boehme [Fri, 13 Dec 2019 11:14:04 +0000 (12:14 +0100)]
s3:auth: fill in info3 domain name in passwd_to_SamInfo3()

This is needed for make_session_info_from_username() to fill in the domain
name. The callchain goes like this:

make_session_info_from_username()
-> make_server_info_pw()
-> passwd_to_SamInfo3()

Other callers of passwd_to_SamInfo3() are also affected. A subsequent change
will let set_conn_force_user_group() user the domainname from the session_info
returned from make_session_info_from_username() to create substitution
context. Without this fix domain name would be NULL.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 weeks agosmbd: RIP conn->origpath
Ralph Boehme [Tue, 7 Apr 2020 07:56:51 +0000 (09:56 +0200)]
smbd: RIP conn->origpath

conn->origpath is always a duplicate of conn->connectpath.

The only function that sets conn->connectpath is set_conn_connectpath() and
everywhere it's called, there's a subsequent talloc_strdup() into
conn->origpath.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 weeks agosmbd: avoid become_user_without_service() in close_directory()
Ralph Boehme [Tue, 7 Apr 2020 07:55:35 +0000 (09:55 +0200)]
smbd: avoid become_user_without_service() in close_directory()

Here we called become_user_without_service() just in order to be able to fetch
the nt_token and unix_token subsequently via get_current_[nt|u]tok(conn). The
same can be achieved by fetching the session_info with
smbXsrv_session_info_lookup().

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 weeks agosmbd: avoid become_user_without_service() in close_remove_share_mode()
Ralph Boehme [Tue, 7 Apr 2020 07:54:24 +0000 (09:54 +0200)]
smbd: avoid become_user_without_service() in close_remove_share_mode()

Here we called become_user_without_service() just in order to be able to fetch
the nt_token and unix_token subsequently via
get_current_[nt|u]tok(conn). The same can be achieved by fetching the
session_info with smbXsrv_session_info_lookup().

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 weeks agosmbd: don't free smb_fname_parent in unix_mode()
Ralph Boehme [Fri, 29 May 2020 09:44:28 +0000 (11:44 +0200)]
smbd: don't free smb_fname_parent in unix_mode()

The TALLOC_FREEs should have been removed as part of
45a560bce3ef06c211e60e3932521303cc396896. Sorry!

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri May 29 20:02:55 UTC 2020 on sn-devel-184

4 weeks agosmbd: remove dead code
Ralph Boehme [Fri, 29 May 2020 09:27:35 +0000 (11:27 +0200)]
smbd: remove dead code

LINKS_READ_ONLY is not defined anywhere since ages.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 weeks agoAdd net-ads-join dnshostname=fqdn option
Isaac Boukris [Wed, 27 May 2020 13:54:12 +0000 (15:54 +0200)]
Add net-ads-join dnshostname=fqdn option

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14396

Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri May 29 13:33:28 UTC 2020 on sn-devel-184

4 weeks agoAdd msDS-AdditionalDnsHostName entries to the keytab
Isaac Boukris [Wed, 27 May 2020 13:36:28 +0000 (15:36 +0200)]
Add msDS-AdditionalDnsHostName entries to the keytab

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14396

Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
4 weeks agoAdd a test for msDS-AdditionalDnsHostName entries in keytab
Isaac Boukris [Wed, 27 May 2020 15:55:12 +0000 (17:55 +0200)]
Add a test for msDS-AdditionalDnsHostName entries in keytab

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14396

Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
4 weeks agoRefactor ads_keytab_add_entry() to make it iterable
Isaac Boukris [Wed, 27 May 2020 11:25:17 +0000 (13:25 +0200)]
Refactor ads_keytab_add_entry() to make it iterable

so we can more easily add msDS-AdditionalDnsHostName entries.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14396

Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
4 weeks agoFix accidental overwrite of dnsHostName by the last netbios alias
Isaac Boukris [Wed, 27 May 2020 13:52:46 +0000 (15:52 +0200)]
Fix accidental overwrite of dnsHostName by the last netbios alias

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14396

Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
4 weeks agoAdd a test to check dNSHostName with netbios aliases
Isaac Boukris [Wed, 27 May 2020 14:50:45 +0000 (16:50 +0200)]
Add a test to check dNSHostName with netbios aliases

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14396

Signed-off-by: Isaac Boukris <iboukris@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
4 weeks agosmbd: Protect smbd_smb2_getinfo_send() against invalid quota files
Volker Lendecke [Fri, 22 May 2020 12:41:27 +0000 (14:41 +0200)]
smbd: Protect smbd_smb2_getinfo_send() against invalid quota files

Bug: https://bugzilla.samba.org/show_bug.cgi?id=14367

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri May 29 09:55:10 UTC 2020 on sn-devel-184

4 weeks agotorture3: Check error code for quotactl on a non-quota file handle
Volker Lendecke [Fri, 22 May 2020 13:24:06 +0000 (15:24 +0200)]
torture3: Check error code for quotactl on a non-quota file handle

Bug: https://bugzilla.samba.org/show_bug.cgi?id=14367

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>