17 years agothere are places in the samba3 code that don't check properly for
Andrew Tridgell [Mon, 2 Feb 2004 12:09:35 +0000 (12:09 +0000)]
there are places in the samba3 code that don't check properly for
packet-termination of strings. This change ensures that when we go
past the end of a packet we hit 2 null bytes, thus terminating. We are
relying on the SAFETY_MARGIN packet allocation stuff here.
(This used to be commit 655ec168288159f5c0961ed8cbdd84c4e14eab26)

17 years agothe conversion from int to size_t in charcnv did not take into account
Andrew Tridgell [Mon, 2 Feb 2004 12:02:43 +0000 (12:02 +0000)]
the conversion from int to size_t in charcnv did not take into account
one place where we checked "if (src_len > 0)".

I actually would greatly prefer to switch back to int for src_len. The
type *can* be negative, which means an unsigned type is
inappropriate. There is absolutely no reason why "int" should not be
used for a parameter like this.

I didn't change back to int as we are close to a release and I wanted
a mininal change, but please don't go changing types like this in
future without very careful testing and a damn good reason.

this bug broke pull_ucs2(), I would not be surprised if it caused all
sorts of nastiness. Thanks to vl for noticing the symptoms!
(This used to be commit 8b8f0c527959c707f274b435fc59156e37232981)

17 years agoRemove bogus check. No functional change, just cosmetics.
Volker Lendecke [Mon, 2 Feb 2004 07:53:56 +0000 (07:53 +0000)]
Remove bogus check. No functional change, just cosmetics.

(This used to be commit e3a5e2d9c23e8ba6bc817e433e596f535644c862)

17 years agoAlways at least try to compile in cracklib support.
Andrew Bartlett [Mon, 2 Feb 2004 07:47:25 +0000 (07:47 +0000)]
Always at least try to compile in cracklib support.

Andrew Bartlett
(This used to be commit 6cde5e8307c2425c5c496a2a5fb9fcde6c8ef433)

17 years agoMerge the 'use cracklib' parameter from HEAD back to 3.0
Andrew Bartlett [Mon, 2 Feb 2004 07:45:50 +0000 (07:45 +0000)]
Merge the 'use cracklib' parameter from HEAD back to 3.0

Andrew Bartlett
(This used to be commit 2202667ebb713fb5d933fcaa1c19dc761da47ccb)

17 years agoremerge andrew's cracklib patch from HEAD and fix a compile warnings
Gerald Carter [Mon, 2 Feb 2004 00:08:35 +0000 (00:08 +0000)]
remerge andrew's cracklib patch from HEAD and fix a compile warnings
(This used to be commit b60f6ec30d05e4e5bba9934a416ddc8bc089824f)

17 years agoInclude sys/acl.h in check for broken nisplus include files. Bug #1025.
Tim Potter [Sun, 1 Feb 2004 22:17:36 +0000 (22:17 +0000)]
Include sys/acl.h in check for broken nisplus include files.  Bug #1025.
(This used to be commit 5ca866f2475e11759d04dbf6469b055808020d5a)

17 years agoDon't log an error in tdb_brlock() if a non-blocking lock returns EAGAIN -
Tim Potter [Sun, 1 Feb 2004 10:55:54 +0000 (10:55 +0000)]
Don't log an error in tdb_brlock() if a non-blocking lock returns EAGAIN -
it's supposed to do that.
(This used to be commit 2423a459471136d701b498ff0db797c70c6d0fce)

17 years ago* BUG 101: patch from to set the SV_TYPE_PRINTQ_SERVER;
Gerald Carter [Sat, 31 Jan 2004 18:25:57 +0000 (18:25 +0000)]
* BUG 101: patch from to set the SV_TYPE_PRINTQ_SERVER;
* don't set the unix_ERR_XX code in mkdir_internal, let the error mapping
  handle it.
(This used to be commit 87343fc15a385153c2205bd8bfe876504d38d9a1)

17 years agocleanup patch for bug 977 so we don't display incorrect debug messages
Gerald Carter [Sat, 31 Jan 2004 14:44:27 +0000 (14:44 +0000)]
cleanup patch for bug 977 so we don't display incorrect debug messages
(This used to be commit 11093ecfb7bab1ecb16d19ac00b3e7e38dff43e2)

17 years agoIf we are setting the NT or LM password to NULL, remove the attribute
Andrew Bartlett [Fri, 30 Jan 2004 23:37:38 +0000 (23:37 +0000)]
If we are setting the NT or LM password to NULL, remove the attribute
rather than writing XXXXX

Andrew Bartlett
(This used to be commit ab7dd748a98361ac9c1c3ca52e9a97aee3f93e6f)

17 years agofix pam config file
Gerald Carter [Fri, 30 Jan 2004 20:27:58 +0000 (20:27 +0000)]
fix pam config file
(This used to be commit 4dcf2f6e39ad07ead37815e9ed978099459b1569)

17 years agofix a few more bugs in Fedora scripts (files not getting installed)
Gerald Carter [Fri, 30 Jan 2004 20:26:03 +0000 (20:26 +0000)]
fix a few more bugs in Fedora scripts (files not getting installed)
(This used to be commit 8ee3cc48c3a1784d6d5e0abb6f81d6f14b616777)

17 years agoFix up name canonicalization (needed for krb5 keytab support later).
Jeremy Allison [Fri, 30 Jan 2004 18:38:48 +0000 (18:38 +0000)]
Fix up name canonicalization (needed for krb5 keytab support later).
Remove source_env handler (no longer used in any codepath).
(This used to be commit 3a3e33603084048e647af86a9badaaf49433c789)

17 years agofixes for fedora packaging
Gerald Carter [Fri, 30 Jan 2004 16:00:42 +0000 (16:00 +0000)]
fixes for fedora packaging
(This used to be commit 1924dfb266525053b48a636818f32eae14730051)

17 years agodisable any account that doesn't have a password and doesn't had the ACB_PWNOTREQ...
Gerald Carter [Fri, 30 Jan 2004 14:59:40 +0000 (14:59 +0000)]
disable any account that doesn't have a password and doesn't had the ACB_PWNOTREQ bit set
(This used to be commit 52bf070b10ca99be7e4b9d1b5e32f69d2667d8f4)

17 years agomore initialization fixes
Gerald Carter [Thu, 29 Jan 2004 22:16:58 +0000 (22:16 +0000)]
more initialization fixes
(This used to be commit 9e590d603547ef1e8388bea66eb5d44e4dfd6412)

17 years agodisable template accounts by default
Gerald Carter [Thu, 29 Jan 2004 20:15:12 +0000 (20:15 +0000)]
disable template accounts by default
(This used to be commit 02899224a195260140496c6e72aee66cc6d65ee4)

17 years agoinitialization fixes
Gerald Carter [Thu, 29 Jan 2004 20:14:50 +0000 (20:14 +0000)]
initialization fixes
(This used to be commit 54fd3992c385fd6208c061131b2c98e448baf2c2)

17 years agoremoving more unused parameters
Gerald Carter [Thu, 29 Jan 2004 17:28:45 +0000 (17:28 +0000)]
removing more unused parameters
(This used to be commit 8135ea08b3dce212a98c17a604619dd383e96c24)

17 years agoBUG 570: don't overwrite LDFLAGS; patch from MORIYAMA Masayuki <moriyama@miraclelinux...
Gerald Carter [Thu, 29 Jan 2004 14:03:48 +0000 (14:03 +0000)]
BUG 570: don't overwrite LDFLAGS; patch from MORIYAMA Masayuki <>
(This used to be commit d39b1b3fd67d117016907aa79ffac7cb89d3cd5b)

17 years agocompletely rewrote the AIX UESS backend (UESS is the AIX equivalent of
Andrew Tridgell [Thu, 29 Jan 2004 06:14:13 +0000 (06:14 +0000)]
completely rewrote the AIX UESS backend (UESS is the AIX equivalent of
NSS). This time I think I've actually got it right. I wrote a fairly
good test suite for UESS modules (similar to nsstest.c) that allowed
me to explore how the modules supplied with AIX actually work.

This new module also incorporates authentication features, so you
don't need a PAM module at all. Just install this UESS module and
authentication will "just work". It also handles password change, so
/usr/bin/passwd can be used to change windows password.
(This used to be commit d62cb9454e310d2baeea0077dad4ba9382ba06cd)

17 years agoRemove an unused parameter from reload_services_file.
Richard Sharpe [Thu, 29 Jan 2004 00:10:40 +0000 (00:10 +0000)]
Remove an unused parameter from reload_services_file.
(This used to be commit 0032c3f46aaef065e95d987dc0506016aabbe644)

17 years agoMerge of Chris's fix.
Jeremy Allison [Wed, 28 Jan 2004 23:41:55 +0000 (23:41 +0000)]
Merge of Chris's fix.
(This used to be commit 1a7714ea32300ba0e48f275addcf2e1f272a96ed)

17 years agoforgotten commit -- version == 3.0.3pre1
Gerald Carter [Tue, 27 Jan 2004 19:00:06 +0000 (19:00 +0000)]
forgotten commit -- version == 3.0.3pre1
(This used to be commit 043a81b94de390136bd18f299d71f1edb526be77)

17 years agofix typo in init script
Gerald Carter [Tue, 27 Jan 2004 15:48:43 +0000 (15:48 +0000)]
fix typo in init script
(This used to be commit bc63d989c06d733fd6c411dde150cf0f50029757)

17 years agoprepping the SAMBA_3_0 branch for 3.0.3 work
Gerald Carter [Tue, 27 Jan 2004 15:29:30 +0000 (15:29 +0000)]
prepping the SAMBA_3_0 branch for 3.0.3 work
(This used to be commit 50f278ddcc046e7578b4397d10c22b424d2b01a3)

17 years agobug 977 - don't create a homes share for a user if a static share already exists...
Gerald Carter [Tue, 27 Jan 2004 15:28:33 +0000 (15:28 +0000)]
bug 977 - don't create a homes share for a user if a static share already exists by the same name
(This used to be commit 6b89a76aa7efaa0ad7a0139aeb3e4ebf5c01cdcb)

17 years agoClarify comment on set_effective_uid()
Andrew Bartlett [Tue, 27 Jan 2004 10:01:30 +0000 (10:01 +0000)]
Clarify comment on set_effective_uid()

Andrew Bartlett
(This used to be commit ca24ae50ea37942dde335e97019880b6ce518a6a)

17 years agoRevise our server-side password change code to cope with the various
Andrew Bartlett [Mon, 26 Jan 2004 09:03:09 +0000 (09:03 +0000)]
Revise our server-side password change code to cope with the various
different feilds that different clients send.  (For example, not all clients
send both password types).

This also cleans up the code to make it clearer what is really going on,
and to make better use of common functions.

Andrew Bartlett
(This used to be commit 934e9f3bd0e8a938263978ffcd1fef51e42fa5e4)

17 years agoThis adds client-side support for the unicode/SAMR password change scheme.
Andrew Bartlett [Mon, 26 Jan 2004 08:45:02 +0000 (08:45 +0000)]
This adds client-side support for the unicode/SAMR password change scheme.

As well as avoiding DOS charset issues, this scheme returns useful error
codes, that we can map back via the pam interface.

This patch also cleans up the interfaces used for password buffers, to
avoid duplication of code.

Andrew Bartlett
(This used to be commit 2a2b1f0c872d154fbcce71a250e23dfad085ba1e)

17 years agoAdd a few more NTSTATUS <=> PAM error mappings.
Andrew Bartlett [Mon, 26 Jan 2004 08:38:34 +0000 (08:38 +0000)]
Add a few more NTSTATUS <=> PAM error mappings.

Andrew Bartlett
(This used to be commit 7495cafd42617c0aa2ba9de69f87426ecacc1297)

17 years agoPatch by Luca Bolcioni <>. Ensure we always
Andrew Bartlett [Mon, 26 Jan 2004 02:19:44 +0000 (02:19 +0000)]
Patch by Luca Bolcioni <>.  Ensure we always
initialise the session key.  Fixes segfaults with security=server, and
encrypt passwords = no.

Andrew Bartlett
(This used to be commit 493ac5ce98fa3fcddb596139240dd762e70d4ac3)

17 years agoFix memleak just introduced. Thanks to abartlet :-)
Volker Lendecke [Sun, 25 Jan 2004 10:14:50 +0000 (10:14 +0000)]
Fix memleak just introduced. Thanks to abartlet :-)

(This used to be commit be485eea81c6bab8067642c26e41a14652ce7ee6)

17 years agoOn my SuSE 8.2 (glibc 2.3.2) the getpwnam inside pdb_getsampwnam reset
Volker Lendecke [Sun, 25 Jan 2004 10:04:10 +0000 (10:04 +0000)]
On my SuSE 8.2 (glibc 2.3.2) the getpwnam inside pdb_getsampwnam reset
the surrounding getpwent loop to the first entry. So smbd went into an
endless loop.

(This used to be commit 1797b16fadd61ef1f30a1be950e3afe7a2e1d791)

17 years agoFix the initialisation vectors for NTLM2, so that they at least make sense,
Andrew Bartlett [Sun, 25 Jan 2004 01:11:10 +0000 (01:11 +0000)]
Fix the initialisation vectors for NTLM2, so that they at least make sense,
even if they don't work yet.

Andrew Bartlett
(This used to be commit 636b98dab9bc27f55bdc65d7dedb58cdf8d8563b)

17 years agoIf we are providing strndup(), ensure we provide a prototype too.
Andrew Bartlett [Sun, 25 Jan 2004 01:02:39 +0000 (01:02 +0000)]
If we are providing strndup(), ensure we provide a prototype too.

Andrew Bartlett
(This used to be commit 109627145463fc4c00b8f6664e3f2e48e0305d56)

17 years agoFix removal of attributes in LDAP - we would not actually remove the old
Andrew Bartlett [Sun, 25 Jan 2004 00:50:39 +0000 (00:50 +0000)]
Fix removal of attributes in LDAP - we would not actually remove the old
value in the previous code.

Andrew Bartlett
(This used to be commit c97d3eb1622ee25c24b0cd81b65ec7d4b854e604)

17 years agoA Samba DC is nothing special these days - so every domain controller
Andrew Bartlett [Sat, 24 Jan 2004 10:46:55 +0000 (10:46 +0000)]
A Samba DC is nothing special these days - so every domain controller
location packet from the client is not a DEBUG(1) event anymore...

(Yes, we printed this for each of these UDP packets...)

Andrew Bartlett
(This used to be commit 4ca0ab7506f15112d996bf68278e54e535c4cab4)

17 years agoFix typo
Volker Lendecke [Fri, 23 Jan 2004 12:57:29 +0000 (12:57 +0000)]
Fix typo
(This used to be commit 09a30014233f111fe978effb12ecb2f88b710cb5)

17 years agoFix decoding of base64. We got the length wrong when the result was not
Volker Lendecke [Fri, 23 Jan 2004 12:04:07 +0000 (12:04 +0000)]
Fix decoding of base64. We got the length wrong when the result was not
an exact multiple of 3.

I also wrote a torture test and it survived some minutes of random stuff
coded/decoded up to 16 MB data. But that would be a bit too embarassing to
commit... :-)

(This used to be commit 6d22f0d8c36bea618ad0adf4eefc2f5a37cb3fda)

17 years agoFix for debian Bug#225328 by LaMont Jones <>, where
Andrew Bartlett [Thu, 22 Jan 2004 10:12:26 +0000 (10:12 +0000)]
Fix for debian Bug#225328 by LaMont Jones <>, where
the failure of our LFS test caused the _GNU_SOURCE define not to be
added, causeing strndup() not to be defined...

I'll into when we really should define _GNU_SOURCE shortly, but the
fix is correct anyway.

Andrew Bartlett
(This used to be commit aca07f33a2f3cca48b44ac92d3b1b35592ffadc7)

17 years ago* Add SIGABRT to fault handling
Stefan Metzmacher [Thu, 22 Jan 2004 01:50:58 +0000 (01:50 +0000)]
* Add SIGABRT to fault handling
  so we now got a backtrace, if we crash
  in libldap with SIGABRT

(This used to be commit b5e814294eb3ce44131084d89014cb8a8840fe74)

17 years agoFix compiler warning
Volker Lendecke [Wed, 21 Jan 2004 14:48:02 +0000 (14:48 +0000)]
Fix compiler warning
(This used to be commit 413ed77142377351a0ed1c6cf800a14809e56e9c)

17 years agoDisplay some nicer error messages for login via 'net'. I don't
Volker Lendecke [Wed, 21 Jan 2004 14:36:56 +0000 (14:36 +0000)]
Display some nicer error messages for login via 'net'. I don't
see a reason why we have so many special cases and not simply use


(This used to be commit ea1a5fb30357f4fe70139ff5583d09cef9fdaa62)

17 years agoinclude tdbdump man page in file list
Gerald Carter [Sat, 17 Jan 2004 01:48:36 +0000 (01:48 +0000)]
include tdbdump man page in file list
(This used to be commit 083d06cad58b8e6e6136d7630e59449b47a699da)

17 years agoFix for a signing bug when the mid wraps.
Jeremy Allison [Sat, 17 Jan 2004 00:30:35 +0000 (00:30 +0000)]
Fix for a signing bug when the mid wraps.
Found by Fran Fabrizio <>.
Add to the *start* of the list not the end of the list.
This ensures that the *last* send sequence with this mid
is returned by preference.
This can happen if the mid wraps and one of the early
mid numbers didn't get a reply and is still lurking on
the list.
(This used to be commit 25d739978fe9081ba0946c36901492127248e3e0)

17 years agostarting WHATSNEW for thepost 3.0.2rc1 release
Gerald Carter [Fri, 16 Jan 2004 22:48:59 +0000 (22:48 +0000)]
starting WHATSNEW for thepost 3.0.2rc1 release
(This used to be commit 4ef4004af06a022dbc4f6757238e77ccfe1b4481)

17 years agofix another bug caused by cli_lsa_query_info_policy() changes
Gerald Carter [Fri, 16 Jan 2004 22:15:35 +0000 (22:15 +0000)]
fix another bug caused by cli_lsa_query_info_policy() changes
(This used to be commit faec928564529c7ffb2653943be9cafbfb9e4688)

17 years agoremove unneeded man pages from packages
Gerald Carter [Fri, 16 Jan 2004 19:01:20 +0000 (19:01 +0000)]
remove unneeded man pages from packages
(This used to be commit 0e0a1632358f27d45b10f315db90afdbb35ee5b2)

17 years agoBUG 891 & 949: Fedora Packaging Fixes
Gerald Carter [Fri, 16 Jan 2004 17:46:38 +0000 (17:46 +0000)]
BUG 891 & 949: Fedora Packaging Fixes
(This used to be commit a7d0aec2b7ef132b5c631cb26d0a93dd66d0fff3)

17 years agoFix another join problem. Don't use a TALLOC_CTX before it has been
Jim McDonough [Fri, 16 Jan 2004 15:07:28 +0000 (15:07 +0000)]
Fix another join problem.  Don't use a TALLOC_CTX before it has been

Also split out the oldstyle join into a new fn, allowing us to call it
with no failure message from net rpc join, but displaying a failure message
when used with net rpc oldjoin.
(This used to be commit 07d6ed4343d7a2575dc974bfbc498b14784b2dc1)

17 years agoPatch from "Stoian Ivanov" <>: Add -g (greppable..) to
Volker Lendecke [Fri, 16 Jan 2004 15:01:09 +0000 (15:01 +0000)]
Patch from "Stoian Ivanov" <>: Add -g (greppable..) to
smbclient -L to make the output usable in pipes.

(This used to be commit 4c904210705f2be16daad21c07a4fb5117a3360b)

17 years agoCommit sid<->[ug]id extensions to on Linux, as well as a
Volker Lendecke [Fri, 16 Jan 2004 13:11:01 +0000 (13:11 +0000)]
Commit sid<->[ug]id extensions to on Linux, as well as a
factored-out nss_winbind.[ch]. I took tridge's public domain license comment
for the nss_winbind.[ch].

This is probably not the last word on that extension, but as it is quite
non-intrusive to the main samba code, I would like to give it a start.

(This used to be commit da5944129fad39010544b82649dfe5531a504ecf)

17 years agoBug 381: check builtin (not local) group SID. Patch from Jianliang Lu <
Gerald Carter [Thu, 15 Jan 2004 20:47:30 +0000 (20:47 +0000)]
Bug 381: check builtin (not local) group SID.  Patch from Jianliang Lu <>
(This used to be commit 2fd2c07df42df42103e81f5eb39bd1778de6ca0a)

17 years agosetting version to 3.0.2rc2
Gerald Carter [Thu, 15 Jan 2004 20:32:27 +0000 (20:32 +0000)]
setting version to 3.0.2rc2
(This used to be commit db1c6721bfe72323978b2d2b7fbd7ef29b914573)

17 years agoadding changelog for 3.0.2rc1
Gerald Carter [Thu, 15 Jan 2004 20:14:02 +0000 (20:14 +0000)]
adding changelog for 3.0.2rc1
(This used to be commit 533fcb5893643cb6136820567e58c4d26ecd9a35)

17 years agoFix net rpc join (at least newstyle) after it was broken by changing
Jim McDonough [Thu, 15 Jan 2004 19:45:36 +0000 (19:45 +0000)]
Fix net rpc join (at least newstyle) after it was broken by changing
the parms to cli_lsa_query_info_policy without changing them here...
(This used to be commit a885df7635a9230bc6cca88e7e8fb1420c74c7fb)

17 years ago* BUG 446
Gerald Carter [Thu, 15 Jan 2004 19:03:18 +0000 (19:03 +0000)]
* BUG 446
  - setup_logging() in smbclient to be interactive (remove the timestamps)
  - Fix bad return value in pull_ucs2( needs more testing to make sure this
    didn't break something else) that caused clistr_pull() to always read
    the same string from the buffer (pull_usc2() could return -1 if the original
    source length was given as -1)
  - increment some debugging messages to avoid printing them out so often
(This used to be commit 79fe75dcdf6cc38e18ca1231e4357893db4d4a08)

17 years agoBUG 958; don't use the -N option when invoking smbclient from the smbtar script
Gerald Carter [Thu, 15 Jan 2004 17:18:39 +0000 (17:18 +0000)]
BUG 958; don't use the -N option when invoking smbclient from the smbtar script
(This used to be commit c51eaec4f09d9c191c6b24dadb1d12770b368da0)

17 years agoreply_spnego_kerberos did not set the domain of the user handed to
Volker Lendecke [Thu, 15 Jan 2004 17:17:58 +0000 (17:17 +0000)]
reply_spnego_kerberos did not set the domain of the user handed to
register_vuid correctly. We ended up with the local netbios name in
substitutions for %D later.


P.S: Tridge, I can *really* see why you want to get rid of global variables
(This used to be commit 3d9931fe291559a907c3e172a66fbce1155497a3)

17 years agoDon't substitute stuff in lp_afs_username_map, this is explicitly
Volker Lendecke [Thu, 15 Jan 2004 17:05:08 +0000 (17:05 +0000)]
Don't substitute stuff in lp_afs_username_map, this is explicitly
done later.

(This used to be commit c4a6151f469764444f4dab8bcae04e1a2bdb0b64)

17 years agoAnd another memory corruption in winbind. Arg 3 of safe_strcpy does not
Volker Lendecke [Thu, 15 Jan 2004 15:36:01 +0000 (15:36 +0000)]
And another memory corruption in winbind. Arg 3 of safe_strcpy does not
include the terminating 0.

(This used to be commit 945c7807641e82500c84e833f03f381497f0a2d0)

17 years agoFix a segfault in winbindd. Calling getusersids with a SID that results in 0
Volker Lendecke [Thu, 15 Jan 2004 15:00:44 +0000 (15:00 +0000)]
Fix a segfault in winbindd. Calling getusersids with a SID that results in 0
groups winbind ended up freeing an uninitialised pointer.

(This used to be commit cd89288e21ba13a9e97c548eccc15cef21a98d07)

17 years ago* Fix sys_chown() when no chown() is presend
Stefan Metzmacher [Thu, 15 Jan 2004 09:08:06 +0000 (09:08 +0000)]
* Fix sys_chown() when no chown() is presend

(This used to be commit b0c0d736919079afc4f9bf5a406000048d26fe71)

17 years ago* Fix XFS quotas: XFS_USER_QUOTA -> USRQUOTA
Stefan Metzmacher [Thu, 15 Jan 2004 08:49:30 +0000 (08:49 +0000)]
* Fix disk_free calculation with group quotas.
* Add debug class 'quota' and a lot of DEBUG()'s
  to the quota code.

(This used to be commit e9e5e2036f13ff847aa3ef52e8be657bef7d5774)

17 years agoBUG 936: fix bind credentials for schannel binds in smbd (and add a comment to winbin...
Gerald Carter [Thu, 15 Jan 2004 06:55:10 +0000 (06:55 +0000)]
BUG 936: fix bind credentials for schannel binds in smbd (and add a comment to winbindd_cm about this
(This used to be commit 5134c6bcbc5180431e95a30559c453f3744fd427)

17 years agoFix for bug 905. Remove POBAD_CC as it doesn't seem to be applicable
Tim Potter [Thu, 15 Jan 2004 06:51:20 +0000 (06:51 +0000)]
Fix for bug 905.  Remove POBAD_CC as it doesn't seem to be applicable
(This used to be commit 67d25f3de803f7e599c51cacd51367f124151d6b)

17 years agoBUG 972; check pointer in cli_ds_getprimarydominfo() before trying to copy a structure
Gerald Carter [Thu, 15 Jan 2004 05:16:29 +0000 (05:16 +0000)]
BUG 972; check pointer in cli_ds_getprimarydominfo() before trying to copy a structure
(This used to be commit 1c15bfacb45d42873f3d7e7cb55ba2cbbbe33d26)

17 years agosource/rpc_parse/parse_prs.c ZERO_STRUCTP(ps) not needed as it is done
Herb Lewis [Wed, 14 Jan 2004 22:53:50 +0000 (22:53 +0000)]
source/rpc_parse/parse_prs.c ZERO_STRUCTP(ps) not needed as it is done
in prs_init now

testsuite/printing/psec.c cannot do a prs_mem_free() when tdb_prs_fetch fails
as the prs structure has not been initialized
(This used to be commit a363e5d8c549861329506bd87c11d82ace5520e5)

17 years agoFix initgroups() call nss_winbind on solaris; patch from John Klinger <john.klinger...
Gerald Carter [Wed, 14 Jan 2004 21:22:30 +0000 (21:22 +0000)]
Fix initgroups() call nss_winbind on solaris; patch from John Klinger <>
(This used to be commit 40b7d863dc246ea23ff3d9cdc167f1fb96166e1d)

17 years agobug 770; correct fix this time; Make sure that we send the SMBjobid for unix jobs...
Gerald Carter [Wed, 14 Jan 2004 20:56:26 +0000 (20:56 +0000)]
bug 770; correct fix this time;  Make sure that we send the SMBjobid for unix jobs back to the client.  Allows windows client to remove print jobs submitted from lpr
(This used to be commit 514561118860f982c458930c34763dac9ce0554e)

17 years agobug 660; using byte order safe macros (or tdb_unpack) when reading 2 or 4 byte values...
Gerald Carter [Wed, 14 Jan 2004 19:12:06 +0000 (19:12 +0000)]
bug 660; using byte order safe macros (or tdb_unpack) when reading 2 or 4 byte values from a tdb buffer
(This used to be commit be9f25bea94415af6b631a9c6e7af28d9d6e6565)

17 years agorevert the cracklib changes until post 3.0.2
Gerald Carter [Wed, 14 Jan 2004 17:34:41 +0000 (17:34 +0000)]
revert the cracklib changes until post 3.0.2
(This used to be commit 6202e0fa727a4307f51bf42f5ced401a7c7b8214)

17 years ago* Revert to using rpc for mixed mode AD domains.
Gerald Carter [Wed, 14 Jan 2004 16:25:39 +0000 (16:25 +0000)]
* Revert to using rpc for mixed mode AD domains.
  The reason for this are:
  (a) the set_dc_type_and_flags() cannot tell the different
      between connecting to an NT4 domain and an NT4 BDC
      of a mixed mode domain.
  (b) the connection management for the rpc backend only
      provides on named pipe per cli_state.  So it is possible
      to connect to an NT4 BDC for netlogon and an AD mixed mode
      DC for lsarpc.  RPC is the lowest common demonimator here.
  (c) Issue with the sequence number value between the
      highestCommittedUSN LDAP attribute and the seq_num returned
      via RPC.

We will revisit this later, but the changes need to make this
work right now are too broad and risky.
(This used to be commit 1ed2e521536108229d153c2996f4757d89461166)

17 years agoRemove duplicate extern.
Jeremy Allison [Wed, 14 Jan 2004 06:44:20 +0000 (06:44 +0000)]
Remove duplicate extern.
(This used to be commit fb088b5679f1def054d8b433c5e6c5b855411488)

17 years agoRemove references to 'jn' which gcc-3.4 with precompiled headers
Jeremy Allison [Wed, 14 Jan 2004 06:41:50 +0000 (06:41 +0000)]
Remove references to 'jn' which gcc-3.4 with precompiled headers
doesn't like.
(This used to be commit da51988cfac91e63f6e0213701aad652bc1bd55e)

17 years agofix XFS quotas the macro changed from HAVE_XFS_QUOTA -> HAVE_XFS_QUOTAS
Stefan Metzmacher [Wed, 14 Jan 2004 02:51:41 +0000 (02:51 +0000)]
fix XFS quotas the macro changed from HAVE_XFS_QUOTA -> HAVE_XFS_QUOTAS

(This used to be commit c73e845055163c1d814710fe4d9960c7f3587f12)

17 years agoRemove duplicate comment.
Andrew Bartlett [Wed, 14 Jan 2004 01:17:21 +0000 (01:17 +0000)]
Remove duplicate comment.

Andrew Bartlett
(This used to be commit b0b2010461d8554334b033c4f07d78c308e73e7f)

17 years agoFinish adding cracklib support - this adds the configure test to enable
Andrew Bartlett [Wed, 14 Jan 2004 01:14:22 +0000 (01:14 +0000)]
Finish adding cracklib support - this adds the configure test to enable
it, on machines that actually have a working cracklib, for which we have
the correct path to the dictionary.

Andrew Bartlett
(This used to be commit 17518018c0264d2a8e4afbc712a22ef4a1a00003)

17 years ago* allow dns lookups to be disabled for DOMAIN#1c (and #1b)
Gerald Carter [Tue, 13 Jan 2004 19:42:53 +0000 (19:42 +0000)]
* allow dns lookups to be disabled for DOMAIN#1c (and #1b)
* fix some a mispelled variable name
(This used to be commit bca702c97620ad8f66015d6e4b41abd4adf22076)

17 years agoOn systems without a working cracklib, ensure we don't include the header
Andrew Bartlett [Mon, 12 Jan 2004 21:12:47 +0000 (21:12 +0000)]
On systems without a working cracklib, ensure we don't include the header
(the actual call to crack was already in this #ifdef)

Andrew Bartlett
(This used to be commit 4a01f3dbb4a2e744b48bdb86c4d91ee4692d38e5)

17 years agofixing compile problems due to my recent ads.h changes
Gerald Carter [Mon, 12 Jan 2004 14:26:50 +0000 (14:26 +0000)]
fixing compile problems due to my recent ads.h changes
(This used to be commit d7b6298b9e4e7f83deaa2c6f3d711c390ff9cefd)

17 years agoFirst stab at cracklib support (password quality checking) in Samba 3.0
Andrew Bartlett [Mon, 12 Jan 2004 12:18:11 +0000 (12:18 +0000)]
First stab at cracklib support (password quality checking) in Samba 3.0

This adds a configure test, that tries to find out if we have a working
cracklib installation, and tries to pick up the debian hints on where
the dictionary might be found.  Default is per my Fedora Core 1 system -
I'm not sure how much it changes.

Andrew Bartlett
(This used to be commit bc770edb788f0b6f719011cda683f045b76b7ba5)

17 years agofix formatting
Gerald Carter [Sun, 11 Jan 2004 14:15:12 +0000 (14:15 +0000)]
fix formatting
(This used to be commit acc9022550b20b144f749411ecdadf18adb09350)

17 years agoupdate copyright to -2004
Stefan Metzmacher [Sun, 11 Jan 2004 13:23:50 +0000 (13:23 +0000)]
update copyright to -2004

(This used to be commit 12d6bc3bd0684646e990c2fc6485fe1a92ac98fb)

17 years agoFix swatdir location for --with-fhs
Jelmer Vernooij [Sat, 10 Jan 2004 22:05:38 +0000 (22:05 +0000)]
Fix swatdir location for --with-fhs
(This used to be commit d12b793d9ca10f966da3446982a5b1d987d51814)

17 years agostarting new version of release notes -- post 3.0.2pre1
Gerald Carter [Fri, 9 Jan 2004 16:02:42 +0000 (16:02 +0000)]
starting new version of release notes -- post 3.0.2pre1
(This used to be commit 83150b5733033aed4b3556ea94782a5b6c7b9aeb)

17 years agofix some warnings from the Sun compiler
Gerald Carter [Fri, 9 Jan 2004 14:54:33 +0000 (14:54 +0000)]
fix some warnings from the Sun compiler
(This used to be commit ebabf72a78f0165521268b73e0fcabe1ea7834fd)

17 years agoRomve debugging assertions (oops...)
Andrew Bartlett [Fri, 9 Jan 2004 02:47:35 +0000 (02:47 +0000)]
Romve debugging assertions (oops...)

Andrew Bartlett
(This used to be commit 7e75a6d681fc63cacc7e5caa7a04568c6019367f)

17 years agoAdd a new type of name lookup 'ads'. This seperates this from normal
Andrew Bartlett [Fri, 9 Jan 2004 02:38:58 +0000 (02:38 +0000)]
Add a new type of name lookup 'ads'.  This seperates this from normal
hostname lookups, and ensures that we don't lookup 'short' (ie NetBIOS)
domain names in DNS.

Andrew Bartlett
(This used to be commit 35f6347a73ce7423adb78c7e95492bb6d98f4c40)

17 years agoUse StrCaseCmp, not strcasecmp. Should fix winbind build on IRIX
Jelmer Vernooij [Thu, 8 Jan 2004 22:53:37 +0000 (22:53 +0000)]
Use StrCaseCmp, not strcasecmp. Should fix winbind build on IRIX
(This used to be commit 65b01f67d5725bc54e6bc19b6e84beef38e372f8)

17 years agofix segfault when sid_ptr == 0 in DsEnumDomainTrusts() reply
Gerald Carter [Thu, 8 Jan 2004 22:21:29 +0000 (22:21 +0000)]
fix segfault when sid_ptr == 0 in DsEnumDomainTrusts() reply
(This used to be commit ba9dc0d9fd3e30a7ddf97b6a4df753db7ba12cc1)

17 years agofix a seg fault caused by abartlet's last checkin; there's no way this could have...
Gerald Carter [Thu, 8 Jan 2004 19:56:40 +0000 (19:56 +0000)]
fix a seg fault caused by abartlet's last checkin; there's no way this could have been tested against an NT4 DC
(This used to be commit 8e8a351cabb502f1a93b219fec064fb4eb094856)

17 years agoWe might not have the 'samba' directory in the samba_3_0 build.
Andrew Bartlett [Thu, 8 Jan 2004 08:44:39 +0000 (08:44 +0000)]
We might not have the 'samba' directory in the samba_3_0 build.

Andrew Bartlett
(This used to be commit a5cf5701e25e93e4e837f7cdc30a8603d289e4a9)

17 years agouse SAFE_FREE(), not free().
Andrew Bartlett [Thu, 8 Jan 2004 08:41:26 +0000 (08:41 +0000)]
use SAFE_FREE(), not free().

Andrew Bartlett
(This used to be commit 595dee660742f8bd5770a5f7aaf3a5d1987dbcfa)

17 years agoThis merges in my 'always use ADS' patch. Tested on a mix of NT and ADS
Andrew Bartlett [Thu, 8 Jan 2004 08:19:18 +0000 (08:19 +0000)]
This merges in my 'always use ADS' patch.  Tested on a mix of NT and ADS
domains, this patch ensures that we always use the ADS backend when
security=ADS, and the remote server is capable.

The routines used for this behaviour have been upgraded to modern Samba
codeing standards.

This is a change in behaviour for mixed mode domains, and if the trusted
domain cannot be reached with our current krb5.conf file, we will show
that domain as disconnected.

This is in line with existing behaviour for native mode domains, and for
our primary domain.

As a consequence of testing this patch, I found that our kerberos error
handling was well below par - we would often throw away useful error
values.  These changes move more routines to ADS_STATUS to return
kerberos errors.

Also found when valgrinding the setup, fix a few memory leaks.

While sniffing the resultant connections, I noticed we would query our
list of trusted domains twice - so I have reworked some of the code to
avoid that.

Andrew Bartlett
(This used to be commit 7c34de8096b86d2869e7177420fe129bd0c7541d)

17 years agoIn tdb_allocate(), we would create a new record by writing a local variable
Andrew Bartlett [Thu, 8 Jan 2004 05:37:23 +0000 (05:37 +0000)]
In tdb_allocate(), we would create a new record by writing a local variable
'newrec' into the tdb.

This was not initialised, so valgrind warned about it.

(Note:  valgrind only makes sense on tdbs with 'mmap = no' in your smb.conf)

Andrew Bartlett
(This used to be commit c9f9d6d3171d720b4ec0ba6af8c0c8ab178cd98b)

17 years agoMake it clearer that the domain here is the domain of the user for
Andrew Bartlett [Thu, 8 Jan 2004 02:57:42 +0000 (02:57 +0000)]
Make it clearer that the domain here is the domain of the user for

Andrew Bartlett
(This used to be commit 7e6cc8f0037f9948230a1e1bd380f30cec5d511e)

17 years agoMove more of winbind to use 'find_our_domain()' rather than the dangerous
Andrew Bartlett [Thu, 8 Jan 2004 02:15:46 +0000 (02:15 +0000)]
Move more of winbind to use 'find_our_domain()' rather than the dangerous

(as find_domain_from_name() can change the data in lp_workgroup())

Andrew Bartlett
(This used to be commit 2e6eaad9ce6a0ad6923b5952ef6cf1c3688b7cfa)