12 years agor3183: moved the unlink of the messaging unixdom socket to the messaging destructor
Andrew Tridgell [Mon, 25 Oct 2004 03:30:39 +0000 (03:30 +0000)]
r3183: moved the unlink of the messaging unixdom socket to the messaging destructor
(This used to be commit ab222b236a091d31b1f5f2cba150a11585ab5836)

12 years agor3182: separate out the BASE-RENAME test into torture/basic/rename.c
Andrew Tridgell [Mon, 25 Oct 2004 02:59:48 +0000 (02:59 +0000)]
r3182: separate out the BASE-RENAME test into torture/basic/rename.c
(This used to be commit c5e72b05d73ff0d57a98b6065bab573e2a226747)

12 years agor3181: shutdown the secrets db on exit so we don't constantly get talloc leak warnings
Andrew Tridgell [Mon, 25 Oct 2004 02:57:20 +0000 (02:57 +0000)]
r3181: shutdown the secrets db on exit so we don't constantly get talloc leak warnings
(This used to be commit 11713da2efc6d45c5594289efa0b6c0e594e6d2e)

12 years agor3180: - basic support for SEC_RIGHT_MAXIMUM_ALLOWED in pvfs
Andrew Tridgell [Mon, 25 Oct 2004 02:36:12 +0000 (02:36 +0000)]
r3180: - basic support for SEC_RIGHT_MAXIMUM_ALLOWED in pvfs

- RAW-CONTEXT test now passes
(This used to be commit 0dae9fef09ec8bce19c39a0caf36e0882e507bc4)

12 years agor3179: - fixed error return on utime failure
Andrew Tridgell [Mon, 25 Oct 2004 01:56:29 +0000 (01:56 +0000)]
r3179: - fixed error return on utime failure

- formatting fix
(This used to be commit 8ca4d7c51e5c76aa28f600d49437a45a8a0d31a9)

12 years agor3178: honor the write_time on pvfs_close()
Andrew Tridgell [Mon, 25 Oct 2004 01:56:01 +0000 (01:56 +0000)]
r3178: honor the write_time on pvfs_close()
(This used to be commit 4e28c45bafa453eaa94716a5b77d830b81efe6cf)

12 years agor3177: check for open files on rename
Andrew Tridgell [Mon, 25 Oct 2004 01:55:38 +0000 (01:55 +0000)]
r3177: check for open files on rename
(This used to be commit c334182095c53b09fcb65a40053b518acb6ec38b)

12 years agor3176: added a script to run all the filesystem torture tests that are
Andrew Tridgell [Mon, 25 Oct 2004 01:49:54 +0000 (01:49 +0000)]
r3176: added a script to run all the filesystem torture tests that are
expected to pass. This allows easy testing for regressions when I
change core routines in the posix backend.
(This used to be commit 867cae746671916c95d18ac4baf8d9604e437202)

12 years agor3175: Add winbind back into includes.h (spotted by tpot)
Andrew Bartlett [Mon, 25 Oct 2004 01:34:56 +0000 (01:34 +0000)]
r3175: Add winbind back into includes.h (spotted by tpot)

Andrew Bartlett
(This used to be commit 2b0f04167d6512c7eaa44f8234f0be63c55f9582)

12 years agor3174: added pvfs_is_open() to allow us to check for open files on unlink. We
Andrew Tridgell [Mon, 25 Oct 2004 01:29:31 +0000 (01:29 +0000)]
r3174: added pvfs_is_open() to allow us to check for open files on unlink. We
now pass BASE-UNLINK.
(This used to be commit f23a2f8538bda8f6790e86c93ee22436388b2975)

12 years agor3173: make the RAW-QFILEINFO test cope better with null strings from the server
Andrew Tridgell [Mon, 25 Oct 2004 01:16:35 +0000 (01:16 +0000)]
r3173: make the RAW-QFILEINFO test cope better with null strings from the server
(This used to be commit a10fca41de7e19e610bf9fd0a854b7b35d652561)

12 years agor3172: much better qfileinfo implementation in pvfs. We now pass RAW-QFILEINFO
Andrew Tridgell [Mon, 25 Oct 2004 01:16:04 +0000 (01:16 +0000)]
r3172: much better qfileinfo implementation in pvfs. We now pass RAW-QFILEINFO
(This used to be commit 65c2c81b8cf6aeeccdc53d8145c2595f230bd531)

12 years agor3171: in qfileinfo getattre and standard have identical structures, so
Andrew Tridgell [Mon, 25 Oct 2004 01:15:16 +0000 (01:15 +0000)]
r3171: in qfileinfo getattre and standard have identical structures, so
simplify code by making them aliases
(This used to be commit 91a1dc121cba77a3400935c199897cde50396cdd)

12 years agor3170: Add winbind client support back into Samba4. This is to allow
Andrew Bartlett [Sun, 24 Oct 2004 23:54:00 +0000 (23:54 +0000)]
r3170: Add winbind client support back into Samba4.  This is to allow
auth_winbind to work, and to therefore use the new ntlm_auth and
GENSEC in an otherwise Samba3 setup.

I'm not quite sure what fun-and games my svn cp caused as I merged
this from samba_3_0, but anyway...

Andrew Bartlett
(This used to be commit 5925b94a59da406d7e6b8cc695c99ba112fdfcd6)

12 years agor3169: unlink() is called on the listening unix socket every time a child process
Jelmer Vernooij [Sun, 24 Oct 2004 23:30:47 +0000 (23:30 +0000)]
r3169: unlink() is called on the listening unix socket every time a child process
exits. Commenting it out until we have a clean way of doing this.
(This used to be commit fa0760dd5fa361be3b72dc4adc8b736e8a862606)

12 years agor3168: Use generic function for looking up endpoints
Jelmer Vernooij [Sun, 24 Oct 2004 23:12:13 +0000 (23:12 +0000)]
r3168: Use generic function for looking up endpoints
(This used to be commit 45a3e2a9815058a3a828c573573c5eee605f9129)

12 years agor3167: Add a member 'endpoint' to the dcerpc_binding struct to use instead of
Jelmer Vernooij [Sun, 24 Oct 2004 22:46:47 +0000 (22:46 +0000)]
r3167: Add a member 'endpoint' to the dcerpc_binding struct to use instead of
(This used to be commit 18582083af800abd3d8de40eb73255c8ae6598dd)

12 years agor3166: Bunch of small GUI updates. gwcrontab works again, as does selecting a
Jelmer Vernooij [Sun, 24 Oct 2004 17:34:48 +0000 (17:34 +0000)]
r3166: Bunch of small GUI updates. gwcrontab works again, as does selecting a
domain in gwsam
(This used to be commit 575e380ab45787cbe0fa2bdda6e1164e3e36f2b8)

12 years agor3165: Support local connections in Gtk+ tools
Jelmer Vernooij [Sun, 24 Oct 2004 17:06:35 +0000 (17:06 +0000)]
r3165: Support local connections in Gtk+ tools
(This used to be commit 3de0cf22ddd6b7fb4a2214f3f99d37174c54840f)

12 years agor3164: Look up ncalrpc identifiers using the EPMAPPER. ncalrpc now works nicely :-)
Jelmer Vernooij [Sun, 24 Oct 2004 16:31:00 +0000 (16:31 +0000)]
r3164: Look up ncalrpc identifiers using the EPMAPPER. ncalrpc now works nicely :-)
The various interface that support ncalrpc work nicely when tested
with smbtorture and ncalrpc.

Running RPC-SAMR against local smbd here is slightly faster using ncalrpc:
ncalrpc:  1.8 sec
ncacn_ip_tcp: 1.9 sec
ncacn_np: 2.5 sec
(This used to be commit 2cfc8f24ce209f47153d3a5bd7007dd1b0578b26)

12 years agor3163: Add server side support for ncalrpc: and ncacn_unix_stream:
Jelmer Vernooij [Sun, 24 Oct 2004 15:48:19 +0000 (15:48 +0000)]
r3163: Add server side support for ncalrpc: and ncacn_unix_stream:

Examples of binding strings are :


N.B. The unix socket support in lib/socket/ appears to close and remove the
socket it is listening on after the first client disconnects so until
that has been fixed, it is only possible to do one ncalrpc: or ncacn_unix_stream: request per instance of smbd :-)

Support for looking up NCALRPC names via the endpoint mapper will be added later.
(This used to be commit 426f3e63cae3d306dcdc13ee4b655eed30057ff8)

12 years agor3162: Add client-side support for the ncalrpc: and ncacn_unix_stream: transports.
Jelmer Vernooij [Sun, 24 Oct 2004 14:57:16 +0000 (14:57 +0000)]
r3162: Add client-side support for the ncalrpc: and ncacn_unix_stream: transports.

ncalrpc uses the new config option "ncalrpc dir" for creating unix sockets.
(This used to be commit b15cfbe2512961a199ecb069730d9a19787579f5)

12 years agor3161: pvfs now passes the RAW-SEEK test
Andrew Tridgell [Sun, 24 Oct 2004 14:18:03 +0000 (14:18 +0000)]
r3161: pvfs now passes the RAW-SEEK test
(This used to be commit a953d4a42c8fa3fe930c319d5157fc406a1035da)

12 years agor3160: recognise RAW_SFILEINFO_DISPOSITION_INFORMATION (fixes temporary files from...
Andrew Tridgell [Sun, 24 Oct 2004 13:41:27 +0000 (13:41 +0000)]
r3160: recognise RAW_SFILEINFO_DISPOSITION_INFORMATION (fixes temporary files from excel)
(This used to be commit 1c05147f7103127c11b06bb0a812970577ace5f6)

12 years agor3159: use easy to recognise file handle numbers for new file, old file and directory
Andrew Tridgell [Sun, 24 Oct 2004 13:40:49 +0000 (13:40 +0000)]
r3159: use easy to recognise file handle numbers for new file, old file and directory
in pvfs_open, to make analysing sniffs easy
(This used to be commit 5c16ed02542f7e143d66f4ba8d166bb6882bf53a)

12 years agor3158: Use the new tower build functions to generate protocol towers, making it
Jelmer Vernooij [Sun, 24 Oct 2004 13:30:50 +0000 (13:30 +0000)]
r3158: Use the new tower build functions to generate protocol towers, making it
easier to deal with more different transports.
(This used to be commit ee9bcfddf01ed65082bdf0bb2b43e4f3a66c3f5b)

12 years agor3157: Add ncacn_http
Jelmer Vernooij [Sun, 24 Oct 2004 13:22:58 +0000 (13:22 +0000)]
r3157: Add ncacn_http
(This used to be commit a0c4138edf919ee0c4b236f201c09fc4deb2cc09)

12 years agor3156: Couple of fixes in the conversion functions between binding structs and
Jelmer Vernooij [Sun, 24 Oct 2004 13:00:51 +0000 (13:00 +0000)]
r3156: Couple of fixes in the conversion functions between binding structs and
protocol towers
(This used to be commit f41dfc6c5a85bf241e4bcc0669f6191bf531e89a)

12 years agor3155: reformat a delete test
Andrew Tridgell [Sun, 24 Oct 2004 12:55:12 +0000 (12:55 +0000)]
r3155: reformat a delete test
(This used to be commit 739c9e401cfbe04f2596e5b4b178243263218c04)

12 years agor3154: pvfs now passes all of BASE-DELETE
Andrew Tridgell [Sun, 24 Oct 2004 12:53:13 +0000 (12:53 +0000)]
r3154: pvfs now passes all of BASE-DELETE
(This used to be commit abbfca1401818edd896493ab9c875224e3b7e0e7)

12 years agor3153: pvfs now passes the first 9 of the BASE-DELETE tests
Andrew Tridgell [Sun, 24 Oct 2004 12:39:15 +0000 (12:39 +0000)]
r3153: pvfs now passes the first 9 of the BASE-DELETE tests
(This used to be commit f8041feaebc9170763ce04d2dd90cfc1c7889c21)

12 years agor3152: reformatted some of the delete test code
Andrew Tridgell [Sun, 24 Oct 2004 12:38:32 +0000 (12:38 +0000)]
r3152: reformatted some of the delete test code
(This used to be commit d7b0dece6fbc2b5f8216b6a6a41e3db76b8627aa)

12 years agor3150: printing __location__ is more useful than a operation number
Andrew Tridgell [Sun, 24 Oct 2004 10:27:38 +0000 (10:27 +0000)]
r3150: printing __location__ is more useful than a operation number
(This used to be commit 022b21460a572803b86ef5c11f6fe0b6fa1dcae1)

12 years agor3149: separate the delete on close test into torture/basic/delete.c
Andrew Tridgell [Sun, 24 Oct 2004 09:08:52 +0000 (09:08 +0000)]
r3149: separate the delete on close test into torture/basic/delete.c
(This used to be commit 50379a0a58d9eade3e1390713ef89473c66e65fc)

12 years agor3148: make --failures work for the BASE-DENY1 and BASE-DENY2 tests
Andrew Tridgell [Sun, 24 Oct 2004 09:08:17 +0000 (09:08 +0000)]
r3148: make --failures work for the BASE-DENY1 and BASE-DENY2 tests
(This used to be commit 6e87feb89c57ca900ef4125e48f5de5ff80ff7b9)

12 years agor3147: added basic share modes support for pvfs (or more precisely, ntcreatex
Andrew Tridgell [Sun, 24 Oct 2004 08:31:41 +0000 (08:31 +0000)]
r3147: added basic share modes support for pvfs (or more precisely, ntcreatex
share_access support).  This is enough for us to pass the BASE-DENY2
test, but is a long way from fully correct share modes.
(This used to be commit b5a6dd3cbf28a3a3b3a3656042ac8f50fca29e1c)

12 years agor3142: fill in all the ntcreatex response fields explicitly, rather than
Andrew Tridgell [Sat, 23 Oct 2004 06:22:57 +0000 (06:22 +0000)]
r3142: fill in all the ntcreatex response fields explicitly, rather than
zeroing. This makes it clearer what bits are not yet implemented (and
is more valgrind friendly)
(This used to be commit 18b471327b596f3ea8f6a7b39ba0a83b2584ed0b)

12 years agor3136: - Allow specifying socket type when adding smbd service
Jelmer Vernooij [Fri, 22 Oct 2004 10:52:57 +0000 (10:52 +0000)]
r3136: - Allow specifying socket type when adding smbd service
- Make sure a epm_tower struct is completely initialized
- Some more minor fixes
(This used to be commit d560dcbdb85cb2c6915bdb9e2f82f1872b0f5a52)

12 years agor3135: split the "create new" logic out from the "open existing" logic in
Andrew Tridgell [Fri, 22 Oct 2004 07:01:32 +0000 (07:01 +0000)]
r3135: split the "create new" logic out from the "open existing" logic in
pvfs_open, and handle the various race conditions that are inherent in
cifs on unix, so we do the best we can when the race happens.

the ntcreatex code is really starting to take shape now
(This used to be commit 395c3815b468ae55de9a1135e478711f0e7d8cfc)

12 years agor3134: use struct idr_context * in tid allocation
Andrew Tridgell [Fri, 22 Oct 2004 06:57:31 +0000 (06:57 +0000)]
r3134: use struct idr_context * in tid allocation
(This used to be commit 3ea9445226a678b410bf565ec114a3c544f8ade3)

12 years agor3133: - more consistent error checking in rename and setfileinfo
Andrew Tridgell [Fri, 22 Oct 2004 06:55:18 +0000 (06:55 +0000)]
r3133: - more consistent error checking in rename and setfileinfo

- add paranoid checking of device/inode change during open to detect race conditions
(This used to be commit 043361fed487ed494fa497ffde1007b3f3bc0c29)

12 years agor3132: - fixed a type conflict found by talloc_array_p()
Andrew Tridgell [Fri, 22 Oct 2004 06:53:18 +0000 (06:53 +0000)]
r3132: - fixed a type conflict found by talloc_array_p()

- use struct idr_context * in ipc code
(This used to be commit c33cdd0d550fcaf78573e73b50ffe530ea6d9b17)

12 years agor3131: - make map_nt_error_from_unix() return NT_STATUS_UNSUCCESSFUL if errno is 0
Andrew Tridgell [Fri, 22 Oct 2004 06:49:27 +0000 (06:49 +0000)]
r3131: - make map_nt_error_from_unix() return NT_STATUS_UNSUCCESSFUL if errno is 0

- more consistent checking for system call return values in simple backend
(This used to be commit 375a9a1347abf0b917cf94ea0cabcdea37d60e98)

12 years agor3130: - added a LOCAL-IDTREE test suite
Andrew Tridgell [Fri, 22 Oct 2004 06:46:04 +0000 (06:46 +0000)]
r3130: - added a LOCAL-IDTREE test suite

- made idtree return a "struct idr_context *" instead of a void*

- more efficient idr_remove for ids that are not present (patch from Jim Houston)
(This used to be commit f8d12d4b4ae5a38de7869deb782cb8f48504844c)

12 years agor3129: typo
Volker Lendecke [Fri, 22 Oct 2004 04:48:24 +0000 (04:48 +0000)]
r3129: typo
(This used to be commit f9dfd5ff1fcfd21fee9b08993b5fe6a6fae7f9d5)

12 years agor3128: Return the correct error code for a secrets/kerberos login, but
Andrew Bartlett [Fri, 22 Oct 2004 03:02:51 +0000 (03:02 +0000)]
r3128: Return the correct error code for a secrets/kerberos login, but
skipping 'bad encryption type'.

Andrew Bartlett
(This used to be commit 4efb87eb03acfa888d455e4ca0aff18bda7f7ba5)

12 years agor3127: added the initial code for the open files database. Doesn't do
Andrew Tridgell [Fri, 22 Oct 2004 01:19:07 +0000 (01:19 +0000)]
r3127: added the initial code for the open files database. Doesn't do
anything yet, but will soon be the core of the shares modes code.
(This used to be commit ad1edabf95c6c331aac4f0caa7d31193e26bc176)

12 years agor3126: in the brlock code I had used a void* for the brl context as I didn't
Andrew Tridgell [Fri, 22 Oct 2004 01:14:49 +0000 (01:14 +0000)]
r3126: in the brlock code I had used a void* for the brl context as I didn't
want to expose the brl context structure outside the brlock.c
code. Instead, I now use "struct brl_context *" and rely on C being
happy to pass around pointers to unknown structures as long as they
are not dereferenced. I will be interested to see how the build farm
likes this.
(This used to be commit cb155c8ad837285c5a7f5b104968239df0b65fd2)

12 years agor3125: Store object UUID directly instead of using a pointer (struct dcerpc_binding)
Jelmer Vernooij [Thu, 21 Oct 2004 21:57:30 +0000 (21:57 +0000)]
r3125: Store object UUID directly instead of using a pointer (struct dcerpc_binding)
Let test fail if messaging_init() fails instead of generating segfault in the LOCAL-MESSAGING test
(This used to be commit 0609f410ef756501d50c04b544387ae547fcd63c)

12 years agor3124: Add dcerpc_binding_from_tower()
Jelmer Vernooij [Thu, 21 Oct 2004 21:02:51 +0000 (21:02 +0000)]
r3124: Add dcerpc_binding_from_tower()
Add tests for dcerpc_binding_from_tower()
(This used to be commit 88c6d34bba1a409127b26f86bd963bfab30a804c)

12 years agor3123: Add dcerpc_binding_build_tower()
Jelmer Vernooij [Thu, 21 Oct 2004 19:54:38 +0000 (19:54 +0000)]
r3123: Add dcerpc_binding_build_tower()
Add local test for testing the functions dcerpc_parse_binding(),
dcerpc_binding_string() and dcerpc_binding_build_tower()
(This used to be commit 7a07c2c769b8e51178789eed4a31577f5d39f63a)

12 years agor3118: Eliminate struct dcesrv_ep_description and replace it with
Jelmer Vernooij [Thu, 21 Oct 2004 17:40:55 +0000 (17:40 +0000)]
r3118: Eliminate struct dcesrv_ep_description and replace it with
struct dcerpc_binding.
(This used to be commit 2046e14cf8d010d4e715124859df2c1c3c782266)

12 years agor3115: Bugfixes and extra debug in our kerberos verify code.
Andrew Bartlett [Thu, 21 Oct 2004 15:24:50 +0000 (15:24 +0000)]
r3115: Bugfixes and extra debug in our kerberos verify code.

Andrew Bartlett
(This used to be commit 9f19aae0c0812b156054385ef77785971488e21c)

12 years agor3114: - More work on merging the various structs that describe endpoints
Jelmer Vernooij [Thu, 21 Oct 2004 12:47:02 +0000 (12:47 +0000)]
r3114: - More work on merging the various structs that describe endpoints
- Add protocol sequence to dcerpc transports (will be used later on)
- Add more transports to the list
(This used to be commit ab110192e6e2c1e5a3b2befe7b61158744f15d18)

12 years agor3113: make us able to generate the PAC with the same align as a MS KDC
Stefan Metzmacher [Thu, 21 Oct 2004 12:36:54 +0000 (12:36 +0000)]
r3113: make us able to generate the PAC with the same align as a MS KDC

(we should fix pidl to handle NDR_ALIGN8 correct as a real fix for this problem)

(This used to be commit ab7a26a95052cfd8bac1d03b534b5b516b409f61)

12 years agor3112: Fix two more instances of epm_towers (sorry, metze!)
Jelmer Vernooij [Thu, 21 Oct 2004 11:39:58 +0000 (11:39 +0000)]
r3112: Fix two more instances of epm_towers (sorry, metze!)
(This used to be commit 7baf493966aa3fb61623d6030b5ccc26a5fcb186)

12 years agor3111: Add a few more protocol identifiers, rhs for ncalrpc
Jelmer Vernooij [Thu, 21 Oct 2004 10:52:03 +0000 (10:52 +0000)]
r3111: Add a few more protocol identifiers, rhs for ncalrpc
(This used to be commit 53567a83cbca9df60bef76a15df24d2cd89a16b0)

12 years agor3110: Fix the krb5 client and server, so that it doesn't segfault. There
Andrew Bartlett [Thu, 21 Oct 2004 08:52:01 +0000 (08:52 +0000)]
r3110: Fix the krb5 client and server, so that it doesn't segfault.  There
were also gensec bugs that didn't turn up until we hit error paths in
the krb5 code.

Andrew Bartlett
(This used to be commit e08366ffeb52e8c522d3808a2af1aa0bc632b55f)

12 years agor3109: Give krbtgt and our machine account a random password in provision.
Andrew Bartlett [Thu, 21 Oct 2004 07:10:59 +0000 (07:10 +0000)]
r3109: Give krbtgt and our machine account a random password in provision.

Andrew Bartlett
(This used to be commit 560a8c9f424495f85284a456e829326d2a931e6e)

12 years agor3108: try to cope with servers that put FILE_ATTRIBUTE_NONINDEXED on files in the...
Andrew Tridgell [Thu, 21 Oct 2004 06:37:15 +0000 (06:37 +0000)]
r3108: try to cope with servers that put FILE_ATTRIBUTE_NONINDEXED on files in the RAW-OPEN test
(This used to be commit bed7d12f266b6aa6d4f694dd74a2c6134cd72663)

12 years agor3107: slight tweak to the openx -> ntcreatex mapping routine. This mapping
Andrew Tridgell [Thu, 21 Oct 2004 06:36:14 +0000 (06:36 +0000)]
r3107: slight tweak to the openx -> ntcreatex mapping routine. This mapping
can never be perfect, as openx can do things that ntcreatex can't, but
with this tweak we get close (the BASE-DENY1 test passes completely,
for example)
(This used to be commit 88112b9677b3c9ca97d349905c95516c6f29c8a7)

12 years agor3106: don't call a tree disconnect in the cifs backend, as during a smbd
Andrew Tridgell [Thu, 21 Oct 2004 06:34:17 +0000 (06:34 +0000)]
r3106: don't call a tree disconnect in the cifs backend, as during a smbd
server shutdown we don't want a synchronous operation which may block
to be called, thus delaying the shutdown.
(This used to be commit 5882f7305fa850c39088e85eefd311c8ede15597)

12 years agor3105: using __location__ instead of __LINE__ to give info on error locations is...
Andrew Tridgell [Thu, 21 Oct 2004 03:49:17 +0000 (03:49 +0000)]
r3105: using __location__ instead of __LINE__ to give info on error locations is more useful
(This used to be commit 80dd22a1f1aea27312b3cd06addf50e7c288259e)

12 years agor3104: My Win2k3 server, with current updates, still sends the LM key for level 6.
Andrew Bartlett [Thu, 21 Oct 2004 01:55:46 +0000 (01:55 +0000)]
r3104: My Win2k3 server, with current updates, still sends the LM key for level 6.

I'm not quite sure what's going on here, but adjust expected values
till I can find out how to reproduce this the other way...

Andrew Bartlett
(This used to be commit 3f0f6b38f2401e3654f73f46a22d5c10fbacaeca)

12 years agor3103: use a destructor to ensure that on abnormnal rpc request termination
Andrew Tridgell [Thu, 21 Oct 2004 01:44:46 +0000 (01:44 +0000)]
r3103: use a destructor to ensure that on abnormnal rpc request termination
it is removed from the pending list.
(This used to be commit 33176e9751374de3b5dc3f5f9b19c6824140d90a)

12 years agor3102: typo
Stefan Metzmacher [Thu, 21 Oct 2004 00:49:39 +0000 (00:49 +0000)]
r3102: typo

(This used to be commit 3bbda7475a63f939019a41a0b7da8d179c533d79)

12 years agor3101: some minor fixes
Stefan Metzmacher [Thu, 21 Oct 2004 00:47:05 +0000 (00:47 +0000)]
r3101: some minor fixes

(This used to be commit 61de2229e27c55041cb4e1aac32bc1d8ed68a05c)

12 years agor3100: support 'bin/smbclient //w2k3-101/c$ -U \\administrator@w2k3.vmnet1.vm.base'
Stefan Metzmacher [Thu, 21 Oct 2004 00:26:43 +0000 (00:26 +0000)]
r3100: support 'bin/smbclient //w2k3-101/c$ -U \\administrator@w2k3.vmnet1.vm.base'

we need to send an empty string as userdomain in this case.
fix bug #1317 in the client side

(This used to be commit 958aa8de630b2a88f29ccdf80ac0fc44a8205401)

12 years agor3099: implment sldb_ModifyDN()
Stefan Metzmacher [Wed, 20 Oct 2004 23:27:09 +0000 (23:27 +0000)]
r3099: implment sldb_ModifyDN()

(This used to be commit a25d1c44198fe9dd2c0a1c3472b58000f2d95e60)

12 years agor3098: - fix segfault in sldb_Compare()
Stefan Metzmacher [Wed, 20 Oct 2004 23:25:39 +0000 (23:25 +0000)]
r3098: - fix segfault in sldb_Compare()

- be more verbose on the INVALID_DN errstr

(This used to be commit 4b8d90866efb0ed7fcc8e44e29c3d84f7537621c)

12 years agor3097: - an empty string is a valid DN
Stefan Metzmacher [Wed, 20 Oct 2004 23:12:30 +0000 (23:12 +0000)]
r3097: - an empty string is a valid DN

- detect in valid DN's

- some error handling fixes

(This used to be commit d92eff232864aaf1e0e3c6bb26079cd5abb29d79)

12 years agor3096: typo
Stefan Metzmacher [Wed, 20 Oct 2004 22:44:08 +0000 (22:44 +0000)]
r3096: typo

(This used to be commit c730d7d638875c239f0b67c1d4b25eb1fb01c5ff)

12 years agor3095: - fix a free'ing of msg.dn
Stefan Metzmacher [Wed, 20 Oct 2004 20:48:31 +0000 (20:48 +0000)]
r3095: - fix a free'ing of msg.dn

- reenable index tests

(This used to be commit 1e7e94fdb10db831090f9bd37e39053dfcde04ce)

12 years agor3094: import all LDAP error codes from the RFC 2251
Stefan Metzmacher [Wed, 20 Oct 2004 20:34:32 +0000 (20:34 +0000)]
r3094: import all LDAP error codes from the RFC 2251

(This used to be commit f1d8f4bc5df5b4f284739096684c9dbc76352511)

12 years agor3093: - implment ldb_rename() and ldbrename
Stefan Metzmacher [Wed, 20 Oct 2004 19:28:02 +0000 (19:28 +0000)]
r3093: - implment ldb_rename() and ldbrename

- add tests for ldbrename

- disable all tests which regenerate the index
  (this is broken for me...the process hangs,
   tridge we need to discuss that)

- link only the needed stuff to the ldb tools

- build ldbtest inside samba

(This used to be commit 18552f4786c24e0019cc87726ef4c05365fe586e)

12 years agor3092: prepare for build inside samba
Stefan Metzmacher [Wed, 20 Oct 2004 19:21:10 +0000 (19:21 +0000)]
r3092: prepare for build inside samba

(This used to be commit f7564bf4d2efb702cf3d11237fbe2adf5efb1ebf)

12 years agor3091: link only the needed stuff
Stefan Metzmacher [Wed, 20 Oct 2004 19:19:03 +0000 (19:19 +0000)]
r3091: link only the needed stuff

(This used to be commit 71ccac56c21635e7f6eb8d558230f637f50149ad)

12 years agor3089: fix memleak
Stefan Metzmacher [Wed, 20 Oct 2004 17:42:17 +0000 (17:42 +0000)]
r3089: fix memleak

(This used to be commit 52eab8dc17a1cd1a8c0382ab8d6e7f6c7ddeea19)

12 years agor3087: fixed a typo
Andrew Tridgell [Wed, 20 Oct 2004 12:24:31 +0000 (12:24 +0000)]
r3087: fixed a typo
(This used to be commit 3791b97694f052b0b7e170e07c21f7a5739d74dd)

12 years agor3086: fixed smbpid handling in the cifs backend
Andrew Tridgell [Wed, 20 Oct 2004 12:08:40 +0000 (12:08 +0000)]
r3086: fixed smbpid handling in the cifs backend
(This used to be commit fbc6949e95df6ea70ca9892099efb537ded97287)

12 years agor3085: make the RAW-WRITE tests more robust to errors in previous parts of the test
Andrew Tridgell [Wed, 20 Oct 2004 11:13:54 +0000 (11:13 +0000)]
r3085: make the RAW-WRITE tests more robust to errors in previous parts of the test
(This used to be commit 6ea815b6d426d37723a200226cb5f7236a13017f)

12 years agor3084: mincnt and maxcnt were the wrong way around in readbraw server code
Andrew Tridgell [Wed, 20 Oct 2004 11:11:55 +0000 (11:11 +0000)]
r3084: mincnt and maxcnt were the wrong way around in readbraw server code
(This used to be commit e11b000319953dfeeb84fed142e857a5247a93e9)

12 years agor3083: fixed a couple of generic mapping errors found with RAW-* and cifs:mapgeneric
Andrew Tridgell [Wed, 20 Oct 2004 11:10:51 +0000 (11:10 +0000)]
r3083: fixed a couple of generic mapping errors found with RAW-* and cifs:mapgeneric
(This used to be commit 76329798ff7f804bf4d7e6e9c1bb4c4dc7b9bb01)

12 years agor3082: added a "cifs:mapgeneric" option, which tells the cifs backend to use
Andrew Tridgell [Wed, 20 Oct 2004 11:08:58 +0000 (11:08 +0000)]
r3082: added a "cifs:mapgeneric" option, which tells the cifs backend to use
the ntvfs_generic mapping functions rather than sending the exact
function asked for. This allows the generic mapping functions to be
tested by comparing the behaviour of smbtorture against two cifs
backend shares, one using "cifs:mapgeneric = true" and the other
"cifs:mapgeneric = False"
(This used to be commit c240c6bca5e10f1acbff45b0ed41c4c1ebcaae96)

12 years agor3081: several updates to ntvfs and server side async request handling in
Andrew Tridgell [Wed, 20 Oct 2004 08:28:31 +0000 (08:28 +0000)]
r3081: several updates to ntvfs and server side async request handling in
preparation for the full share modes and ntcreatex code that I am
working on.

highlights include:

 - changed the way a backend determines if it is allowed to process a
   request asynchronously. The previous method of looking at the
   send_fn caused problems when an intermediate ntvfs module disabled
   it, and the caller then wanted to finished processing using this
   function. The new method is a REQ_CONTROL_MAY_ASYNC flag in
   req->control_flags, which is also a bit easier to read

 - fixed 2 bugs in the readbraw server code. One related to trying to
   answer a readbraw with smb signing (which can't work, and crashed
   our signing code), the second related to error handling, which
   attempted to send a normal SMB error packet, when readbraw must
   send a 0 read reply (as it has no header)

 - added several more ntvfs_generic.c generic mapping functions. This
   means that backends no longer need to implement such esoteric
   functions as SMBwriteunlock() if they don't want to. The backend
   can just request the mapping layer turn it into a write followed by
   an unlock. This makes the backends considerably simpler as they
   only need to implement one style of each function for lock, read,
   write, open etc, rather than the full host of functions that SMB
   provides. A backend can still choose to implement them
   individually, of course, and the CIFS backend does that.

 - simplified the generic structures to make them identical to the
   principal call for several common SMB calls (such as
   RAW_WRITE_GENERIC now being an alias for RAW_WRITE_WRITEX).

 - started rewriting the pvfs_open() code in preparation for the full
   ntcreatex semantics.

 - in pvfs_open and ipc_open, initially allocate the open file
   structure as a child of the request, so on error we don't need to
   clean up. Then when we are going to succeed the open steal the
   pointer into the long term backend context. This makes for much
   simpler error handling (and fixes some bugs)

 - use a destructor in the ipc backend to make sure that everthing is
   cleaned up on receive error conditions.

 - switched the ipc backend to using idtree for fnum allocation

 - in the ntvfs_generic mapping routines, use a allocated secondary
   structure not a stack structure to ensure the request pointer
   remains valid even if the backend replies async.
(This used to be commit 3457c1836c09c82956697eb21627dfa2ed37682e)

12 years agor3080: Make the Samba4 SAMR server pass the new, nasty torture test (now that
Andrew Bartlett [Wed, 20 Oct 2004 02:26:59 +0000 (02:26 +0000)]
r3080: Make the Samba4 SAMR server pass the new, nasty torture test (now that
SAMR_FIELD_PASSWORD has been split up).

Andrew Bartlett
(This used to be commit 5f2295a5fb422ad028e67b240e55206acefb48bd)

12 years agor3079: make code more pretty :-)
Andrew Bartlett [Wed, 20 Oct 2004 02:14:28 +0000 (02:14 +0000)]
r3079: make code more pretty :-)

Andrew Bartlett
(This used to be commit 9c911b361c4dbb058eb48150c113c2e95b8053da)

12 years agor3078: Allow more things to be set as command line options to provision.
Andrew Bartlett [Wed, 20 Oct 2004 02:13:45 +0000 (02:13 +0000)]
r3078: Allow more things to be set as command line options to provision.

Andrew Bartlett
(This used to be commit 2df85686f55049276eb60cbc3ca4bc1cfa9f7f0f)

12 years agor3077: Add initial handling of Account Flags in SAMR user info level 21 and 25.
Andrew Bartlett [Wed, 20 Oct 2004 02:12:52 +0000 (02:12 +0000)]
r3077: Add initial handling of Account Flags in SAMR user info level 21 and 25.

Andrew Bartlett
(This used to be commit 51774a9bcad97686e5259ac8d753b3df58072622)

12 years agor3076: Fix memory leak.
Andrew Bartlett [Wed, 20 Oct 2004 02:11:40 +0000 (02:11 +0000)]
r3076: Fix memory leak.

Andrew Bartlett
(This used to be commit 4091fee8e807e5cd7089dc6753324766d10678c2)

12 years agor3075: Initialise (and check for intialisation) of the private pointer to
Andrew Bartlett [Wed, 20 Oct 2004 02:10:46 +0000 (02:10 +0000)]
r3075: Initialise (and check for intialisation) of the private pointer to
ensure we don't segfault on the cleanup from an incomplete schannel

Andrew Bartlett
(This used to be commit 173f29a1d8db111d5adb258eead5379d681d3bb2)

12 years agor3074: Add in a new 'field present' flag samr.idl for the Account Flags
Andrew Bartlett [Wed, 20 Oct 2004 02:08:36 +0000 (02:08 +0000)]
r3074: Add in a new 'field present' flag samr.idl for the Account Flags
field.  Add torture test for setting this feild - including all the
odd cases (not all the flags 'stick', and not others cannot be

Seperate the two 'password change' flags, and test them both in the
torture code.

Check that the password did change after every password set call.

Andrew Bartlett
(This used to be commit 3759128bd33b802d5213d50ba25f7c7d11cfe1d7)

12 years agor3073: Fix bug in the handling of null-terminated ASCII strings in RPC.
Andrew Bartlett [Wed, 20 Oct 2004 02:02:00 +0000 (02:02 +0000)]
r3073: Fix bug in the handling of null-terminated ASCII strings in RPC.

Because we didn't count the null terminator, we would not move past it
in the packet.

Andrew Bartlett
(This used to be commit 8b38bffc7098610c469ab61b7e0e6884f046f286)

12 years agor3064: - use UINT8_MAX and UINT16_MAX instead of hex values for idr_get_new() limits
Andrew Tridgell [Tue, 19 Oct 2004 12:06:01 +0000 (12:06 +0000)]
r3064:  - use UINT8_MAX and UINT16_MAX instead of hex values for idr_get_new() limits

 - change idr_get_new() to use > instead of >= in the limit check
(This used to be commit 834b09929bcb8aabdd151b7c2306001497cabdb4)

12 years agor3063: our default dos charset is CP850, but some systems don't have that, so
Andrew Tridgell [Tue, 19 Oct 2004 10:15:34 +0000 (10:15 +0000)]
r3063: our default dos charset is CP850, but some systems don't have that, so
as a special case, automatically fall back to ASCII if its not found.
(This used to be commit 55aeb33343180929fbd7b3568b058b506aee7540)

12 years agor3062: handle spaces at the start of options in lp_set_cmdline()
Andrew Tridgell [Tue, 19 Oct 2004 10:02:02 +0000 (10:02 +0000)]
r3062: handle spaces at the start of options in lp_set_cmdline()
(This used to be commit 069305adaf5e88d83f4591acced807d5ea1aa194)

12 years agor3061: change a debug to help track down a charset problem
Andrew Tridgell [Tue, 19 Oct 2004 09:53:23 +0000 (09:53 +0000)]
r3061: change a debug to help track down a charset problem
(This used to be commit 4d2497b7f4cb6aa6fdf1e03b56f72b1022cb92b8)

12 years agor3060: Replace magic number with a C99 constant.
Tim Potter [Tue, 19 Oct 2004 07:41:19 +0000 (07:41 +0000)]
r3060: Replace magic number with a C99 constant.
(This used to be commit b572be00b3432317169c6fa6df3f91a0c8f23fcb)

12 years agor3059: completely get rid of the MAX_CONNECTIONS limit, as a idle tree
Andrew Tridgell [Tue, 19 Oct 2004 07:18:56 +0000 (07:18 +0000)]
r3059: completely get rid of the MAX_CONNECTIONS limit, as a idle tree
connect is very cheap now.
(This used to be commit 8856f010e96d2f20d349a51820f225a8493f6eef)

12 years agor3058: we don't use the bitmap code any more, delete it
Andrew Tridgell [Tue, 19 Oct 2004 07:10:56 +0000 (07:10 +0000)]
r3058: we don't use the bitmap code any more, delete it
(This used to be commit 2b0554b3b598accb1b2ddade1bf17fa2cc2cb05b)