12 years agor21345: Smaller fixes for adssearch:
Günther Deschner [Wed, 14 Feb 2007 16:20:38 +0000 (16:20 +0000)]
r21345: Smaller fixes for adssearch:

* get rid of horrible ads.h parsing
* display hex bitmasks

(This used to be commit 97ce4ccea215098f574a40a3192d37910f30c79a)

12 years agor21339: Fix the non-linux build. This is more evidence that this needs to be
Jim McDonough [Wed, 14 Feb 2007 14:25:56 +0000 (14:25 +0000)]
r21339: Fix the non-linux build.  This is more evidence that this needs to be
moved up one layer.
(This used to be commit 552ae93b14ff1674a8b2f369e57ad2d7d0712a70)

12 years agor21336: Fix indent (as pointed out by Volker).
Günther Deschner [Wed, 14 Feb 2007 13:51:42 +0000 (13:51 +0000)]
r21336: Fix indent (as pointed out by Volker).

(This used to be commit dcbf7a1250aa5c6293ffba6a930ee23537ec9484)

12 years agor21324: Add linux setlease to the vfs layer. Next round, as Volker points out,
Jim McDonough [Wed, 14 Feb 2007 02:37:14 +0000 (02:37 +0000)]
r21324: Add linux setlease to the vfs layer.  Next round, as Volker points out,
it should be abstracted a little higher up so other os'es can have an
entry, but it will take a bit more work.  Thanks to Chetan Shringarpure
and Mathias Dietz.

I didn't increment the vfs number again because the kernel change notify
stuff hasn't been released yet anyway.
(This used to be commit 9463211bf3b46ee408b88dfbf42d498e3839d4cc)

12 years agor21320: Display query_user info level 16 in rpcclient.
Günther Deschner [Tue, 13 Feb 2007 16:04:36 +0000 (16:04 +0000)]
r21320: Display query_user info level 16 in rpcclient.

(This used to be commit bc77622134e606b8a643454493ba316f84312d52)

12 years agor21319: Remove functions not needed anymore
Volker Lendecke [Tue, 13 Feb 2007 15:57:54 +0000 (15:57 +0000)]
r21319: Remove functions not needed anymore
(This used to be commit 0c8a364aec68bc7338d034b6f8223ec4085c9e07)

12 years agor21318: Fix Bug #4225.
Günther Deschner [Tue, 13 Feb 2007 15:56:09 +0000 (15:56 +0000)]
r21318: Fix Bug #4225.

Cached logon with pam_winbind should work now also for NT4 and samba3

(This used to be commit b2f91154820219959b8008b15802c70e1d76d158)

12 years agor21312: merge from SAMBA_4_0:
Stefan Metzmacher [Tue, 13 Feb 2007 12:42:28 +0000 (12:42 +0000)]
r21312: merge from SAMBA_4_0:

fix memory hierachy, and access to already freed memory

(This used to be commit 05a23dd75655a80667627e00e0a441b54ec92b22)

12 years agor21310: Fix invalid printfs in pam_winbind.
Günther Deschner [Tue, 13 Feb 2007 11:04:10 +0000 (11:04 +0000)]
r21310: Fix invalid printfs in pam_winbind.

(This used to be commit 5a7b2fccb3cdc6a849aedcd256eea86faec1d54c)

12 years agor21309: Add PRINTF_ATTRIBUTE checks for log statements.
Günther Deschner [Tue, 13 Feb 2007 10:56:04 +0000 (10:56 +0000)]
r21309: Add PRINTF_ATTRIBUTE checks for log statements.

(This used to be commit 968dfcc8218cacdd97c2c66929e95f5062ff464a)

12 years agor21308: Fix some typos and ensure to null terminate the correct strings.
Günther Deschner [Tue, 13 Feb 2007 10:42:53 +0000 (10:42 +0000)]
r21308: Fix some typos and ensure to null terminate the correct strings.

(This used to be commit 16c90f30b93f32c4f8fed00a6cc154c596e4244d)

12 years agor21303: As discussed on samba-technical: Change the static array for the in-memory
Volker Lendecke [Mon, 12 Feb 2007 23:16:02 +0000 (23:16 +0000)]
r21303: As discussed on samba-technical: Change the static array for the in-memory
mirrors of the hash chain locks to a dynamically allocated one.

Jeremy, I count on you to revert it if the build farm freaks out, it's after
midnight here :-)

(This used to be commit c50f099be1fcae2d533e1c3816cb25c315ba167a)

12 years agor21284: Fix some unitilized variable warnings pointed out by Volker.
Gerald Carter [Sun, 11 Feb 2007 19:47:38 +0000 (19:47 +0000)]
r21284: Fix some unitilized variable warnings pointed out by Volker.
(This used to be commit 5c3edad86098c5271cb141b8f7885ca7f5b48072)

12 years agor21283: Do not display away debug output of cifs dfs resolver by default
Steve French [Sun, 11 Feb 2007 19:28:52 +0000 (19:28 +0000)]
r21283: Do not display away debug output of cifs dfs resolver by default
per Dave Howell's suggestion
(This used to be commit 529d64b4c862bee051e13a87e521d919c6dd84f5)

12 years agor21280: Fix an uninitialized variable warning. Jeremy, please check.
Volker Lendecke [Sun, 11 Feb 2007 14:55:21 +0000 (14:55 +0000)]
r21280: Fix an uninitialized variable warning. Jeremy, please check.

(This used to be commit 4faa37a515fb6c6fa0f9364271755f954429beec)

12 years agor21279: Get rid of 'aio write behind', this is broken.
Volker Lendecke [Sun, 11 Feb 2007 14:39:21 +0000 (14:39 +0000)]
r21279: Get rid of 'aio write behind', this is broken.

It should probably better be integrated with our write cache.

(This used to be commit 58bfd168b046a97a895aaa3384fd7af8d077a1d5)

12 years agor21278: The main goal of this was to get rid of the NetInBuffer / set_InBuffer. But it
Volker Lendecke [Sun, 11 Feb 2007 14:07:50 +0000 (14:07 +0000)]
r21278: The main goal of this was to get rid of the NetInBuffer / set_InBuffer. But it
turns out that this patch actually speeds up the async writes considerably.

I tested writing 100.000 times 65535 bytes with the allowed 10 ops in
parallel. Without this patch it took about 32 seconds on my dual-core 1.6GHz
laptop. With this patch it dropped to about 26 seconds. I can only explain it
by better cache locality, NewInBuffer allocates more than 128k, so we jump
around in memory more.

Jeremy, please check!

(This used to be commit 452d51bc6fd41771b9c41ba6391664513d7cf2cd)

12 years agor21277: Fix an off by one error in the signal handler for aio: We can actually receive
Volker Lendecke [Sun, 11 Feb 2007 13:42:48 +0000 (13:42 +0000)]
r21277: Fix an off by one error in the signal handler for aio: We can actually receive
AIO_PENDING_SIZE signals, not one less.

Jeremy I'm not merging this to 3_0_25, I want you to look at it first!

(This used to be commit 8fd0ec58360a349826508fc361a943650fdd6694)

12 years agor21274: As we now have POSIX opens which can unlink
Jeremy Allison [Sun, 11 Feb 2007 04:37:56 +0000 (04:37 +0000)]
r21274: As we now have POSIX opens which can unlink
with other open files we may have taken
the delete code path with more than one share mode
entry - ensure we only delete once by resetting
the delete on close flag.
(This used to be commit 429dff31663e71556b5193b25d5b8e7e09fa5b9c)

12 years agor21273: * Protect the sasl bind against a NULL principal string
Gerald Carter [Sat, 10 Feb 2007 20:29:09 +0000 (20:29 +0000)]
r21273: * Protect the sasl bind against a NULL principal string
  in the SPNEGO negTokenInit
(This used to be commit fe70c224964bf15d626bfd4e0cc6d060e45bba87)

12 years agor21269: Reformatting
Volker Lendecke [Sat, 10 Feb 2007 13:15:58 +0000 (13:15 +0000)]
r21269: Reformatting
(This used to be commit b2eaa733c52113f53b6ff8aea9fce20ede1e3b1f)

12 years agor21265: Fix some valgrind errors -- not in 3_0
Volker Lendecke [Fri, 9 Feb 2007 23:14:23 +0000 (23:14 +0000)]
r21265: Fix some valgrind errors -- not in 3_0
(This used to be commit b419a3407532efcd50f54c77927b3b3bb566845f)

12 years agor21264: LDAP_OPT_ERROR_NUMBER seems more portable than LDAP_OPT_RESULT_CODE
Volker Lendecke [Fri, 9 Feb 2007 21:25:22 +0000 (21:25 +0000)]
r21264: LDAP_OPT_ERROR_NUMBER seems more portable than LDAP_OPT_RESULT_CODE
(This used to be commit 1b3239f2abea9146c7d0d4af06c47a63e0caf006)

12 years agor21263: getpeername() returning -1 is not a reliable indication if a TCP connection is
Volker Lendecke [Fri, 9 Feb 2007 20:58:17 +0000 (20:58 +0000)]
r21263: getpeername() returning -1 is not a reliable indication if a TCP connection is
dead. Might be my code, this rings a very distant bell...

Attempt to fix bug # 4372.

(This used to be commit 730cc3dc1e332449f3e902217ccb9cc3057b9ef3)

12 years agor21262: Final part of BUG 4093: fix %a with Windows XP 64bit
Gerald Carter [Fri, 9 Feb 2007 19:41:09 +0000 (19:41 +0000)]
r21262: Final part of BUG 4093: fix %a with Windows XP 64bit
(This used to be commit e2681eb4be1a9bd001eed0f39e5b5d370cf71ed6)

12 years agor21259: Fix coverity bug id #340. No way to process
Jeremy Allison [Fri, 9 Feb 2007 05:16:25 +0000 (05:16 +0000)]
r21259: Fix coverity bug id #340. No way to process
logon parameter as the code was written.
(This used to be commit 7f1aee96a09d77de76b2cdbe5c2e6f27e6968b09)

12 years agor21258: Fix for connecting printers from Vista by storing
Gerald Carter [Fri, 9 Feb 2007 02:12:12 +0000 (02:12 +0000)]
r21258: Fix for connecting printers from Vista by storing
the printer GUID as a REG_SZ as Vista seems to
whine about unknown REG_BINARY values.

Thanks to Martin Zielinski <> for his excellent
analysis on this.
(This used to be commit fa5490b71b5cd41b63b028aa8a316e1197263083)

12 years agor21257: Better fix for bug #4188 :
Jeremy Allison [Fri, 9 Feb 2007 02:03:39 +0000 (02:03 +0000)]
r21257: Better fix for bug #4188 :
Windows Vista RC1 and RC2 can't delete directory on Samba share
based on work by Joe Meadows <>.
(This used to be commit 2dab8928769938ab79da7b7ce2d165fc388f9b00)

12 years agor21251: Okay, after Jeremy has kindly tested this, check it in :-)
Volker Lendecke [Thu, 8 Feb 2007 21:57:41 +0000 (21:57 +0000)]
r21251: Okay, after Jeremy has kindly tested this, check it in :-)

Attached find a workaround that works for me. This is not the "correct" fix,
to me it seems our DFS referral marshalling is broken. Vista requests level 4,
we reply with level 2, and Vista seems not to like that. If we reply with
level 3 it seems more happy.

Needs more work!

(This used to be commit 4c3a9135629415086698da28596f68f7a9db9133)

12 years agor21250: Partial fix for BUG 4093: Make %a expand to "Vista"
Gerald Carter [Thu, 8 Feb 2007 21:48:09 +0000 (21:48 +0000)]
r21250: Partial fix for BUG 4093: Make %a expand to "Vista"
based on the flags2 values in the negprot request.

This also includes some code for testing the dialect
strings for "SMB 2.001" but this is unreliable as Vista
only sends that in the 1st negprot and caches the fact
that we don't support it.  Restartnig the WOrkstation
service on the client clears the cache.
(This used to be commit d781eeb0e4362b7af1497634d26315498a5257d4)

12 years agor21247: In the refactoring I dropped a RESOLVE_DFSPATH call
Jeremy Allison [Thu, 8 Feb 2007 20:31:18 +0000 (20:31 +0000)]
r21247: In the refactoring I dropped a RESOLVE_DFSPATH call
from setpathinfo. Return it and make sure all paths
go through a dfs resolve.
(This used to be commit 7fd3a146c11b70428ab5fbd7dc0272706abf8280)

12 years agor21246: Remove incorrect control on unix set info.
Jeremy Allison [Thu, 8 Feb 2007 19:42:27 +0000 (19:42 +0000)]
r21246: Remove incorrect control on unix set info.
We can take path or handle based calls.
(This used to be commit a19fe0f0c4a809d9b086e904586243949f57ec96)

12 years agor21240: Fix longstanding Bug #4009.
Günther Deschner [Thu, 8 Feb 2007 17:02:39 +0000 (17:02 +0000)]
r21240: Fix longstanding Bug #4009.

For the winbind cached ADS LDAP connection handling
(ads_cached_connection()) we were (incorrectly) assuming that the
service ticket lifetime equaled the tgt lifetime. For setups where the
service ticket just lives 10 minutes, we were leaving hundreds of LDAP
connections in CLOSE_WAIT state, until we fail to service entirely with
"Too many open files".

Also sequence_number() in winbindd_ads.c needs to delete the cached LDAP
connection after the ads_do_search_retry() has failed to submit the
search request (although the bind succeeded (returning an expired
service ticket that we cannot delete from the memory cred cache - this
will get fixed later)).

(This used to be commit 7e1a84b7226fb8dcd5d34c64a3478a6d886a9a91)

12 years agor21239: if the workgroup name is longer than 16 chars we get garbage in the string
Simo Sorce [Thu, 8 Feb 2007 14:55:21 +0000 (14:55 +0000)]
r21239: if the workgroup name is longer than 16 chars we get garbage in the string
server_len is usually 256 (fstring).

Correctly terminate saving the lenght
(This used to be commit e7e44554bf7c61020e2c5c652e3f8f37a296d3aa)

12 years agor21238: Fix tab indent in self-written krb5.confs.
Günther Deschner [Thu, 8 Feb 2007 13:50:47 +0000 (13:50 +0000)]
r21238: Fix tab indent in self-written krb5.confs.

(This used to be commit 4df582fa1049afe96bbee7e8cab93cfa82208ba3)

12 years agor21237: Forgot configure checks in 3_0 (3_0_25 is fine) for heimdal kinit fix.
Günther Deschner [Thu, 8 Feb 2007 12:40:29 +0000 (12:40 +0000)]
r21237: Forgot configure checks in 3_0 (3_0_25 is fine) for heimdal kinit fix.

(This used to be commit 8700829c1f6b8851035c6b6d3da7aea720320db7)

12 years agor21231: get rid of unused defines that cause a redefined warning
Herb Lewis [Thu, 8 Feb 2007 02:17:29 +0000 (02:17 +0000)]
r21231: get rid of unused defines that cause a redefined warning
(This used to be commit 509ae5ffa17be340c41fecaaace75816c18316c6)

12 years agor21229: Don't indirect through a potentially null pointer :-).
Jeremy Allison [Thu, 8 Feb 2007 00:41:57 +0000 (00:41 +0000)]
r21229: Don't indirect through a potentially null pointer :-).
(This used to be commit 6723f9d85ccb4883f15658aceb021b4c4a752edf)

12 years agor21228: Fix for fd leak on error path. Thanks to
Jeremy Allison [Thu, 8 Feb 2007 00:28:25 +0000 (00:28 +0000)]
r21228: Fix for fd leak on error path. Thanks to for this fix !
(This used to be commit 70b5db7d8c6aa324ad98436fe3fafe715c04c5a8)

12 years agor21227: Quick fix for Stevef - ensure the returned data on open
Jeremy Allison [Thu, 8 Feb 2007 00:14:37 +0000 (00:14 +0000)]
r21227: Quick fix for Stevef - ensure the returned data on open
is 8 byte aligned.
(This used to be commit 7645044fcf77644839bb0d74163d93d03284bd67)

12 years agor21226: Fix bug #4377 (rename of "foo" -> "Foo" fails).
Jeremy Allison [Wed, 7 Feb 2007 22:20:31 +0000 (22:20 +0000)]
r21226: Fix bug #4377 (rename of "foo" -> "Foo" fails).
This is actually an interesting case as it exposed bad code in our DFS redirect
module (that was where the bug was introduced).
Caused by our turning on dfsroot be default.
(This used to be commit 5fe25588f57ee59d70a66c755dfe70312e7afd08)

12 years agor21225: Couple of fixes from Martin Zielinski,
Jeremy Allison [Wed, 7 Feb 2007 20:20:56 +0000 (20:20 +0000)]
r21225: Couple of fixes from Martin Zielinski,
one typo, one to make sure that time initialization
is done before modules that depend on it (printer
(This used to be commit 6df32b4a6a9abd40e963c188b4c8769f15a0ab9b)

12 years agor21224: Initial checkin of cifs_host_name resolver helper script
Steve French [Wed, 7 Feb 2007 20:16:02 +0000 (20:16 +0000)]
r21224: Initial checkin of cifs_host_name resolver helper script
(needed by /sbin keyctl utils to finish the upcall)
(This used to be commit 738d29dbcc6eae44ea91bdcf59a38c423dad1e29)

12 years agor21223: Try and fix bug #4361 - Vista backup fails.
Jeremy Allison [Wed, 7 Feb 2007 19:43:44 +0000 (19:43 +0000)]
r21223: Try and fix bug #4361 - Vista backup fails.
Based on work from  Joe Meadows <>.
One for the Vista patchset.
(This used to be commit 470a4dc30874b00c599806cb6dbc06fe2775144c)

12 years agor21219: Speed up the initial startup time of smbd on systems with loaded disk
Volker Lendecke [Wed, 7 Feb 2007 13:26:13 +0000 (13:26 +0000)]
r21219: Speed up the initial startup time of smbd on systems with loaded disk
subsystems. See the comment in the diff.

(This used to be commit 92fdb1193de8e7c857603e4fcd4a92b9a0a0f3bd)

12 years agor21218: Fix typo
Volker Lendecke [Wed, 7 Feb 2007 12:16:23 +0000 (12:16 +0000)]
r21218: Fix typo
(This used to be commit 5b25ce30022b5968717691223d065a8e0770c6e3)

12 years agor21217: Just found a system that does not define in_addr_t but only struct
Volker Lendecke [Wed, 7 Feb 2007 11:26:36 +0000 (11:26 +0000)]
r21217: Just found a system that does not define in_addr_t but only struct
in_addr. Okay, it's a SuSE 7.0, but if the fix is so simple I think we should
not drop that :-)

(This used to be commit a5d0d1c1e63c63388540a24854bde380cd4b06bf)

12 years agor21210: Fix POSIX open to return an info level.
Jeremy Allison [Wed, 7 Feb 2007 02:39:43 +0000 (02:39 +0000)]
r21210: Fix POSIX open to return an info level.
(This used to be commit 5fa720f04f5d3b736145f9323aa8f4e623c14a41)

12 years agor21207: Make the code match the spec :-).
Jeremy Allison [Wed, 7 Feb 2007 00:49:45 +0000 (00:49 +0000)]
r21207: Make the code match the spec :-).
(This used to be commit 36afae2d48a3c3e97d1c2c35275f99d51ba2b64a)

12 years agor21204: Add define for new QFS Info for "who am i"
Steve French [Tue, 6 Feb 2007 23:25:02 +0000 (23:25 +0000)]
r21204: Add define for new QFS Info for "who am i"
(This used to be commit 739a608eadd9448791366f26b42b06d38d77e037)

12 years agor21203: Regenerate C files after pidl updates.
Jelmer Vernooij [Tue, 6 Feb 2007 23:02:27 +0000 (23:02 +0000)]
r21203: Regenerate C files after pidl updates.
(This used to be commit 1dc2ba09c7afc516d894fddfed613990ccf1f1ee)

12 years agor21202: On some build hosts, the first tests fail with CONNECTION_REFUSED. On my
Volker Lendecke [Tue, 6 Feb 2007 22:38:31 +0000 (22:38 +0000)]
r21202: On some build hosts, the first tests fail with CONNECTION_REFUSED. On my
solaris 9 box I could solve that with an increased wait time.

(This used to be commit 4ea654857af48640d86377418f7a91a91c830ced)

12 years agor21191: Add in the POSIX open/mkdir/unlink calls.
Jeremy Allison [Tue, 6 Feb 2007 21:05:34 +0000 (21:05 +0000)]
r21191: Add in the POSIX open/mkdir/unlink calls.
Move more error code returns to NTSTATUS.
Client test code to follow... See if this
passes the build-farm before I add it into
(This used to be commit 83dbbdff345fa9e427c9579183f4380004bf3dd7)

12 years agor21188: bumping passdb version number to make sure this is different than the 3.0...
Gerald Carter [Tue, 6 Feb 2007 21:00:51 +0000 (21:00 +0000)]
r21188: bumping passdb version number to make sure this is different than the 3.0.25 branch
(This used to be commit b10f4cdfc0767dbd88f29f42fa5a8d9a9c1959a2)

12 years agor21184: Dummy checkin to let the build farm pick up r21183 of Samba4
Volker Lendecke [Tue, 6 Feb 2007 20:07:29 +0000 (20:07 +0000)]
r21184: Dummy checkin to let the build farm pick up r21183 of Samba4
(This used to be commit 22c9511314d563e1f4480099d2990cb5fbb8546a)

12 years agor21182: * Refactor the code to obtain the LDAP connection credentials
Gerald Carter [Tue, 6 Feb 2007 17:29:18 +0000 (17:29 +0000)]
r21182: * Refactor the code to obtain the LDAP connection credentials
  from both idmap_ldap_{alloc,db}_init()
* Fix the backwards compat support in idmap_ldap.c
* Fix a spelling error in the idmap_fetch_secret() function name
(This used to be commit 615a10435618abb89852910a0d36c1d9ff35647f)

12 years agor21181: Add some debug, fix the NT_STATUS_IO_TIMEOUT problems in the RAW-NOTIFY test
Volker Lendecke [Tue, 6 Feb 2007 17:28:03 +0000 (17:28 +0000)]
r21181: Add some debug, fix the NT_STATUS_IO_TIMEOUT problems in the RAW-NOTIFY test
in the build farm.

(This used to be commit 3dd1bf667f42bd03a7b7159b9c2ad9ccbd269130)

12 years agor21180: fix backwards compatible idmap backends parameter parsing
Gerald Carter [Tue, 6 Feb 2007 15:31:17 +0000 (15:31 +0000)]
r21180: fix backwards compatible idmap backends parameter parsing
(This used to be commit 01af19cc9d8e282ffd6ff6b52699ed2d0369ff69)

12 years agor21176: merged va_end() changes from Samba4
Andrew Tridgell [Tue, 6 Feb 2007 05:58:35 +0000 (05:58 +0000)]
r21176: merged va_end() changes from Samba4
(This used to be commit 04f6f01dfeda2fa076209a94cdf8e59f6ce47008)

12 years agor21166: Ensure we return the correct "EROFS" error on a non-writable
Jeremy Allison [Mon, 5 Feb 2007 23:33:53 +0000 (23:33 +0000)]
r21166: Ensure we return the correct "EROFS" error on a non-writable
(This used to be commit 1e25501e8e6c568ab8892e05e0a60197e267d2b5)

12 years agor21165: Lets try the build farm without inotify, we're seeing some
Volker Lendecke [Mon, 5 Feb 2007 21:18:44 +0000 (21:18 +0000)]
r21165: Lets try the build farm without inotify, we're seeing some

Samba4 disables inotify as well. Does anybody know why Samba4 does it? Maybe
the same justification holds for 3 as well.

(This used to be commit de216a574c49f97e86a90c96627de4b5a3ea4b1c)

12 years agor21164: Fix from Martin Zielinski <> for EnumprinterdataEX
Jeremy Allison [Mon, 5 Feb 2007 19:32:31 +0000 (19:32 +0000)]
r21164: Fix from Martin Zielinski <> for EnumprinterdataEX
on Vista.
(This used to be commit b16707a8615e1d00839d31e7a3061fb111336691)

12 years agor21161: Another fix for pam_winbind: Move the entire pwd expiry handling into
Günther Deschner [Mon, 5 Feb 2007 18:11:41 +0000 (18:11 +0000)]
r21161: Another fix for pam_winbind: Move the entire pwd expiry handling into
the PAM_SUCCESS block.

(This used to be commit f4a704745cb0bd2c5dc2a9b16619d8ee30fd7ba1)

12 years agor21160: Some more pam_winbind fixes:
Günther Deschner [Mon, 5 Feb 2007 18:04:28 +0000 (18:04 +0000)]
r21160: Some more pam_winbind fixes:

* Consolidate all pam_winbind password expiry warnings in the one
_pam_send_password_expiry_message() call.
* Also convert some more NTSTATUS codes to error messages.
* Add paranoia check to only do all the post-processing after PAM_SUCCESS.

(This used to be commit 02713f314b65a14e659e801f7eebea453756ac44)

12 years agor21159: Cleanup pam_sm_chauthtok() in pam_winbind:
Günther Deschner [Mon, 5 Feb 2007 17:35:25 +0000 (17:35 +0000)]
r21159: Cleanup pam_sm_chauthtok() in pam_winbind:

Set info3 strings, krb5ccname and returned username after we changed a
password and sucessfully re-authenticated afterwards. In that case we
ended up without this information.

(This used to be commit 034d42ba7236e67303a8221b7a613799d1a61b83)

12 years agor21158: Add _pam_setup_krb5_env() and _pam_warn_logon_type() functions for
Günther Deschner [Mon, 5 Feb 2007 17:28:55 +0000 (17:28 +0000)]
r21158: Add _pam_setup_krb5_env() and _pam_warn_logon_type() functions for

(This used to be commit 1feb961577475dceb97948cd2fdb987005890498)

12 years agor21157: this is 3.0.26 trunk
Stefan Metzmacher [Mon, 5 Feb 2007 17:20:15 +0000 (17:20 +0000)]
r21157: this is 3.0.26 trunk

(This used to be commit 04feb8e39c3f8a3fecd5cac63e64c38cfc313c95)

12 years agor21155: Forgot one _PAM_LOG_STATE_DATA_STRING call (only in 3_0).
Günther Deschner [Mon, 5 Feb 2007 17:14:30 +0000 (17:14 +0000)]
r21155: Forgot one _PAM_LOG_STATE_DATA_STRING call (only in 3_0).

(This used to be commit 86b34cd5d6675c8f0a0becdcded36de4a815c898)

12 years agor21154: Add PAM_WINBIND_LOGONSERVER, also merge the various pam_set_data calls.
Günther Deschner [Mon, 5 Feb 2007 17:12:13 +0000 (17:12 +0000)]
r21154: Add PAM_WINBIND_LOGONSERVER, also merge the various pam_set_data calls.

(This used to be commit 97a0b1b79499af10930500ce857c93ffbacfdb6e)

12 years agor21152: Correctly omit pam conversations when PAM_SILENT has been set by the
Günther Deschner [Mon, 5 Feb 2007 15:25:31 +0000 (15:25 +0000)]
r21152: Correctly omit pam conversations when PAM_SILENT has been set by the
calling application.

(This used to be commit ebfae9a671d2c960178228ba7fdcd07cb2f49a05)

12 years agor21151: applying patches for CVE-2007-045[34]
Gerald Carter [Mon, 5 Feb 2007 15:16:30 +0000 (15:16 +0000)]
r21151: applying patches for CVE-2007-045[34]
(This used to be commit 1d46b2ae3447b3521987b2ab1064a6ea314cfa07)

12 years agor21150: Activate RAW-NOTIFY
Volker Lendecke [Mon, 5 Feb 2007 15:07:44 +0000 (15:07 +0000)]
r21150: Activate RAW-NOTIFY
(This used to be commit 39809d7391723d3c310fc11705b1de20074c4bbf)

12 years agor21149: Only say we are a groupmember for the optimized (rid 513) membership
Günther Deschner [Mon, 5 Feb 2007 15:04:09 +0000 (15:04 +0000)]
r21149: Only say we are a groupmember for the optimized (rid 513) membership
lookup when we actually are. Although the Linux nss winbind backend
protects against num_mem != 0 && buf == NULL.

(This used to be commit a9ac4630b46242f88bd7a4e92511b55cc82e9940)

12 years agor21146: Fix debug typos.
Günther Deschner [Mon, 5 Feb 2007 14:57:31 +0000 (14:57 +0000)]
r21146: Fix debug typos.

(This used to be commit cdef1d00b89abd632281d428f1e1a6b322559af4)

12 years agor21145: Convert some int to BOOL in pam_winbind (only in 3_0).
Günther Deschner [Mon, 5 Feb 2007 14:46:36 +0000 (14:46 +0000)]
r21145: Convert some int to BOOL in pam_winbind (only in 3_0).

(This used to be commit 1b82c5fa0e363942947453a8e1b74aa2b95d8733)

12 years agor21144: Create more accurate warning message when the pam_winbind chauthtok has
Günther Deschner [Mon, 5 Feb 2007 14:43:06 +0000 (14:43 +0000)]
r21144: Create more accurate warning message when the pam_winbind chauthtok has

(This used to be commit 2ac9cb3bbd1980df54f1b6cc2cfb823be43f3230)

12 years agor21143: Fix wrong check for pam error codes for getpwnam and lookup winbind
Günther Deschner [Mon, 5 Feb 2007 14:34:12 +0000 (14:34 +0000)]
r21143: Fix wrong check for pam error codes for getpwnam and lookup winbind
requests in pam_winbind (Bug #4094).

Inspired by fix from Lars Heete.

(This used to be commit 88e2185d2913e835e074dc3cc4ab1c631c3296a5)

12 years agor21133: - Apply patch from ages ago, which should allow following \\server\share...
Derrell Lipman [Sat, 3 Feb 2007 17:20:53 +0000 (17:20 +0000)]
r21133: - Apply patch from ages ago, which should allow following \\server\share\path
  DFS referrals.  This doesn't appear to break anything in the non-DFS case,
  but I don't have an environment to test DFS referrals.  Need confirmation
  from OP that this solves the problem.
(This used to be commit e479a9c094fa42354aad7aa76a712bf67d3d4d45)

12 years agor21132: - Fixes bug 4366. Documentation for smbc_utimes() was incorrect.
Derrell Lipman [Sat, 3 Feb 2007 17:13:58 +0000 (17:13 +0000)]
r21132: - Fixes bug 4366.  Documentation for smbc_utimes() was incorrect.

- Should fix bug 4115 (but needs confirmation from OP).  If the kerberos use
  flag is set in the context, then also pass it to smbc_attr_server for use by

- Should fix bug 4309 (but needs confirmation from OP).  We no longer send a
  keepalive packet unconditionally.  Instead, we assume (yes, possibly
  incorrectly, but it's the best guess we can make) that if the connection is
  on port 139, it's netbios and otherwise, it isn't.  If netbios is in use, we
  send a keepalive packet.  Otherwise, we check that the connection is alive
  using getpeername().
(This used to be commit 2f9be59c10ef991a51cc858ab594187b5ca61382)

12 years agor21131: Some notify fixes
Volker Lendecke [Sat, 3 Feb 2007 16:53:52 +0000 (16:53 +0000)]
r21131: Some notify fixes
(This used to be commit b9300e1d5acba4e2537fcc6631d1ee4d53685f64)

12 years agor21130: Don't mix SAFE_FREE() and TALLOC_FREE().
Gerald Carter [Sat, 3 Feb 2007 13:31:47 +0000 (13:31 +0000)]
r21130: Don't mix SAFE_FREE() and TALLOC_FREE().
(This used to be commit 5c36d67d272a52f58532daa3c3c09b8f8b6a34e0)

12 years agor21129: Fix from Martin Zielinski <> - ensure
Jeremy Allison [Sat, 3 Feb 2007 00:50:47 +0000 (00:50 +0000)]
r21129: Fix from Martin Zielinski <> - ensure
the hand marshalled container size is a multiple
of 4 bytes for RPC alignment.
(This used to be commit 0e9ad2b29f1c05dc3f5d5e9659fe0557fa077d2e)

12 years agor21128: Fix Vista connecting to Samba in share level security.
Jeremy Allison [Fri, 2 Feb 2007 22:02:42 +0000 (22:02 +0000)]
r21128: Fix Vista connecting to Samba in share level security.
Vista sends the NTLMv2 blob by default in the tconX
packet. Make sure we save off the workgroup the user
was logged into on the client in the sessionsetupX
and re-use it for the NTLMv2 calc.
(This used to be commit 45dcf62960c2815c4d8e0c5f4a2d0af24df83290)

12 years agor21127: Add a mitigating comment ;-))
Volker Lendecke [Fri, 2 Feb 2007 17:48:21 +0000 (17:48 +0000)]
r21127: Add a mitigating comment ;-))
(This used to be commit 918a6910d0d315b2786c5f8645babf6a13b8a949)

12 years agor21123: Make notify_fsp() static to notify.c.
Volker Lendecke [Fri, 2 Feb 2007 14:55:21 +0000 (14:55 +0000)]
r21123: Make notify_fsp() static to notify.c.

(This used to be commit d663b729c0b3f4265fa90a5df8534ad52b8f04eb)

12 years agor21122: Simplify code in pam_winbind a bit.
Günther Deschner [Fri, 2 Feb 2007 13:03:06 +0000 (13:03 +0000)]
r21122: Simplify code in pam_winbind a bit.

(This used to be commit 08ca5ea6f1b09506055b2508aa79704f39b3bbd7)

12 years agor21121: Fix error message, based on RAW-NOTIFY
Volker Lendecke [Fri, 2 Feb 2007 12:38:18 +0000 (12:38 +0000)]
r21121: Fix error message, based on RAW-NOTIFY
(This used to be commit 2d0a0a0b34fe4b8778d453ccfb5df6bc4534ef62)

12 years agor21120: Make notify a bit more robust: Delete the notify records if we figured out
Volker Lendecke [Fri, 2 Feb 2007 11:34:16 +0000 (11:34 +0000)]
r21120: Make notify a bit more robust: Delete the notify records if we figured out
that the process holding it is not around anymore.

Tridge, please review this and possibly also include it in 4. We can discuss
the error message for "unknown target" from messaging_send, INVALID_HANDLE
seemed to be most appropriate to me.

(This used to be commit 3b3ed7429e54b571375914e473eafc9888b5b204)

12 years agor21117: Add rpccli_samr_chgpasswd_user to rpcclient for testing.
Günther Deschner [Thu, 1 Feb 2007 22:12:37 +0000 (22:12 +0000)]
r21117: Add rpccli_samr_chgpasswd_user to rpcclient for testing.

(This used to be commit 4036cb51692d3f12a8f56a412fa5b2ca830d005b)

12 years agor21116: Fix the build -- sorry!
Volker Lendecke [Thu, 1 Feb 2007 22:06:59 +0000 (22:06 +0000)]
r21116: Fix the build -- sorry!
(This used to be commit f4b073d8c85070290f475e7e2575c1233b9a9c4e)

12 years agor21115: notify_internal.c needs to remove the table entry if a process has crashed. So
Volker Lendecke [Thu, 1 Feb 2007 19:29:07 +0000 (19:29 +0000)]
r21115: notify_internal.c needs to remove the table entry if a process has crashed. So
it needs the specific error message.

Make messages.c return NTSTATUS and specificially NT_STATUS_INVALID_HANDLE if
sending to a non-existent process.

(This used to be commit 3f620d181da0c356c8ffbdb5b380ccab3645a972)

12 years agor21114: Fix 'net usershare': Adding "guest_ok=y" required a correct acl. Set the
Volker Lendecke [Thu, 1 Feb 2007 16:22:07 +0000 (16:22 +0000)]
r21114: Fix 'net usershare': Adding "guest_ok=y" required a correct acl. Set the
default if "" is set. And fix the calculation for too man shares.

Thanks to Karolin Seeger <>

(This used to be commit 5b12eb873f8f603a6143342c282014af76ec7752)

12 years agor21113: Increment vfs version, thanks to metze for pointing it out
Volker Lendecke [Thu, 1 Feb 2007 15:29:24 +0000 (15:29 +0000)]
r21113: Increment vfs version, thanks to metze for pointing it out
(This used to be commit 3da52b500d63856c10d9d71ee2d0fb5fe1b28bdd)

12 years agor21112: fix const compile warning
Gerald Carter [Thu, 1 Feb 2007 15:22:08 +0000 (15:22 +0000)]
r21112: fix const compile warning
(This used to be commit 6b754f7c96400d5d1f14e807aac0aa925c45eefb)

12 years agor21111: Reorganize the change notify params a bit. We now have the per-share
Volker Lendecke [Thu, 1 Feb 2007 15:11:06 +0000 (15:11 +0000)]
r21111: Reorganize the change notify params a bit. We now have the per-share

change notify = [yes]/no           # do we do it at all
kernel change notify = [yes]/no    # enable/disable inotify

Those who want FAM need to say

change notify = yes
vfs objects = notify_fam

(This used to be commit c3a44d8b9606fc516faceb69b8e87bfc8be312f3)

12 years agor21110: Fix kinit with Heimdal (Bug #4226).
Günther Deschner [Thu, 1 Feb 2007 15:10:13 +0000 (15:10 +0000)]
r21110: Fix kinit with Heimdal (Bug #4226).

(This used to be commit ea38e1f8362d75e7ac058a7c4aa06f1ca92ec108)

12 years agor21109: Send notify_fam.c through the VFS. Lets see how the build farm likes this.
Volker Lendecke [Thu, 1 Feb 2007 14:31:10 +0000 (14:31 +0000)]
r21109: Send notify_fam.c through the VFS. Lets see how the build farm likes this.

(This used to be commit e57a6d4d6341a52de55860e7f97031a63810dbfa)

12 years agor21108: Send sys_notify_watch through the VFS, FAM is next
Volker Lendecke [Thu, 1 Feb 2007 13:36:02 +0000 (13:36 +0000)]
r21108: Send sys_notify_watch through the VFS, FAM is next
(This used to be commit 603a96761391f36ae9a1c8777d3333ab5c02eb34)

12 years agor21107: Adapt notify_fam.c to the new infrastructure. This works in my test, but...
Volker Lendecke [Thu, 1 Feb 2007 12:36:21 +0000 (12:36 +0000)]
r21107: Adapt notify_fam.c to the new infrastructure. This works in my test, but does
not survive the raw-notify test just because famd is too slow. Events are
coming in too late and are thus unsyncronized.

Now to get that through the VFS.

(This used to be commit c84bf6c4f92ffe3728acef7de7cefbc08307ea39)

12 years agor21106: We neither need a account lockout policy handler nor a check domain
Günther Deschner [Thu, 1 Feb 2007 12:24:08 +0000 (12:24 +0000)]
r21106: We neither need a account lockout policy handler nor a check domain
online handler for internal (local SAM, BUILTIN) childs. Jeremy, please

(This used to be commit 7d0e2e70684a7e3d377f56ed0244ed136b0b1a99)