12 years agor5743: Add perl-script to check for multiple LDAP-entries on request of Richard
Günther Deschner [Fri, 11 Mar 2005 12:24:24 +0000 (12:24 +0000)]
r5743: Add perl-script to check for multiple LDAP-entries on request of Richard

Users my run this script after they have vampired a windows domain
controller to verify their system has no double sids, double uids, etc.

(This used to be commit 31bd709a41e1bfe1f269a829c30e55a9538303df)

12 years agor5740: setting version in 3.0 development branch to 3.0.13pre1
Gerald Carter [Fri, 11 Mar 2005 10:53:22 +0000 (10:53 +0000)]
r5740: setting version in 3.0 development branch to 3.0.13pre1
(This used to be commit 81651b4d8b5050a80fd28a36dc922d9fed51ade6)

12 years agor5738: fix my build breakage; fix a few compiler warnings
Gerald Carter [Fri, 11 Mar 2005 10:35:41 +0000 (10:35 +0000)]
r5738: fix my build breakage; fix a few compiler warnings
(This used to be commit acbe9efeb6de33610776560978f8632cbb847821)

12 years agor5735: rest of derrel's patch for BUG 2308; had to move the options structure from...
Gerald Carter [Thu, 10 Mar 2005 23:41:19 +0000 (23:41 +0000)]
r5735: rest of derrel's patch for BUG 2308; had to move the options structure from the _SMBCCTX to the internals structure to maintain binary compatibility (derrel, we should talk more about this)
(This used to be commit a5ea01bf15758bb2be26ba16784dc0975be783bf)

12 years agor5733: Don't crash when the SID column contains NULL (Fixes #2316)
Jelmer Vernooij [Thu, 10 Mar 2005 22:47:56 +0000 (22:47 +0000)]
r5733: Don't crash when the SID column contains NULL (Fixes #2316)
Patch by Justin Ossevoort
(This used to be commit a281148168624dcab24e12f1cc7b0f6c7caf0185)

12 years agor5731: Get delayed write semantics closer to W2K3. We need to store 2 times.
Jeremy Allison [Thu, 10 Mar 2005 21:43:58 +0000 (21:43 +0000)]
r5731: Get delayed write semantics closer to W2K3. We need to store 2 times.
This may fix bug #2382.
(This used to be commit a27c351e6beafc6609790a9bb9a3d0a1331e8f35)

12 years agor5729: partial fixes for BUG 2308; libsmbclient patches from Derrell Lipman <derrell...
Gerald Carter [Thu, 10 Mar 2005 20:14:24 +0000 (20:14 +0000)]
r5729: partial fixes for BUG 2308; libsmbclient patches from Derrell Lipman <>
(This used to be commit 88678bc05c3018eb181f97523a0b84b60e3c358d)

12 years agor5726: merge LsaLookupPrivValue() code from trunk
Gerald Carter [Thu, 10 Mar 2005 18:50:47 +0000 (18:50 +0000)]
r5726: merge LsaLookupPrivValue() code from trunk
(This used to be commit 277203b5356af58ce62eb4eec0db2eccadeeffd6)

12 years agor5724: Fix compiler warning
Volker Lendecke [Thu, 10 Mar 2005 17:23:49 +0000 (17:23 +0000)]
r5724: Fix compiler warning
(This used to be commit c2f710e3219aab647c0ed294d1d3481f5578b930)

12 years agor5723: Add missing part of fix for #2271. After analysing the actions of a XP
Jeremy Allison [Thu, 10 Mar 2005 02:00:24 +0000 (02:00 +0000)]
r5723: Add missing part of fix for #2271. After analysing the actions of a XP
client against a Samba server. It never uses the "continue" flag, but always
does "new search, continue from this file" instead. Change our client code
to do the same (it appears that's all they test in W2K etc.).
(This used to be commit 710bceee325005b8ca8e8ed04acc50bafa92b6e6)

12 years agor5720: Attempt to fix bug #2382 (Excel shared workbook stops working). Also
Jeremy Allison [Thu, 10 Mar 2005 01:30:14 +0000 (01:30 +0000)]
r5720: Attempt to fix bug #2382 (Excel shared workbook stops working). Also
incorporates part of the fix created by
for bug #2045 (MS-Office behavior of timestamp).
(This used to be commit 4f3b12ac73487f4ccb37c17506af1abf5acc80cd)

12 years agor5718: Don't update fields that haven't changed (fixes #1957)
Jelmer Vernooij [Thu, 10 Mar 2005 01:06:16 +0000 (01:06 +0000)]
r5718: Don't update fields that haven't changed (fixes #1957)
(This used to be commit 5c682c665dbf517280deef0d6cec7dadc737a2bc)

12 years agor5717: BUG 2215: horrible code in nmbd_winsproxy.c; gcc folks at redhat claim its...
Gerald Carter [Wed, 9 Mar 2005 22:20:40 +0000 (22:20 +0000)]
r5717: BUG 2215: horrible code in nmbd_winsproxy.c;  gcc folks at redhat claim its in violation of the C spec.  It's so horrible I believe them
(This used to be commit fa7eb5693314efb14d42a739f8006ddf8d41e9d5)

12 years agor5715: Update for new CIFS POSIX info levels
Steve French [Wed, 9 Mar 2005 21:43:00 +0000 (21:43 +0000)]
r5715: Update for new CIFS POSIX info levels
(This used to be commit af12daba2ae57a1f768248ba60d7769063f8200b)

12 years agor5708: BUG 2424: patch from Vince Brimhall <> to ensure that...
Gerald Carter [Wed, 9 Mar 2005 15:22:06 +0000 (15:22 +0000)]
r5708: BUG 2424: patch from Vince Brimhall <> to ensure that uidNumber and gidNumber use match the rfc2307 schema
(This used to be commit c1727dc9e01f960c1eedf023b4de49ad6f418b18)

12 years agor5707: BUG 2425: remove ubran legend wrt to win98 and the DFS_PATHNAMES capability bit
Gerald Carter [Wed, 9 Mar 2005 15:13:23 +0000 (15:13 +0000)]
r5707: BUG 2425: remove ubran legend wrt to win98 and the DFS_PATHNAMES capability bit
(This used to be commit 6511bfe84a4036e0d203858aa2f604e346c9412b)

12 years agor5705: Have unknown_6 default to 1260 (fixed #892)
Jelmer Vernooij [Wed, 9 Mar 2005 10:10:43 +0000 (10:10 +0000)]
r5705: Have unknown_6 default to 1260 (fixed #892)
(This used to be commit 710ce847a79fa9e7ba488de46a2f69fc9d617e62)

12 years agor5702: Fix bug #2271. Correctly pull out and use resume names in a
Jeremy Allison [Wed, 9 Mar 2005 00:06:27 +0000 (00:06 +0000)]
r5702: Fix bug #2271. Correctly pull out and use resume names in a
directory listing (we were incorrectly understanding what was
returned in the "last name" entry).
(This used to be commit 4f2da9ecf1e5cee4749839ea1b35a942d27de09e)

12 years agor5700: Fix problems where we're not pointing to the start of entry for a
Jeremy Allison [Tue, 8 Mar 2005 23:03:38 +0000 (23:03 +0000)]
r5700: Fix problems where we're not pointing to the start of entry for a
couple of info levels - W2K3 always points to the start, not the name.
(This used to be commit 76fb181031e6e3df5b653496692737fd947b7818)

12 years agor5696: BUG 2355: use bsd style commands for 'printing = cups' but \!defined(HAVE_CUPS)
Gerald Carter [Tue, 8 Mar 2005 21:04:36 +0000 (21:04 +0000)]
r5696: BUG 2355: use bsd style commands for 'printing = cups' but \!defined(HAVE_CUPS)
(This used to be commit 5216728d82fcbdcba9a06f9730806ef4a4d6108f)

12 years agor5692: Fix compile warnings
Volker Lendecke [Tue, 8 Mar 2005 17:42:59 +0000 (17:42 +0000)]
r5692: Fix compile warnings
(This used to be commit 6fad82d3d536fe2f7184377137d062710b40b4f2)

12 years agor5691: wrapping the pause/resume/purge printer commands in
Gerald Carter [Tue, 8 Mar 2005 17:22:39 +0000 (17:22 +0000)]
r5691: wrapping the pause/resume/purge printer commands in
{become,unbecome}_root() blocks.  We've already done
a print_access_check() to ensure the user is admin.
The means that non-root users can pause and manage printers.
I really don't see how this worked before without setuid
binaries on the server.

Also update print_queue_update() interface to allow an smbd
to update the print queue cache locally rather than going through
the bg lpq daemon.  This is needed for things like pjob_delete()
to ensure the cache is current for the specific client.
(This used to be commit f75369ec865f4ba1ae8201ae750c0f45158ed536)

12 years agor5689: Allow for better protection of sensitive attributes in IBM Directory Server.
Jim McDonough [Tue, 8 Mar 2005 11:02:48 +0000 (11:02 +0000)]
r5689: Allow for better protection of sensitive attributes in IBM Directory Server.
(This used to be commit dafdd8d0741311ed0f0b35d30062f0052446f8c4)

12 years agor5688: ignore user_xattr mount parm so as not to confuse it with a user name
Steve French [Tue, 8 Mar 2005 00:00:13 +0000 (00:00 +0000)]
r5688: ignore user_xattr mount parm so as not to confuse it with a user name
(This used to be commit 58afef91c52293d72f1066a27387a60e51be4e79)

12 years agor5687: Fix for bug #2398 from Kevin Dalley <>.
Jeremy Allison [Mon, 7 Mar 2005 23:54:24 +0000 (23:54 +0000)]
r5687: Fix for bug #2398 from Kevin Dalley <>.
smbtar shouldn't assume /dev/null means dryrun.
(This used to be commit 84e7b7db8992db7812b8e09b8633c257657fb91c)

12 years agor5685: BUG 1881: only define PRINT_SPOOL_PREFIX if it is not already defined
Gerald Carter [Mon, 7 Mar 2005 23:24:19 +0000 (23:24 +0000)]
r5685: BUG 1881: only define PRINT_SPOOL_PREFIX if it is not already defined
(This used to be commit a42e3fc63cdbabd96f05e6af64344e1489ebf9da)

12 years agor5684: BUG 2405: patch from Torsten Werner <> to define...
Gerald Carter [Mon, 7 Mar 2005 22:10:27 +0000 (22:10 +0000)]
r5684: BUG 2405: patch from Torsten Werner <> to define 'lpstat' printcap output on HPUX
(This used to be commit 98596037caa47a27c4f87793f9875ec18b0f23c2)

12 years agor5683: BUG 2363: allow 'in use' driver to be removed as long as one 'Windows NT x86...
Gerald Carter [Mon, 7 Mar 2005 22:06:25 +0000 (22:06 +0000)]
r5683: BUG 2363: allow 'in use' driver to be removed as long as one 'Windows NT x86' driver remains'
(This used to be commit 743ddbc7f204977431b8eaa48c3838b3cc9bdb11)

12 years agor5657: Fix uninitialized variable warning
Volker Lendecke [Sat, 5 Mar 2005 08:12:40 +0000 (08:12 +0000)]
r5657: Fix uninitialized variable warning
(This used to be commit f74737ce574aa4b47367fccb1b95769778187515)

12 years agor5655: Added support for Novell NDS universal password. Code donated by
Jeremy Allison [Sat, 5 Mar 2005 01:22:53 +0000 (01:22 +0000)]
r5655: Added support for Novell NDS universal password. Code donated by
Vince Brimhall <> - slight tidyup by me to
use Samba conventions.
Vince - thanks a *lot* for this code - please test to make sure
I haven't messed anything up.
(This used to be commit 6f5ea963abe8e19d17a1803d4bedd9d87a317e58)

12 years agor5654: Fix bug 1604 -- make winbind work with more than 10 trusted domains.
Volker Lendecke [Fri, 4 Mar 2005 19:29:18 +0000 (19:29 +0000)]
r5654: Fix bug 1604 -- make winbind work with more than 10 trusted domains.

TODO: This needs to be merged to trunk separately, it has changed a little,
but it's friday evening here.

(This used to be commit 49c3e04632e9fcdf552259412e8ec54d18269516)

12 years agor5653: Fixiing typos.
John Terpstra [Fri, 4 Mar 2005 17:38:25 +0000 (17:38 +0000)]
r5653: Fixiing typos.
(This used to be commit 7df1cfed723d1c22070b0a829946fe61d064e0d1)

12 years agor5650: add help lines for net rpc group addmem and delmem commands
Herb Lewis [Thu, 3 Mar 2005 18:55:36 +0000 (18:55 +0000)]
r5650: add help lines for net rpc group addmem and delmem commands
partial fix for Bug 2417 - we need to look for other missing
(This used to be commit bd4405b41592e064428bfa0dab8f216692f0fec6)

12 years agor5647: Caches are good for performance, but you get a consistency problem.
Volker Lendecke [Thu, 3 Mar 2005 16:52:44 +0000 (16:52 +0000)]
r5647: Caches are good for performance, but you get a consistency problem.

Fix bug # 2401.

(This used to be commit eb4ef94f244d28fe531d0b9f724a66ed3834b687)

12 years agor5645: Add an autoconf test for -Wdeclaration-after-statement so we don't add it
Tim Potter [Thu, 3 Mar 2005 06:15:13 +0000 (06:15 +0000)]
r5645: Add an autoconf test for -Wdeclaration-after-statement so we don't add it
to the configure.developer CFLAGS if it's not supported.
(This used to be commit ce0dedea8d95f07745ba3e945dc88bceb97989d7)

12 years agor5641: Fix from James Peach @ SGI for oplock2 test.
Jeremy Allison [Thu, 3 Mar 2005 04:08:13 +0000 (04:08 +0000)]
r5641: Fix from James Peach @ SGI for oplock2 test.
(This used to be commit 69e99d97d1547ec8f8e7f9756b87f211c90557b6)

12 years agor5640: On failed mount (ENXIO) retry share name in uppercase (fix mount to FastConnec...
Steve French [Thu, 3 Mar 2005 04:07:55 +0000 (04:07 +0000)]
r5640: On failed mount (ENXIO) retry share name in uppercase (fix mount to FastConnect AIX SMB server)
(This used to be commit 8bd98b643d097cbd5e1650ec63a2f3176c3879d7)

12 years agor5639: update smb.h with missing defines
Steve French [Thu, 3 Mar 2005 04:05:33 +0000 (04:05 +0000)]
r5639: update smb.h with missing defines
(This used to be commit 0f188da8578165077b6d6df58c6e82be11943d40)

12 years agor5637: Actually test and fix the crash bugs (sorry:-).
Jeremy Allison [Thu, 3 Mar 2005 04:03:36 +0000 (04:03 +0000)]
r5637: Actually test and fix the crash bugs (sorry:-).
(This used to be commit 4348ca48549ded8c056877befa216f0e768cb2c1)

12 years agor5636: Re-add the allocation size - parameterized by share as
Jeremy Allison [Thu, 3 Mar 2005 03:43:57 +0000 (03:43 +0000)]
r5636: Re-add the allocation size - parameterized by share as
"allocation roundup size", by default set as 1Mb. From
advice by BlueArc about Windows client behaviour. VC++
people can set this to zero to turn it off.
(This used to be commit 833ca101772bfab65dbd79eb64f63464177f144e)

12 years agor5634: Fix 64-bit overflow problems found by BlueArc torture tester.
Jeremy Allison [Thu, 3 Mar 2005 02:07:00 +0000 (02:07 +0000)]
r5634: Fix 64-bit overflow problems found by BlueArc torture tester.
We still have a few strange bugs with 64-bit locking values. I will
get traces.
(This used to be commit ff4c201d93e1f59ce61e9341f7f94ce92389ed7b)

12 years agor5632: Fix infinite looping bug found by nasty BlueArc test :-).
Jeremy Allison [Thu, 3 Mar 2005 02:04:36 +0000 (02:04 +0000)]
r5632: Fix infinite looping bug found by nasty BlueArc test :-).
When finding a singleton directory remember that we're
at the end and don't continuously return the same name.
(This used to be commit 3da50060279609f534aeffe6338b0a2b07d0e8f1)

12 years agor5630: This may be a mistake ... needs more cthon investigation.
Jeremy Allison [Wed, 2 Mar 2005 21:43:54 +0000 (21:43 +0000)]
r5630: This may be a mistake ... needs more cthon investigation.
(This used to be commit 0322c5884666bf62a37de069a1cd0ae888ac4285)

12 years agor5628: Deprecate the write cache parameter - this code will go away soon.
Jeremy Allison [Wed, 2 Mar 2005 20:30:37 +0000 (20:30 +0000)]
r5628: Deprecate the write cache parameter - this code will go away soon.
(This used to be commit 743cd4a53627cc2be5271fa78f6b0980a4407862)

12 years agor5625: Reformat (tidy).
Jeremy Allison [Wed, 2 Mar 2005 20:19:10 +0000 (20:19 +0000)]
r5625: Reformat (tidy).
(This used to be commit b94db3a75806f1b09a8a0366029812ba2195727c)

12 years agor5623: Horrible band-aid patch to fix Blue-Arc torture tester.
Jeremy Allison [Wed, 2 Mar 2005 18:19:32 +0000 (18:19 +0000)]
r5623: Horrible band-aid patch to fix Blue-Arc torture tester.
I know this isn't right but will work until I can refactor
the deny mode code with the Samba4 algorithm.
(This used to be commit f38f464c722a441402e2d6e2622bcce9227c33b5)

12 years agor5616: Forgot about the sticky bit on directories (commonly set on /tmp). If this...
Jeremy Allison [Wed, 2 Mar 2005 03:41:44 +0000 (03:41 +0000)]
r5616: Forgot about the sticky bit on directories (commonly set on /tmp). If this is set
then only the owner or root can delete a file. We now use
the same algorithm to check file delete.
(This used to be commit eb18104d10428a5daef2316088edc3dbaff58708)

12 years agor5614: fix proto for copy_fn() after changes to cli_list()
Gerald Carter [Wed, 2 Mar 2005 03:24:40 +0000 (03:24 +0000)]
r5614: fix proto for copy_fn() after changes to cli_list()
(This used to be commit fb8e746ed65fa3aacda3d6be0e3f28f690fbdacb)

12 years agor5612: Add -Wdeclaration-after-statement to CFLAGS for --enable-developer.
Tim Potter [Wed, 2 Mar 2005 00:33:40 +0000 (00:33 +0000)]
r5612: Add -Wdeclaration-after-statement to CFLAGS for --enable-developer.
(This used to be commit f952da9efbd11d2c84d9fe4993f70e4ceda7d9ae)

12 years agor5608: BUG 2399 - removing dead code (not finished with bug yet).
Gerald Carter [Tue, 1 Mar 2005 21:48:34 +0000 (21:48 +0000)]
r5608: BUG 2399 - removing dead code (not finished with bug yet).
(This used to be commit 48353c199cfbfd56760b34ccf99b089bb627e2ed)

12 years agor5607: Fix for bug #2399 - ensure we use SMB_VFS_STAT instead of stat
Jeremy Allison [Tue, 1 Mar 2005 21:26:01 +0000 (21:26 +0000)]
r5607: Fix for bug #2399 - ensure we use SMB_VFS_STAT instead of stat
when checking for existance of a pathname.
(This used to be commit 08aac40e3ac0911673ea7e6ef35ba7fe9822d2fd)

12 years agor5605: only display the publish check box on printer if
Gerald Carter [Tue, 1 Mar 2005 17:28:25 +0000 (17:28 +0000)]
r5605: only display the publish check box on printer if
we are a member of an AD domain

clean up some hardcoded constands with the REG_XXX constant.
(This used to be commit a1d0be740d9ea8c9ea8c04950da826dd84bbc51b)

12 years agor5600: Bring IBM Directory Server schema up to date with openldap schema
Jim McDonough [Tue, 1 Mar 2005 14:00:25 +0000 (14:00 +0000)]
r5600: Bring IBM Directory Server schema up to date with openldap schema
(This used to be commit 639de6afc09709774fbcce1a8149bde172bd542e)

12 years agor5597: full fix for BUG 2394 (unresolved symbols on IRIX)
Gerald Carter [Mon, 28 Feb 2005 19:14:07 +0000 (19:14 +0000)]
r5597: full fix for BUG 2394 (unresolved symbols on IRIX)
(This used to be commit cb08dd5f9087ac2e965dec8ba24c9e908fd6fcd3)

12 years agor5596: BUG 2394: fix nmbd linking issue on IRIX
Gerald Carter [Mon, 28 Feb 2005 17:14:18 +0000 (17:14 +0000)]
r5596: BUG 2394: fix nmbd linking issue on IRIX
(This used to be commit 0a07f2b1d91e071618e67c4e9ee8274763eaf5aa)

12 years agor5594: Fix comment to read "remove" instead of "add"
Jim McDonough [Mon, 28 Feb 2005 11:17:13 +0000 (11:17 +0000)]
r5594: Fix comment to read "remove" instead of "add"
(This used to be commit 6884a2fa6e3d19a436edfb428056978ae127f442)

12 years agor5593: More reversal of accidental commit.
Jim McDonough [Mon, 28 Feb 2005 11:13:22 +0000 (11:13 +0000)]
r5593: More reversal of accidental commit.
(This used to be commit ec78c3f2a2e38abe96132475a22bfd52c850b001)

12 years agor5592: Oops, accidentally committed test version of rpcclient. Reverting changes.
Jim McDonough [Mon, 28 Feb 2005 11:11:55 +0000 (11:11 +0000)]
r5592: Oops, accidentally committed test version of rpcclient.  Reverting changes.
(This used to be commit a5fe34ca7d57c18f510b9cc68e75c4db370fe052)

12 years agor5591: Implement "net rpc trustdom del", including client side of
Jim McDonough [Mon, 28 Feb 2005 10:55:13 +0000 (10:55 +0000)]
r5591: Implement "net rpc trustdom del", including client side of
(This used to be commit 8360695fc02dfb09aff92a434bf9d411e65c478c)

12 years agor5589: Ensure the torture code that uses cli_list and cli_list_old
Jeremy Allison [Mon, 28 Feb 2005 07:01:52 +0000 (07:01 +0000)]
r5589: Ensure the torture code that uses cli_list and cli_list_old
matches the new MS-DFS function prototypes. Should fix the
build farm tests.
(This used to be commit 3d4d8bb6544abc4959f75bb962d8e1fb3d37a55e)

12 years agor5580: Fix "net rpc trustdom add". Much closer to what windows does. Also stop
Jim McDonough [Sat, 26 Feb 2005 15:26:55 +0000 (15:26 +0000)]
r5580: Fix "net rpc trustdom add".  Much closer to what windows does.  Also stop
referencing unknown_6 from sam, because it's just fixed at 1260, the max
len of LOGON_HRS.  Need to go in and mark it as "remove me" from passdb.
(This used to be commit ffac752875938d510446ebbeba6fc983f65cda1e)

12 years agor5578: get 'recurse; dir' working across multiple levels of dfs referrals
Gerald Carter [Sat, 26 Feb 2005 15:03:16 +0000 (15:03 +0000)]
r5578: get 'recurse; dir' working across multiple levels of dfs referrals

note that this does not handle the situation where the same \\server\share
is mounted mutliple times in the dfs tree since I store a single mount
path per struct cli_state *
(This used to be commit 52c82b51ba9729cc53a049d8e9fbb7365d652c51)

12 years agor5577: get recurse; dir working across single level dfs referrals
Gerald Carter [Sat, 26 Feb 2005 14:42:55 +0000 (14:42 +0000)]
r5577: get recurse; dir working across single level dfs referrals
(This used to be commit d4443807bc7a5a8615c69517365a92709db7ce29)

12 years agor5571: fix another breakage on gcc 2.96
Gerald Carter [Fri, 25 Feb 2005 19:26:07 +0000 (19:26 +0000)]
r5571: fix another breakage on gcc 2.96
(This used to be commit cadd5a44e7f1d532aa4dad7a4233e5ea2c814a10)

12 years agor5568: fix more breakage on gcc 2.96
Gerald Carter [Fri, 25 Feb 2005 18:49:42 +0000 (18:49 +0000)]
r5568: fix more breakage on gcc 2.96
(This used to be commit 3eeecff05efec9310cf2bed7c6fe9a6d80dd6d0d)

12 years agor5565: fix breakage on gcc 2.96
Gerald Carter [Fri, 25 Feb 2005 18:38:19 +0000 (18:38 +0000)]
r5565: fix breakage on gcc 2.96
(This used to be commit 67f8a1e3bc545d4ebbe0f7d05ea16c6231f2e82c)

12 years agor5562: * bump version to 3.0.12pre2
Gerald Carter [Fri, 25 Feb 2005 15:56:13 +0000 (15:56 +0000)]
r5562: * bump version to 3.0.12pre2
* change special character in gd's valid workstation
  check to a '+' to be more in line with the characters
  used by valid users
(This used to be commit 8bff0486508b9952c192345302b9313ac0b2270e)

12 years agor5560: make sure session setup message is displayed after changes to client.c
Gerald Carter [Fri, 25 Feb 2005 15:22:49 +0000 (15:22 +0000)]
r5560: make sure session setup message is displayed after changes to client.c
(This used to be commit 3f5e52e90861d071870a369fac246a822f4ff2ce)

12 years agor5556: Fix the build on AIX.
Günther Deschner [Fri, 25 Feb 2005 14:12:05 +0000 (14:12 +0000)]
r5556: Fix the build on AIX.

use AF_UNIX instead of AF_LOCAL (thanks to Doug VanLeuven
<>) and make smbldap_open() a bit more readable.

(This used to be commit 526d6a9493cd091f2a9b8e072f11e673133fe5c1)

12 years agor5548: Stop lying about allocation sizes to Windows clients. It was a nice
Jeremy Allison [Fri, 25 Feb 2005 02:22:44 +0000 (02:22 +0000)]
r5548: Stop lying about allocation sizes to Windows clients. It was a nice
idea, and aparently improved performance in some circumstances, but it
breaks the VC++ compiler :-(. Not cool. Fix bug #2146.
(This used to be commit b9f147634df0126320ffe3b9a23068e76f6c1681)

12 years agor5547: Fix compile warning.
Günther Deschner [Thu, 24 Feb 2005 23:30:47 +0000 (23:30 +0000)]
r5547: Fix compile warning.

(This used to be commit a5e215650e09f087f8aede96475bd26649aa244e)

12 years agor5546: Fix some comments in "net rpc printer migrate settings"
Günther Deschner [Thu, 24 Feb 2005 23:25:35 +0000 (23:25 +0000)]
r5546: Fix some comments in "net rpc printer migrate settings"

(This used to be commit 67552103ee77013d08e06ed651f6ca6b3b76813e)

12 years agor5545: move cli_cm_XXX() connection handling code to clidfs and out of client.c;...
Gerald Carter [Thu, 24 Feb 2005 21:54:52 +0000 (21:54 +0000)]
r5545: move cli_cm_XXX() connection handling code to clidfs and out of client.c;  client.c still maintains a pointer to the first connection so the change is fairly reansparent to other smbclient functions such as -L and -M
(This used to be commit d6a05ffd664e2e304f6e481af34a4c5d640fc3f9)

12 years agor5543: Fix for bug #962 - using MB sharenames containing a ']' character.
Jeremy Allison [Thu, 24 Feb 2005 21:06:11 +0000 (21:06 +0000)]
r5543: Fix for bug #962 - using MB sharenames containing a ']' character.
Processing a share name is now MB safe so long as the correct
unix charset is in scope.
(This used to be commit 5bd027e9ed095c01fc176178ff51b5839fe0c140)

12 years agor5542: fix a few more msdfs bugs in smbclient against both smbd and 2k dfs root
Gerald Carter [Thu, 24 Feb 2005 19:10:28 +0000 (19:10 +0000)]
r5542: fix a few more msdfs bugs in smbclient against both smbd and 2k dfs root
(This used to be commit 5d2624c453b0bc961302edd9f2421a7c3d504d1f)

12 years agor5541: Fix crash bug in the client-spoolss enumdataex-call.
Günther Deschner [Thu, 24 Feb 2005 17:00:24 +0000 (17:00 +0000)]
r5541: Fix crash bug in the client-spoolss enumdataex-call.

With Windows2003 it's perfectly legal to receive no data when querying a
value-less subkey. Found while migrating printer settings.

(This used to be commit 3e04def03377b2eae2987c87b18ccadf5b48a6fe)

12 years agor5536: Avoid intermediate copy of NT and LM responses in NETLOGON client.
Andrew Bartlett [Thu, 24 Feb 2005 03:45:09 +0000 (03:45 +0000)]
r5536: Avoid intermediate copy of NT and LM responses in NETLOGON client.

This copy was length-limited, which broke when the NTLMv2 response was
more than 128 bytes in length.

Andrew Bartlett
(This used to be commit bae18aaaff7f9eff90db566b9a254a11d281aa01)

12 years agor5535: Reformat so I can actually maintain this code and eventually convert to MB...
Jeremy Allison [Thu, 24 Feb 2005 02:19:17 +0000 (02:19 +0000)]
r5535: Reformat so I can actually maintain this code and eventually convert to MB safe.
(This used to be commit 0285754c1408b4155e115a5f76b1f5ff481c9d7e)

12 years agor5532: Patch to detect infinite loops when traversing a tdb from "Shlomi Yaakobovich...
Jeremy Allison [Thu, 24 Feb 2005 01:07:09 +0000 (01:07 +0000)]
r5532: Patch to detect infinite loops when traversing a tdb from "Shlomi Yaakobovich" <>
(This used to be commit f997c28bb8ca253dca943a578a617b3c20ccfa5e)

12 years agor5530: Keep the TRANS call up to date with the NTCreateX call.
Jeremy Allison [Thu, 24 Feb 2005 01:03:35 +0000 (01:03 +0000)]
r5530: Keep the TRANS call up to date with the NTCreateX call.
(This used to be commit 98a07e1520d6fb1f6f5320bc70ac33d4c5052ea6)

12 years agor5528: Expand the invalid-workstation-scheme. Workstation-Names with leading
Günther Deschner [Thu, 24 Feb 2005 00:26:24 +0000 (00:26 +0000)]
r5528: Expand the invalid-workstation-scheme. Workstation-Names with leading
'@'-sign are expanded on-the-fly as posix-groups of workstations. This
allows optional, more flexible login-control in larger networks.

(This used to be commit 8f143b6800e0b6964c8ba4ba9607dc74da12ae59)

12 years agor5527: Allow own netbios name to be set in smbclient's session setup.
Günther Deschner [Thu, 24 Feb 2005 00:11:42 +0000 (00:11 +0000)]
r5527: Allow own netbios name to be set in smbclient's session setup.

(This used to be commit 3660b7e64d9a17bcaa4f43c6d782b0b1d52ed6ab)

12 years agor5525: Add extra case to torture to test this (we currently fail with the wrong
Jeremy Allison [Wed, 23 Feb 2005 23:41:15 +0000 (23:41 +0000)]
r5525: Add extra case to torture to test this (we currently fail with the wrong
error message but we correctly deny the open).
(This used to be commit 99b89867c33a2209c42b6610d62ead0cf2af05af)

12 years agor5524: Don't do share mode checks on can_delete if open, the rest of the open
Jeremy Allison [Wed, 23 Feb 2005 23:39:51 +0000 (23:39 +0000)]
r5524: Don't do share mode checks on can_delete if open, the rest of the open
code will do this correctly. More for bug #2201.
(This used to be commit faecf639efdecf949e91184d041489aa54e8664f)

12 years agor5522: Better handling of LDAP over IPC connections that have expired on the
Günther Deschner [Wed, 23 Feb 2005 20:38:29 +0000 (20:38 +0000)]
r5522: Better handling of LDAP over IPC connections that have expired on the

(This used to be commit 8017a7a150023dc3353181f7737b2363d38593fa)

12 years agor5521: allow smbclient to follow multiple leveles of dfs referrals (no loop checking...
Gerald Carter [Wed, 23 Feb 2005 20:00:26 +0000 (20:00 +0000)]
r5521: allow smbclient to follow multiple leveles of dfs referrals (no loop checking currently)
(This used to be commit 3c09b1f30f8b85036c487fdaf7fca11886bc90d7)

12 years agor5520: fix last remaining dfs issues with smbclient.
Gerald Carter [Wed, 23 Feb 2005 19:26:32 +0000 (19:26 +0000)]
r5520: fix last remaining dfs issues with smbclient.

* all the unix extension commands should work
* send the correct TRANS2_FINDFIRST format to 2k to
  get a listing from a msdfs root share (tested against
  smbd as well).
* mkdir, rmdir, etc... all seem ok.

I'm sure bugs will pop up so keep testing.

Last thing I plan on doing is to clean up the horrible
mess with connection management in smbclient and global
variables (so i can move the cli_cm_xx() routines to a
separate file).
(This used to be commit 53d6a5f9d16aef4afc60b4b37b296b256da00dfd)

12 years agor5519: fix msdfs support for [m]get and [m]put
Gerald Carter [Wed, 23 Feb 2005 18:27:13 +0000 (18:27 +0000)]
r5519: fix msdfs support for [m]get and [m]put
(This used to be commit 6a9e4d6af1a4a4f426189e71aac5a4e7e217d6f7)

12 years agor5518: Add initial msdfs support to smbclient. Currently I can only
Gerald Carter [Wed, 23 Feb 2005 17:29:28 +0000 (17:29 +0000)]
r5518: Add initial msdfs support to smbclient.  Currently I can only
cd up and down the tree and get directory listings.

Still have to figure out how to get a directory listing on a
2k dfs root.  Also have to work out some issues with relative paths
that cross dfs mount points.

We're protected from the new code paths when connecting to
a non-dfs root share ( the flag from the tcon&X is stored
in the struct cli_state* )
(This used to be commit e57fd2c5f00de2b11a2b44374830e89a90bc0022)

12 years agor5517: code cleanup; rename the sorted_tree to pathtree (used by registry code)
Gerald Carter [Wed, 23 Feb 2005 16:36:44 +0000 (16:36 +0000)]
r5517: code cleanup; rename the sorted_tree to pathtree (used by registry code)
I was going to use this for tracking dfs mounts in smbclient
but found another way.  Still the cleanup is valid so commiting it.
should be minimally disruptive since it is not widely used.
(This used to be commit 00738dca3b07083c91545910486a1f30f2b17281)

12 years agor5513: Fix for bug #2201 - use same logic with "delete readonly"
Jeremy Allison [Wed, 23 Feb 2005 02:20:54 +0000 (02:20 +0000)]
r5513: Fix for bug #2201 - use same logic with "delete readonly"
when setting the delete on close flag as we do in SMBunlink
(This used to be commit 7a94eaf1811c79ae52ee78b1cd9cfc691e1d65a0)

12 years agor5511: Fix pipe-mismatch for NETDFS.
Günther Deschner [Tue, 22 Feb 2005 23:55:31 +0000 (23:55 +0000)]
r5511: Fix pipe-mismatch for NETDFS.

(This used to be commit 1c8616618cf35a5aaef03b6e570d95d1a3e34e4e)

12 years agor5510: Optimisation to only do can_delete check if client asks for FILE_SHARE_DELETE.
Jeremy Allison [Tue, 22 Feb 2005 20:55:48 +0000 (20:55 +0000)]
r5510: Optimisation to only do can_delete check if client asks for FILE_SHARE_DELETE.
Not completely correct but will catch the XP SP2 problem.
(This used to be commit 1e2d0fcdbb72735f8b53d9faaec07d711ae236d0)

12 years agor5508: Typo - ZERO_STRUCT -> ZERO_STRUCTP.
Jeremy Allison [Tue, 22 Feb 2005 20:54:06 +0000 (20:54 +0000)]
(This used to be commit 76e1d90aef45ccc089492d962e0f284e2e4d8e7a)

12 years agor5497: Fix for DIR1 failures in build farm. It struck me that we
Jeremy Allison [Tue, 22 Feb 2005 05:11:37 +0000 (05:11 +0000)]
r5497: Fix for DIR1 failures in build farm. It struck me that we
only care about failing with ACCESS_DENIED if we can't delete
with DELETE access requested. All other errors will be processed
as normal.
(This used to be commit 360800592c55c9dd8fd787944b3d482f2b9eb951)

12 years agor5495: * add in some code from Mike Nix <> for the SMBsplopen
Gerald Carter [Tue, 22 Feb 2005 03:31:22 +0000 (03:31 +0000)]
r5495: * add in some code from Mike Nix <> for the SMBsplopen
  and SMBsplclose commands (BUG 2010)
* clarify some debug messages in smbspool (also from Mike)

my changes:

* start adding msdfs client routines
* enable smbclient to maintain multiple connections
* set the CAP_DFS flag for our internal clienht routines.

I actualy have a dfs referral working in do_cd() but that code
is too ugly to live so I'm not checking it in just yet.
Further work is to merge with vl's changes in trunk to support multiple
TIDs per cli_state *.
(This used to be commit 0449756309812d854037ba0af631abad678e670e)

12 years agor5484: Fix a memleak
Volker Lendecke [Mon, 21 Feb 2005 11:21:11 +0000 (11:21 +0000)]
r5484: Fix a memleak
(This used to be commit 7b9cb0601ce465361618fcc2c88f8195d93f130a)

12 years agor5481: Fix a memleak
Volker Lendecke [Mon, 21 Feb 2005 11:11:13 +0000 (11:11 +0000)]
r5481: Fix a memleak
(This used to be commit 36bcfc5dae99868fc94ca01f902fec3d19926f5e)

12 years agor5471: In cli_samr_lookup_rids, flags is not a flags but an array size. W2k3 rejects
Volker Lendecke [Sun, 20 Feb 2005 15:15:33 +0000 (15:15 +0000)]
r5471: In cli_samr_lookup_rids, flags is not a flags but an array size. W2k3 rejects
everything but 1000 here, so there's no point in exposing that to the caller.


(This used to be commit 03ec1bd9e54b065c0494bc57a3d78ac0ae28e234)

12 years agor5469: Fix error codes of samr_lookup_rids: There's also STATUS_SOME_UNMAPPED.
Volker Lendecke [Sun, 20 Feb 2005 14:26:58 +0000 (14:26 +0000)]
r5469: Fix error codes of samr_lookup_rids: There's also STATUS_SOME_UNMAPPED.


(This used to be commit 43dcf0f5cb5dc2dd37ab3cdc2905970d9cc50ba4)