From: Andrew Tridgell Date: Wed, 20 Jul 2005 00:09:23 +0000 (+0000) Subject: r8624: removed valgrind comment on tdb that no longer applies X-Git-Tag: samba-4.0.0alpha6~801^3~9774 X-Git-Url: http://git.samba.org/samba.git/?p=bbaumbach%2Fsamba-autobuild%2F.git;a=commitdiff_plain;h=f650ea10120d41ceff8ea04975fea7637cb45a0a r8624: removed valgrind comment on tdb that no longer applies (This used to be commit 8f222c8c7a750c739d3288da0b1edb1efc3b1ffc) --- diff --git a/source4/lib/tdb/common/tdb.c b/source4/lib/tdb/common/tdb.c index 44533aad271..4c2d9a1addb 100644 --- a/source4/lib/tdb/common/tdb.c +++ b/source4/lib/tdb/common/tdb.c @@ -27,25 +27,6 @@ */ -/* NOTE: If you use tdbs under valgrind, and in particular if you run - * tdbtorture, you may get spurious "uninitialized value" warnings. I - * think this is because valgrind doesn't understand that the mmap'd - * area may be written to by other processes. Memory can, from the - * point of view of the grinded process, spontaneously become - * initialized. - * - * I can think of a few solutions. [mbp 20030311] - * - * 1 - Write suppressions for Valgrind so that it doesn't complain - * about this. Probably the most reasonable but people need to - * remember to use them. - * - * 2 - Use IO not mmap when running under valgrind. Not so nice. - * - * 3 - Use the special valgrind macros to mark memory as valid at the - * right time. Probably too hard -- the process just doesn't know. - */ - #ifndef _SAMBA_BUILD_ #if HAVE_CONFIG_H #include