From: Andreas Schneider <asn@samba.org>
Date: Wed, 12 Dec 2018 09:08:53 +0000 (+0100)
Subject: libcli:security: Do not duplicate invalid aces
X-Git-Tag: tdb-1.3.17~353
X-Git-Url: http://git.samba.org/samba.git/?p=bbaumbach%2Fsamba-autobuild%2F.git;a=commitdiff_plain;h=e7a8e4e6433bf26f6eac46e6a5f65f421a8981bb

libcli:security: Do not duplicate invalid aces

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
---

diff --git a/libcli/security/security_descriptor.c b/libcli/security/security_descriptor.c
index 0a2bb952b0e..02c3212fa63 100644
--- a/libcli/security/security_descriptor.c
+++ b/libcli/security/security_descriptor.c
@@ -58,6 +58,10 @@ struct security_acl *security_acl_dup(TALLOC_CTX *mem_ctx,
 		return NULL;
 	}
 
+	if (oacl->aces == NULL && oacl->num_aces > 0) {
+		return NULL;
+	}
+
 	nacl = talloc (mem_ctx, struct security_acl);
 	if (nacl == NULL) {
 		return NULL;