From: Matthias Dieter Wallnöfer <mdw@samba.org>
Date: Mon, 12 Sep 2011 13:45:11 +0000 (+0200)
Subject: s4:lib/socket/interface.c - "ifaces" strictly needs to be initialised
X-Git-Tag: samba-4.0.0alpha17~11
X-Git-Url: http://git.samba.org/samba.git/?p=bbaumbach%2Fsamba-autobuild%2F.git;a=commitdiff_plain;h=d0df75701e529e2d872691f8be047c5b55118930

s4:lib/socket/interface.c - "ifaces" strictly needs to be initialised

Please consider a failing "get_interfaces" call and the "talloc_free()"
operation on a possible uninitialised "ifaces" on line 326.

https://bugzilla.samba.org/show_bug.cgi?id=8397

Reviewed-by: Jelmer

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Mon Sep 12 23:49:12 CEST 2011 on sn-devel-104
---

diff --git a/source4/lib/socket/interface.c b/source4/lib/socket/interface.c
index 42e19467688..7994716e83d 100644
--- a/source4/lib/socket/interface.c
+++ b/source4/lib/socket/interface.c
@@ -293,7 +293,7 @@ void load_interface_list(TALLOC_CTX *mem_ctx, struct loadparm_context *lp_ctx, s
 {
 	const char **ptr = lpcfg_interfaces(lp_ctx);
 	int i;
-	struct iface_struct *ifaces;
+	struct iface_struct *ifaces = NULL;
 	int total_probed;
 	bool enable_ipv6 = lpcfg_parm_bool(lp_ctx, NULL, "ipv6", "enable", true);