s4:lib/socket/interface.c - "ifaces" strictly needs to be initialised

Please consider a failing "get_interfaces" call and the "talloc_free()"
operation on a possible uninitialised "ifaces" on line 326.

https://bugzilla.samba.org/show_bug.cgi?id=8397

Reviewed-by: Jelmer
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Mon Sep 12 23:49:12 CEST 2011 on sn-devel-104

diff --git a/source4/lib/socket/interface.c b/source4/lib/socket/interface.c
index 42e19467688141120b3de72b60c65f1e0f79a3d3..7994716e83d875d76a8f2a20274b258ef3f0f3fa 100644 (file)
--- a/source4/lib/socket/interface.c
+++ b/source4/lib/socket/interface.c
@@ -293,7 +293,7 @@ void load_interface_list(TALLOC_CTX *mem_ctx, struct loadparm_context *lp_ctx, s
 {
        const char **ptr = lpcfg_interfaces(lp_ctx);
        int i;
-       struct iface_struct *ifaces;
+       struct iface_struct *ifaces = NULL;
        int total_probed;
        bool enable_ipv6 = lpcfg_parm_bool(lp_ctx, NULL, "ipv6", "enable", true);