s3:net ads join: check for success of fetching machine password in dns update block

log and cleanup accordingly if failed

diff --git a/source3/utils/net_ads.c b/source3/utils/net_ads.c
index 22486ea7fbdeab32c997d7b93b82289eac5d8527..ddfe10b9143c34851c4bcc4c81bb571e9c79a194 100644 (file)
--- a/source3/utils/net_ads.c
+++ b/source3/utils/net_ads.c
@@ -1486,6 +1486,11 @@ int net_ads_join(struct net_context *c, int argc, const char **argv)
 
                ads_dns->auth.password = secrets_fetch_machine_password(
                        r->out.netbios_domain_name, NULL, NULL);
+               if (ads_dns->auth.password == NULL) {
+                       d_fprintf(stderr, _("DNS update failed: out of memory\n"));
+                       goto dns_done;
+               }
+
                ads_dns->auth.realm = SMB_STRDUP(r->out.dns_domain_name);
                strupper_m(ads_dns->auth.realm);
                ads_kinit_password(ads_dns);