ctdb: Remove double sanity checks from ctdb_daemon_read_cb
authorSwen Schillig <swen@vnet.ibm.com>
Tue, 13 Mar 2018 07:57:40 +0000 (08:57 +0100)
committerMartin Schwenke <martins@samba.org>
Wed, 4 Apr 2018 04:35:17 +0000 (06:35 +0200)
Within ctdb_daemon_read_cb the provided data is checked for sanity,
e.g. correct size and content. This is not required because it was
done already by the caller (queue_process).

Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Jeremy Allison <jra@samba.org>
ctdb/server/ctdb_daemon.c

index 6d2f70f99b6205861c936d013e76510109e1071c..3b06972d030e6698a3f7972d3f9db7de3db536e2 100644 (file)
@@ -895,11 +895,6 @@ static void ctdb_daemon_read_cb(uint8_t *data, size_t cnt, void *args)
                return;
        }
        hdr = (struct ctdb_req_header *)data;
-       if (cnt != hdr->length) {
-               ctdb_set_error(client->ctdb, "Bad header length %u expected %u\n in daemon", 
-                              (unsigned)hdr->length, (unsigned)cnt);
-               return;
-       }
 
        if (hdr->ctdb_magic != CTDB_MAGIC) {
                ctdb_set_error(client->ctdb, "Non CTDB packet rejected\n");