libgpo: gpo_copy_file() shouldn't explicitly call smb1
authorDavid Mulder <dmulder@suse.com>
Wed, 11 Apr 2018 18:40:18 +0000 (12:40 -0600)
committerDouglas Bagnall <dbagnall@samba.org>
Thu, 12 Apr 2018 06:13:34 +0000 (08:13 +0200)
Don't call cli_openx directly to open a file this
calls smb1 code explicitly, which fails if we did
a multi-protocol negotiate and negotiated smb2+.
Use the higher level cli_open() instead.

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
libgpo/gpo_filesync.c

index 6e3efdaf6c1b5a1c91ae84a73647b105425a70d5..bf0bb5381fc389feb57677bd02046734eac8c36e 100644 (file)
@@ -50,7 +50,7 @@ NTSTATUS gpo_copy_file(TALLOC_CTX *mem_ctx,
        int read_size = io_bufsize;
        off_t nread = 0;
 
-       result = cli_openx(cli, nt_path, O_RDONLY, DENY_NONE, &fnum);
+       result = cli_open(cli, nt_path, O_RDONLY, DENY_NONE, &fnum);
        if (!NT_STATUS_IS_OK(result)) {
                goto out;
        }