libcli: Avoid an explicit memset call

On x86 with -O3, this saves surprising 160 bytes .text

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>

diff --git a/libcli/security/util_sid.c b/libcli/security/util_sid.c
index 9a24a4ab8fab4c681899cef11ecc700fc09dc4a0..8e42826fa7d1d21c1fef3a2b90db27f9713fcc6a 100644 (file)
--- a/libcli/security/util_sid.c
+++ b/libcli/security/util_sid.c
@@ -225,10 +225,10 @@ void sid_copy(struct dom_sid *dst, const struct dom_sid *src)
 {
        int i;
 
-       ZERO_STRUCTP(dst);
-
-       dst->sid_rev_num = src->sid_rev_num;
-       dst->num_auths = src->num_auths;
+       *dst = (struct dom_sid) {
+               .sid_rev_num = src->sid_rev_num,
+               .num_auths = src->num_auths,
+       };
 
        memcpy(&dst->id_auth[0], &src->id_auth[0], sizeof(src->id_auth));