s4:repl - change also here the counter variables to "unsigned"
authorMatthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
Fri, 6 Nov 2009 19:14:41 +0000 (20:14 +0100)
committerMatthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
Fri, 5 Mar 2010 17:28:35 +0000 (18:28 +0100)
I changed also some "uint32_t" to "unsigned" since the LDB interface doesn't
specify the bitlength of the unsigned type.

source4/dsdb/repl/drepl_notify.c
source4/dsdb/repl/drepl_partitions.c
source4/dsdb/repl/replicated_objects.c

index c3ca5ed31018b5b147d951d48078d304ad358a0a..5047da33077c0210947537dafce6d45561bca47a 100644 (file)
@@ -170,7 +170,7 @@ static void dreplsrv_notify_del_repsTo(struct dreplsrv_notify_operation *op)
        struct repsFromToBlob *reps;
        WERROR werr;
        struct dreplsrv_service *s = op->service;
-       int i;
+       uint32_t i;
 
        werr = dsdb_loadreps(s->samdb, op, op->source_dsa->partition->dn, "repsTo", &reps, &count);
        if (!W_ERROR_IS_OK(werr)) {
@@ -324,7 +324,8 @@ static WERROR dreplsrv_notify_check(struct dreplsrv_service *s,
        WERROR werr;
        uint64_t uSNHighest;
        uint64_t uSNUrgent;
-       int ret, i;
+       uint32_t i;
+       int ret;
 
        werr = dsdb_loadreps(s->samdb, mem_ctx, p->dn, "repsTo", &reps, &count);
        if (count == 0) {
index b57a5c81c0cd4a1595fc578dc2c24c999860efbb..b17a17d5a333e9c605c3682188ebd49322ca5840 100644 (file)
@@ -40,7 +40,7 @@ WERROR dreplsrv_load_partitions(struct dreplsrv_service *s)
        struct ldb_result *r;
        struct ldb_message_element *el;
        static const char *attrs[] = { "hasMasterNCs", NULL };
-       uint32_t i;
+       unsigned int i;
        int ret;
 
        basedn = samdb_ntds_settings_dn(s->samdb);
@@ -195,7 +195,7 @@ static WERROR udv_convert(TALLOC_CTX *mem_ctx,
                          const struct replUpToDateVectorCtr2 *udv,
                          struct drsuapi_DsReplicaCursorCtrEx *udv_ex)
 {
-       int i;
+       uint32_t i;
 
        udv_ex->version = 2;
        udv_ex->reserved1 = 0;
@@ -220,7 +220,7 @@ static WERROR dreplsrv_refresh_partition(struct dreplsrv_service *s,
        struct dom_sid *nc_sid;
        struct ldb_message_element *orf_el = NULL;
        struct ldb_result *r;
-       uint32_t i;
+       unsigned int i;
        int ret;
        TALLOC_CTX *mem_ctx = talloc_new(p);
        static const char *attrs[] = {
index b95bf87e3660232f1415e5cec99182965b771c24..4d500e9637e8a488937675a09f0a574399085bde 100644 (file)
@@ -115,7 +115,7 @@ static WERROR dsdb_convert_object_ex(struct ldb_context *ldb,
                struct drsuapi_DsReplicaMetaData *d;
                struct replPropertyMetaData1 *m;
                struct ldb_message_element *e;
-               int j;
+               uint32_t j;
 
                a = &in->object.attribute_ctr.attributes[i];
                d = &in->meta_data_ctr->meta_data[i];
@@ -342,7 +342,7 @@ static WERROR dsdb_convert_object(struct ldb_context *ldb,
                                  struct ldb_message **_msg)
 {
        WERROR status;
-       uint32_t i;
+       unsigned int i;
        struct ldb_message *msg;
 
        if (!in->object.identifier) {