waf:lib/replace correct detection of libiconv

add -liconv as a complete command line argument,
not all characters on their own

Bug: https://bugzilla.samba.org/show_bug.cgi?id=9911

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/lib/replace/wscript b/lib/replace/wscript
index a316032efeac47801dc6a453bac1d62708fbe03e..09efdc8831f1fd057b532921a2f68f6b21bb0d0d 100644 (file)
--- a/lib/replace/wscript
+++ b/lib/replace/wscript
@@ -390,7 +390,7 @@ removeea setea
             # Some hosts need lib iconv for linking with lib intl
             # So we try with flags just in case it helps.
             oldflags = conf.env['EXTRA_LDFLAGS'];
-            conf.env['EXTRA_LDFLAGS'].extend("-liconv")
+            conf.env['EXTRA_LDFLAGS'].extend(["-liconv"])
             conf.CHECK_FUNCS_IN('dgettext gettext bindtextdomain textdomain bind_textdomain_codeset',
                                 'intl', checklibc=False, headers='libintl.h')
             conf.env['EXTRA_LDFLAGS'] = oldflags