git.samba.org / bbaumbach / samba-autobuild / .git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: e71d0d7) | patch
netcmd/ldapcmp: avoid list comprehension in for loop
authorJoe Guo <joeg@catalyst.net.nz>
Sun, 28 Oct 2018 21:16:02 +0000 (10:16 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Wed, 21 Nov 2018 06:46:19 +0000 (07:46 +0100)
commit86882bd12e506e3a7ceac4f3e9e282df55398a7f
treefd907678fc3e203fc25201f93d7e358b0d9b7994tree
parente71d0d71203474b1b30c8c8250c28ba4889b1f20commit | diff
netcmd/ldapcmp: avoid list comprehension in for loop

The list comprehension will repeat for each item.
For large database, this make the command freeze.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python/samba/netcmd/ldapcmp.py diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.