Finish removal of iconv_convenience in public API's.
[bbaumbach/samba-autobuild/.git] / source4 / lib / ldb-samba / ldif_handlers.c
index f2c985e81a2075ca9d444c1ffa58fddef791ff0b..5e21199488de7d65a92fc3ebc344af52bca1dd60 100644 (file)
 
 /*
   use ndr_print_* to convert a NDR formatted blob to a ldif formatted blob
+
+  If mask_errors is true, then function succeeds but out data
+  is set to "<Unable to decode binary data>" message
+
+  \return 0 on success; -1 on error
 */
 static int ldif_write_NDR(struct ldb_context *ldb, void *mem_ctx,
                          const struct ldb_val *in, struct ldb_val *out,
                          size_t struct_size,
                          ndr_pull_flags_fn_t pull_fn,
-                         ndr_print_fn_t print_fn)
+                         ndr_print_fn_t print_fn,
+                         bool mask_errors)
 {
        uint8_t *p;
        enum ndr_err_code err;
@@ -51,9 +57,12 @@ static int ldif_write_NDR(struct ldb_context *ldb, void *mem_ctx,
        }
        p = talloc_size(mem_ctx, struct_size);
        err = ndr_pull_struct_blob(in, mem_ctx, 
-                                  lp_iconv_convenience(ldb_get_opaque(ldb, "loadparm")), 
                                   p, pull_fn);
        if (err != NDR_ERR_SUCCESS) {
+               /* fail in not in mask_error mode */
+               if (!mask_errors) {
+                       return -1;
+               }
                talloc_free(p);
                out->data = (uint8_t *)talloc_strdup(mem_ctx, "<Unable to decode binary data>");
                out->length = strlen((const char *)out->data);
@@ -80,7 +89,7 @@ static int ldif_read_objectSid(struct ldb_context *ldb, void *mem_ctx,
        if (sid == NULL) {
                return -1;
        }
-       ndr_err = ndr_push_struct_blob(out, mem_ctx, NULL, sid,
+       ndr_err = ndr_push_struct_blob(out, mem_ctx, sid,
                                       (ndr_push_flags_fn_t)ndr_push_dom_sid);
        talloc_free(sid);
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
@@ -102,7 +111,7 @@ int ldif_write_objectSid(struct ldb_context *ldb, void *mem_ctx,
        if (sid == NULL) {
                return -1;
        }
-       ndr_err = ndr_pull_struct_blob_all(in, sid, NULL, sid,
+       ndr_err = ndr_pull_struct_blob_all(in, sid, sid,
                                           (ndr_pull_flags_fn_t)ndr_pull_dom_sid);
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                talloc_free(sid);
@@ -199,7 +208,7 @@ static int extended_dn_read_SID(struct ldb_context *ldb, void *mem_ctx,
                                     (const char *)in->data, in->length);
 
        /* Check it looks like a SID */
-       ndr_err = ndr_pull_struct_blob_all(out, mem_ctx, NULL, &sid,
+       ndr_err = ndr_pull_struct_blob_all(out, mem_ctx, &sid,
                                           (ndr_pull_flags_fn_t)ndr_pull_dom_sid);
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                return -1;
@@ -215,16 +224,14 @@ static int ldif_read_objectGUID(struct ldb_context *ldb, void *mem_ctx,
 {
        struct GUID guid;
        NTSTATUS status;
-       enum ndr_err_code ndr_err;
 
        status = GUID_from_data_blob(in, &guid);
        if (!NT_STATUS_IS_OK(status)) {
                return -1;
        }
 
-       ndr_err = ndr_push_struct_blob(out, mem_ctx, NULL, &guid,
-                                      (ndr_push_flags_fn_t)ndr_push_GUID);
-       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+       status = GUID_to_ndr_blob(&guid, mem_ctx, out);
+       if (!NT_STATUS_IS_OK(status)) {
                return -1;
        }
        return 0;
@@ -237,10 +244,10 @@ static int ldif_write_objectGUID(struct ldb_context *ldb, void *mem_ctx,
                                 const struct ldb_val *in, struct ldb_val *out)
 {
        struct GUID guid;
-       enum ndr_err_code ndr_err;
-       ndr_err = ndr_pull_struct_blob_all(in, mem_ctx, NULL, &guid,
-                                          (ndr_pull_flags_fn_t)ndr_pull_GUID);
-       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+       NTSTATUS status;
+
+       status = GUID_from_ndr_blob(in, &guid);
+       if (!NT_STATUS_IS_OK(status)) {
                return -1;
        }
        out->data = (uint8_t *)GUID_string(mem_ctx, &guid);
@@ -263,7 +270,8 @@ static int extended_dn_read_GUID(struct ldb_context *ldb, void *mem_ctx,
                              const struct ldb_val *in, struct ldb_val *out)
 {
        struct GUID guid;
-       enum ndr_err_code ndr_err;
+       NTSTATUS status;
+
        if (in->length == 36 && ldif_read_objectGUID(ldb, mem_ctx, in, out) == 0) {
                return 0;
        }
@@ -283,9 +291,9 @@ static int extended_dn_read_GUID(struct ldb_context *ldb, void *mem_ctx,
                                      (const char *)in->data, in->length);
        
        /* Check it looks like a GUID */
-       ndr_err = ndr_pull_struct_blob_all(out, mem_ctx, NULL, &guid,
-                                          (ndr_pull_flags_fn_t)ndr_pull_GUID);
-       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+       status = GUID_from_ndr_blob(out, &guid);
+       if (!NT_STATUS_IS_OK(status)) {
+               data_blob_free(out);
                return -1;
        }
        return 0;
@@ -356,7 +364,7 @@ static int ldif_read_ntSecurityDescriptor(struct ldb_context *ldb, void *mem_ctx
                return -1;
        }
 
-       ndr_err = ndr_pull_struct_blob(in, sd, NULL, sd,
+       ndr_err = ndr_pull_struct_blob(in, sd, sd,
                                       (ndr_pull_flags_fn_t)ndr_pull_security_descriptor);
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                /* If this does not parse, then it is probably SDDL, and we should try it that way */
@@ -369,7 +377,7 @@ static int ldif_read_ntSecurityDescriptor(struct ldb_context *ldb, void *mem_ctx
                }
        }
 
-       ndr_err = ndr_push_struct_blob(out, mem_ctx, NULL, sd,
+       ndr_err = ndr_push_struct_blob(out, mem_ctx, sd,
                                       (ndr_push_flags_fn_t)ndr_push_security_descriptor);
        talloc_free(sd);
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
@@ -392,7 +400,8 @@ static int ldif_write_ntSecurityDescriptor(struct ldb_context *ldb, void *mem_ct
                return ldif_write_NDR(ldb, mem_ctx, in, out, 
                                      sizeof(struct security_descriptor),
                                      (ndr_pull_flags_fn_t)ndr_pull_security_descriptor,
-                                     (ndr_print_fn_t)ndr_print_security_descriptor);
+                                     (ndr_print_fn_t)ndr_print_security_descriptor,
+                                     true);
                                      
        }
 
@@ -401,13 +410,13 @@ static int ldif_write_ntSecurityDescriptor(struct ldb_context *ldb, void *mem_ct
                return -1;
        }
        /* We can't use ndr_pull_struct_blob_all because this contains relative pointers */
-       ndr_err = ndr_pull_struct_blob(in, sd, NULL, sd,
+       ndr_err = ndr_pull_struct_blob(in, sd, sd,
                                           (ndr_pull_flags_fn_t)ndr_pull_security_descriptor);
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                talloc_free(sd);
                return -1;
        }
-       out->data = (uint8_t *)sddl_encode(mem_ctx, sd, NULL);
+       out->data = (uint8_t *)sddl_encode(mem_ctx, sd, samdb_domain_sid_cache_only(ldb));
        talloc_free(sd);
        if (out->data == NULL) {
                return -1;
@@ -425,7 +434,7 @@ static int ldif_canonicalise_objectCategory(struct ldb_context *ldb, void *mem_c
                                            const struct ldb_val *in, struct ldb_val *out)
 {
        struct ldb_dn *dn1 = NULL;
-       const struct dsdb_schema *schema = dsdb_get_schema(ldb);
+       const struct dsdb_schema *schema = dsdb_get_schema(ldb, NULL);
        const struct dsdb_class *sclass;
        TALLOC_CTX *tmp_ctx = talloc_new(mem_ctx);
        if (!tmp_ctx) {
@@ -481,6 +490,19 @@ static int ldif_comparison_objectCategory(struct ldb_context *ldb, void *mem_ctx
                                  v1, v2);
 }
 
+/*
+  convert a NDR formatted blob to a ldif formatted schemaInfo
+*/
+static int ldif_write_schemaInfo(struct ldb_context *ldb, void *mem_ctx,
+                                const struct ldb_val *in, struct ldb_val *out)
+{
+       return ldif_write_NDR(ldb, mem_ctx, in, out,
+                             sizeof(struct repsFromToBlob),
+                             (ndr_pull_flags_fn_t)ndr_pull_schemaInfoBlob,
+                             (ndr_print_fn_t)ndr_print_schemaInfoBlob,
+                             true);
+}
+
 /*
   convert a ldif formatted prefixMap to a NDR formatted blob
 */
@@ -523,7 +545,7 @@ static int ldif_read_prefixMap(struct ldb_context *ldb, void *mem_ctx,
                                p[0] = '\0';
                        }
                }
-               /* allow a traling seperator */
+               /* allow a trailing separator */
                if (line == p) {
                        break;
                }
@@ -565,7 +587,6 @@ static int ldif_read_prefixMap(struct ldb_context *ldb, void *mem_ctx,
        }
 
        ndr_err = ndr_push_struct_blob(out, mem_ctx, 
-                                      lp_iconv_convenience(ldb_get_opaque(ldb, "loadparm")), 
                                       blob,
                                       (ndr_push_flags_fn_t)ndr_push_prefixMapBlob);
        talloc_free(tmp_ctx);
@@ -587,11 +608,22 @@ static int ldif_write_prefixMap(struct ldb_context *ldb, void *mem_ctx,
        uint32_t i;
 
        if (ldb_get_flags(ldb) & LDB_FLG_SHOW_BINARY) {
-               return ldif_write_NDR(ldb, mem_ctx, in, out, 
-                                     sizeof(struct prefixMapBlob),
-                                     (ndr_pull_flags_fn_t)ndr_pull_prefixMapBlob,
-                                     (ndr_print_fn_t)ndr_print_prefixMapBlob);
-                                     
+               int err;
+               /* try to decode the blob as S4 prefixMap */
+               err = ldif_write_NDR(ldb, mem_ctx, in, out,
+                                    sizeof(struct prefixMapBlob),
+                                    (ndr_pull_flags_fn_t)ndr_pull_prefixMapBlob,
+                                    (ndr_print_fn_t)ndr_print_prefixMapBlob,
+                                    false);
+               if (0 == err) {
+                       return err;
+               }
+               /* try parsing it as Windows PrefixMap value */
+               return ldif_write_NDR(ldb, mem_ctx, in, out,
+                                     sizeof(struct drsuapi_MSPrefixMap_Ctr),
+                                     (ndr_pull_flags_fn_t)ndr_pull_drsuapi_MSPrefixMap_Ctr,
+                                     (ndr_print_fn_t)ndr_print_drsuapi_MSPrefixMap_Ctr,
+                                     true);
        }
 
        blob = talloc(mem_ctx, struct prefixMapBlob);
@@ -599,7 +631,6 @@ static int ldif_write_prefixMap(struct ldb_context *ldb, void *mem_ctx,
                return -1;
        }
        ndr_err = ndr_pull_struct_blob_all(in, blob, 
-                                          lp_iconv_convenience(ldb_get_opaque(ldb, "loadparm")), 
                                           blob,
                                           (ndr_pull_flags_fn_t)ndr_pull_prefixMapBlob);
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
@@ -679,20 +710,63 @@ static int ldif_comparison_prefixMap(struct ldb_context *ldb, void *mem_ctx,
                                  v1, v2);
 }
 
-/* Canonicalisation of two 32-bit integers */
-static int ldif_canonicalise_int32(struct ldb_context *ldb, void *mem_ctx,
-                       const struct ldb_val *in, struct ldb_val *out)
+/* length limited conversion of a ldb_val to a int32_t */
+static int val_to_int32(const struct ldb_val *in, int32_t *v)
 {
        char *end;
+       char buf[64];
+
+       /* make sure we don't read past the end of the data */
+       if (in->length > sizeof(buf)-1) {
+               return LDB_ERR_INVALID_ATTRIBUTE_SYNTAX;
+       }
+       strncpy(buf, (char *)in->data, in->length);
+       buf[in->length] = 0;
+
        /* We've to use "strtoll" here to have the intended overflows.
         * Otherwise we may get "LONG_MAX" and the conversion is wrong. */
-       int32_t i = (int32_t) strtoll((char *)in->data, &end, 0);
+       *v = (int32_t) strtoll(buf, &end, 0);
        if (*end != 0) {
-               return -1;
+               return LDB_ERR_INVALID_ATTRIBUTE_SYNTAX;
+       }
+       return LDB_SUCCESS;
+}
+
+/* length limited conversion of a ldb_val to a int64_t */
+static int val_to_int64(const struct ldb_val *in, int64_t *v)
+{
+       char *end;
+       char buf[64];
+
+       /* make sure we don't read past the end of the data */
+       if (in->length > sizeof(buf)-1) {
+               return LDB_ERR_INVALID_ATTRIBUTE_SYNTAX;
+       }
+       strncpy(buf, (char *)in->data, in->length);
+       buf[in->length] = 0;
+
+       *v = (int64_t) strtoll(buf, &end, 0);
+       if (*end != 0) {
+               return LDB_ERR_INVALID_ATTRIBUTE_SYNTAX;
+       }
+       return LDB_SUCCESS;
+}
+
+/* Canonicalisation of two 32-bit integers */
+static int ldif_canonicalise_int32(struct ldb_context *ldb, void *mem_ctx,
+                       const struct ldb_val *in, struct ldb_val *out)
+{
+       int32_t i;
+       int ret;
+
+       ret = val_to_int32(in, &i);
+       if (ret != LDB_SUCCESS) {
+               return ret;
        }
        out->data = (uint8_t *) talloc_asprintf(mem_ctx, "%d", i);
        if (out->data == NULL) {
-               return -1;
+               ldb_oom(ldb);
+               return LDB_ERR_OPERATIONS_ERROR;
        }
        out->length = strlen((char *)out->data);
        return 0;
@@ -700,12 +774,44 @@ static int ldif_canonicalise_int32(struct ldb_context *ldb, void *mem_ctx,
 
 /* Comparison of two 32-bit integers */
 static int ldif_comparison_int32(struct ldb_context *ldb, void *mem_ctx,
-                       const struct ldb_val *v1, const struct ldb_val *v2)
+                                const struct ldb_val *v1, const struct ldb_val *v2)
 {
-       /* We've to use "strtoll" here to have the intended overflows.
-        * Otherwise we may get "LONG_MAX" and the conversion is wrong. */
-       return (int32_t) strtoll((char *)v1->data, NULL, 0)
-        - (int32_t) strtoll((char *)v2->data, NULL, 0);
+       int32_t i1=0, i2=0;
+       val_to_int32(v1, &i1);
+       val_to_int32(v2, &i2);
+       if (i1 == i2) return 0;
+       return i1 > i2? 1 : -1;
+}
+
+/* Canonicalisation of two 64-bit integers */
+static int ldif_canonicalise_int64(struct ldb_context *ldb, void *mem_ctx,
+                                  const struct ldb_val *in, struct ldb_val *out)
+{
+       int64_t i;
+       int ret;
+
+       ret = val_to_int64(in, &i);
+       if (ret != LDB_SUCCESS) {
+               return ret;
+       }
+       out->data = (uint8_t *) talloc_asprintf(mem_ctx, "%lld", (long long)i);
+       if (out->data == NULL) {
+               ldb_oom(ldb);
+               return LDB_ERR_OPERATIONS_ERROR;
+       }
+       out->length = strlen((char *)out->data);
+       return 0;
+}
+
+/* Comparison of two 64-bit integers */
+static int ldif_comparison_int64(struct ldb_context *ldb, void *mem_ctx,
+                                const struct ldb_val *v1, const struct ldb_val *v2)
+{
+       int64_t i1=0, i2=0;
+       val_to_int64(v1, &i1);
+       val_to_int64(v2, &i2);
+       if (i1 == i2) return 0;
+       return i1 > i2? 1 : -1;
 }
 
 /*
@@ -717,7 +823,8 @@ static int ldif_write_repsFromTo(struct ldb_context *ldb, void *mem_ctx,
        return ldif_write_NDR(ldb, mem_ctx, in, out, 
                              sizeof(struct repsFromToBlob),
                              (ndr_pull_flags_fn_t)ndr_pull_repsFromToBlob,
-                             (ndr_print_fn_t)ndr_print_repsFromToBlob);
+                             (ndr_print_fn_t)ndr_print_repsFromToBlob,
+                             true);
 }
 
 /*
@@ -729,7 +836,8 @@ static int ldif_write_replPropertyMetaData(struct ldb_context *ldb, void *mem_ct
        return ldif_write_NDR(ldb, mem_ctx, in, out, 
                              sizeof(struct replPropertyMetaDataBlob),
                              (ndr_pull_flags_fn_t)ndr_pull_replPropertyMetaDataBlob,
-                             (ndr_print_fn_t)ndr_print_replPropertyMetaDataBlob);
+                             (ndr_print_fn_t)ndr_print_replPropertyMetaDataBlob,
+                             true);
 }
 
 /*
@@ -741,7 +849,8 @@ static int ldif_write_replUpToDateVector(struct ldb_context *ldb, void *mem_ctx,
        return ldif_write_NDR(ldb, mem_ctx, in, out, 
                              sizeof(struct replUpToDateVectorBlob),
                              (ndr_pull_flags_fn_t)ndr_pull_replUpToDateVectorBlob,
-                             (ndr_print_fn_t)ndr_print_replUpToDateVectorBlob);
+                             (ndr_print_fn_t)ndr_print_replUpToDateVectorBlob,
+                             true);
 }
 
 
@@ -755,6 +864,64 @@ static int extended_dn_write_hex(struct ldb_context *ldb, void *mem_ctx,
        return 0;
 }
 
+
+/*
+  write a 64 bit 2-part range
+*/
+static int ldif_write_range64(struct ldb_context *ldb, void *mem_ctx,
+                             const struct ldb_val *in, struct ldb_val *out)
+{
+       int64_t v;
+       int ret;
+       ret = val_to_int64(in, &v);
+       if (ret != LDB_SUCCESS) {
+               return ret;
+       }
+       out->data = (uint8_t *)talloc_asprintf(mem_ctx, "%lu-%lu",
+                                              (unsigned long)(v&0xFFFFFFFF),
+                                              (unsigned long)(v>>32));
+       if (out->data == NULL) {
+               ldb_oom(ldb);
+               return LDB_ERR_OPERATIONS_ERROR;
+       }
+       out->length = strlen((char *)out->data);
+       return LDB_SUCCESS;
+}
+
+/*
+  read a 64 bit 2-part range
+*/
+static int ldif_read_range64(struct ldb_context *ldb, void *mem_ctx,
+                             const struct ldb_val *in, struct ldb_val *out)
+{
+       unsigned long high, low;
+       char buf[64];
+
+       if (memchr(in->data, '-', in->length) == NULL) {
+               return ldb_handler_copy(ldb, mem_ctx, in, out);
+       }
+
+       if (in->length > sizeof(buf)-1) {
+               return LDB_ERR_INVALID_ATTRIBUTE_SYNTAX;
+       }
+       strncpy(buf, (const char *)in->data, in->length);
+       buf[in->length] = 0;
+
+       if (sscanf(buf, "%lu-%lu", &low, &high) != 2) {
+               return LDB_ERR_INVALID_ATTRIBUTE_SYNTAX;
+       }
+
+       out->data = (uint8_t *)talloc_asprintf(mem_ctx, "%llu",
+                                              (unsigned long long)(((uint64_t)high)<<32) | (low));
+
+       if (out->data == NULL) {
+               ldb_oom(ldb);
+               return LDB_ERR_OPERATIONS_ERROR;
+       }
+       out->length = strlen((char *)out->data);
+       return LDB_SUCCESS;
+}
+
 static const struct ldb_schema_syntax samba_syntaxes[] = {
        {
                .name             = LDB_SYNTAX_SAMBA_SID,
@@ -780,6 +947,12 @@ static const struct ldb_schema_syntax samba_syntaxes[] = {
                .ldif_write_fn    = ldb_handler_copy,
                .canonicalise_fn  = ldif_canonicalise_objectCategory,
                .comparison_fn    = ldif_comparison_objectCategory
+       },{
+               .name             = LDB_SYNTAX_SAMBA_SCHEMAINFO,
+               .ldif_read_fn     = ldb_handler_copy,
+               .ldif_write_fn    = ldif_write_schemaInfo,
+               .canonicalise_fn  = ldb_handler_copy,
+               .comparison_fn    = ldb_comparison_binary
        },{
                .name             = LDB_SYNTAX_SAMBA_PREFIX_MAP,
                .ldif_read_fn     = ldif_read_prefixMap,
@@ -822,6 +995,12 @@ static const struct ldb_schema_syntax samba_syntaxes[] = {
                .ldif_write_fn    = ldb_handler_copy,
                .canonicalise_fn  = dsdb_dn_string_canonicalise,
                .comparison_fn    = dsdb_dn_string_comparison
+       },{
+               .name             = LDB_SYNTAX_SAMBA_RANGE64,
+               .ldif_read_fn     = ldif_read_range64,
+               .ldif_write_fn    = ldif_write_range64,
+               .canonicalise_fn  = ldif_canonicalise_int64,
+               .comparison_fn    = ldif_comparison_int64
        },
 };
 
@@ -841,6 +1020,41 @@ static const struct ldb_dn_extended_syntax samba_dn_syntax[] = {
                .read_fn          = ldb_handler_copy,
                .write_clear_fn   = ldb_handler_copy,
                .write_hex_fn     = ldb_handler_copy
+       },{
+               .name             = "RMD_INVOCID",
+               .read_fn          = extended_dn_read_GUID,
+               .write_clear_fn   = ldif_write_objectGUID,
+               .write_hex_fn     = extended_dn_write_hex
+       },{
+               .name             = "RMD_FLAGS",
+               .read_fn          = ldb_handler_copy,
+               .write_clear_fn   = ldb_handler_copy,
+               .write_hex_fn     = ldb_handler_copy
+       },{
+               .name             = "RMD_ADDTIME",
+               .read_fn          = ldb_handler_copy,
+               .write_clear_fn   = ldb_handler_copy,
+               .write_hex_fn     = ldb_handler_copy
+       },{
+               .name             = "RMD_CHANGETIME",
+               .read_fn          = ldb_handler_copy,
+               .write_clear_fn   = ldb_handler_copy,
+               .write_hex_fn     = ldb_handler_copy
+       },{
+               .name             = "RMD_LOCAL_USN",
+               .read_fn          = ldb_handler_copy,
+               .write_clear_fn   = ldb_handler_copy,
+               .write_hex_fn     = ldb_handler_copy
+       },{
+               .name             = "RMD_ORIGINATING_USN",
+               .read_fn          = ldb_handler_copy,
+               .write_clear_fn   = ldb_handler_copy,
+               .write_hex_fn     = ldb_handler_copy
+       },{
+               .name             = "RMD_VERSION",
+               .read_fn          = ldb_handler_copy,
+               .write_clear_fn   = ldb_handler_copy,
+               .write_hex_fn     = ldb_handler_copy
        }
 };
 
@@ -851,10 +1065,12 @@ static const struct {
 } samba_attributes[] = {
        { "objectSid",                  LDB_SYNTAX_SAMBA_SID },
        { "securityIdentifier",         LDB_SYNTAX_SAMBA_SID },
+       { "tokenGroups",                LDB_SYNTAX_SAMBA_SID },
        { "ntSecurityDescriptor",       LDB_SYNTAX_SAMBA_SECURITY_DESCRIPTOR },
        { "objectGUID",                 LDB_SYNTAX_SAMBA_GUID },
        { "invocationId",               LDB_SYNTAX_SAMBA_GUID },
        { "schemaIDGUID",               LDB_SYNTAX_SAMBA_GUID },
+       { "oMSyntax",                   LDB_SYNTAX_SAMBA_INT32 },
        { "attributeSecurityGUID",      LDB_SYNTAX_SAMBA_GUID },
        { "parentGUID",                 LDB_SYNTAX_SAMBA_GUID },
        { "siteGUID",                   LDB_SYNTAX_SAMBA_GUID },
@@ -862,17 +1078,22 @@ static const struct {
        { "fRSVersionGUID",             LDB_SYNTAX_SAMBA_GUID },
        { "fRSReplicaSetGUID",          LDB_SYNTAX_SAMBA_GUID },
        { "netbootGUID",                LDB_SYNTAX_SAMBA_GUID },
+       { "msDS-OptionalFeatureGUID",   LDB_SYNTAX_SAMBA_GUID },
        { "objectCategory",             LDB_SYNTAX_SAMBA_OBJECT_CATEGORY },
+       { "schemaInfo",                 LDB_SYNTAX_SAMBA_SCHEMAINFO },
        { "prefixMap",                  LDB_SYNTAX_SAMBA_PREFIX_MAP },
        { "repsFrom",                   LDB_SYNTAX_SAMBA_REPSFROMTO },
        { "repsTo",                     LDB_SYNTAX_SAMBA_REPSFROMTO },
        { "replPropertyMetaData",       LDB_SYNTAX_SAMBA_REPLPROPERTYMETADATA },
        { "replUpToDateVector",         LDB_SYNTAX_SAMBA_REPLUPTODATEVECTOR },
+       { "rIDAllocationPool",          LDB_SYNTAX_SAMBA_RANGE64 },
+       { "rIDPreviousAllocationPool",  LDB_SYNTAX_SAMBA_RANGE64 },
+       { "rIDAvailablePool",           LDB_SYNTAX_SAMBA_RANGE64 },
 };
 
 const struct ldb_schema_syntax *ldb_samba_syntax_by_name(struct ldb_context *ldb, const char *name)
 {
-       uint32_t j;
+       unsigned int j;
        const struct ldb_schema_syntax *s = NULL;
        
        for (j=0; j < ARRAY_SIZE(samba_syntaxes); j++) {
@@ -886,7 +1107,7 @@ const struct ldb_schema_syntax *ldb_samba_syntax_by_name(struct ldb_context *ldb
 
 const struct ldb_schema_syntax *ldb_samba_syntax_by_lDAPDisplayName(struct ldb_context *ldb, const char *name)
 {
-       uint32_t j;
+       unsigned int j;
        const struct ldb_schema_syntax *s = NULL;
 
        for (j=0; j < ARRAY_SIZE(samba_attributes); j++) {
@@ -904,7 +1125,7 @@ const struct ldb_schema_syntax *ldb_samba_syntax_by_lDAPDisplayName(struct ldb_c
 */
 int ldb_register_samba_handlers(struct ldb_context *ldb)
 {
-       uint32_t i;
+       unsigned int i;
 
        for (i=0; i < ARRAY_SIZE(samba_attributes); i++) {
                int ret;