Finish removal of iconv_convenience in public API's.
[bbaumbach/samba-autobuild/.git] / source4 / lib / ldb-samba / ldif_handlers.c
index 04fcd66b6eb79dd7b2b67830b8224ddf3b65da46..5e21199488de7d65a92fc3ebc344af52bca1dd60 100644 (file)
@@ -2,7 +2,8 @@
    ldb database library - ldif handlers for Samba
 
    Copyright (C) Andrew Tridgell 2005
-   Copyright (C) Andrew Bartlett 2006-2007
+   Copyright (C) Andrew Bartlett 2006-2009
+   Copyright (C) Matthias Dieter Wallnöfer 2009
      ** NOTE! The following LGPL license applies to the ldb
      ** library. This does NOT imply that all of Samba is released
      ** under the LGPL
 */
 
 #include "includes.h"
-#include "lib/ldb/include/ldb_includes.h"
+#include "lib/ldb/include/ldb.h"
+#include "lib/ldb/include/ldb_module.h"
+#include "ldb_handlers.h"
 #include "dsdb/samdb/samdb.h"
 #include "librpc/gen_ndr/ndr_security.h"
 #include "librpc/gen_ndr/ndr_misc.h"
 #include "librpc/gen_ndr/ndr_drsblobs.h"
+#include "librpc/ndr/libndr.h"
 #include "libcli/security/security.h"
 #include "param/param.h"
+#include "../lib/util/asn1.h"
+
+/*
+  use ndr_print_* to convert a NDR formatted blob to a ldif formatted blob
+
+  If mask_errors is true, then function succeeds but out data
+  is set to "<Unable to decode binary data>" message
+
+  \return 0 on success; -1 on error
+*/
+static int ldif_write_NDR(struct ldb_context *ldb, void *mem_ctx,
+                         const struct ldb_val *in, struct ldb_val *out,
+                         size_t struct_size,
+                         ndr_pull_flags_fn_t pull_fn,
+                         ndr_print_fn_t print_fn,
+                         bool mask_errors)
+{
+       uint8_t *p;
+       enum ndr_err_code err;
+       if (!(ldb_get_flags(ldb) & LDB_FLG_SHOW_BINARY)) {
+               return ldb_handler_copy(ldb, mem_ctx, in, out);
+       }
+       p = talloc_size(mem_ctx, struct_size);
+       err = ndr_pull_struct_blob(in, mem_ctx, 
+                                  p, pull_fn);
+       if (err != NDR_ERR_SUCCESS) {
+               /* fail in not in mask_error mode */
+               if (!mask_errors) {
+                       return -1;
+               }
+               talloc_free(p);
+               out->data = (uint8_t *)talloc_strdup(mem_ctx, "<Unable to decode binary data>");
+               out->length = strlen((const char *)out->data);
+               return 0;
+       }
+       out->data = (uint8_t *)ndr_print_struct_string(mem_ctx, print_fn, "NDR", p);
+       talloc_free(p);
+       if (out->data == NULL) {
+               return ldb_handler_copy(ldb, mem_ctx, in, out);         
+       }
+       out->length = strlen((char *)out->data);
+       return 0;
+}
 
 /*
   convert a ldif formatted objectSid to a NDR formatted blob
@@ -42,7 +89,7 @@ static int ldif_read_objectSid(struct ldb_context *ldb, void *mem_ctx,
        if (sid == NULL) {
                return -1;
        }
-       ndr_err = ndr_push_struct_blob(out, mem_ctx, NULL, sid,
+       ndr_err = ndr_push_struct_blob(out, mem_ctx, sid,
                                       (ndr_push_flags_fn_t)ndr_push_dom_sid);
        talloc_free(sid);
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
@@ -54,7 +101,7 @@ static int ldif_read_objectSid(struct ldb_context *ldb, void *mem_ctx,
 /*
   convert a NDR formatted blob to a ldif formatted objectSid
 */
-static int ldif_write_objectSid(struct ldb_context *ldb, void *mem_ctx,
+int ldif_write_objectSid(struct ldb_context *ldb, void *mem_ctx,
                                const struct ldb_val *in, struct ldb_val *out)
 {
        struct dom_sid *sid;
@@ -64,8 +111,8 @@ static int ldif_write_objectSid(struct ldb_context *ldb, void *mem_ctx,
        if (sid == NULL) {
                return -1;
        }
-       ndr_err = ndr_pull_struct_blob(in, sid, NULL, sid,
-                                      (ndr_pull_flags_fn_t)ndr_pull_dom_sid);
+       ndr_err = ndr_pull_struct_blob_all(in, sid, sid,
+                                          (ndr_pull_flags_fn_t)ndr_pull_dom_sid);
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                talloc_free(sid);
                return -1;
@@ -78,7 +125,7 @@ static int ldif_write_objectSid(struct ldb_context *ldb, void *mem_ctx,
        return 0;
 }
 
-static bool ldb_comparision_objectSid_isString(const struct ldb_val *v)
+bool ldif_comparision_objectSid_isString(const struct ldb_val *v)
 {
        if (v->length < 3) {
                return false;
@@ -92,13 +139,13 @@ static bool ldb_comparision_objectSid_isString(const struct ldb_val *v)
 /*
   compare two objectSids
 */
-static int ldb_comparison_objectSid(struct ldb_context *ldb, void *mem_ctx,
+static int ldif_comparison_objectSid(struct ldb_context *ldb, void *mem_ctx,
                                    const struct ldb_val *v1, const struct ldb_val *v2)
 {
-       if (ldb_comparision_objectSid_isString(v1) && ldb_comparision_objectSid_isString(v2)) {
+       if (ldif_comparision_objectSid_isString(v1) && ldif_comparision_objectSid_isString(v2)) {
                return ldb_comparison_binary(ldb, mem_ctx, v1, v2);
-       } else if (ldb_comparision_objectSid_isString(v1)
-                  && !ldb_comparision_objectSid_isString(v2)) {
+       } else if (ldif_comparision_objectSid_isString(v1)
+                  && !ldif_comparision_objectSid_isString(v2)) {
                struct ldb_val v;
                int ret;
                if (ldif_read_objectSid(ldb, mem_ctx, v1, &v) != 0) {
@@ -108,8 +155,8 @@ static int ldb_comparison_objectSid(struct ldb_context *ldb, void *mem_ctx,
                ret = ldb_comparison_binary(ldb, mem_ctx, &v, v2);
                talloc_free(v.data);
                return ret;
-       } else if (!ldb_comparision_objectSid_isString(v1)
-                  && ldb_comparision_objectSid_isString(v2)) {
+       } else if (!ldif_comparision_objectSid_isString(v1)
+                  && ldif_comparision_objectSid_isString(v2)) {
                struct ldb_val v;
                int ret;
                if (ldif_read_objectSid(ldb, mem_ctx, v2, &v) != 0) {
@@ -126,18 +173,49 @@ static int ldb_comparison_objectSid(struct ldb_context *ldb, void *mem_ctx,
 /*
   canonicalise a objectSid
 */
-static int ldb_canonicalise_objectSid(struct ldb_context *ldb, void *mem_ctx,
+static int ldif_canonicalise_objectSid(struct ldb_context *ldb, void *mem_ctx,
                                      const struct ldb_val *in, struct ldb_val *out)
 {
-       if (ldb_comparision_objectSid_isString(in)) {
+       if (ldif_comparision_objectSid_isString(in)) {
                if (ldif_read_objectSid(ldb, mem_ctx, in, out) != 0) {
                        /* Perhaps not a string after all */
                        return ldb_handler_copy(ldb, mem_ctx, in, out);
                }
+               return 0;
        }
        return ldb_handler_copy(ldb, mem_ctx, in, out);
 }
 
+static int extended_dn_read_SID(struct ldb_context *ldb, void *mem_ctx,
+                             const struct ldb_val *in, struct ldb_val *out)
+{
+       struct dom_sid sid;
+       enum ndr_err_code ndr_err;
+       if (ldif_comparision_objectSid_isString(in)) {
+               if (ldif_read_objectSid(ldb, mem_ctx, in, out) == 0) {
+                       return 0;
+               }
+       }
+       
+       /* Perhaps not a string after all */
+       *out = data_blob_talloc(mem_ctx, NULL, in->length/2+1);
+
+       if (!out->data) {
+               return -1;
+       }
+
+       (*out).length = strhex_to_str((char *)out->data, out->length,
+                                    (const char *)in->data, in->length);
+
+       /* Check it looks like a SID */
+       ndr_err = ndr_pull_struct_blob_all(out, mem_ctx, &sid,
+                                          (ndr_pull_flags_fn_t)ndr_pull_dom_sid);
+       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+               return -1;
+       }
+       return 0;
+}
+
 /*
   convert a ldif formatted objectGUID to a NDR formatted blob
 */
@@ -145,23 +223,15 @@ static int ldif_read_objectGUID(struct ldb_context *ldb, void *mem_ctx,
                                const struct ldb_val *in, struct ldb_val *out)
 {
        struct GUID guid;
-       char *guid_string;
        NTSTATUS status;
-       enum ndr_err_code ndr_err;
-       guid_string = talloc_strndup(mem_ctx, in->data, in->length);
-       if (!guid_string) {
-               return -1;
-       }
 
-       status = GUID_from_string(guid_string, &guid);
-       talloc_free(guid_string);
+       status = GUID_from_data_blob(in, &guid);
        if (!NT_STATUS_IS_OK(status)) {
                return -1;
        }
 
-       ndr_err = ndr_push_struct_blob(out, mem_ctx, NULL, &guid,
-                                      (ndr_push_flags_fn_t)ndr_push_GUID);
-       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+       status = GUID_to_ndr_blob(&guid, mem_ctx, out);
+       if (!NT_STATUS_IS_OK(status)) {
                return -1;
        }
        return 0;
@@ -174,10 +244,10 @@ static int ldif_write_objectGUID(struct ldb_context *ldb, void *mem_ctx,
                                 const struct ldb_val *in, struct ldb_val *out)
 {
        struct GUID guid;
-       enum ndr_err_code ndr_err;
-       ndr_err = ndr_pull_struct_blob(in, mem_ctx, NULL, &guid,
-                                      (ndr_pull_flags_fn_t)ndr_pull_GUID);
-       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+       NTSTATUS status;
+
+       status = GUID_from_ndr_blob(in, &guid);
+       if (!NT_STATUS_IS_OK(status)) {
                return -1;
        }
        out->data = (uint8_t *)GUID_string(mem_ctx, &guid);
@@ -188,34 +258,57 @@ static int ldif_write_objectGUID(struct ldb_context *ldb, void *mem_ctx,
        return 0;
 }
 
-static bool ldb_comparision_objectGUID_isString(const struct ldb_val *v)
+static bool ldif_comparision_objectGUID_isString(const struct ldb_val *v)
+{
+       if (v->length != 36 && v->length != 38) return false;
+
+       /* Might be a GUID string, can't be a binary GUID (fixed 16 bytes) */
+       return true;
+}
+
+static int extended_dn_read_GUID(struct ldb_context *ldb, void *mem_ctx,
+                             const struct ldb_val *in, struct ldb_val *out)
 {
        struct GUID guid;
        NTSTATUS status;
 
-       if (v->length < 33) return false;
-
-       /* see if the input if null-terninated (safety check for the below) */
-       if (v->data[v->length] != '\0') return false;
+       if (in->length == 36 && ldif_read_objectGUID(ldb, mem_ctx, in, out) == 0) {
+               return 0;
+       }
 
-       status = GUID_from_string((const char *)v->data, &guid);
+       /* Try as 'hex' form */
+       if (in->length != 32) {
+               return -1;
+       }
+               
+       *out = data_blob_talloc(mem_ctx, NULL, in->length/2+1);
+       
+       if (!out->data) {
+               return -1;
+       }
+       
+       (*out).length = strhex_to_str((char *)out->data, out->length,
+                                     (const char *)in->data, in->length);
+       
+       /* Check it looks like a GUID */
+       status = GUID_from_ndr_blob(out, &guid);
        if (!NT_STATUS_IS_OK(status)) {
-               return false;
+               data_blob_free(out);
+               return -1;
        }
-
-       return true;
+       return 0;
 }
 
 /*
   compare two objectGUIDs
 */
-static int ldb_comparison_objectGUID(struct ldb_context *ldb, void *mem_ctx,
+static int ldif_comparison_objectGUID(struct ldb_context *ldb, void *mem_ctx,
                                     const struct ldb_val *v1, const struct ldb_val *v2)
 {
-       if (ldb_comparision_objectGUID_isString(v1) && ldb_comparision_objectGUID_isString(v2)) {
+       if (ldif_comparision_objectGUID_isString(v1) && ldif_comparision_objectGUID_isString(v2)) {
                return ldb_comparison_binary(ldb, mem_ctx, v1, v2);
-       } else if (ldb_comparision_objectGUID_isString(v1)
-                  && !ldb_comparision_objectGUID_isString(v2)) {
+       } else if (ldif_comparision_objectGUID_isString(v1)
+                  && !ldif_comparision_objectGUID_isString(v2)) {
                struct ldb_val v;
                int ret;
                if (ldif_read_objectGUID(ldb, mem_ctx, v1, &v) != 0) {
@@ -225,8 +318,8 @@ static int ldb_comparison_objectGUID(struct ldb_context *ldb, void *mem_ctx,
                ret = ldb_comparison_binary(ldb, mem_ctx, &v, v2);
                talloc_free(v.data);
                return ret;
-       } else if (!ldb_comparision_objectGUID_isString(v1)
-                  && ldb_comparision_objectGUID_isString(v2)) {
+       } else if (!ldif_comparision_objectGUID_isString(v1)
+                  && ldif_comparision_objectGUID_isString(v2)) {
                struct ldb_val v;
                int ret;
                if (ldif_read_objectGUID(ldb, mem_ctx, v2, &v) != 0) {
@@ -243,14 +336,15 @@ static int ldb_comparison_objectGUID(struct ldb_context *ldb, void *mem_ctx,
 /*
   canonicalise a objectGUID
 */
-static int ldb_canonicalise_objectGUID(struct ldb_context *ldb, void *mem_ctx,
+static int ldif_canonicalise_objectGUID(struct ldb_context *ldb, void *mem_ctx,
                                       const struct ldb_val *in, struct ldb_val *out)
 {
-       if (ldb_comparision_objectGUID_isString(in)) {
+       if (ldif_comparision_objectGUID_isString(in)) {
                if (ldif_read_objectGUID(ldb, mem_ctx, in, out) != 0) {
                        /* Perhaps it wasn't a valid string after all */
                        return ldb_handler_copy(ldb, mem_ctx, in, out);
                }
+               return 0;
        }
        return ldb_handler_copy(ldb, mem_ctx, in, out);
 }
@@ -265,16 +359,31 @@ static int ldif_read_ntSecurityDescriptor(struct ldb_context *ldb, void *mem_ctx
        struct security_descriptor *sd;
        enum ndr_err_code ndr_err;
 
-       sd = sddl_decode(mem_ctx, (const char *)in->data, NULL);
+       sd = talloc(mem_ctx, struct security_descriptor);
        if (sd == NULL) {
                return -1;
        }
-       ndr_err = ndr_push_struct_blob(out, mem_ctx, NULL, sd,
+
+       ndr_err = ndr_pull_struct_blob(in, sd, sd,
+                                      (ndr_pull_flags_fn_t)ndr_pull_security_descriptor);
+       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+               /* If this does not parse, then it is probably SDDL, and we should try it that way */
+               
+               const struct dom_sid *sid = samdb_domain_sid(ldb);
+               talloc_free(sd);
+               sd = sddl_decode(mem_ctx, (const char *)in->data, sid);
+               if (sd == NULL) {
+                       return -1;
+               }
+       }
+
+       ndr_err = ndr_push_struct_blob(out, mem_ctx, sd,
                                       (ndr_push_flags_fn_t)ndr_push_security_descriptor);
        talloc_free(sd);
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                return -1;
        }
+
        return 0;
 }
 
@@ -287,17 +396,27 @@ static int ldif_write_ntSecurityDescriptor(struct ldb_context *ldb, void *mem_ct
        struct security_descriptor *sd;
        enum ndr_err_code ndr_err;
 
+       if (ldb_get_flags(ldb) & LDB_FLG_SHOW_BINARY) {
+               return ldif_write_NDR(ldb, mem_ctx, in, out, 
+                                     sizeof(struct security_descriptor),
+                                     (ndr_pull_flags_fn_t)ndr_pull_security_descriptor,
+                                     (ndr_print_fn_t)ndr_print_security_descriptor,
+                                     true);
+                                     
+       }
+
        sd = talloc(mem_ctx, struct security_descriptor);
        if (sd == NULL) {
                return -1;
        }
-       ndr_err = ndr_pull_struct_blob(in, sd, NULL, sd,
-                                      (ndr_pull_flags_fn_t)ndr_pull_security_descriptor);
+       /* We can't use ndr_pull_struct_blob_all because this contains relative pointers */
+       ndr_err = ndr_pull_struct_blob(in, sd, sd,
+                                          (ndr_pull_flags_fn_t)ndr_pull_security_descriptor);
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                talloc_free(sd);
                return -1;
        }
-       out->data = (uint8_t *)sddl_encode(mem_ctx, sd, NULL);
+       out->data = (uint8_t *)sddl_encode(mem_ctx, sd, samdb_domain_sid_cache_only(ldb));
        talloc_free(sd);
        if (out->data == NULL) {
                return -1;
@@ -315,14 +434,15 @@ static int ldif_canonicalise_objectCategory(struct ldb_context *ldb, void *mem_c
                                            const struct ldb_val *in, struct ldb_val *out)
 {
        struct ldb_dn *dn1 = NULL;
-       const struct dsdb_schema *schema = dsdb_get_schema(ldb);
-       const struct dsdb_class *class;
+       const struct dsdb_schema *schema = dsdb_get_schema(ldb, NULL);
+       const struct dsdb_class *sclass;
        TALLOC_CTX *tmp_ctx = talloc_new(mem_ctx);
        if (!tmp_ctx) {
                return LDB_ERR_OPERATIONS_ERROR;
        }
 
        if (!schema) {
+               talloc_free(tmp_ctx);
                *out = data_blob_talloc(mem_ctx, in->data, in->length);
                if (in->data && !out->data) {
                        return LDB_ERR_OPERATIONS_ERROR;
@@ -332,10 +452,10 @@ static int ldif_canonicalise_objectCategory(struct ldb_context *ldb, void *mem_c
        dn1 = ldb_dn_from_ldb_val(tmp_ctx, ldb, in);
        if ( ! ldb_dn_validate(dn1)) {
                const char *lDAPDisplayName = talloc_strndup(tmp_ctx, (char *)in->data, in->length);
-               class = dsdb_class_by_lDAPDisplayName(schema, lDAPDisplayName);
-               if (class) {
+               sclass = dsdb_class_by_lDAPDisplayName(schema, lDAPDisplayName);
+               if (sclass) {
                        struct ldb_dn *dn = ldb_dn_new(mem_ctx, ldb,  
-                                                      class->defaultObjectCategory);
+                                                      sclass->defaultObjectCategory);
                        *out = data_blob_string_const(ldb_dn_alloc_casefold(mem_ctx, dn));
                        talloc_free(tmp_ctx);
 
@@ -366,26 +486,21 @@ static int ldif_comparison_objectCategory(struct ldb_context *ldb, void *mem_ctx
                                          const struct ldb_val *v1,
                                          const struct ldb_val *v2)
 {
+       return ldb_any_comparison(ldb, mem_ctx, ldif_canonicalise_objectCategory,
+                                 v1, v2);
+}
 
-       int ret, ret1, ret2;
-       struct ldb_val v1_canon, v2_canon;
-       TALLOC_CTX *tmp_ctx = talloc_new(mem_ctx);
-
-       /* I could try and bail if tmp_ctx was NULL, but what return
-        * value would I use?
-        *
-        * It seems easier to continue on the NULL context 
-        */
-       ret1 = ldif_canonicalise_objectCategory(ldb, tmp_ctx, v1, &v1_canon);
-       ret2 = ldif_canonicalise_objectCategory(ldb, tmp_ctx, v2, &v2_canon);
-
-       if (ret1 == LDB_SUCCESS && ret2 == LDB_SUCCESS) {
-               ret = data_blob_cmp(&v1_canon, &v2_canon);
-       } else {
-               ret = data_blob_cmp(v1, v2);
-       }
-       talloc_free(tmp_ctx);
-       return ret;
+/*
+  convert a NDR formatted blob to a ldif formatted schemaInfo
+*/
+static int ldif_write_schemaInfo(struct ldb_context *ldb, void *mem_ctx,
+                                const struct ldb_val *in, struct ldb_val *out)
+{
+       return ldif_write_NDR(ldb, mem_ctx, in, out,
+                             sizeof(struct repsFromToBlob),
+                             (ndr_pull_flags_fn_t)ndr_pull_schemaInfoBlob,
+                             (ndr_print_fn_t)ndr_print_schemaInfoBlob,
+                             true);
 }
 
 /*
@@ -397,6 +512,7 @@ static int ldif_read_prefixMap(struct ldb_context *ldb, void *mem_ctx,
        struct prefixMapBlob *blob;
        enum ndr_err_code ndr_err;
        char *string, *line, *p, *oid;
+       DATA_BLOB oid_blob;
 
        TALLOC_CTX *tmp_ctx = talloc_new(mem_ctx);
 
@@ -429,7 +545,7 @@ static int ldif_read_prefixMap(struct ldb_context *ldb, void *mem_ctx,
                                p[0] = '\0';
                        }
                }
-               /* allow a traling seperator */
+               /* allow a trailing separator */
                if (line == p) {
                        break;
                }
@@ -453,8 +569,12 @@ static int ldif_read_prefixMap(struct ldb_context *ldb, void *mem_ctx,
                /* we know there must be at least ":" */
                oid++;
 
-               blob->ctr.dsdb.mappings[blob->ctr.dsdb.num_mappings].oid.oid
-                       = talloc_strdup(blob->ctr.dsdb.mappings, oid);
+               if (!ber_write_partial_OID_String(blob->ctr.dsdb.mappings, &oid_blob, oid)) {
+                       talloc_free(tmp_ctx);
+                       return -1;
+               }
+               blob->ctr.dsdb.mappings[blob->ctr.dsdb.num_mappings].oid.length = oid_blob.length;
+               blob->ctr.dsdb.mappings[blob->ctr.dsdb.num_mappings].oid.binary_oid = oid_blob.data;
 
                blob->ctr.dsdb.num_mappings++;
 
@@ -467,7 +587,6 @@ static int ldif_read_prefixMap(struct ldb_context *ldb, void *mem_ctx,
        }
 
        ndr_err = ndr_push_struct_blob(out, mem_ctx, 
-                                      lp_iconv_convenience(ldb_get_opaque(ldb, "loadparm")), 
                                       blob,
                                       (ndr_push_flags_fn_t)ndr_push_prefixMapBlob);
        talloc_free(tmp_ctx);
@@ -488,41 +607,74 @@ static int ldif_write_prefixMap(struct ldb_context *ldb, void *mem_ctx,
        char *string;
        uint32_t i;
 
+       if (ldb_get_flags(ldb) & LDB_FLG_SHOW_BINARY) {
+               int err;
+               /* try to decode the blob as S4 prefixMap */
+               err = ldif_write_NDR(ldb, mem_ctx, in, out,
+                                    sizeof(struct prefixMapBlob),
+                                    (ndr_pull_flags_fn_t)ndr_pull_prefixMapBlob,
+                                    (ndr_print_fn_t)ndr_print_prefixMapBlob,
+                                    false);
+               if (0 == err) {
+                       return err;
+               }
+               /* try parsing it as Windows PrefixMap value */
+               return ldif_write_NDR(ldb, mem_ctx, in, out,
+                                     sizeof(struct drsuapi_MSPrefixMap_Ctr),
+                                     (ndr_pull_flags_fn_t)ndr_pull_drsuapi_MSPrefixMap_Ctr,
+                                     (ndr_print_fn_t)ndr_print_drsuapi_MSPrefixMap_Ctr,
+                                     true);
+       }
+
        blob = talloc(mem_ctx, struct prefixMapBlob);
        if (blob == NULL) {
                return -1;
        }
-       ndr_err = ndr_pull_struct_blob(in, blob, 
-                                      lp_iconv_convenience(ldb_get_opaque(ldb, "loadparm")), 
-                                      blob,
-                                      (ndr_pull_flags_fn_t)ndr_pull_prefixMapBlob);
+       ndr_err = ndr_pull_struct_blob_all(in, blob, 
+                                          blob,
+                                          (ndr_pull_flags_fn_t)ndr_pull_prefixMapBlob);
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
-               talloc_free(blob);
-               return -1;
+               goto failed;
        }
        if (blob->version != PREFIX_MAP_VERSION_DSDB) {
-               return -1;
+               goto failed;
        }
        string = talloc_strdup(mem_ctx, "");
        if (string == NULL) {
-               return -1;
+               goto failed;
        }
 
        for (i=0; i < blob->ctr.dsdb.num_mappings; i++) {
+               DATA_BLOB oid_blob;
+               const char *partial_oid = NULL;
+
                if (i > 0) {
                        string = talloc_asprintf_append(string, ";"); 
                }
+
+               oid_blob = data_blob_const(blob->ctr.dsdb.mappings[i].oid.binary_oid,
+                                          blob->ctr.dsdb.mappings[i].oid.length);
+               if (!ber_read_partial_OID_String(blob, oid_blob, &partial_oid)) {
+                       DEBUG(0, ("ber_read_partial_OID failed on prefixMap item with id: 0x%X",
+                                 blob->ctr.dsdb.mappings[i].id_prefix));
+                       goto failed;
+               }
                string = talloc_asprintf_append(string, "%u:%s", 
                                                   blob->ctr.dsdb.mappings[i].id_prefix,
-                                                  blob->ctr.dsdb.mappings[i].oid.oid);
+                                                  partial_oid);
+               talloc_free(discard_const(partial_oid));
                if (string == NULL) {
-                       return -1;
+                       goto failed;
                }
        }
 
        talloc_free(blob);
        *out = data_blob_string_const(string);
        return 0;
+
+failed:
+       talloc_free(blob);
+       return -1;
 }
 
 static bool ldif_comparision_prefixMap_isString(const struct ldb_val *v)
@@ -554,76 +706,371 @@ static int ldif_comparison_prefixMap(struct ldb_context *ldb, void *mem_ctx,
                                     const struct ldb_val *v1,
                                     const struct ldb_val *v2)
 {
+       return ldb_any_comparison(ldb, mem_ctx, ldif_canonicalise_prefixMap,
+                                 v1, v2);
+}
 
-       int ret, ret1, ret2;
-       struct ldb_val v1_canon, v2_canon;
-       TALLOC_CTX *tmp_ctx = talloc_new(mem_ctx);
+/* length limited conversion of a ldb_val to a int32_t */
+static int val_to_int32(const struct ldb_val *in, int32_t *v)
+{
+       char *end;
+       char buf[64];
+
+       /* make sure we don't read past the end of the data */
+       if (in->length > sizeof(buf)-1) {
+               return LDB_ERR_INVALID_ATTRIBUTE_SYNTAX;
+       }
+       strncpy(buf, (char *)in->data, in->length);
+       buf[in->length] = 0;
+
+       /* We've to use "strtoll" here to have the intended overflows.
+        * Otherwise we may get "LONG_MAX" and the conversion is wrong. */
+       *v = (int32_t) strtoll(buf, &end, 0);
+       if (*end != 0) {
+               return LDB_ERR_INVALID_ATTRIBUTE_SYNTAX;
+       }
+       return LDB_SUCCESS;
+}
 
-       /* I could try and bail if tmp_ctx was NULL, but what return
-        * value would I use?
-        *
-        * It seems easier to continue on the NULL context 
-        */
-       ret1 = ldif_canonicalise_prefixMap(ldb, tmp_ctx, v1, &v1_canon);
-       ret2 = ldif_canonicalise_prefixMap(ldb, tmp_ctx, v2, &v2_canon);
+/* length limited conversion of a ldb_val to a int64_t */
+static int val_to_int64(const struct ldb_val *in, int64_t *v)
+{
+       char *end;
+       char buf[64];
 
-       if (ret1 == LDB_SUCCESS && ret2 == LDB_SUCCESS) {
-               ret = data_blob_cmp(&v1_canon, &v2_canon);
-       } else {
-               ret = data_blob_cmp(v1, v2);
+       /* make sure we don't read past the end of the data */
+       if (in->length > sizeof(buf)-1) {
+               return LDB_ERR_INVALID_ATTRIBUTE_SYNTAX;
        }
-       talloc_free(tmp_ctx);
-       return ret;
+       strncpy(buf, (char *)in->data, in->length);
+       buf[in->length] = 0;
+
+       *v = (int64_t) strtoll(buf, &end, 0);
+       if (*end != 0) {
+               return LDB_ERR_INVALID_ATTRIBUTE_SYNTAX;
+       }
+       return LDB_SUCCESS;
+}
+
+/* Canonicalisation of two 32-bit integers */
+static int ldif_canonicalise_int32(struct ldb_context *ldb, void *mem_ctx,
+                       const struct ldb_val *in, struct ldb_val *out)
+{
+       int32_t i;
+       int ret;
+
+       ret = val_to_int32(in, &i);
+       if (ret != LDB_SUCCESS) {
+               return ret;
+       }
+       out->data = (uint8_t *) talloc_asprintf(mem_ctx, "%d", i);
+       if (out->data == NULL) {
+               ldb_oom(ldb);
+               return LDB_ERR_OPERATIONS_ERROR;
+       }
+       out->length = strlen((char *)out->data);
+       return 0;
+}
+
+/* Comparison of two 32-bit integers */
+static int ldif_comparison_int32(struct ldb_context *ldb, void *mem_ctx,
+                                const struct ldb_val *v1, const struct ldb_val *v2)
+{
+       int32_t i1=0, i2=0;
+       val_to_int32(v1, &i1);
+       val_to_int32(v2, &i2);
+       if (i1 == i2) return 0;
+       return i1 > i2? 1 : -1;
+}
+
+/* Canonicalisation of two 64-bit integers */
+static int ldif_canonicalise_int64(struct ldb_context *ldb, void *mem_ctx,
+                                  const struct ldb_val *in, struct ldb_val *out)
+{
+       int64_t i;
+       int ret;
+
+       ret = val_to_int64(in, &i);
+       if (ret != LDB_SUCCESS) {
+               return ret;
+       }
+       out->data = (uint8_t *) talloc_asprintf(mem_ctx, "%lld", (long long)i);
+       if (out->data == NULL) {
+               ldb_oom(ldb);
+               return LDB_ERR_OPERATIONS_ERROR;
+       }
+       out->length = strlen((char *)out->data);
+       return 0;
 }
 
-#define LDB_SYNTAX_SAMBA_GUID                  "LDB_SYNTAX_SAMBA_GUID"
-#define LDB_SYNTAX_SAMBA_OBJECT_CATEGORY       "LDB_SYNTAX_SAMBA_OBJECT_CATEGORY"
-#define LDB_SYNTAX_SAMBA_PREFIX_MAP    "LDB_SYNTAX_SAMBA_PREFIX_MAP"
+/* Comparison of two 64-bit integers */
+static int ldif_comparison_int64(struct ldb_context *ldb, void *mem_ctx,
+                                const struct ldb_val *v1, const struct ldb_val *v2)
+{
+       int64_t i1=0, i2=0;
+       val_to_int64(v1, &i1);
+       val_to_int64(v2, &i2);
+       if (i1 == i2) return 0;
+       return i1 > i2? 1 : -1;
+}
+
+/*
+  convert a NDR formatted blob to a ldif formatted repsFromTo
+*/
+static int ldif_write_repsFromTo(struct ldb_context *ldb, void *mem_ctx,
+                                const struct ldb_val *in, struct ldb_val *out)
+{
+       return ldif_write_NDR(ldb, mem_ctx, in, out, 
+                             sizeof(struct repsFromToBlob),
+                             (ndr_pull_flags_fn_t)ndr_pull_repsFromToBlob,
+                             (ndr_print_fn_t)ndr_print_repsFromToBlob,
+                             true);
+}
+
+/*
+  convert a NDR formatted blob to a ldif formatted replPropertyMetaData
+*/
+static int ldif_write_replPropertyMetaData(struct ldb_context *ldb, void *mem_ctx,
+                                          const struct ldb_val *in, struct ldb_val *out)
+{
+       return ldif_write_NDR(ldb, mem_ctx, in, out, 
+                             sizeof(struct replPropertyMetaDataBlob),
+                             (ndr_pull_flags_fn_t)ndr_pull_replPropertyMetaDataBlob,
+                             (ndr_print_fn_t)ndr_print_replPropertyMetaDataBlob,
+                             true);
+}
+
+/*
+  convert a NDR formatted blob to a ldif formatted replUpToDateVector
+*/
+static int ldif_write_replUpToDateVector(struct ldb_context *ldb, void *mem_ctx,
+                                        const struct ldb_val *in, struct ldb_val *out)
+{
+       return ldif_write_NDR(ldb, mem_ctx, in, out, 
+                             sizeof(struct replUpToDateVectorBlob),
+                             (ndr_pull_flags_fn_t)ndr_pull_replUpToDateVectorBlob,
+                             (ndr_print_fn_t)ndr_print_replUpToDateVectorBlob,
+                             true);
+}
+
+
+static int extended_dn_write_hex(struct ldb_context *ldb, void *mem_ctx,
+                                const struct ldb_val *in, struct ldb_val *out)
+{
+       *out = data_blob_string_const(data_blob_hex_string_lower(mem_ctx, in));
+       if (!out->data) {
+               return -1;
+       }
+       return 0;
+}
+
+
+/*
+  write a 64 bit 2-part range
+*/
+static int ldif_write_range64(struct ldb_context *ldb, void *mem_ctx,
+                             const struct ldb_val *in, struct ldb_val *out)
+{
+       int64_t v;
+       int ret;
+       ret = val_to_int64(in, &v);
+       if (ret != LDB_SUCCESS) {
+               return ret;
+       }
+       out->data = (uint8_t *)talloc_asprintf(mem_ctx, "%lu-%lu",
+                                              (unsigned long)(v&0xFFFFFFFF),
+                                              (unsigned long)(v>>32));
+       if (out->data == NULL) {
+               ldb_oom(ldb);
+               return LDB_ERR_OPERATIONS_ERROR;
+       }
+       out->length = strlen((char *)out->data);
+       return LDB_SUCCESS;
+}
+
+/*
+  read a 64 bit 2-part range
+*/
+static int ldif_read_range64(struct ldb_context *ldb, void *mem_ctx,
+                             const struct ldb_val *in, struct ldb_val *out)
+{
+       unsigned long high, low;
+       char buf[64];
+
+       if (memchr(in->data, '-', in->length) == NULL) {
+               return ldb_handler_copy(ldb, mem_ctx, in, out);
+       }
+
+       if (in->length > sizeof(buf)-1) {
+               return LDB_ERR_INVALID_ATTRIBUTE_SYNTAX;
+       }
+       strncpy(buf, (const char *)in->data, in->length);
+       buf[in->length] = 0;
+
+       if (sscanf(buf, "%lu-%lu", &low, &high) != 2) {
+               return LDB_ERR_INVALID_ATTRIBUTE_SYNTAX;
+       }
+
+       out->data = (uint8_t *)talloc_asprintf(mem_ctx, "%llu",
+                                              (unsigned long long)(((uint64_t)high)<<32) | (low));
+
+       if (out->data == NULL) {
+               ldb_oom(ldb);
+               return LDB_ERR_OPERATIONS_ERROR;
+       }
+       out->length = strlen((char *)out->data);
+       return LDB_SUCCESS;
+}
 
 static const struct ldb_schema_syntax samba_syntaxes[] = {
        {
-               .name           = LDB_SYNTAX_SAMBA_SID,
-               .ldif_read_fn   = ldif_read_objectSid,
-               .ldif_write_fn  = ldif_write_objectSid,
-               .canonicalise_fn= ldb_canonicalise_objectSid,
-               .comparison_fn  = ldb_comparison_objectSid
+               .name             = LDB_SYNTAX_SAMBA_SID,
+               .ldif_read_fn     = ldif_read_objectSid,
+               .ldif_write_fn    = ldif_write_objectSid,
+               .canonicalise_fn  = ldif_canonicalise_objectSid,
+               .comparison_fn    = ldif_comparison_objectSid
+       },{
+               .name             = LDB_SYNTAX_SAMBA_SECURITY_DESCRIPTOR,
+               .ldif_read_fn     = ldif_read_ntSecurityDescriptor,
+               .ldif_write_fn    = ldif_write_ntSecurityDescriptor,
+               .canonicalise_fn  = ldb_handler_copy,
+               .comparison_fn    = ldb_comparison_binary
+       },{
+               .name             = LDB_SYNTAX_SAMBA_GUID,
+               .ldif_read_fn     = ldif_read_objectGUID,
+               .ldif_write_fn    = ldif_write_objectGUID,
+               .canonicalise_fn  = ldif_canonicalise_objectGUID,
+               .comparison_fn    = ldif_comparison_objectGUID
+       },{
+               .name             = LDB_SYNTAX_SAMBA_OBJECT_CATEGORY,
+               .ldif_read_fn     = ldb_handler_copy,
+               .ldif_write_fn    = ldb_handler_copy,
+               .canonicalise_fn  = ldif_canonicalise_objectCategory,
+               .comparison_fn    = ldif_comparison_objectCategory
+       },{
+               .name             = LDB_SYNTAX_SAMBA_SCHEMAINFO,
+               .ldif_read_fn     = ldb_handler_copy,
+               .ldif_write_fn    = ldif_write_schemaInfo,
+               .canonicalise_fn  = ldb_handler_copy,
+               .comparison_fn    = ldb_comparison_binary
+       },{
+               .name             = LDB_SYNTAX_SAMBA_PREFIX_MAP,
+               .ldif_read_fn     = ldif_read_prefixMap,
+               .ldif_write_fn    = ldif_write_prefixMap,
+               .canonicalise_fn  = ldif_canonicalise_prefixMap,
+               .comparison_fn    = ldif_comparison_prefixMap
+       },{
+               .name             = LDB_SYNTAX_SAMBA_INT32,
+               .ldif_read_fn     = ldb_handler_copy,
+               .ldif_write_fn    = ldb_handler_copy,
+               .canonicalise_fn  = ldif_canonicalise_int32,
+               .comparison_fn    = ldif_comparison_int32
+       },{
+               .name             = LDB_SYNTAX_SAMBA_REPSFROMTO,
+               .ldif_read_fn     = ldb_handler_copy,
+               .ldif_write_fn    = ldif_write_repsFromTo,
+               .canonicalise_fn  = ldb_handler_copy,
+               .comparison_fn    = ldb_comparison_binary
+       },{
+               .name             = LDB_SYNTAX_SAMBA_REPLPROPERTYMETADATA,
+               .ldif_read_fn     = ldb_handler_copy,
+               .ldif_write_fn    = ldif_write_replPropertyMetaData,
+               .canonicalise_fn  = ldb_handler_copy,
+               .comparison_fn    = ldb_comparison_binary
+       },{
+               .name             = LDB_SYNTAX_SAMBA_REPLUPTODATEVECTOR,
+               .ldif_read_fn     = ldb_handler_copy,
+               .ldif_write_fn    = ldif_write_replUpToDateVector,
+               .canonicalise_fn  = ldb_handler_copy,
+               .comparison_fn    = ldb_comparison_binary
+       },{
+               .name             = DSDB_SYNTAX_BINARY_DN,
+               .ldif_read_fn     = ldb_handler_copy,
+               .ldif_write_fn    = ldb_handler_copy,
+               .canonicalise_fn  = dsdb_dn_binary_canonicalise,
+               .comparison_fn    = dsdb_dn_binary_comparison
+       },{
+               .name             = DSDB_SYNTAX_STRING_DN,
+               .ldif_read_fn     = ldb_handler_copy,
+               .ldif_write_fn    = ldb_handler_copy,
+               .canonicalise_fn  = dsdb_dn_string_canonicalise,
+               .comparison_fn    = dsdb_dn_string_comparison
+       },{
+               .name             = LDB_SYNTAX_SAMBA_RANGE64,
+               .ldif_read_fn     = ldif_read_range64,
+               .ldif_write_fn    = ldif_write_range64,
+               .canonicalise_fn  = ldif_canonicalise_int64,
+               .comparison_fn    = ldif_comparison_int64
+       },
+};
+
+static const struct ldb_dn_extended_syntax samba_dn_syntax[] = {
+       {
+               .name             = "SID",
+               .read_fn          = extended_dn_read_SID,
+               .write_clear_fn   = ldif_write_objectSid,
+               .write_hex_fn     = extended_dn_write_hex
+       },{
+               .name             = "GUID",
+               .read_fn          = extended_dn_read_GUID,
+               .write_clear_fn   = ldif_write_objectGUID,
+               .write_hex_fn     = extended_dn_write_hex
+       },{
+               .name             = "WKGUID",
+               .read_fn          = ldb_handler_copy,
+               .write_clear_fn   = ldb_handler_copy,
+               .write_hex_fn     = ldb_handler_copy
        },{
-               .name           = LDB_SYNTAX_SAMBA_SECURITY_DESCRIPTOR,
-               .ldif_read_fn   = ldif_read_ntSecurityDescriptor,
-               .ldif_write_fn  = ldif_write_ntSecurityDescriptor,
-               .canonicalise_fn= ldb_handler_copy,
-               .comparison_fn  = ldb_comparison_binary
+               .name             = "RMD_INVOCID",
+               .read_fn          = extended_dn_read_GUID,
+               .write_clear_fn   = ldif_write_objectGUID,
+               .write_hex_fn     = extended_dn_write_hex
        },{
-               .name           = LDB_SYNTAX_SAMBA_GUID,
-               .ldif_read_fn   = ldif_read_objectGUID,
-               .ldif_write_fn  = ldif_write_objectGUID,
-               .canonicalise_fn= ldb_canonicalise_objectGUID,
-               .comparison_fn  = ldb_comparison_objectGUID
+               .name             = "RMD_FLAGS",
+               .read_fn          = ldb_handler_copy,
+               .write_clear_fn   = ldb_handler_copy,
+               .write_hex_fn     = ldb_handler_copy
        },{
-               .name           = LDB_SYNTAX_SAMBA_OBJECT_CATEGORY,
-               .ldif_read_fn   = ldb_handler_copy,
-               .ldif_write_fn  = ldb_handler_copy,
-               .canonicalise_fn= ldif_canonicalise_objectCategory,
-               .comparison_fn  = ldif_comparison_objectCategory
+               .name             = "RMD_ADDTIME",
+               .read_fn          = ldb_handler_copy,
+               .write_clear_fn   = ldb_handler_copy,
+               .write_hex_fn     = ldb_handler_copy
        },{
-               .name           = LDB_SYNTAX_SAMBA_PREFIX_MAP,
-               .ldif_read_fn   = ldif_read_prefixMap,
-               .ldif_write_fn  = ldif_write_prefixMap,
-               .canonicalise_fn= ldif_canonicalise_prefixMap,
-               .comparison_fn  = ldif_comparison_prefixMap
+               .name             = "RMD_CHANGETIME",
+               .read_fn          = ldb_handler_copy,
+               .write_clear_fn   = ldb_handler_copy,
+               .write_hex_fn     = ldb_handler_copy
+       },{
+               .name             = "RMD_LOCAL_USN",
+               .read_fn          = ldb_handler_copy,
+               .write_clear_fn   = ldb_handler_copy,
+               .write_hex_fn     = ldb_handler_copy
+       },{
+               .name             = "RMD_ORIGINATING_USN",
+               .read_fn          = ldb_handler_copy,
+               .write_clear_fn   = ldb_handler_copy,
+               .write_hex_fn     = ldb_handler_copy
+       },{
+               .name             = "RMD_VERSION",
+               .read_fn          = ldb_handler_copy,
+               .write_clear_fn   = ldb_handler_copy,
+               .write_hex_fn     = ldb_handler_copy
        }
 };
 
+/* TODO: Should be dynamic at some point */
 static const struct {
        const char *name;
        const char *syntax;
 } samba_attributes[] = {
        { "objectSid",                  LDB_SYNTAX_SAMBA_SID },
        { "securityIdentifier",         LDB_SYNTAX_SAMBA_SID },
+       { "tokenGroups",                LDB_SYNTAX_SAMBA_SID },
        { "ntSecurityDescriptor",       LDB_SYNTAX_SAMBA_SECURITY_DESCRIPTOR },
        { "objectGUID",                 LDB_SYNTAX_SAMBA_GUID },
        { "invocationId",               LDB_SYNTAX_SAMBA_GUID },
        { "schemaIDGUID",               LDB_SYNTAX_SAMBA_GUID },
+       { "oMSyntax",                   LDB_SYNTAX_SAMBA_INT32 },
        { "attributeSecurityGUID",      LDB_SYNTAX_SAMBA_GUID },
        { "parentGUID",                 LDB_SYNTAX_SAMBA_GUID },
        { "siteGUID",                   LDB_SYNTAX_SAMBA_GUID },
@@ -631,13 +1078,22 @@ static const struct {
        { "fRSVersionGUID",             LDB_SYNTAX_SAMBA_GUID },
        { "fRSReplicaSetGUID",          LDB_SYNTAX_SAMBA_GUID },
        { "netbootGUID",                LDB_SYNTAX_SAMBA_GUID },
+       { "msDS-OptionalFeatureGUID",   LDB_SYNTAX_SAMBA_GUID },
        { "objectCategory",             LDB_SYNTAX_SAMBA_OBJECT_CATEGORY },
-       { "prefixMap",                  LDB_SYNTAX_SAMBA_PREFIX_MAP }
+       { "schemaInfo",                 LDB_SYNTAX_SAMBA_SCHEMAINFO },
+       { "prefixMap",                  LDB_SYNTAX_SAMBA_PREFIX_MAP },
+       { "repsFrom",                   LDB_SYNTAX_SAMBA_REPSFROMTO },
+       { "repsTo",                     LDB_SYNTAX_SAMBA_REPSFROMTO },
+       { "replPropertyMetaData",       LDB_SYNTAX_SAMBA_REPLPROPERTYMETADATA },
+       { "replUpToDateVector",         LDB_SYNTAX_SAMBA_REPLUPTODATEVECTOR },
+       { "rIDAllocationPool",          LDB_SYNTAX_SAMBA_RANGE64 },
+       { "rIDPreviousAllocationPool",  LDB_SYNTAX_SAMBA_RANGE64 },
+       { "rIDAvailablePool",           LDB_SYNTAX_SAMBA_RANGE64 },
 };
 
 const struct ldb_schema_syntax *ldb_samba_syntax_by_name(struct ldb_context *ldb, const char *name)
 {
-       uint32_t j;
+       unsigned int j;
        const struct ldb_schema_syntax *s = NULL;
        
        for (j=0; j < ARRAY_SIZE(samba_syntaxes); j++) {
@@ -649,13 +1105,27 @@ const struct ldb_schema_syntax *ldb_samba_syntax_by_name(struct ldb_context *ldb
        return s;
 }
 
+const struct ldb_schema_syntax *ldb_samba_syntax_by_lDAPDisplayName(struct ldb_context *ldb, const char *name)
+{
+       unsigned int j;
+       const struct ldb_schema_syntax *s = NULL;
+
+       for (j=0; j < ARRAY_SIZE(samba_attributes); j++) {
+               if (strcmp(samba_attributes[j].name, name) == 0) {
+                       s = ldb_samba_syntax_by_name(ldb, samba_attributes[j].syntax);
+                       break;
+               }
+       }
+       
+       return s;
+}
 
 /*
   register the samba ldif handlers
 */
 int ldb_register_samba_handlers(struct ldb_context *ldb)
 {
-       uint32_t i;
+       unsigned int i;
 
        for (i=0; i < ARRAY_SIZE(samba_attributes); i++) {
                int ret;
@@ -677,5 +1147,15 @@ int ldb_register_samba_handlers(struct ldb_context *ldb)
                }
        }
 
+       for (i=0; i < ARRAY_SIZE(samba_dn_syntax); i++) {
+               int ret;
+               ret = ldb_dn_extended_add_syntax(ldb, LDB_ATTR_FLAG_FIXED, &samba_dn_syntax[i]);
+               if (ret != LDB_SUCCESS) {
+                       return ret;
+               }
+
+               
+       }
+
        return LDB_SUCCESS;
 }