Added a whole bunch more permission constants.
[bbaumbach/samba-autobuild/.git] / source3 / python / py_spoolss.c
index 4d64ab0a76064c7f6f38abd7a3fa9e2a8ee2033d..b3087deef79a6c32528db43ddc23886ed25c48d0 100644 (file)
    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 */
 
-#include "includes.h"
-#include "Python.h"
-
-#include "python/py_common.h"
-#include "python/py_conv.h"
 #include "python/py_spoolss.h"
-#include "python/py_spoolss_forms.h"
-#include "python/py_spoolss_ports.h"
 
 /* Exceptions this module can raise */
 
@@ -35,192 +28,9 @@ PyObject *spoolss_error, *spoolss_werror;
  * Routines to convert from python hashes to Samba structures
  */
 
-struct pyconv py_PRINTER_INFO_0[] = {
-       { "printer_name", PY_UNISTR, offsetof(PRINTER_INFO_0, printername) },
-       { "server_name", PY_UNISTR, offsetof(PRINTER_INFO_0, servername) },
-
-       { "cjobs", PY_UINT32, offsetof(PRINTER_INFO_0, cjobs) },
-       { "total_jobs", PY_UINT32, offsetof(PRINTER_INFO_0, total_jobs) },
-       { "total_bytes", PY_UINT32, offsetof(PRINTER_INFO_0, total_bytes) },
-
-       { "year", PY_UINT16, offsetof(PRINTER_INFO_0, year) },
-       { "month", PY_UINT16, offsetof(PRINTER_INFO_0, month) },
-       { "day_of_week", PY_UINT16, offsetof(PRINTER_INFO_0, dayofweek) },
-       { "day", PY_UINT16, offsetof(PRINTER_INFO_0, day) },
-       { "hour", PY_UINT16, offsetof(PRINTER_INFO_0, hour) },
-       { "minute", PY_UINT16, offsetof(PRINTER_INFO_0, minute) },
-       { "second", PY_UINT16, offsetof(PRINTER_INFO_0, second) },
-       { "milliseconds", PY_UINT16, offsetof(PRINTER_INFO_0, milliseconds) },
-
-       { "global_counter", PY_UINT32, offsetof(PRINTER_INFO_0, global_counter) },
-       { "total_pages", PY_UINT32, offsetof(PRINTER_INFO_0, total_pages) },
-
-       { "major_version", PY_UINT16, offsetof(PRINTER_INFO_0, major_version) },
-       { "build_version", PY_UINT16, offsetof(PRINTER_INFO_0, build_version) },
-
-       { "unknown7", PY_UINT32, offsetof(PRINTER_INFO_0, unknown7) },
-       { "unknown8", PY_UINT32, offsetof(PRINTER_INFO_0, unknown8) },
-       { "unknown9", PY_UINT32, offsetof(PRINTER_INFO_0, unknown9) },
-       { "session_counter", PY_UINT32, offsetof(PRINTER_INFO_0, session_counter)},
-       { "unknown11", PY_UINT32, offsetof(PRINTER_INFO_0, unknown11) },
-       { "printer_errors", PY_UINT32, offsetof(PRINTER_INFO_0, printer_errors) },
-       { "unknown13", PY_UINT32, offsetof(PRINTER_INFO_0, unknown13) },
-       { "unknown14", PY_UINT32, offsetof(PRINTER_INFO_0, unknown14) },
-       { "unknown15", PY_UINT32, offsetof(PRINTER_INFO_0, unknown15) },
-       { "unknown16", PY_UINT32, offsetof(PRINTER_INFO_0, unknown16) },
-       { "change_id", PY_UINT32, offsetof(PRINTER_INFO_0, change_id) },
-       { "unknown18", PY_UINT32, offsetof(PRINTER_INFO_0, unknown18) },
-       { "status", PY_UINT32, offsetof(PRINTER_INFO_0, status) },
-       { "unknown20", PY_UINT32, offsetof(PRINTER_INFO_0, unknown20) },
-       { "c_setprinter", PY_UINT32, offsetof(PRINTER_INFO_0, c_setprinter) },
-       { "unknown22", PY_UINT32, offsetof(PRINTER_INFO_0, unknown22) },
-       { "unknown23", PY_UINT32, offsetof(PRINTER_INFO_0, unknown23) },
-       { "unknown24", PY_UINT32, offsetof(PRINTER_INFO_0, unknown24) },
-       { "unknown25", PY_UINT32, offsetof(PRINTER_INFO_0, unknown25) },
-       { "unknown26", PY_UINT32, offsetof(PRINTER_INFO_0, unknown26) },
-       { "unknown27", PY_UINT32, offsetof(PRINTER_INFO_0, unknown27) },
-       { "unknown28", PY_UINT32, offsetof(PRINTER_INFO_0, unknown28) },
-       { "unknown29", PY_UINT32, offsetof(PRINTER_INFO_0, unknown29) },
-
-       { NULL }
-};     
-
-struct pyconv py_PRINTER_INFO_1[] = {
-       { "printer_name", PY_UNISTR, offsetof(PRINTER_INFO_1, name) },
-       { "description", PY_UNISTR, offsetof(PRINTER_INFO_1, description) },
-       { "comment", PY_UNISTR, offsetof(PRINTER_INFO_1, comment) },
-       { "flags", PY_UINT32, offsetof(PRINTER_INFO_1, flags) },
-       { NULL }
-};     
-
-struct pyconv py_PRINTER_INFO_2[] = {
-       { "server_name", PY_UNISTR, offsetof(PRINTER_INFO_2, servername) },
-       { "printer_name", PY_UNISTR, offsetof(PRINTER_INFO_2, printername) },
-       { "share_name", PY_UNISTR, offsetof(PRINTER_INFO_2, sharename) },
-       { "port_name", PY_UNISTR, offsetof(PRINTER_INFO_2, portname) },
-       { "driver_name", PY_UNISTR, offsetof(PRINTER_INFO_2, drivername) },
-       { "comment", PY_UNISTR, offsetof(PRINTER_INFO_2, comment) },
-       { "location", PY_UNISTR, offsetof(PRINTER_INFO_2, location) },
-       { "datatype", PY_UNISTR, offsetof(PRINTER_INFO_2, datatype) },
-       { "sepfile", PY_UNISTR, offsetof(PRINTER_INFO_2, sepfile) },
-       { "print_processor", PY_UNISTR, offsetof(PRINTER_INFO_2, printprocessor) },
-       { "parameters", PY_UNISTR, offsetof(PRINTER_INFO_2, parameters) },
-       { "attributes", PY_UINT32, offsetof(PRINTER_INFO_2, attributes) },
-       { "default_priority", PY_UINT32, offsetof(PRINTER_INFO_2, defaultpriority) },
-       { "priority", PY_UINT32, offsetof(PRINTER_INFO_2, priority) },
-       { "start_time", PY_UINT32, offsetof(PRINTER_INFO_2, starttime) },
-       { "until_time", PY_UINT32, offsetof(PRINTER_INFO_2, untiltime) },
-       { "status", PY_UINT32, offsetof(PRINTER_INFO_2, status) },
-       { "cjobs", PY_UINT32, offsetof(PRINTER_INFO_2, cjobs) },
-       { "average_ppm", PY_UINT32, offsetof(PRINTER_INFO_2, averageppm) },
-       { NULL }
-};     
-
-struct pyconv py_PRINTER_INFO_3[] = {
-       { "flags", PY_UINT32, offsetof(PRINTER_INFO_3, flags) },
-       { NULL }
-};     
-
-struct pyconv py_DEVICEMODE[] = {
-       { "device_name", PY_UNISTR, offsetof(DEVICEMODE, devicename) },
-       { "spec_version", PY_UINT16, offsetof(DEVICEMODE, specversion) },
-       { "driver_version", PY_UINT16, offsetof(DEVICEMODE, driverversion) },
-       { "size", PY_UINT16, offsetof(DEVICEMODE, size) },
-       { "fields", PY_UINT16, offsetof(DEVICEMODE, fields) },
-       { "orientation", PY_UINT16, offsetof(DEVICEMODE, orientation) },
-       { "paper_size", PY_UINT16, offsetof(DEVICEMODE, papersize) },
-       { "paper_width", PY_UINT16, offsetof(DEVICEMODE, paperwidth) },
-       { "paper_length", PY_UINT16, offsetof(DEVICEMODE, paperlength) },
-       { "scale", PY_UINT16, offsetof(DEVICEMODE, scale) },
-       { "copies", PY_UINT16, offsetof(DEVICEMODE, copies) },
-       { "default_source", PY_UINT16, offsetof(DEVICEMODE, defaultsource) },
-       { "print_quality", PY_UINT16, offsetof(DEVICEMODE, printquality) },
-       { "color", PY_UINT16, offsetof(DEVICEMODE, color) },
-       { "duplex", PY_UINT16, offsetof(DEVICEMODE, duplex) },
-       { "y_resolution", PY_UINT16, offsetof(DEVICEMODE, yresolution) },
-       { "tt_option", PY_UINT16, offsetof(DEVICEMODE, ttoption) },
-       { "collate", PY_UINT16, offsetof(DEVICEMODE, collate) },
-       { "form_name", PY_UNISTR, offsetof(DEVICEMODE, formname) },
-       { "log_pixels", PY_UINT16, offsetof(DEVICEMODE, logpixels) },
-       { "bits_per_pel", PY_UINT32, offsetof(DEVICEMODE, bitsperpel) },
-       { "pels_width", PY_UINT32, offsetof(DEVICEMODE, pelswidth) },
-       { "pels_height", PY_UINT32, offsetof(DEVICEMODE, pelsheight) },
-       { "display_flags", PY_UINT32, offsetof(DEVICEMODE, displayflags) },
-       { "display_frequency", PY_UINT32, offsetof(DEVICEMODE, displayfrequency) },
-       { "icm_method", PY_UINT32, offsetof(DEVICEMODE, icmmethod) },
-       { "icm_intent", PY_UINT32, offsetof(DEVICEMODE, icmintent) },
-       { "media_type", PY_UINT32, offsetof(DEVICEMODE, mediatype) },
-       { "dither_type", PY_UINT32, offsetof(DEVICEMODE, dithertype) },
-       { "reserved1", PY_UINT32, offsetof(DEVICEMODE, reserved1) },
-       { "reserved2", PY_UINT32, offsetof(DEVICEMODE, reserved2) },
-       { "panning_width", PY_UINT32, offsetof(DEVICEMODE, panningwidth) },
-       { "panning_height", PY_UINT32, offsetof(DEVICEMODE, panningheight) },
-       { NULL }
-};
-
-struct pyconv py_DRIVER_INFO_1[] = {
-       { "name", PY_UNISTR, offsetof(DRIVER_INFO_1, name) },
-       { NULL }
-};
-
-struct pyconv py_DRIVER_INFO_2[] = {
-       { "version", PY_UINT32, offsetof(DRIVER_INFO_2, version) },
-       { "name", PY_UNISTR, offsetof(DRIVER_INFO_2, name) },
-       { "architecture", PY_UNISTR, offsetof(DRIVER_INFO_2, architecture) },
-       { "driver_path", PY_UNISTR, offsetof(DRIVER_INFO_2, driverpath) },
-       { "data_file", PY_UNISTR, offsetof(DRIVER_INFO_2, datafile) },
-       { "config_file", PY_UNISTR, offsetof(DRIVER_INFO_2, configfile) },
-       { NULL }
-};
-
-struct pyconv py_DRIVER_INFO_3[] = {
-       { "version", PY_UINT32, offsetof(DRIVER_INFO_3, version) },
-       { "name", PY_UNISTR, offsetof(DRIVER_INFO_3, name) },
-       { "architecture", PY_UNISTR, offsetof(DRIVER_INFO_3, architecture) },
-       { "driver_path", PY_UNISTR, offsetof(DRIVER_INFO_3, driverpath) },
-       { "data_file", PY_UNISTR, offsetof(DRIVER_INFO_3, datafile) },
-       { "config_file", PY_UNISTR, offsetof(DRIVER_INFO_3, configfile) },
-       { "help_file", PY_UNISTR, offsetof(DRIVER_INFO_3, helpfile) },
-       /* dependentfiles */
-       { "monitor_name", PY_UNISTR, offsetof(DRIVER_INFO_3, monitorname) },
-       { "default_datatype", PY_UNISTR, offsetof(DRIVER_INFO_3, defaultdatatype) },
-       { NULL }
-};
-
-struct pyconv py_DRIVER_INFO_6[] = {
-       { "version", PY_UINT32, offsetof(DRIVER_INFO_6, version) },
-       { "name", PY_UNISTR, offsetof(DRIVER_INFO_6, name) },
-       { "architecture", PY_UNISTR, offsetof(DRIVER_INFO_6, architecture) },
-       { "driver_path", PY_UNISTR, offsetof(DRIVER_INFO_6, driverpath) },
-       { "data_file", PY_UNISTR, offsetof(DRIVER_INFO_6, datafile) },
-       { "config_file", PY_UNISTR, offsetof(DRIVER_INFO_6, configfile) },
-       { "help_file", PY_UNISTR, offsetof(DRIVER_INFO_6, helpfile) },
-       /* dependentfiles */
-       { "monitor_name", PY_UNISTR, offsetof(DRIVER_INFO_6, monitorname) },
-       { "default_datatype", PY_UNISTR, offsetof(DRIVER_INFO_6, defaultdatatype) },
-       /* driver_date */
-
-       { "padding", PY_UINT32, offsetof(DRIVER_INFO_6, padding) },
-       { "driver_version_low", PY_UINT32, offsetof(DRIVER_INFO_6, driver_version_low) },
-       { "driver_version_high", PY_UINT32, offsetof(DRIVER_INFO_6, driver_version_high) },
-       { "mfg_name", PY_UNISTR, offsetof(DRIVER_INFO_6, mfgname) },
-       { "oem_url", PY_UNISTR, offsetof(DRIVER_INFO_6, oem_url) },
-       { "hardware_id", PY_UNISTR, offsetof(DRIVER_INFO_6, hardware_id) },
-       { "provider", PY_UNISTR, offsetof(DRIVER_INFO_6, provider) },
-       
-       { NULL }
-};
-
-/* Return a cli_state struct opened on the SPOOLSS pipe.  If credentials
-   are passed use them. */
-
-typedef struct cli_state *(cli_pipe_fn)(
-       struct cli_state *cli, char *system_name,
-       struct ntuser_creds *creds);
-
-static struct cli_state *open_pipe_creds(char *system_name, PyObject *creds, 
-                                        cli_pipe_fn *connect_fn,
-                                        struct cli_state *cli)
+struct cli_state *open_pipe_creds(char *system_name, PyObject *creds, 
+                                 cli_pipe_fn *connect_fn,
+                                 struct cli_state *cli)
 {
        struct ntuser_creds nt_creds;
 
@@ -288,8 +98,8 @@ static struct cli_state *open_pipe_creds(char *system_name, PyObject *creds,
        return cli;
 }
 
-static PyObject *new_policy_hnd_object(struct cli_state *cli
-                                      TALLOC_CTX *mem_ctx, POLICY_HND *pol)
+PyObject *new_policy_hnd_object(struct cli_state *cli, TALLOC_CTX *mem_ctx
+                               POLICY_HND *pol)
 {
        spoolss_policy_hnd_object *o;
 
@@ -302,583 +112,80 @@ static PyObject *new_policy_hnd_object(struct cli_state *cli,
        return (PyObject*)o;
 }
      
-/* Open a printer */
-
-static PyObject *spoolss_openprinter(PyObject *self, PyObject *args,
-                                    PyObject *kw)
-{
-       char *full_name, *computer_name = NULL;
-       TALLOC_CTX *mem_ctx;
-       POLICY_HND hnd;
-       WERROR werror;
-       PyObject *result = NULL, *creds = NULL;
-       static char *kwlist[] = { "printername", "creds", "access", NULL };
-       uint32 desired_access = MAXIMUM_ALLOWED_ACCESS;
-       struct cli_state *cli;
-
-       if (!PyArg_ParseTupleAndKeywords(
-               args, kw, "s|O!i", kwlist, &full_name, &PyDict_Type, &creds,
-               &desired_access)) {
-
-               goto done;
-       }
-
-       /* FIXME: Return name format exception for names without a UNC
-          prefix */ 
-
-       computer_name = strdup(full_name + 2);
-
-       if (strchr(computer_name, '\\')) {
-               char *c = strchr(computer_name, '\\');
-               *c = 0;
-       }
-
-       if (!(cli = open_pipe_creds(computer_name, creds, 
-                                   cli_spoolss_initialise, NULL))) {
-               fprintf(stderr, "could not initialise cli state\n");
-               goto done;
-       }
-
-       if (!(mem_ctx = talloc_init())) {
-               fprintf(stderr, "unable to initialise talloc context\n");
-               goto done;
-       }
-
-       werror = cli_spoolss_open_printer_ex(
-               cli, mem_ctx, full_name, "", desired_access, computer_name, 
-               "", &hnd);
-
-       if (!W_ERROR_IS_OK(werror)) {
-               cli_shutdown(cli);
-               SAFE_FREE(cli);
-               PyErr_SetObject(spoolss_werror,
-                               PyInt_FromLong(W_ERROR_V(werror)));
-               goto done;
-       }
-
-       result = new_policy_hnd_object(cli, mem_ctx, &hnd);
-
- done:
-       SAFE_FREE(computer_name);
-
-       return result;
-}
-
-/* Close a printer */
-
-static PyObject *spoolss_closeprinter(PyObject *self, PyObject *args)
-{
-       PyObject *po;
-       spoolss_policy_hnd_object *hnd;
-       WERROR result;
-
-       /* Parse parameters */
-
-       if (!PyArg_ParseTuple(args, "O!", &spoolss_policy_hnd_type, &po))
-               return NULL;
-
-       hnd = (spoolss_policy_hnd_object *)po;
-
-       /* Call rpc function */
-
-       result = cli_spoolss_close_printer(hnd->cli, hnd->mem_ctx, &hnd->pol);
-
-       /* Cleanup samba stuf */
-
-       cli_shutdown(hnd->cli);
-       talloc_destroy(hnd->mem_ctx);
-
-       /* Return value */
-
-       Py_INCREF(Py_None);
-       return Py_None; 
-}
-
-/* Fetch printer driver */
-
-static PyObject *spoolss_getprinterdriver(PyObject *self, PyObject *args,
-                                         PyObject *kw)
-{
-       spoolss_policy_hnd_object *hnd = (spoolss_policy_hnd_object *)self;
-       WERROR werror;
-       PyObject *result;
-       PRINTER_DRIVER_CTR ctr;
-       int level = 1;
-       uint32 needed;
-       char *arch = "Windows NT x86";
-       static char *kwlist[] = {"level", "arch", NULL};
-
-       /* Parse parameters */
-
-       if (!PyArg_ParseTupleAndKeywords(args, kw, "|is", kwlist, 
-                                        &level, &arch))
-               return NULL;
-
-       /* Call rpc function */
-
-       werror = cli_spoolss_getprinterdriver(
-               hnd->cli, hnd->mem_ctx, 0, &needed, &hnd->pol, level,
-               arch, &ctr);
-
-       if (W_ERROR_V(werror) == ERRinsufficientbuffer)
-               werror = cli_spoolss_getprinterdriver(
-                       hnd->cli, hnd->mem_ctx, needed, NULL, &hnd->pol,
-                       level, arch, &ctr);
-
-       /* Return value */
-       
-       result = Py_None;
-
-       if (W_ERROR_IS_OK(werror)) {
-               switch (level) {
-               case 1:
-                       result = from_struct(&ctr.info1, py_DRIVER_INFO_1);
-                       break;
-               case 2: 
-                       result = from_struct(&ctr.info2, py_DRIVER_INFO_2);
-                       break;
-               case 6:
-                       result = from_struct(&ctr.info6, py_DRIVER_INFO_6);
-                       break;
-               default:
-                       result = Py_None;
-                       break;
-               }
-       }
-       
-       Py_INCREF(result);
-       return result;
-}
-
-/* Enumerate printer drivers */
-
-static PyObject *spoolss_enumprinterdrivers(PyObject *self, PyObject *args,
-                                           PyObject *kw)
-{
-       spoolss_policy_hnd_object *hnd = (spoolss_policy_hnd_object *)self;
-       WERROR werror;
-       PyObject *result;
-       PRINTER_DRIVER_CTR ctr;
-       int level = 1, i;
-       uint32 needed, num_drivers;
-       char *arch = "Windows NT x86";
-       static char *kwlist[] = {"level", "arch", NULL};
-
-       /* Parse parameters */
-
-       if (!PyArg_ParseTupleAndKeywords(args, kw, "|is", kwlist, 
-                                        &level, &arch))
-               return NULL;
-       
-       /* Call rpc function */
-       
-       werror = cli_spoolss_enumprinterdrivers(
-               hnd->cli, hnd->mem_ctx, 0, &needed, level, arch,
-               &num_drivers, &ctr);
-
-       if (W_ERROR_V(werror) == ERRinsufficientbuffer)
-               werror = cli_spoolss_enumprinterdrivers(
-                       hnd->cli, hnd->mem_ctx, needed, NULL, level, arch, 
-                       &num_drivers, &ctr);
-
-       /* Return value */
-       
-       result = Py_None;
-
-       if (!W_ERROR_IS_OK(werror))
-               goto done;
-
-       switch (level) {
-       case 1:
-               result = PyList_New(num_drivers);
-               
-               for (i = 0; i < num_drivers; i++) {
-                       PyObject *value;
-                       
-                       value = from_struct(&ctr.info1, py_DRIVER_INFO_1);
-                       PyList_SetItem(result, i, value);
-               }
-               
-               break;
-       case 2: 
-               result = PyList_New(num_drivers);
-
-               for(i = 0; i < num_drivers; i++) {
-                       PyObject *value;
-
-                       value = from_struct(&ctr.info2, py_DRIVER_INFO_2);
-                       PyList_SetItem(result, i, value);
-               }
-
-               break;
-       case 6: 
-               result = PyList_New(num_drivers);
-
-               for(i = 0; i < num_drivers; i++) {
-                       PyObject *value;
-
-                       value = from_struct(&ctr.info2, py_DRIVER_INFO_6);
-                       PyList_SetItem(result, i, value);
-               }
-
-               break;
-       default:
-               result = Py_None;
-               break;
-       }
-       
- done:
-       Py_INCREF(result);
-       return result;
-}
-
-/* Convert a security descriptor to a Python dict */
-
-static PyObject *PySID_FromSID(DOM_SID *sid)
-{
-       fstring sidstr;
-
-       if (!sid) {
-               Py_INCREF(Py_None);
-               return Py_None;
-       }
-
-       if (sid_to_string(sidstr, sid))
-               return PyString_FromString(sidstr);
-
-       Py_INCREF(Py_None);
-       return Py_None; 
-}
-
-static PyObject *PyACE_FromACE(SEC_ACE *ace)
-{
-       PyObject *obj;
-
-       if (!ace) {
-               Py_INCREF(Py_None);
-               return Py_None;
-       }
-
-       obj = PyDict_New();
-
-       PyDict_SetItemString(obj, "type", PyInt_FromLong(ace->type));
-       PyDict_SetItemString(obj, "flags", PyInt_FromLong(ace->flags));
-       PyDict_SetItemString(obj, "mask", PyInt_FromLong(ace->info.mask));
-
-       PyDict_SetItemString(obj, "trustee", PySID_FromSID(&ace->trustee));
-
-       return obj;
-}
-
-static PyObject *PyACL_FromACL(SEC_ACL *acl)
-{
-       PyObject *obj, *ace_list;
-       int i;
-
-       if (!acl) {
-               Py_INCREF(Py_None);
-               return Py_None;
-       }
-
-       obj = PyDict_New();
-
-       PyDict_SetItemString(obj, "revision", PyInt_FromLong(acl->revision));
-
-       ace_list = PyList_New(acl->num_aces);
-
-       for (i = 0; i < acl->num_aces; i++)
-               PyList_SetItem(ace_list, i, PyACE_FromACE(&acl->ace[i]));
-
-       PyDict_SetItemString(obj, "ace_list", ace_list);
-
-       return obj;
-}
-
-static PyObject *PySECDESC_FromSECDESC(SEC_DESC *sd)
-{
-       PyObject *obj = PyDict_New();
-
-       PyDict_SetItemString(obj, "revision", PyInt_FromLong(sd->revision));
-       PyDict_SetItemString(obj, "type", PyInt_FromLong(sd->type));
-
-       PyDict_SetItemString(obj, "owner_sid", PySID_FromSID(sd->owner_sid));
-       PyDict_SetItemString(obj, "group_sid", PySID_FromSID(sd->grp_sid));
-
-       PyDict_SetItemString(obj, "dacl", PyACL_FromACL(sd->dacl));
-       PyDict_SetItemString(obj, "sacl", PyACL_FromACL(sd->sacl));
-
-       return obj;
-}
-
-PyObject *PyDEVICEMODE_FromDEVICEMODE(DEVICEMODE *devmode)
-{
-       PyObject *obj;
-
-       obj = from_struct(devmode, py_DEVICEMODE);
-
-       PyDict_SetItemString(obj, "private",
-                            PyString_FromStringAndSize(devmode->private, 
-                                                       devmode->driverextra));
-
-       return obj;
-}
-
-/* Fetch printer information */
-
-static PyObject *spoolss_getprinter(PyObject *self, PyObject *args,
-                                   PyObject *kw)
-{
-       spoolss_policy_hnd_object *hnd = (spoolss_policy_hnd_object *)self;
-       WERROR werror;
-       PyObject *result;
-       PRINTER_INFO_CTR ctr;
-       int level = 1;
-       uint32 needed;
-       static char *kwlist[] = {"level", NULL};
-
-       /* Parse parameters */
-
-       if (!PyArg_ParseTupleAndKeywords(args, kw, "|i", kwlist, &level))
-               return NULL;
-       
-       /* Call rpc function */
-       
-       werror = cli_spoolss_getprinter(
-               hnd->cli, hnd->mem_ctx, 0, &needed, &hnd->pol, level, &ctr);
-
-       if (W_ERROR_V(werror) == ERRinsufficientbuffer)
-               werror = cli_spoolss_getprinter(
-                       hnd->cli, hnd->mem_ctx, needed, NULL, &hnd->pol,
-                       level, &ctr);
-
-       /* Return value */
-
-       result = Py_None;
-
-       if (!W_ERROR_IS_OK(werror))
-               goto done;
-
-       switch (level) {
-
-       case 0:
-               result = from_struct(ctr.printers_0, py_PRINTER_INFO_0);
-
-               break;
-
-       case 1:
-               result = from_struct(ctr.printers_1, py_PRINTER_INFO_1);
-
-               break;
-
-       case 2:
-               result = from_struct(ctr.printers_2, py_PRINTER_INFO_2);
-
-               PyDict_SetItemString(result, "security_descriptor", 
-                                    PySECDESC_FromSECDESC(
-                                            ctr.printers_2->secdesc));
-               
-               PyDict_SetItemString(result, "device_mode",
-                                    PyDEVICEMODE_FromDEVICEMODE(
-                                            ctr.printers_2->devmode));
-
-               break;
-
-       case 3:
-               result = from_struct(ctr.printers_3, py_PRINTER_INFO_3);
-
-               PyDict_SetItemString(result, "security_descriptor",
-                                    PySECDESC_FromSECDESC(
-                                            ctr.printers_3->secdesc));
-               break;
-
-       default:
-               result = Py_None;
-               break;
-       }
- done:
-       Py_INCREF(result);
-       return result;
-}
-
-/* Set printer information */
-
-static PyObject *spoolss_setprinter(PyObject *self, PyObject *args,
-                                   PyObject *kw)
-{
-       spoolss_policy_hnd_object *hnd = (spoolss_policy_hnd_object *)self;
-       WERROR werror;
-       PyObject *result, *info;
-       PRINTER_INFO_CTR ctr;
-       int level = 1;
-       static char *kwlist[] = {"dict", "level", NULL};
-       union {
-               PRINTER_INFO_0 printers_0;
-               PRINTER_INFO_1 printers_1;
-               PRINTER_INFO_2 printers_2;
-               PRINTER_INFO_3 printers_3;
-               PRINTER_INFO_4 printers_4;
-               PRINTER_INFO_5 printers_5;
-       } pinfo;
-
-       /* Parse parameters */
-
-       if (!PyArg_ParseTupleAndKeywords(args, kw, "O!|i", kwlist, 
-                                        &PyDict_Type, &info, &level))
-               return NULL;
-       
-       /* Fill in printer info */
-
-       ZERO_STRUCT(ctr);
-
-       switch (level) {
-       case 1:
-               ctr.printers_1 = &pinfo.printers_1;
-               to_struct(&pinfo.printers_1, info, py_PRINTER_INFO_1);
-               break;
-       default:
-       }
-
-       /* Call rpc function */
-       
-       werror = cli_spoolss_setprinter(hnd->cli, hnd->mem_ctx, &hnd->pol,
-                                       level, &ctr, 0);
-
-       /* Return value */
-
-       result = Py_None;
-
-       if (!W_ERROR_IS_OK(werror))
-               goto done;
-
- done:
-       Py_INCREF(result);
-       return result;
-}
+/* 
+ * Method dispatch table
+ */
 
-/* Enumerate printers */
+static PyMethodDef spoolss_methods[] = {
 
-static PyObject *spoolss_enumprinters(PyObject *self, PyObject *args,
-                                     PyObject *kw)
-{
-       WERROR werror;
-       PyObject *result, *creds = NULL;
-       PRINTER_INFO_CTR ctr;
-       int level = 1, flags = PRINTER_ENUM_LOCAL, i;
-       uint32 needed, num_printers;
-       static char *kwlist[] = {"server", "name", "level", "flags", 
-                                "creds", NULL};
-       TALLOC_CTX *mem_ctx = NULL;
-       struct cli_state *cli = NULL;
-       char *server, *name = NULL;
-
-       /* Parse parameters */
-
-       if (!PyArg_ParseTupleAndKeywords(args, kw, "s|siiO!", kwlist, 
-                                        &server, &name, &level, &flags, 
-                                        &PyDict_Type, &creds))
-               return NULL;
+       /* Open/close printer handles */
        
-       if (server[0] == '\\' && server[1] == '\\')
-               server += 2;
+       { "openprinter", spoolss_openprinter, METH_VARARGS | METH_KEYWORDS, 
+         "openprinter(printername, [creds, access]) -> <spoolss hnd object>
 
-       mem_ctx = talloc_init();
-       cli = open_pipe_creds(server, creds, cli_spoolss_initialise, NULL);
+Open a printer given by printername in UNC format.  Optionally a 
+dictionary of (username, password) may be given in which case they are
+used when opening the RPC pipe.  An access mask may also be given which
+defaults to MAXIMUM_ALLOWED_ACCESS.
 
-       /* Call rpc function */
-       
-       werror = cli_spoolss_enum_printers(
-               cli, mem_ctx, 0, &needed, flags, level,
-               &num_printers, &ctr);
+Example:
 
-       if (W_ERROR_V(werror) == ERRinsufficientbuffer)
-               werror = cli_spoolss_enum_printers(
-                       cli, mem_ctx, needed, NULL, flags, level,
-                       &num_printers, &ctr);
-
-       /* Return value */
+>>> hnd = spoolss.openprinter(\"\\\\\\\\NPSD-PDC2\\\\meanie\")
+"},
        
-       result = Py_None;
-
-       if (!W_ERROR_IS_OK(werror))
-               goto done;
-
-       result = PyList_New(num_printers);
-
-       switch (level) {
-       case 0: 
-               for (i = 0; i < num_printers; i++) {
-                       PyObject *value;
-
-                       value = from_struct (
-                               &ctr.printers_0[i], py_PRINTER_INFO_0);
+       { "closeprinter", spoolss_closeprinter, METH_VARARGS, 
+         "closeprinter()
 
-                       PyList_SetItem(result, i, value);
-               }
+Close a printer handle opened with openprinter or addprinter.
 
-               break;
-       case 1:
-               for(i = 0; i < num_printers; i++) {
-                       PyObject *value;
+Example:
 
-                       value = from_struct(
-                               &ctr.printers_1[i], py_PRINTER_INFO_1);
+>>> spoolss.closeprinter(hnd)
+"},
 
-                       PyList_SetItem(result, i, value);
-               }
-               
-               break;
-       case 2:
-               for(i = 0; i < num_printers; i++) {
-                       PyObject *value;
+       /* Server enumeratation functions */
 
-                       value = from_struct(
-                               &ctr.printers_2[i], py_PRINTER_INFO_2);
+       { "enumprinters", spoolss_enumprinters, METH_VARARGS | METH_KEYWORDS,
+         "enumprinters(server, [creds, level, flags]) -> list
 
-                       PyList_SetItem(result, i, value);
-               }
-               
-               break;
-       case 3:
-               for(i = 0; i < num_printers; i++) {
-                       PyObject *value;
+Return a list of printers on a print server.  The credentials, info level
+and flags may be specified as keyword arguments.
 
-                       value = from_struct(
-                               &ctr.printers_3[i], py_PRINTER_INFO_3);
+Example:
 
-                       PyList_SetItem(result, i, value);
-               }
-               
-               break;
-       }
+>>> print spoolss.enumprinters(\"\\\\\\\\npsd-pdc2\")
+[{'comment': 'i am a comment', 'printer_name': 'meanie', 'flags': 8388608, 
+  'description': 'meanie,Generic / Text Only,i am a location'}, 
+ {'comment': '', 'printer_name': 'fileprint', 'flags': 8388608, 
+  'description': 'fileprint,Generic / Text Only,'}]
+"},
 
- done:
-       Py_INCREF(result);
-       return result;
-}
+       { "enumports", spoolss_enumports, METH_VARARGS | METH_KEYWORDS,
+         "enumports(server, [creds, level]) -> list
 
-/* 
- * Method dispatch table
- */
+Return a list of ports on a print server.
 
-static PyMethodDef spoolss_methods[] = {
+Example:
 
-       /* Open/close printer handles */
-       
-       { "openprinter", spoolss_openprinter, METH_VARARGS | METH_KEYWORDS, 
-         "Open printer" },
-       
-       { "closeprinter", spoolss_closeprinter, METH_VARARGS, 
-         "Close printer" },
+>>> print spoolss.enumports(\"\\\\\\\\npsd-pdc2\")
+[{'name': 'LPT1:'}, {'name': 'LPT2:'}, {'name': 'COM1:'}, {'name': 'COM2:'}, 
+ {'name': 'FILE:'}, {'name': '\\\\nautilus1\\zpekt3r'}]
+"},
 
-       /* Enumerate printers */
+       { "enumprinterdrivers", spoolss_enumprinterdrivers, METH_VARARGS |
+         METH_KEYWORDS, 
+"enumprinterdrivers(server, [level, arch, creds]) -> list
 
-       { "enumprinters", spoolss_enumprinters, METH_VARARGS | METH_KEYWORDS,
-         "Enumerate printers" },
+Return a list of printer drivers.
+"},
+       /* Miscellaneous other commands */
 
-       /* Ports */
+       { "getprinterdriverdir", spoolss_getprinterdriverdir, METH_VARARGS |
+         METH_KEYWORDS, "getprinterdriverdir(server, [creds]) -> string
 
-       { "enumports", spoolss_enumports, METH_VARARGS,
-         "Enumerate ports" },
+Return the printer driver directory for a given architecture.  The 
+architecture defaults to \"Windows NT x86\".
+"},
 
        { NULL }
 };
@@ -890,26 +197,46 @@ static PyMethodDef spoolss_hnd_methods[] = {
        /* Printer info */
 
        { "getprinter", spoolss_getprinter, METH_VARARGS | METH_KEYWORDS,
-         "Fetch printer information" },
+         "getprinter([level]) -> dict
+
+Return a dictionary of print information.  The info level defaults to 1.
+
+Example:
+
+>>> hnd.getprinter()
+{'comment': 'i am a comment', 'printer_name': '\\\\NPSD-PDC2\\meanie', 
+ 'description': '\\\\NPSD-PDC2\\meanie,Generic / Text Only,i am a location',
+ 'flags': 8388608}
+"},
 
        { "setprinter", spoolss_setprinter, METH_VARARGS | METH_KEYWORDS,
-         "Set printer information" },
+         "setprinter(dict) -> None
+
+Set printer information.
+"},
 
        /* Printer drivers */
 
        { "getprinterdriver", spoolss_getprinterdriver, 
-         METH_VARARGS | METH_KEYWORDS, "Fetch printer driver" },
+         METH_VARARGS | METH_KEYWORDS, 
+         "getprinterdriver([level = 1, arch = \"Windows NT x86\"] -> dict
 
-       { "enumprinterdrivers", spoolss_enumprinterdrivers,
-         METH_VARARGS | METH_KEYWORDS, "Enumerate printer drivers" },
+Return a dictionary of printer driver information.
+"},
 
        /* Forms */
 
        { "enumforms", spoolss_enumforms, METH_VARARGS | METH_KEYWORDS,
-         "Enumerate forms" },
+         "enumforms([level = 1]) -> list
+
+Return a list of forms supported by a printer.
+"},
 
        { "setform", spoolss_setform, METH_VARARGS | METH_KEYWORDS,
-         "Modify properties of a form" },
+         "setform(dict) -> None
+
+Set the form given by the dictionary argument.
+"},
 
        { "addform", spoolss_addform, METH_VARARGS | METH_KEYWORDS,
          "Insert a form" },
@@ -934,22 +261,32 @@ static PyObject *py_policy_hnd_getattr(PyObject *self, char *attrname)
        return Py_FindMethod(spoolss_hnd_methods, self, attrname);
 }
 
+static char spoolss_type_doc[] = 
+"Python wrapper for Windows NT SPOOLSS rpc pipe.";
+
 PyTypeObject spoolss_policy_hnd_type = {
        PyObject_HEAD_INIT(NULL)
        0,
-       "Policy Handle",
+       "spoolss.hnd",
        sizeof(spoolss_policy_hnd_object),
        0,
-       py_policy_hnd_dealloc, /*tp_dealloc*/
-       0,          /*tp_print*/
-       py_policy_hnd_getattr,          /*tp_getattr*/
-       0,          /*tp_setattr*/
-       0,          /*tp_compare*/
-       0,          /*tp_repr*/
-       0,          /*tp_as_number*/
-       0,          /*tp_as_sequence*/
-       0,          /*tp_as_mapping*/
-       0,          /*tp_hash */
+       py_policy_hnd_dealloc,  /* tp_dealloc*/
+       0,                      /* tp_print*/
+       py_policy_hnd_getattr,  /* tp_getattr*/
+       0,                      /* tp_setattr*/
+       0,                      /* tp_compare*/
+       0,                      /* tp_repr*/
+       0,                      /* tp_as_number*/
+       0,                      /* tp_as_sequence*/
+       0,                      /* tp_as_mapping*/
+       0,                      /* tp_hash */
+       0,                      /* tp_call */
+       0,                      /* tp_str */
+       0,                      /* tp_getattro */
+       0,                      /* tp_setattro */
+       0,                      /* tp_as_buffer*/
+       Py_TPFLAGS_DEFAULT,     /* tp_flags */
+       spoolss_type_doc,       /* tp_doc */
 };
 
 /* Initialise constants */
@@ -963,7 +300,27 @@ struct spoolss_const {
 
        { "MAXIMUM_ALLOWED_ACCESS", MAXIMUM_ALLOWED_ACCESS },
        { "SERVER_ALL_ACCESS", SERVER_ALL_ACCESS },
+       { "SERVER_READ", SERVER_READ },
+       { "SERVER_WRITE", SERVER_WRITE },
+       { "SERVER_EXECUTE", SERVER_EXECUTE },
+       { "SERVER_ACCESS_ADMINISTER", SERVER_ACCESS_ADMINISTER },
+       { "SERVER_ACCESS_ENUMERATE", SERVER_ACCESS_ENUMERATE },
        { "PRINTER_ALL_ACCESS", PRINTER_ALL_ACCESS },
+       { "PRINTER_READ", PRINTER_READ },
+       { "PRINTER_WRITE", PRINTER_WRITE },
+       { "PRINTER_EXECUTE", PRINTER_EXECUTE },
+       { "PRINTER_ACCESS_ADMINISTER", PRINTER_ACCESS_ADMINISTER },
+       { "PRINTER_ACCESS_USE", PRINTER_ACCESS_USE },
+       { "JOB_ACCESS_ADMINISTER", JOB_ACCESS_ADMINISTER },
+       { "JOB_ALL_ACCESS", JOB_ALL_ACCESS },
+       { "JOB_READ", JOB_READ },
+       { "JOB_WRITE", JOB_WRITE },
+       { "JOB_EXECUTE", JOB_EXECUTE },
+       { "STANDARD_RIGHTS_ALL_ACCESS", STANDARD_RIGHTS_ALL_ACCESS },
+       { "STANDARD_RIGHTS_EXECUTE_ACCESS", STANDARD_RIGHTS_EXECUTE_ACCESS },
+       { "STANDARD_RIGHTS_READ_ACCESS", STANDARD_RIGHTS_READ_ACCESS },
+       { "STANDARD_RIGHTS_REQUIRED_ACCESS", STANDARD_RIGHTS_REQUIRED_ACCESS },
+       { "STANDARD_RIGHTS_WRITE_ACCESS", STANDARD_RIGHTS_WRITE_ACCESS },
 
        /* Printer enumeration flags */
 
@@ -976,6 +333,45 @@ struct spoolss_const {
        { "PRINTER_ENUM_SHARED", PRINTER_ENUM_SHARED },
        { "PRINTER_ENUM_NETWORK", PRINTER_ENUM_NETWORK },
 
+       /* Form types */
+
+       { "FORM_USER", FORM_USER },
+       { "FORM_BUILTIN", FORM_BUILTIN },
+       { "FORM_PRINTER", FORM_PRINTER },
+
+       /* WERRORs */
+
+       { "WERR_OK", 0 },
+       { "WERR_BADFILE", 2 },
+       { "WERR_ACCESS_DENIED", 5 },
+       { "WERR_BADFID", 6 },
+       { "WERR_BADFUNC", 1 },
+       { "WERR_INSUFFICIENT_BUFFER", 122 },
+       { "WERR_NO_SUCH_SHARE", 67 },
+       { "WERR_ALREADY_EXISTS", 80 },
+       { "WERR_INVALID_PARAM", 87 },
+       { "WERR_NOT_SUPPORTED", 50 },
+       { "WERR_BAD_PASSWORD", 86 },
+       { "WERR_NOMEM", 8 },
+       { "WERR_INVALID_NAME", 123 },
+       { "WERR_UNKNOWN_LEVEL", 124 },
+       { "WERR_OBJECT_PATH_INVALID", 161 },
+       { "WERR_NO_MORE_ITEMS", 259 },
+       { "WERR_MORE_DATA", 234 },
+       { "WERR_UNKNOWN_PRINTER_DRIVER", 1797 },
+       { "WERR_INVALID_PRINTER_NAME", 1801 },
+       { "WERR_PRINTER_ALREADY_EXISTS", 1802 },
+       { "WERR_INVALID_DATATYPE", 1804 },
+       { "WERR_INVALID_ENVIRONMENT", 1805 },
+       { "WERR_INVALID_FORM_NAME", 1902 },
+       { "WERR_INVALID_FORM_SIZE", 1903 },
+       { "WERR_BUF_TOO_SMALL", 2123 },
+       { "WERR_JOB_NOT_FOUND", 2151 },
+       { "WERR_DEST_NOT_FOUND", 2152 },
+       { "WERR_NOT_LOCAL_DOMAIN", 2320 },
+       { "WERR_PRINTER_DRIVER_IN_USE", 3001 },
+       { "WERR_STATUS_MORE_ENTRIES  ", 0x0105 },
+
        { NULL },
 };
 
@@ -1015,6 +411,9 @@ void initspoolss(void)
 
        spoolss_policy_hnd_type.ob_type = &PyType_Type;
 
+       PyDict_SetItemString(dict, "spoolss.hnd", 
+                            (PyObject *)&spoolss_policy_hnd_type);
+
        /* Initialise constants */
 
        const_init(dict);