r5518: Add initial msdfs support to smbclient. Currently I can only
[bbaumbach/samba-autobuild/.git] / source3 / client / client.c
index 9cd9c81f23c5566c72076e6fe16dc11c88a4ed86..53e425c519828a72fccfcd7d3823c98e07848137 100644 (file)
@@ -1,9 +1,10 @@
 /* 
    Unix SMB/CIFS implementation.
    SMB client
-   Copyright (C) Andrew Tridgell 1994-1998
-   Copyright (C) Simo Sorce 2001-2002
-   Copyright (C) Jelmer Vernooij 2003
+   Copyright (C) Andrew Tridgell          1994-1998
+   Copyright (C) Simo Sorce               2001-2002
+   Copyright (C) Jelmer Vernooij          2003
+   Copyright (C) Gerald (Jerry) Carter    2004
    
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
 #define NO_SYSLOG
 
 #include "includes.h"
-#include "../client/client_proto.h"
+#include "client/client_proto.h"
 #ifndef REGISTER
 #define REGISTER 0
 #endif
 
-struct cli_state *cli;
 extern BOOL in_client;
 static int port = 0;
 pstring cur_dir = "\\";
@@ -39,6 +39,7 @@ static pstring username;
 static pstring password;
 static BOOL use_kerberos;
 static BOOL got_pass;
+static BOOL grepable=False;
 static char *cmdstr = NULL;
 
 static int io_bufsize = 64512;
@@ -46,7 +47,7 @@ static int io_bufsize = 64512;
 static int name_type = 0x20;
 static int max_protocol = PROTOCOL_NT1;
 
-static int process_tok(fstring tok);
+static int process_tok(pstring tok);
 static int cmd_help(void);
 
 /* 30 second timeout on most commands */
@@ -96,15 +97,236 @@ static unsigned int put_total_time_ms = 0;
 /* totals globals */
 static double dir_total;
 
-#define USENMB
 
-/* some forward declarations */
-static struct cli_state *do_connect(const char *server, const char *share);
+struct client_connection {
+       struct client_connection *prev, *next;
+       struct client_connection *parent;
+       struct cli_state *cli;
+       pstring mntpath;
+};
+
+struct cli_state *cli;
+static struct client_connection *connections;
+
+/********************************************************************
+ Return a connection to a server.
+********************************************************************/
+
+static struct cli_state *do_connect( const char *server, const char *share,
+                                     BOOL show_sessetup )
+{
+       struct cli_state *c;
+       struct nmb_name called, calling;
+       const char *server_n;
+       struct in_addr ip;
+       pstring servicename;
+       char *sharename;
+       
+       /* make a copy so we don't modify the global string 'service' */
+       pstrcpy(servicename, share);
+       sharename = servicename;
+       if (*sharename == '\\') {
+               server = sharename+2;
+               sharename = strchr_m(server,'\\');
+               if (!sharename) return NULL;
+               *sharename = 0;
+               sharename++;
+       }
+
+       server_n = server;
+       
+       zero_ip(&ip);
+
+       make_nmb_name(&calling, global_myname(), 0x0);
+       make_nmb_name(&called , server, name_type);
+
+ again:
+       zero_ip(&ip);
+       if (have_ip) ip = dest_ip;
+
+       /* have to open a new connection */
+       if (!(c=cli_initialise(NULL)) || (cli_set_port(c, port) != port) ||
+           !cli_connect(c, server_n, &ip)) {
+               d_printf("Connection to %s failed\n", server_n);
+               return NULL;
+       }
+
+       c->protocol = max_protocol;
+       c->use_kerberos = use_kerberos;
+       cli_setup_signing_state(c, cmdline_auth_info.signing_state);
+               
+
+       if (!cli_session_request(c, &calling, &called)) {
+               char *p;
+               d_printf("session request to %s failed (%s)\n", 
+                        called.name, cli_errstr(c));
+               cli_shutdown(c);
+               if ((p=strchr_m(called.name, '.'))) {
+                       *p = 0;
+                       goto again;
+               }
+               if (strcmp(called.name, "*SMBSERVER")) {
+                       make_nmb_name(&called , "*SMBSERVER", 0x20);
+                       goto again;
+               }
+               return NULL;
+       }
+
+       DEBUG(4,(" session request ok\n"));
+
+       if (!cli_negprot(c)) {
+               d_printf("protocol negotiation failed\n");
+               cli_shutdown(c);
+               return NULL;
+       }
+
+       if (!got_pass) {
+               char *pass = getpass("Password: ");
+               if (pass) {
+                       pstrcpy(password, pass);
+                       got_pass = 1;
+               }
+       }
+
+       if (!cli_session_setup(c, username, 
+                              password, strlen(password),
+                              password, strlen(password),
+                              lp_workgroup())) {
+               /* if a password was not supplied then try again with a null username */
+               if (password[0] || !username[0] || use_kerberos ||
+                   !cli_session_setup(c, "", "", 0, "", 0, lp_workgroup())) { 
+                       d_printf("session setup failed: %s\n", cli_errstr(c));
+                       if (NT_STATUS_V(cli_nt_error(c)) == 
+                           NT_STATUS_V(NT_STATUS_MORE_PROCESSING_REQUIRED))
+                               d_printf("did you forget to run kinit?\n");
+                       cli_shutdown(c);
+                       return NULL;
+               }
+               d_printf("Anonymous login successful\n");
+       }
+
+       if ( show_sessetup ) {
+               if (*c->server_domain) {
+                       DEBUG(1,("Domain=[%s] OS=[%s] Server=[%s]\n",
+                               c->server_domain,c->server_os,c->server_type));
+               } else if (*c->server_os || *c->server_type){
+                       DEBUG(1,("OS=[%s] Server=[%s]\n",
+                                c->server_os,c->server_type));
+               }               
+       }
+       DEBUG(4,(" session setup ok\n"));
+
+       if (!cli_send_tconX(c, sharename, "?????",
+                           password, strlen(password)+1)) {
+               d_printf("tree connect failed: %s\n", cli_errstr(c));
+               cli_shutdown(c);
+               return NULL;
+       }
+
+       DEBUG(4,(" tconx ok\n"));
+
+       return c;
+}
+
+/********************************************************************
+ Add a new connection to the list
+********************************************************************/
+
+static struct cli_state* cli_cm_connect( const char *server, const char *share,
+                                         BOOL show_hdr )
+{
+       struct client_connection *node, *pparent, *p;
+       
+       node = SMB_XMALLOC_P( struct client_connection );
+       
+       node->cli = do_connect( server, share, show_hdr );
+
+       if ( !node->cli ) {
+               SAFE_FREE( node );
+               return NULL;
+       }
+
+       pparent = NULL;
+       for ( p=connections; p; p=p->next ) {
+               if ( strequal(cli->desthost, p->cli->desthost) && strequal(cli->share, p->cli->share) )
+                       pparent = p;
+       }
+       
+       node->parent = pparent;
+       pstrcpy( node->mntpath, cur_dir );
+
+       DLIST_ADD( connections, node );
+
+       return node->cli;
+
+}
+
+/********************************************************************
+ Return a connection to a server.
+********************************************************************/
+
+static struct cli_state* cli_cm_find( const char *server, const char *share )
+{
+       struct client_connection *p;
+
+       for ( p=connections; p; p=p->next ) {
+               if ( strequal(server, p->cli->desthost) && strequal(share,p->cli->share) )
+                       return p->cli;
+       }
+
+       return NULL;
+}
+
+/****************************************************************************
+ open a client connection to a \\server\share.  Set's the current *cli 
+ global variable as a side-effect (but only if the connection is successful).
+****************************************************************************/
+
+struct cli_state* cli_cm_open( const char *server, const char *share, BOOL show_hdr )
+{
+       struct cli_state *c;
+       
+       /* try to reuse an existing connection */
+
+       c = cli_cm_find( server, share );
+       
+       if ( !c )
+               c = cli_cm_connect( server, share, show_hdr );
+
+       return c;
+}
+
+/****************************************************************************
+****************************************************************************/
+
+struct cli_state* cli_cm_current( void )
+{
+       return cli;
+}
+
+/****************************************************************************
+****************************************************************************/
+
+const char* cli_cm_get_mntpath( struct cli_state *pcli )
+{
+       struct client_connection *p;
+       
+       for ( p=connections; p; p=p->next ) {
+               if ( strequal(pcli->desthost, p->cli->desthost) && strequal(pcli->share, p->cli->share) )
+                       break;
+       }
+       
+       if ( !p )
+               return NULL;
+               
+       return p->mntpath;
+}
 
 /****************************************************************************
-write to a local file with CR/LF->LF translation if appropriate. return the 
-number taken from the buffer. This may not equal the number written.
+ Write to a local file with CR/LF->LF translation if appropriate. Return the 
+ number taken from the buffer. This may not equal the number written.
 ****************************************************************************/
+
 static int writefile(int f, char *b, int n)
 {
        int i;
@@ -129,9 +351,10 @@ static int writefile(int f, char *b, int n)
 }
 
 /****************************************************************************
 read from a file with LF->CR/LF translation if appropriate. return the 
 number read. read approx n bytes.
Read from a file with LF->CR/LF translation if appropriate. Return the 
+ number read. read approx n bytes.
 ****************************************************************************/
+
 static int readfile(char *b, int n, XFILE *f)
 {
        int i;
@@ -156,10 +379,10 @@ static int readfile(char *b, int n, XFILE *f)
        return(i);
 }
  
-
 /****************************************************************************
-send a message
+ Send a message.
 ****************************************************************************/
+
 static void send_message(void)
 {
        int total_len = 0;
@@ -206,17 +429,22 @@ static void send_message(void)
        }      
 }
 
-
-
 /****************************************************************************
-check the space on a device
+ Check the space on a device.
 ****************************************************************************/
+
 static int do_dskattr(void)
 {
        int total, bsize, avail;
+       struct cli_state *targetcli;
+       pstring targetpath;
 
-       if (!cli_dskattr(cli, &bsize, &total, &avail)) {
-               d_printf("Error in dskattr: %s\n",cli_errstr(cli)); 
+       if ( !cli_resolve_path( cli, cur_dir, &targetcli, targetpath ) ) {
+               d_printf("Error in dskattr: %s\n", cli_errstr(cli));
+       }
+
+       if (!cli_dskattr(targetcli, &bsize, &total, &avail)) {
+               d_printf("Error in dskattr: %s\n",cli_errstr(targetcli)); 
                return 1;
        }
 
@@ -227,8 +455,9 @@ static int do_dskattr(void)
 }
 
 /****************************************************************************
-show cd/pwd
+ Show cd/pwd.
 ****************************************************************************/
+
 static int cmd_pwd(void)
 {
        d_printf("Current directory is %s",service);
@@ -236,53 +465,67 @@ static int cmd_pwd(void)
        return 0;
 }
 
-
 /****************************************************************************
-change directory - inner section
+ Change directory - inner section.
 ****************************************************************************/
+
 static int do_cd(char *newdir)
 {
        char *p = newdir;
        pstring saved_dir;
        pstring dname;
+       pstring targetpath;
+       struct cli_state *targetcli;
       
        dos_format(newdir);
 
-       /* Save the current directory in case the
-          new directory is invalid */
+       /* Save the current directory in case the new directory is invalid */
+
        pstrcpy(saved_dir, cur_dir);
+
        if (*p == '\\')
                pstrcpy(cur_dir,p);
        else
                pstrcat(cur_dir,p);
+
        if (*(cur_dir+strlen(cur_dir)-1) != '\\') {
                pstrcat(cur_dir, "\\");
        }
+
        dos_clean_name(cur_dir);
-       pstrcpy(dname,cur_dir);
+       pstrcpy( dname, cur_dir );
        pstrcat(cur_dir,"\\");
        dos_clean_name(cur_dir);
        
-       if (!strequal(cur_dir,"\\")) {
-               if (!cli_chkpath(cli, dname)) {
-                       d_printf("cd %s: %s\n", dname, cli_errstr(cli));
+       if ( !cli_resolve_path( cli, dname, &targetcli, targetpath ) ) {
+               d_printf("cd %s: %s\n", dname, cli_errstr(cli));
+               pstrcpy(cur_dir,saved_dir);
+       }
+
+       pstrcat( targetpath, "\\" );
+       dos_clean_name( targetpath );
+
+       if ( !strequal(targetpath,"\\") ) {     
+               if ( !cli_chkpath(targetcli, targetpath) ) {
+                       d_printf("cd %s: %s\n", dname, cli_errstr(targetcli));
                        pstrcpy(cur_dir,saved_dir);
                }
        }
-       
+
        pstrcpy(cd_path,cur_dir);
 
        return 0;
 }
 
 /****************************************************************************
-change directory
+ Change directory.
 ****************************************************************************/
+
 static int cmd_cd(void)
 {
-       fstring buf;
+       pstring buf;
        int rc = 0;
-
+               
        if (next_token_nr(NULL,buf,NULL,sizeof(buf)))
                rc = do_cd(buf);
        else
@@ -291,13 +534,14 @@ static int cmd_cd(void)
        return rc;
 }
 
-
 /*******************************************************************
-  decide if a file should be operated on
-  ********************************************************************/
+ Decide if a file should be operated on.
+********************************************************************/
+
 static BOOL do_this_one(file_info *finfo)
 {
-       if (finfo->mode & aDIR) return(True);
+       if (finfo->mode & aDIR)
+               return(True);
 
        if (*fileselection && 
            !mask_match(finfo->name,fileselection,False)) {
@@ -319,8 +563,9 @@ static BOOL do_this_one(file_info *finfo)
 }
 
 /****************************************************************************
-  display info about a file
-  ****************************************************************************/
+ Display info about a file.
+****************************************************************************/
+
 static void display_finfo(file_info *finfo)
 {
        if (do_this_one(finfo)) {
@@ -334,10 +579,10 @@ static void display_finfo(file_info *finfo)
        }
 }
 
-
 /****************************************************************************
-   accumulate size of a file
-  ****************************************************************************/
+ Accumulate size of a file.
+****************************************************************************/
+
 static void do_du(file_info *finfo)
 {
        if (do_this_one(finfo)) {
@@ -354,8 +599,8 @@ static long do_list_queue_end = 0;
 static void (*do_list_fn)(file_info *);
 
 /****************************************************************************
-functions for do_list_queue
-  ****************************************************************************/
+ Functions for do_list_queue.
+****************************************************************************/
 
 /*
  * The do_list_queue is a NUL-separated list of strings stored in a
@@ -368,6 +613,7 @@ functions for do_list_queue
  * Functions check to ensure that do_list_queue is non-NULL before
  * accessing it.
  */
+
 static void reset_do_list_queue(void)
 {
        SAFE_FREE(do_list_queue);
@@ -380,7 +626,7 @@ static void init_do_list_queue(void)
 {
        reset_do_list_queue();
        do_list_queue_size = 1024;
-       do_list_queue = malloc(do_list_queue_size);
+       do_list_queue = SMB_MALLOC(do_list_queue_size);
        if (do_list_queue == 0) { 
                d_printf("malloc fail for size %d\n",
                         (int)do_list_queue_size);
@@ -396,14 +642,11 @@ static void adjust_do_list_queue(void)
         * If the starting point of the queue is more than half way through,
         * move everything toward the beginning.
         */
-       if (do_list_queue && (do_list_queue_start == do_list_queue_end))
-       {
+       if (do_list_queue && (do_list_queue_start == do_list_queue_end)) {
                DEBUG(4,("do_list_queue is empty\n"));
                do_list_queue_start = do_list_queue_end = 0;
                *do_list_queue = '\0';
-       }
-       else if (do_list_queue_start > (do_list_queue_size / 2))
-       {
+       } else if (do_list_queue_start > (do_list_queue_size / 2)) {
                DEBUG(4,("sliding do_list_queue backward\n"));
                memmove(do_list_queue,
                        do_list_queue + do_list_queue_start,
@@ -411,33 +654,28 @@ static void adjust_do_list_queue(void)
                do_list_queue_end -= do_list_queue_start;
                do_list_queue_start = 0;
        }
-          
 }
 
 static void add_to_do_list_queue(const char* entry)
 {
        char *dlq;
        long new_end = do_list_queue_end + ((long)strlen(entry)) + 1;
-       while (new_end > do_list_queue_size)
-       {
+       while (new_end > do_list_queue_size) {
                do_list_queue_size *= 2;
                DEBUG(4,("enlarging do_list_queue to %d\n",
                         (int)do_list_queue_size));
-               dlq = Realloc(do_list_queue, do_list_queue_size);
+               dlq = SMB_REALLOC(do_list_queue, do_list_queue_size);
                if (! dlq) {
                        d_printf("failure enlarging do_list_queue to %d bytes\n",
                                 (int)do_list_queue_size);
                        reset_do_list_queue();
-               }
-               else
-               {
+               } else {
                        do_list_queue = dlq;
                        memset(do_list_queue + do_list_queue_size / 2,
                               0, do_list_queue_size / 2);
                }
        }
-       if (do_list_queue)
-       {
+       if (do_list_queue) {
                safe_strcpy_base(do_list_queue + do_list_queue_end, 
                                 entry, do_list_queue, do_list_queue_size);
                do_list_queue_end = new_end;
@@ -453,8 +691,7 @@ static char *do_list_queue_head(void)
 
 static void remove_do_list_queue_head(void)
 {
-       if (do_list_queue_end > do_list_queue_start)
-       {
+       if (do_list_queue_end > do_list_queue_start) {
                do_list_queue_start += strlen(do_list_queue_head()) + 1;
                adjust_do_list_queue();
                DEBUG(4,("removed head of do_list_queue (start=%d, end=%d)\n",
@@ -468,8 +705,9 @@ static int do_list_queue_empty(void)
 }
 
 /****************************************************************************
-a helper for do_list
-  ****************************************************************************/
+ A helper for do_list.
+****************************************************************************/
+
 static void do_list_helper(file_info *f, const char *mask, void *state)
 {
        if (f->mode & aDIR) {
@@ -489,7 +727,8 @@ static void do_list_helper(file_info *f, const char *mask, void *state)
 
                        pstrcpy(mask2, mask);
                        p = strrchr_m(mask2,'\\');
-                       if (!p) return;
+                       if (!p)
+                               return;
                        p[1] = 0;
                        pstrcat(mask2, f->name);
                        pstrcat(mask2,"\\*");
@@ -503,16 +742,17 @@ static void do_list_helper(file_info *f, const char *mask, void *state)
        }
 }
 
-
 /****************************************************************************
-a wrapper around cli_list that adds recursion
-  ****************************************************************************/
+ A wrapper around cli_list that adds recursion.
+****************************************************************************/
+
 void do_list(const char *mask,uint16 attribute,void (*fn)(file_info *),BOOL rec, BOOL dirs)
 {
        static int in_do_list = 0;
+       struct cli_state *targetcli;
+       pstring targetpath;
 
-       if (in_do_list && rec)
-       {
+       if (in_do_list && rec) {
                fprintf(stderr, "INTERNAL ERROR: do_list called recursively when the recursive flag is true\n");
                exit(1);
        }
@@ -523,13 +763,11 @@ void do_list(const char *mask,uint16 attribute,void (*fn)(file_info *),BOOL rec,
        do_list_dirs = dirs;
        do_list_fn = fn;
 
-       if (rec)
-       {
+       if (rec) {
                init_do_list_queue();
                add_to_do_list_queue(mask);
                
-               while (! do_list_queue_empty())
-               {
+               while (! do_list_queue_empty()) {
                        /*
                         * Need to copy head so that it doesn't become
                         * invalid inside the call to cli_list.  This
@@ -539,34 +777,42 @@ void do_list(const char *mask,uint16 attribute,void (*fn)(file_info *),BOOL rec,
                         */
                        pstring head;
                        pstrcpy(head, do_list_queue_head());
-                       cli_list(cli, head, attribute, do_list_helper, NULL);
+                       
+                       /* check for dfs */
+                       
+                       if ( !cli_resolve_path( cli, head, &targetcli, targetpath ) ) {
+                               d_printf("do_list: [%s] %s\n", head, cli_errstr(cli));
+                               continue;
+                       }
+                       
+                       cli_list(targetcli, targetpath, attribute, do_list_helper, NULL);
                        remove_do_list_queue_head();
-                       if ((! do_list_queue_empty()) && (fn == display_finfo))
-                       {
+                       if ((! do_list_queue_empty()) && (fn == display_finfo)) {
                                char* next_file = do_list_queue_head();
                                char* save_ch = 0;
                                if ((strlen(next_file) >= 2) &&
                                    (next_file[strlen(next_file) - 1] == '*') &&
-                                   (next_file[strlen(next_file) - 2] == '\\'))
-                               {
+                                   (next_file[strlen(next_file) - 2] == '\\')) {
                                        save_ch = next_file +
                                                strlen(next_file) - 2;
                                        *save_ch = '\0';
                                }
                                d_printf("\n%s\n",next_file);
-                               if (save_ch)
-                               {
+                               if (save_ch) {
                                        *save_ch = '\\';
                                }
                        }
                }
-       }
-       else
-       {
-               if (cli_list(cli, mask, attribute, do_list_helper, NULL) == -1)
-               {
-                       d_printf("%s listing %s\n", cli_errstr(cli), mask);
+       } else {
+               /* check for dfs */
+                       
+               if ( cli_resolve_path( cli, mask, &targetcli, targetpath ) ) {
+                       if (cli_list(targetcli, targetpath, attribute, do_list_helper, NULL) == -1) 
+                               d_printf("%s listing %s\n", cli_errstr(targetcli), targetpath);
                }
+               else
+                       d_printf("do_list: [%s] %s\n", mask, cli_errstr(cli));
+               
        }
 
        in_do_list = 0;
@@ -574,29 +820,33 @@ void do_list(const char *mask,uint16 attribute,void (*fn)(file_info *),BOOL rec,
 }
 
 /****************************************************************************
-  get a directory listing
-  ****************************************************************************/
+ Get a directory listing.
+****************************************************************************/
+
 static int cmd_dir(void)
 {
        uint16 attribute = aDIR | aSYSTEM | aHIDDEN;
        pstring mask;
-       fstring buf;
+       pstring buf;
        char *p=buf;
        int rc;
        
        dir_total = 0;
-       pstrcpy(mask,cur_dir);
-       if(mask[strlen(mask)-1]!='\\')
-               pstrcat(mask,"\\");
+       if (strcmp(cur_dir, "\\") != 0) {
+               pstrcpy(mask,cur_dir);
+               if(mask[strlen(mask)-1]!='\\')
+                       pstrcat(mask,"\\");
+       } else {
+               pstrcpy(mask, "\\");
+       }
        
        if (next_token_nr(NULL,buf,NULL,sizeof(buf))) {
                dos_format(p);
                if (*p == '\\')
-                       pstrcpy(mask,p);
+                       pstrcpy(mask,p + 1);
                else
                        pstrcat(mask,p);
-       }
-       else {
+       } else {
                pstrcat(mask,"*");
        }
 
@@ -609,15 +859,15 @@ static int cmd_dir(void)
        return rc;
 }
 
-
 /****************************************************************************
-  get a directory listing
-  ****************************************************************************/
+ Get a directory listing.
+****************************************************************************/
+
 static int cmd_du(void)
 {
        uint16 attribute = aDIR | aSYSTEM | aHIDDEN;
        pstring mask;
-       fstring buf;
+       pstring buf;
        char *p=buf;
        int rc;
        
@@ -645,10 +895,10 @@ static int cmd_du(void)
        return rc;
 }
 
-
 /****************************************************************************
-  get a file from rname to lname
-  ****************************************************************************/
+ Get a file from rname to lname
+****************************************************************************/
+
 static int do_get(char *rname, char *lname, BOOL reget)
 {  
        int handle = 0, fnum;
@@ -706,10 +956,10 @@ static int do_get(char *rname, char *lname, BOOL reget)
                return 1;
        }
 
-       DEBUG(2,("getting file %s of size %.0f as %s ", 
+       DEBUG(1,("getting file %s of size %.0f as %s ", 
                 rname, (double)size, lname));
 
-       if(!(data = (char *)malloc(read_size))) { 
+       if(!(data = (char *)SMB_MALLOC(read_size))) { 
                d_printf("malloc fail for size %d\n", read_size);
                cli_close(cli, fnum);
                return 1;
@@ -718,7 +968,8 @@ static int do_get(char *rname, char *lname, BOOL reget)
        while (1) {
                int n = cli_read(cli, fnum, data, nread + start, read_size);
 
-               if (n <= 0) break;
+               if (n <= 0)
+                       break;
  
                if (writefile(handle,data, n) != n) {
                        d_printf("Error writing local file\n");
@@ -762,7 +1013,7 @@ static int do_get(char *rname, char *lname, BOOL reget)
                get_total_time_ms += this_time;
                get_total_size += nread;
                
-               DEBUG(2,("(%3.1f kb/s) (average %3.1f kb/s)\n",
+               DEBUG(1,("(%3.1f kb/s) (average %3.1f kb/s)\n",
                         nread / (1.024*this_time + 1.0e-4),
                         get_total_size / (1.024*get_total_time_ms)));
        }
@@ -770,10 +1021,10 @@ static int do_get(char *rname, char *lname, BOOL reget)
        return rc;
 }
 
-
 /****************************************************************************
-  get a file
-  ****************************************************************************/
+ Get a file.
+****************************************************************************/
+
 static int cmd_get(void)
 {
        pstring lname;
@@ -797,10 +1048,10 @@ static int cmd_get(void)
        return do_get(rname, lname, False);
 }
 
-
 /****************************************************************************
-  do a mget operation on one file
-  ****************************************************************************/
+ Do an mget operation on one file.
+****************************************************************************/
+
 static void do_mget(file_info *finfo)
 {
        pstring rname;
@@ -823,7 +1074,8 @@ static void do_mget(file_info *finfo)
                slprintf(quest,sizeof(pstring)-1,
                         "Get file %s? ",finfo->name);
 
-       if (prompt && !yesno(quest)) return;
+       if (prompt && !yesno(quest))
+               return;
 
        if (!(finfo->mode & aDIR)) {
                pstrcpy(rname,cur_dir);
@@ -863,19 +1115,19 @@ static void do_mget(file_info *finfo)
        pstrcpy(cur_dir,saved_curdir);
 }
 
-
 /****************************************************************************
-view the file using the pager
+ View the file using the pager.
 ****************************************************************************/
+
 static int cmd_more(void)
 {
-       fstring rname,lname,pager_cmd;
+       pstring rname,lname,pager_cmd;
        char *pager;
        int fd;
        int rc = 0;
 
-       fstrcpy(rname,cur_dir);
-       fstrcat(rname,"\\");
+       pstrcpy(rname,cur_dir);
+       pstrcat(rname,"\\");
        
        slprintf(lname,sizeof(lname)-1, "%s/smbmore.XXXXXX",tmpdir());
        fd = smb_mkstemp(lname);
@@ -904,16 +1156,15 @@ static int cmd_more(void)
        return rc;
 }
 
-
-
 /****************************************************************************
-do a mget command
+ Do a mget command.
 ****************************************************************************/
+
 static int cmd_mget(void)
 {
        uint16 attribute = aSYSTEM | aHIDDEN;
        pstring mget_mask;
-       fstring buf;
+       pstring buf;
        char *p=buf;
 
        *mget_mask = 0;
@@ -946,10 +1197,10 @@ static int cmd_mget(void)
        return 0;
 }
 
-
 /****************************************************************************
-make a directory of name "name"
+ Make a directory of name "name".
 ****************************************************************************/
+
 static BOOL do_mkdir(char *name)
 {
        if (!cli_mkdir(cli, name)) {
@@ -962,11 +1213,12 @@ static BOOL do_mkdir(char *name)
 }
 
 /****************************************************************************
-show 8.3 name of a file
+ Show 8.3 name of a file.
 ****************************************************************************/
+
 static BOOL do_altname(char *name)
 {
-       fstring altname;
+       pstring altname;
        if (!NT_STATUS_IS_OK(cli_qpathinfo_alt_name(cli, name, altname))) {
                d_printf("%s getting alt name for %s\n",
                         cli_errstr(cli),name);
@@ -977,10 +1229,10 @@ static BOOL do_altname(char *name)
        return(True);
 }
 
-
 /****************************************************************************
  Exit client.
 ****************************************************************************/
+
 static int cmd_quit(void)
 {
        cli_shutdown(cli);
@@ -989,14 +1241,14 @@ static int cmd_quit(void)
        return 0;
 }
 
-
 /****************************************************************************
-  make a directory
-  ****************************************************************************/
+ Make a directory.
+****************************************************************************/
+
 static int cmd_mkdir(void)
 {
        pstring mask;
-       fstring buf;
+       pstring buf;
        char *p=buf;
   
        pstrcpy(mask,cur_dir);
@@ -1014,7 +1266,7 @@ static int cmd_mkdir(void)
                *ddir2 = 0;
                
                pstrcpy(ddir,mask);
-               trim_string(ddir,".",NULL);
+               trim_char(ddir,'.','\0');
                p = strtok(ddir,"/\\");
                while (p) {
                        pstrcat(ddir2,p);
@@ -1031,14 +1283,14 @@ static int cmd_mkdir(void)
        return 0;
 }
 
-
 /****************************************************************************
-  show alt name
-  ****************************************************************************/
+ Show alt name.
+****************************************************************************/
+
 static int cmd_altname(void)
 {
        pstring name;
-       fstring buf;
+       pstring buf;
        char *p=buf;
   
        pstrcpy(name,cur_dir);
@@ -1054,10 +1306,10 @@ static int cmd_altname(void)
        return 0;
 }
 
-
 /****************************************************************************
-  put a single file
-  ****************************************************************************/
+ Put a single file.
+****************************************************************************/
+
 static int do_put(char *rname, char *lname, BOOL reput)
 {
        int fnum;
@@ -1111,12 +1363,11 @@ static int do_put(char *rname, char *lname, BOOL reput)
                d_printf("Error opening local file %s\n",lname);
                return 1;
        }
-
   
        DEBUG(1,("putting file %s as %s ",lname,
                 rname));
   
-       buf = (char *)malloc(maxwrite);
+       buf = (char *)SMB_MALLOC(maxwrite);
        if (!buf) {
                d_printf("ERROR: Not enough memory!\n");
                return 1;
@@ -1183,16 +1434,15 @@ static int do_put(char *rname, char *lname, BOOL reput)
        return rc;
 }
 
-
 /****************************************************************************
-  put a file
-  ****************************************************************************/
+ Put a file.
+****************************************************************************/
+
 static int cmd_put(void)
 {
        pstring lname;
        pstring rname;
-       fstring buf;
+       pstring buf;
        char *p=buf;
        
        pstrcpy(rname,cur_dir);
@@ -1226,7 +1476,7 @@ static int cmd_put(void)
 }
 
 /*************************************
-  File list structure
+ File list structure.
 *************************************/
 
 static struct file_list {
@@ -1236,15 +1486,14 @@ static struct file_list {
 } *file_list;
 
 /****************************************************************************
-  Free a file_list structure
+ Free a file_list structure.
 ****************************************************************************/
 
 static void free_file_list (struct file_list * list)
 {
        struct file_list *tmp;
        
-       while (list)
-       {
+       while (list) {
                tmp = list;
                DLIST_REMOVE(list, list);
                SAFE_FREE(tmp->file_path);
@@ -1253,9 +1502,10 @@ static void free_file_list (struct file_list * list)
 }
 
 /****************************************************************************
-  seek in a directory/file list until you get something that doesn't start with
-  the specified name
-  ****************************************************************************/
+ Seek in a directory/file list until you get something that doesn't start with
+ the specified name.
+****************************************************************************/
+
 static BOOL seek_list(struct file_list *list, char *name)
 {
        while (list) {
@@ -1270,8 +1520,9 @@ static BOOL seek_list(struct file_list *list, char *name)
 }
 
 /****************************************************************************
-  set the file selection mask
-  ****************************************************************************/
+ Set the file selection mask.
+****************************************************************************/
+
 static int cmd_select(void)
 {
        pstrcpy(fileselection,"");
@@ -1284,6 +1535,7 @@ static int cmd_select(void)
   Recursive file matching function act as find
   match must be always set to True when calling this function
 ****************************************************************************/
+
 static int file_find(struct file_list **list, const char *directory, 
                      const char *expression, BOOL match)
 {
@@ -1296,11 +1548,14 @@ static int file_find(struct file_list **list, const char *directory,
        const char *dname;
 
         dir = opendir(directory);
-       if (!dir) return -1;
+       if (!dir)
+               return -1;
        
         while ((dname = readdirname(dir))) {
-               if (!strcmp("..", dname)) continue;
-               if (!strcmp(".", dname)) continue;
+               if (!strcmp("..", dname))
+                       continue;
+               if (!strcmp(".", dname))
+                       continue;
                
                if (asprintf(&path, "%s/%s", directory, dname) <= 0) {
                        continue;
@@ -1325,7 +1580,7 @@ static int file_find(struct file_list **list, const char *directory,
                                        return -1;
                                }
                        }
-                       entry = (struct file_list *) malloc(sizeof (struct file_list));
+                       entry = SMB_MALLOC_P(struct file_list);
                        if (!entry) {
                                d_printf("Out of memory in file_find\n");
                                closedir(dir);
@@ -1344,11 +1599,12 @@ static int file_find(struct file_list **list, const char *directory,
 }
 
 /****************************************************************************
-  mput some files
-  ****************************************************************************/
+ mput some files.
+****************************************************************************/
+
 static int cmd_mput(void)
 {
-       fstring buf;
+       pstring buf;
        char *p=buf;
        
        while (next_token_nr(NULL,p,NULL,sizeof(buf))) {
@@ -1425,10 +1681,10 @@ static int cmd_mput(void)
        return 0;
 }
 
-
 /****************************************************************************
-  cancel a print job
-  ****************************************************************************/
+ Cancel a print job.
+****************************************************************************/
+
 static int do_cancel(int job)
 {
        if (cli_printjob_del(cli, job)) {
@@ -1440,13 +1696,13 @@ static int do_cancel(int job)
        }
 }
 
-
 /****************************************************************************
-  cancel a print job
-  ****************************************************************************/
+ Cancel a print job.
+****************************************************************************/
+
 static int cmd_cancel(void)
 {
-       fstring buf;
+       pstring buf;
        int job; 
 
        if (!next_token_nr(NULL,buf,NULL,sizeof(buf))) {
@@ -1461,10 +1717,10 @@ static int cmd_cancel(void)
        return 0;
 }
 
-
 /****************************************************************************
-  print a file
-  ****************************************************************************/
+ Print a file.
+****************************************************************************/
+
 static int cmd_print(void)
 {
        pstring lname;
@@ -1489,18 +1745,19 @@ static int cmd_print(void)
        return do_put(rname, lname, False);
 }
 
-
 /****************************************************************************
- show a print queue entry
+ Show a print queue entry.
 ****************************************************************************/
+
 static void queue_fn(struct print_job_info *p)
 {
        d_printf("%-6d   %-9d    %s\n", (int)p->id, (int)p->size, p->name);
 }
 
 /****************************************************************************
- show a print queue
+ Show a print queue.
 ****************************************************************************/
+
 static int cmd_queue(void)
 {
        cli_print_queue(cli, queue_fn);
@@ -1509,8 +1766,9 @@ static int cmd_queue(void)
 }
 
 /****************************************************************************
-delete some files
+ Delete some files.
 ****************************************************************************/
+
 static void do_del(file_info *finfo)
 {
        pstring mask;
@@ -1527,12 +1785,13 @@ static void do_del(file_info *finfo)
 }
 
 /****************************************************************************
-delete some files
+ Delete some files.
 ****************************************************************************/
+
 static int cmd_del(void)
 {
        pstring mask;
-       fstring buf;
+       pstring buf;
        uint16 attribute = aSYSTEM | aHIDDEN;
 
        if (recurse)
@@ -1553,10 +1812,11 @@ static int cmd_del(void)
 
 /****************************************************************************
 ****************************************************************************/
+
 static int cmd_open(void)
 {
        pstring mask;
-       fstring buf;
+       pstring buf;
        
        pstrcpy(mask,cur_dir);
        
@@ -1566,19 +1826,20 @@ static int cmd_open(void)
        }
        pstrcat(mask,buf);
 
-       cli_open(cli, mask, O_RDWR, DENY_ALL);
+       cli_nt_create(cli, mask, FILE_READ_DATA);
 
        return 0;
 }
 
 
 /****************************************************************************
-remove a directory
+ Remove a directory.
 ****************************************************************************/
+
 static int cmd_rmdir(void)
 {
        pstring mask;
-       fstring buf;
+       pstring buf;
   
        pstrcpy(mask,cur_dir);
        
@@ -1602,28 +1863,28 @@ static int cmd_rmdir(void)
 
 static int cmd_link(void)
 {
-       pstring src,dest;
-       fstring buf,buf2;
+       pstring oldname,newname;
+       pstring buf,buf2;
   
        if (!SERVER_HAS_UNIX_CIFS(cli)) {
                d_printf("Server doesn't support UNIX CIFS calls.\n");
                return 1;
        }
 
-       pstrcpy(src,cur_dir);
-       pstrcpy(dest,cur_dir);
+       pstrcpy(oldname,cur_dir);
+       pstrcpy(newname,cur_dir);
   
-       if (!next_token(NULL,buf,NULL,sizeof(buf)) || 
-           !next_token(NULL,buf2,NULL, sizeof(buf2))) {
-               d_printf("link <src> <dest>\n");
+       if (!next_token_nr(NULL,buf,NULL,sizeof(buf)) || 
+           !next_token_nr(NULL,buf2,NULL, sizeof(buf2))) {
+               d_printf("link <oldname> <newname>\n");
                return 1;
        }
 
-       pstrcat(src,buf);
-       pstrcat(dest,buf2);
+       pstrcat(oldname,buf);
+       pstrcat(newname,buf2);
 
-       if (!cli_unix_hardlink(cli, src, dest)) {
-               d_printf("%s linking files (%s -> %s)\n", cli_errstr(cli), src, dest);
+       if (!cli_unix_hardlink(cli, oldname, newname)) {
+               d_printf("%s linking files (%s -> %s)\n", cli_errstr(cli), newname, oldname);
                return 1;
        }  
 
@@ -1636,29 +1897,28 @@ static int cmd_link(void)
 
 static int cmd_symlink(void)
 {
-       pstring src,dest;
-       fstring buf,buf2;
+       pstring oldname,newname;
+       pstring buf,buf2;
   
        if (!SERVER_HAS_UNIX_CIFS(cli)) {
                d_printf("Server doesn't support UNIX CIFS calls.\n");
                return 1;
        }
 
-       pstrcpy(src,cur_dir);
-       pstrcpy(dest,cur_dir);
+       pstrcpy(newname,cur_dir);
        
-       if (!next_token(NULL,buf,NULL,sizeof(buf)) || 
-           !next_token(NULL,buf2,NULL, sizeof(buf2))) {
-               d_printf("symlink <src> <dest>\n");
+       if (!next_token_nr(NULL,buf,NULL,sizeof(buf)) || 
+           !next_token_nr(NULL,buf2,NULL, sizeof(buf2))) {
+               d_printf("symlink <oldname> <newname>\n");
                return 1;
        }
 
-       pstrcat(src,buf);
-       pstrcat(dest,buf2);
+       pstrcpy(oldname,buf);
+       pstrcat(newname,buf2);
 
-       if (!cli_unix_symlink(cli, src, dest)) {
+       if (!cli_unix_symlink(cli, oldname, newname)) {
                d_printf("%s symlinking files (%s -> %s)\n",
-                       cli_errstr(cli), src, dest);
+                       cli_errstr(cli), newname, oldname);
                return 1;
        } 
 
@@ -1673,7 +1933,7 @@ static int cmd_chmod(void)
 {
        pstring src;
        mode_t mode;
-       fstring buf, buf2;
+       pstring buf, buf2;
   
        if (!SERVER_HAS_UNIX_CIFS(cli)) {
                d_printf("Server doesn't support UNIX CIFS calls.\n");
@@ -1682,8 +1942,8 @@ static int cmd_chmod(void)
 
        pstrcpy(src,cur_dir);
        
-       if (!next_token(NULL,buf,NULL,sizeof(buf)) || 
-           !next_token(NULL,buf2,NULL, sizeof(buf2))) {
+       if (!next_token_nr(NULL,buf,NULL,sizeof(buf)) || 
+           !next_token_nr(NULL,buf2,NULL, sizeof(buf2))) {
                d_printf("chmod mode file\n");
                return 1;
        }
@@ -1700,6 +1960,334 @@ static int cmd_chmod(void)
        return 0;
 }
 
+static const char *filetype_to_str(mode_t mode)
+{
+       if (S_ISREG(mode)) {
+               return "regular file";
+       } else if (S_ISDIR(mode)) {
+               return "directory";
+       } else 
+#ifdef S_ISCHR
+       if (S_ISCHR(mode)) {
+               return "character device";
+       } else
+#endif
+#ifdef S_ISBLK
+       if (S_ISBLK(mode)) {
+               return "block device";
+       } else
+#endif
+#ifdef S_ISFIFO
+       if (S_ISFIFO(mode)) {
+               return "fifo";
+       } else
+#endif
+#ifdef S_ISLNK
+       if (S_ISLNK(mode)) {
+               return "symbolic link";
+       } else
+#endif
+#ifdef S_ISSOCK
+       if (S_ISSOCK(mode)) {
+               return "socket";
+       } else
+#endif
+       return "";
+}
+
+static char rwx_to_str(mode_t m, mode_t bt, char ret)
+{
+       if (m & bt) {
+               return ret;
+       } else {
+               return '-';
+       }
+}
+
+static char *unix_mode_to_str(char *s, mode_t m)
+{
+       char *p = s;
+       const char *str = filetype_to_str(m);
+
+       switch(str[0]) {
+               case 'd':
+                       *p++ = 'd';
+                       break;
+               case 'c':
+                       *p++ = 'c';
+                       break;
+               case 'b':
+                       *p++ = 'b';
+                       break;
+               case 'f':
+                       *p++ = 'p';
+                       break;
+               case 's':
+                       *p++ = str[1] == 'y' ? 'l' : 's';
+                       break;
+               case 'r':
+               default:
+                       *p++ = '-';
+                       break;
+       }
+       *p++ = rwx_to_str(m, S_IRUSR, 'r');
+       *p++ = rwx_to_str(m, S_IWUSR, 'w');
+       *p++ = rwx_to_str(m, S_IXUSR, 'x');
+       *p++ = rwx_to_str(m, S_IRGRP, 'r');
+       *p++ = rwx_to_str(m, S_IWGRP, 'w');
+       *p++ = rwx_to_str(m, S_IXGRP, 'x');
+       *p++ = rwx_to_str(m, S_IROTH, 'r');
+       *p++ = rwx_to_str(m, S_IWOTH, 'w');
+       *p++ = rwx_to_str(m, S_IXOTH, 'x');
+       *p++ = '\0';
+       return s;
+}
+
+/****************************************************************************
+ Utility function for UNIX getfacl.
+****************************************************************************/
+
+static char *perms_to_string(fstring permstr, unsigned char perms)
+{
+       fstrcpy(permstr, "---");
+       if (perms & SMB_POSIX_ACL_READ) {
+               permstr[0] = 'r';
+       }
+       if (perms & SMB_POSIX_ACL_WRITE) {
+               permstr[1] = 'w';
+       }
+       if (perms & SMB_POSIX_ACL_EXECUTE) {
+               permstr[2] = 'x';
+       }
+       return permstr;
+}
+
+/****************************************************************************
+ UNIX getfacl.
+****************************************************************************/
+
+static int cmd_getfacl(void)
+{
+       pstring src, name;
+       uint16 major, minor;
+       uint32 caplow, caphigh;
+       char *retbuf = NULL;
+       size_t rb_size = 0;
+       SMB_STRUCT_STAT sbuf;
+       uint16 num_file_acls = 0;
+       uint16 num_dir_acls = 0;
+       uint16 i;
+       if (!SERVER_HAS_UNIX_CIFS(cli)) {
+               d_printf("Server doesn't support UNIX CIFS calls.\n");
+               return 1;
+       }
+
+       if (!cli_unix_extensions_version(cli, &major, &minor, &caplow, &caphigh)) {
+               d_printf("Can't get UNIX CIFS version from server.\n");
+               return 1;
+       }
+
+       if (!(caplow & CIFS_UNIX_POSIX_ACLS_CAP)) {
+               d_printf("This server supports UNIX extensions but doesn't support POSIX ACLs.\n");
+               return 1;
+       }
+
+       pstrcpy(src,cur_dir);
+       
+       if (!next_token_nr(NULL,name,NULL,sizeof(name))) {
+               d_printf("stat file\n");
+               return 1;
+       }
+
+       pstrcat(src,name);
+
+       if (!cli_unix_stat(cli, src, &sbuf)) {
+               d_printf("%s getfacl doing a stat on file %s\n",
+                       cli_errstr(cli), src);
+               return 1;
+       } 
+
+       if (!cli_unix_getfacl(cli, src, &rb_size, &retbuf)) {
+               d_printf("%s getfacl file %s\n",
+                       cli_errstr(cli), src);
+               return 1;
+       } 
+
+       /* ToDo : Print out the ACL values. */
+       if (SVAL(retbuf,0) != SMB_POSIX_ACL_VERSION || rb_size < 6) {
+               d_printf("getfacl file %s, unknown POSIX acl version %u.\n",
+                       src, (unsigned int)CVAL(retbuf,0) );
+               SAFE_FREE(retbuf);
+               return 1;
+       }
+
+       num_file_acls = SVAL(retbuf,2);
+       num_dir_acls = SVAL(retbuf,4);
+       if (rb_size != SMB_POSIX_ACL_HEADER_SIZE + SMB_POSIX_ACL_ENTRY_SIZE*(num_file_acls+num_dir_acls)) {
+               d_printf("getfacl file %s, incorrect POSIX acl buffer size (should be %u, was %u).\n",
+                       src,
+                       (unsigned int)(SMB_POSIX_ACL_HEADER_SIZE + SMB_POSIX_ACL_ENTRY_SIZE*(num_file_acls+num_dir_acls)),
+                       (unsigned int)rb_size);
+
+               SAFE_FREE(retbuf);
+               return 1;
+       }
+
+       d_printf("# file: %s\n", src);
+       d_printf("# owner: %u\n# group: %u\n", (unsigned int)sbuf.st_uid, (unsigned int)sbuf.st_gid);
+
+       if (num_file_acls == 0 && num_dir_acls == 0) {
+               d_printf("No acls found.\n");
+       }
+
+       for (i = 0; i < num_file_acls; i++) {
+               uint32 uorg;
+               fstring permstring;
+               unsigned char tagtype = CVAL(retbuf, SMB_POSIX_ACL_HEADER_SIZE+(i*SMB_POSIX_ACL_ENTRY_SIZE));
+               unsigned char perms = CVAL(retbuf, SMB_POSIX_ACL_HEADER_SIZE+(i*SMB_POSIX_ACL_ENTRY_SIZE)+1);
+
+               switch(tagtype) {
+                       case SMB_POSIX_ACL_USER_OBJ:
+                               d_printf("user::");
+                               break;
+                       case SMB_POSIX_ACL_USER:
+                               uorg = IVAL(retbuf,SMB_POSIX_ACL_HEADER_SIZE+(i*SMB_POSIX_ACL_ENTRY_SIZE)+2);
+                               d_printf("user:%u:", uorg);
+                               break;
+                       case SMB_POSIX_ACL_GROUP_OBJ:
+                               d_printf("group::");
+                               break;
+                       case SMB_POSIX_ACL_GROUP:
+                               uorg = IVAL(retbuf,SMB_POSIX_ACL_HEADER_SIZE+(i*SMB_POSIX_ACL_ENTRY_SIZE)+2);
+                               d_printf("group:%u", uorg);
+                               break;
+                       case SMB_POSIX_ACL_MASK:
+                               d_printf("mask::");
+                               break;
+                       case SMB_POSIX_ACL_OTHER:
+                               d_printf("other::");
+                               break;
+                       default:
+                               d_printf("getfacl file %s, incorrect POSIX acl tagtype (%u).\n",
+                                       src, (unsigned int)tagtype );
+                               SAFE_FREE(retbuf);
+                               return 1;
+               }
+
+               d_printf("%s\n", perms_to_string(permstring, perms));
+       }
+
+       for (i = 0; i < num_dir_acls; i++) {
+               uint32 uorg;
+               fstring permstring;
+               unsigned char tagtype = CVAL(retbuf, SMB_POSIX_ACL_HEADER_SIZE+((i+num_file_acls)*SMB_POSIX_ACL_ENTRY_SIZE));
+               unsigned char perms = CVAL(retbuf, SMB_POSIX_ACL_HEADER_SIZE+((i+num_file_acls)*SMB_POSIX_ACL_ENTRY_SIZE)+1);
+
+               switch(tagtype) {
+                       case SMB_POSIX_ACL_USER_OBJ:
+                               d_printf("default:user::");
+                               break;
+                       case SMB_POSIX_ACL_USER:
+                               uorg = IVAL(retbuf,SMB_POSIX_ACL_HEADER_SIZE+((i+num_file_acls)*SMB_POSIX_ACL_ENTRY_SIZE)+2);
+                               d_printf("default:user:%u:", uorg);
+                               break;
+                       case SMB_POSIX_ACL_GROUP_OBJ:
+                               d_printf("default:group::");
+                               break;
+                       case SMB_POSIX_ACL_GROUP:
+                               uorg = IVAL(retbuf,SMB_POSIX_ACL_HEADER_SIZE+((i+num_file_acls)*SMB_POSIX_ACL_ENTRY_SIZE)+2);
+                               d_printf("default:group:%u", uorg);
+                               break;
+                       case SMB_POSIX_ACL_MASK:
+                               d_printf("default:mask::");
+                               break;
+                       case SMB_POSIX_ACL_OTHER:
+                               d_printf("default:other::");
+                               break;
+                       default:
+                               d_printf("getfacl file %s, incorrect POSIX acl tagtype (%u).\n",
+                                       src, (unsigned int)tagtype );
+                               SAFE_FREE(retbuf);
+                               return 1;
+               }
+
+               d_printf("%s\n", perms_to_string(permstring, perms));
+       }
+
+       SAFE_FREE(retbuf);
+       return 0;
+}
+
+/****************************************************************************
+ UNIX stat.
+****************************************************************************/
+
+static int cmd_stat(void)
+{
+       pstring src, name;
+       fstring mode_str;
+       SMB_STRUCT_STAT sbuf;
+       if (!SERVER_HAS_UNIX_CIFS(cli)) {
+               d_printf("Server doesn't support UNIX CIFS calls.\n");
+               return 1;
+       }
+
+       pstrcpy(src,cur_dir);
+       
+       if (!next_token_nr(NULL,name,NULL,sizeof(name))) {
+               d_printf("stat file\n");
+               return 1;
+       }
+
+       pstrcat(src,name);
+
+       if (!cli_unix_stat(cli, src, &sbuf)) {
+               d_printf("%s stat file %s\n",
+                       cli_errstr(cli), src);
+               return 1;
+       } 
+
+       /* Print out the stat values. */
+       d_printf("File: %s\n", src);
+       d_printf("Size: %-12.0f\tBlocks: %u\t%s\n",
+               (double)sbuf.st_size,
+               (unsigned int)sbuf.st_blocks,
+               filetype_to_str(sbuf.st_mode));
+
+#if defined(S_ISCHR) && defined(S_ISBLK)
+       if (S_ISCHR(sbuf.st_mode) || S_ISBLK(sbuf.st_mode)) {
+               d_printf("Inode: %.0f\tLinks: %u\tDevice type: %u,%u\n",
+                       (double)sbuf.st_ino,
+                       (unsigned int)sbuf.st_nlink,
+                       unix_dev_major(sbuf.st_rdev),
+                       unix_dev_minor(sbuf.st_rdev));
+       } else 
+#endif
+               d_printf("Inode: %.0f\tLinks: %u\n",
+                       (double)sbuf.st_ino,
+                       (unsigned int)sbuf.st_nlink);
+
+       d_printf("Access: (0%03o/%s)\tUid: %u\tGid: %u\n",
+               ((int)sbuf.st_mode & 0777),
+               unix_mode_to_str(mode_str, sbuf.st_mode),
+               (unsigned int)sbuf.st_uid, 
+               (unsigned int)sbuf.st_gid);
+
+       strftime(mode_str, sizeof(mode_str), "%F %T %z", localtime(&sbuf.st_atime));
+       d_printf("Access: %s\n", mode_str);
+
+       strftime(mode_str, sizeof(mode_str), "%F %T %z", localtime(&sbuf.st_mtime));
+       d_printf("Modify: %s\n", mode_str);
+
+       strftime(mode_str, sizeof(mode_str), "%F %T %z", localtime(&sbuf.st_ctime));
+       d_printf("Change: %s\n", mode_str);
+       
+       return 0;
+}
+
+
 /****************************************************************************
  UNIX chown.
 ****************************************************************************/
@@ -1709,7 +2297,7 @@ static int cmd_chown(void)
        pstring src;
        uid_t uid;
        gid_t gid;
-       fstring buf, buf2, buf3;
+       pstring buf, buf2, buf3;
   
        if (!SERVER_HAS_UNIX_CIFS(cli)) {
                d_printf("Server doesn't support UNIX CIFS calls.\n");
@@ -1718,9 +2306,9 @@ static int cmd_chown(void)
 
        pstrcpy(src,cur_dir);
        
-       if (!next_token(NULL,buf,NULL,sizeof(buf)) || 
-           !next_token(NULL,buf2,NULL, sizeof(buf2)) ||
-           !next_token(NULL,buf3,NULL, sizeof(buf3))) {
+       if (!next_token_nr(NULL,buf,NULL,sizeof(buf)) || 
+           !next_token_nr(NULL,buf2,NULL, sizeof(buf2)) ||
+           !next_token_nr(NULL,buf3,NULL, sizeof(buf3))) {
                d_printf("chown uid gid file\n");
                return 1;
        }
@@ -1739,12 +2327,13 @@ static int cmd_chown(void)
 }
 
 /****************************************************************************
-rename some files
+ Rename some file.
 ****************************************************************************/
+
 static int cmd_rename(void)
 {
        pstring src,dest;
-       fstring buf,buf2;
+       pstring buf,buf2;
   
        pstrcpy(src,cur_dir);
        pstrcpy(dest,cur_dir);
@@ -1766,10 +2355,39 @@ static int cmd_rename(void)
        return 0;
 }
 
+/****************************************************************************
+ Hard link files using the NT call.
+****************************************************************************/
+
+static int cmd_hardlink(void)
+{
+       pstring src,dest;
+       pstring buf,buf2;
+  
+       pstrcpy(src,cur_dir);
+       pstrcpy(dest,cur_dir);
+       
+       if (!next_token_nr(NULL,buf,NULL,sizeof(buf)) || 
+           !next_token_nr(NULL,buf2,NULL, sizeof(buf2))) {
+               d_printf("hardlink <src> <dest>\n");
+               return 1;
+       }
+
+       pstrcat(src,buf);
+       pstrcat(dest,buf2);
+
+       if (!cli_nt_hardlink(cli, src, dest)) {
+               d_printf("%s doing an NT hard link of files\n",cli_errstr(cli));
+               return 1;
+       }
+       
+       return 0;
+}
 
 /****************************************************************************
-toggle the prompt flag
+ Toggle the prompt flag.
 ****************************************************************************/
+
 static int cmd_prompt(void)
 {
        prompt = !prompt;
@@ -1778,13 +2396,13 @@ static int cmd_prompt(void)
        return 1;
 }
 
-
 /****************************************************************************
-set the newer than time
+ Set the newer than time.
 ****************************************************************************/
+
 static int cmd_newer(void)
 {
-       fstring buf;
+       pstring buf;
        BOOL ok;
        SMB_STRUCT_STAT sbuf;
 
@@ -1806,11 +2424,12 @@ static int cmd_newer(void)
 }
 
 /****************************************************************************
-set the archive level
+ Set the archive level.
 ****************************************************************************/
+
 static int cmd_archive(void)
 {
-       fstring buf;
+       pstring buf;
 
        if (next_token_nr(NULL,buf,NULL,sizeof(buf))) {
                archive_level = atoi(buf);
@@ -1821,8 +2440,9 @@ static int cmd_archive(void)
 }
 
 /****************************************************************************
-toggle the lowercaseflag
+ Toggle the lowercaseflag.
 ****************************************************************************/
+
 static int cmd_lowercase(void)
 {
        lowercase = !lowercase;
@@ -1831,12 +2451,25 @@ static int cmd_lowercase(void)
        return 0;
 }
 
+/****************************************************************************
+ Toggle the case sensitive flag.
+****************************************************************************/
 
+static int cmd_setcase(void)
+{
+       BOOL orig_case_sensitive = cli_set_case_sensitive(cli, False);
 
+       cli_set_case_sensitive(cli, !orig_case_sensitive);
+       DEBUG(2,("filename case sensitivity is now %s\n",!orig_case_sensitive ?
+               "on":"off"));
+
+       return 0;
+}
 
 /****************************************************************************
-toggle the recurse flag
+ Toggle the recurse flag.
 ****************************************************************************/
+
 static int cmd_recurse(void)
 {
        recurse = !recurse;
@@ -1846,8 +2479,9 @@ static int cmd_recurse(void)
 }
 
 /****************************************************************************
-toggle the translate flag
+ Toggle the translate flag.
 ****************************************************************************/
+
 static int cmd_translate(void)
 {
        translation = !translation;
@@ -1857,10 +2491,10 @@ static int cmd_translate(void)
        return 0;
 }
 
-
 /****************************************************************************
-do a printmode command
+ Do a printmode command.
 ****************************************************************************/
+
 static int cmd_printmode(void)
 {
        fstring buf;
@@ -1877,8 +2511,7 @@ static int cmd_printmode(void)
                }
        }
 
-       switch(printmode)
-               {
+       switch(printmode) {
                case 0: 
                        fstrcpy(mode,"text");
                        break;
@@ -1888,7 +2521,7 @@ static int cmd_printmode(void)
                default: 
                        slprintf(mode,sizeof(mode)-1,"%d",printmode);
                        break;
-               }
+       }
        
        DEBUG(2,("the printmode is now %s\n",mode));
 
@@ -1896,11 +2529,12 @@ static int cmd_printmode(void)
 }
 
 /****************************************************************************
- do the lcd command
+ Do the lcd command.
  ****************************************************************************/
+
 static int cmd_lcd(void)
 {
-       fstring buf;
+       pstring buf;
        pstring d;
        
        if (next_token_nr(NULL,buf,NULL,sizeof(buf)))
@@ -1911,8 +2545,9 @@ static int cmd_lcd(void)
 }
 
 /****************************************************************************
- get a file restarting at end of local file
+ Get a file restarting at end of local file.
  ****************************************************************************/
+
 static int cmd_reget(void)
 {
        pstring local_name;
@@ -1937,13 +2572,14 @@ static int cmd_reget(void)
 }
 
 /****************************************************************************
- put a file restarting at end of local file
+ Put a file restarting at end of local file.
  ****************************************************************************/
+
 static int cmd_reput(void)
 {
        pstring local_name;
        pstring remote_name;
-       fstring buf;
+       pstring buf;
        char *p = buf;
        SMB_STRUCT_STAT st;
        
@@ -1971,10 +2607,10 @@ static int cmd_reput(void)
        return do_put(remote_name, local_name, True);
 }
 
-
 /****************************************************************************
- list a share name
+ List a share name.
  ****************************************************************************/
+
 static void browse_fn(const char *name, uint32 m, 
                       const char *comment, void *state)
 {
@@ -1996,20 +2632,25 @@ static void browse_fn(const char *name, uint32 m,
        /* FIXME: If the remote machine returns non-ascii characters
           in any of these fields, they can corrupt the output.  We
           should remove them. */
-       d_printf("\t%-15.15s%-10.10s%s\n",
-               name,typestr,comment);
+       if (!grepable) {
+               d_printf("\t%-15s %-10.10s%s\n",
+                               name,typestr,comment);
+       } else {
+               d_printf ("%s|%s|%s\n",typestr,name,comment);
+       }
 }
 
-
 /****************************************************************************
-try and browse available connections on a host
+ Try and browse available connections on a host.
 ****************************************************************************/
+
 static BOOL browse_host(BOOL sort)
 {
        int ret;
-
-        d_printf("\n\tSharename      Type      Comment\n");
-        d_printf("\t---------      ----      -------\n");
+       if (!grepable) {
+               d_printf("\n\tSharename       Type      Comment\n");
+               d_printf("\t---------       ----      -------\n");
+       }
 
        if((ret = cli_RNetShareEnum(cli, browse_fn, NULL)) == -1)
                d_printf("Error returning browse list: %s\n", cli_errstr(cli));
@@ -2018,31 +2659,139 @@ static BOOL browse_host(BOOL sort)
 }
 
 /****************************************************************************
-list a server name
+ List a server name.
 ****************************************************************************/
+
 static void server_fn(const char *name, uint32 m, 
                       const char *comment, void *state)
 {
-        d_printf("\t%-16.16s     %s\n", name, comment);
+       
+       if (!grepable){
+               d_printf("\t%-16s     %s\n", name, comment);
+       } else {
+               d_printf("%s|%s|%s\n",(char *)state, name, comment);
+       }
+}
+
+/****************************************************************************
+ Try and browse available connections on a host.
+****************************************************************************/
+
+static BOOL list_servers(const char *wk_grp)
+{
+       fstring state;
+
+       if (!cli->server_domain)
+               return False;
+
+       if (!grepable) {
+               d_printf("\n\tServer               Comment\n");
+               d_printf("\t---------            -------\n");
+       };
+       fstrcpy( state, "Server" );
+       cli_NetServerEnum(cli, cli->server_domain, SV_TYPE_ALL, server_fn,
+                         state);
+
+       if (!grepable) {
+               d_printf("\n\tWorkgroup            Master\n");
+               d_printf("\t---------            -------\n");
+       }; 
+
+       fstrcpy( state, "Workgroup" );
+       cli_NetServerEnum(cli, cli->server_domain, SV_TYPE_DOMAIN_ENUM,
+                         server_fn, state);
+       return True;
 }
 
 /****************************************************************************
-try and browse available connections on a host
+ Print or set current VUID
 ****************************************************************************/
-static BOOL list_servers(char *wk_grp)
+
+static int cmd_vuid(void)
 {
-       if (!cli->server_domain) return False;
+       fstring buf;
        
-        d_printf("\n\tServer               Comment\n");
-        d_printf("\t---------            -------\n");
+       if (!next_token_nr(NULL,buf,NULL,sizeof(buf))) {
+               d_printf("Current VUID is %d\n", cli->vuid);
+               return 0;
+       }
 
-       cli_NetServerEnum(cli, cli->server_domain, SV_TYPE_ALL, server_fn, NULL);
+       cli->vuid = atoi(buf);
+       return 0;
+}
 
-        d_printf("\n\tWorkgroup            Master\n");
-        d_printf("\t---------            -------\n");
+/****************************************************************************
+ Setup a new VUID, by issuing a session setup
+****************************************************************************/
 
-       cli_NetServerEnum(cli, cli->server_domain, SV_TYPE_DOMAIN_ENUM, server_fn, NULL);
-       return True;
+static int cmd_logon(void)
+{
+       pstring l_username, l_password;
+       pstring buf,buf2;
+  
+       if (!next_token_nr(NULL,buf,NULL,sizeof(buf))) {
+               d_printf("logon <username> [<password>]\n");
+               return 0;
+       }
+
+       pstrcpy(l_username, buf);
+
+       if (!next_token_nr(NULL,buf2,NULL,sizeof(buf))) {
+               char *pass = getpass("Password: ");
+               if (pass) {
+                       pstrcpy(l_password, pass);
+                       got_pass = 1;
+               }
+       } else {
+               pstrcpy(l_password, buf2);
+       }
+
+       if (!cli_session_setup(cli, l_username, 
+                              l_password, strlen(l_password),
+                              l_password, strlen(l_password),
+                              lp_workgroup())) {
+               d_printf("session setup failed: %s\n", cli_errstr(cli));
+               return -1;
+       }
+
+       d_printf("Current VUID is %d\n", cli->vuid);
+       return 0;
+}
+
+
+/****************************************************************************
+ list active connections
+****************************************************************************/
+
+static int cmd_list_connect(void)
+{
+       struct client_connection *p;
+       int i;
+
+       for ( p=connections,i=0; p; p=p->next,i++ ) {
+               d_printf("%d:\tserver=%s, share=%s\n", 
+                       i, p->cli->desthost, p->cli->share );
+       }
+
+       return 0;
+}
+
+/****************************************************************************
+ display the current active client connection
+****************************************************************************/
+
+static int cmd_show_connect( void )
+{
+       struct cli_state *targetcli;
+       pstring targetpath;
+       
+       if ( !cli_resolve_path( cli, cur_dir, &targetcli, targetpath ) ) {
+               d_printf("showconnect %s: %s\n", cur_dir, cli_errstr(cli));
+               return 1;
+       }
+       
+       d_printf("//%s/%s\n", targetcli->desthost, targetcli->share);
+       return 0;
 }
 
 /* Some constants for completing filename arguments */
@@ -2062,13 +2811,13 @@ static struct
   int (*fn)(void);
   const char *description;
   char compl_args[2];      /* Completion argument info */
-} commands[] = 
-{
+} commands[] = {
   {"?",cmd_help,"[command] give help on a command",{COMPL_NONE,COMPL_NONE}},
   {"altname",cmd_altname,"<file> show alt name",{COMPL_NONE,COMPL_NONE}},
   {"archive",cmd_archive,"<level>\n0=ignore archive bit\n1=only get archive files\n2=only get archive files and reset archive bit\n3=get all files and reset archive bit",{COMPL_NONE,COMPL_NONE}},
   {"blocksize",cmd_block,"blocksize <number> (default 20)",{COMPL_NONE,COMPL_NONE}},
   {"cancel",cmd_cancel,"<jobid> cancel a print queue entry",{COMPL_NONE,COMPL_NONE}},
+  {"case_sensitive",cmd_setcase,"toggle the case sensitive flag to server",{COMPL_NONE,COMPL_NONE}},
   {"cd",cmd_cd,"[directory] change/report the remote directory",{COMPL_REMOTE,COMPL_NONE}},
   {"chmod",cmd_chmod,"<src> <mode> chmod a file using UNIX permission",{COMPL_REMOTE,COMPL_REMOTE}},
   {"chown",cmd_chown,"<src> <uid> <gid> chown a file using UNIX uids and gids",{COMPL_REMOTE,COMPL_REMOTE}},
@@ -2077,10 +2826,12 @@ static struct
   {"du",cmd_du,"<mask> computes the total size of the current directory",{COMPL_REMOTE,COMPL_NONE}},
   {"exit",cmd_quit,"logoff the server",{COMPL_NONE,COMPL_NONE}},
   {"get",cmd_get,"<remote name> [local name] get a file",{COMPL_REMOTE,COMPL_LOCAL}},
+  {"getfacl",cmd_getfacl,"<file name> get the POSIX ACL on a file (UNIX extensions only)",{COMPL_REMOTE,COMPL_LOCAL}},
+  {"hardlink",cmd_hardlink,"<src> <dest> create a Windows hard link",{COMPL_REMOTE,COMPL_REMOTE}},
   {"help",cmd_help,"[command] give help on a command",{COMPL_NONE,COMPL_NONE}},
   {"history",cmd_history,"displays the command history",{COMPL_NONE,COMPL_NONE}},
   {"lcd",cmd_lcd,"[directory] change/report the local current working directory",{COMPL_LOCAL,COMPL_NONE}},
-  {"link",cmd_link,"<src> <dest> create a UNIX hard link",{COMPL_REMOTE,COMPL_REMOTE}},
+  {"link",cmd_link,"<oldname> <newname> create a UNIX hard link",{COMPL_REMOTE,COMPL_REMOTE}},
   {"lowercase",cmd_lowercase,"toggle lowercasing of filenames for get",{COMPL_NONE,COMPL_NONE}},  
   {"ls",cmd_dir,"<mask> list the contents of the current directory",{COMPL_REMOTE,COMPL_NONE}},
   {"mask",cmd_select,"<mask> mask all filenames against this",{COMPL_REMOTE,COMPL_NONE}},
@@ -2107,22 +2858,27 @@ static struct
   {"rm",cmd_del,"<mask> delete all matching files",{COMPL_REMOTE,COMPL_NONE}},
   {"rmdir",cmd_rmdir,"<directory> remove a directory",{COMPL_NONE,COMPL_NONE}},
   {"setmode",cmd_setmode,"filename <setmode string> change modes of file",{COMPL_REMOTE,COMPL_NONE}},
-  {"symlink",cmd_symlink,"<src> <dest> create a UNIX symlink",{COMPL_REMOTE,COMPL_REMOTE}},
+  {"stat",cmd_stat,"filename Do a UNIX extensions stat call on a file",{COMPL_REMOTE,COMPL_REMOTE}},
+  {"symlink",cmd_symlink,"<oldname> <newname> create a UNIX symlink",{COMPL_REMOTE,COMPL_REMOTE}},
   {"tar",cmd_tar,"tar <c|x>[IXFqbgNan] current directory to/from <file name>",{COMPL_NONE,COMPL_NONE}},
   {"tarmode",cmd_tarmode,"<full|inc|reset|noreset> tar's behaviour towards archive bits",{COMPL_NONE,COMPL_NONE}},
   {"translate",cmd_translate,"toggle text translation for printing",{COMPL_NONE,COMPL_NONE}},
+  {"vuid",cmd_vuid,"change current vuid",{COMPL_NONE,COMPL_NONE}},
+  {"logon",cmd_logon,"establish new logon",{COMPL_NONE,COMPL_NONE}},
+  {"listconnect",cmd_list_connect,"list open connections",{COMPL_NONE,COMPL_NONE}},
+  {"showconnect",cmd_show_connect,"display the current active connection",{COMPL_NONE,COMPL_NONE}},
   
   /* Yes, this must be here, see crh's comment above. */
   {"!",NULL,"run a shell command on the local system",{COMPL_NONE,COMPL_NONE}},
   {NULL,NULL,NULL,{COMPL_NONE,COMPL_NONE}}
 };
 
-
 /*******************************************************************
-  lookup a command string in the list of commands, including 
-  abbreviations
-  ******************************************************************/
-static int process_tok(fstring tok)
+ Lookup a command string in the list of commands, including 
+ abbreviations.
+******************************************************************/
+
+static int process_tok(pstring tok)
 {
        int i = 0, matches = 0;
        int cmd=0;
@@ -2149,12 +2905,13 @@ static int process_tok(fstring tok)
 }
 
 /****************************************************************************
-help
+ Help.
 ****************************************************************************/
+
 static int cmd_help(void)
 {
        int i=0,j;
-       fstring buf;
+       pstring buf;
        
        if (next_token_nr(NULL,buf,NULL,sizeof(buf))) {
                if ((i = process_tok(buf)) >= 0)
@@ -2172,8 +2929,9 @@ static int cmd_help(void)
 }
 
 /****************************************************************************
-process a -c command string
+ Process a -c command string.
 ****************************************************************************/
+
 static int process_command_string(char *cmd)
 {
        pstring line;
@@ -2183,14 +2941,14 @@ static int process_command_string(char *cmd)
        /* establish the connection if not already */
        
        if (!cli) {
-               cli = do_connect(desthost, service);
+               cli = cli_cm_connect(desthost, service, True);
                if (!cli)
                        return 0;
        }
        
        while (cmd[0] != '\0')    {
                char *p;
-               fstring tok;
+               pstring tok;
                int i;
                
                if ((p = strchr_m(cmd, ';')) == 0) {
@@ -2198,7 +2956,8 @@ static int process_command_string(char *cmd)
                        line[1000] = '\0';
                        cmd += strlen(cmd);
                } else {
-                       if (p - cmd > 999) p = cmd + 999;
+                       if (p - cmd > 999)
+                               p = cmd + 999;
                        strncpy(line, cmd, p - cmd);
                        line[p - cmd] = '\0';
                        cmd = p + 1;
@@ -2236,7 +2995,7 @@ static void completion_remote_filter(file_info *f, const char *mask, void *state
 
        if ((info->count < MAX_COMPLETIONS - 1) && (strncmp(info->text, f->name, info->len) == 0) && (strcmp(f->name, ".") != 0) && (strcmp(f->name, "..") != 0)) {
                if ((info->dirmask[0] == 0) && !(f->mode & aDIR))
-                       info->matches[info->count] = strdup(f->name);
+                       info->matches[info->count] = SMB_STRDUP(f->name);
                else {
                        pstring tmp;
 
@@ -2247,7 +3006,7 @@ static void completion_remote_filter(file_info *f, const char *mask, void *state
                        pstrcat(tmp, f->name);
                        if (f->mode & aDIR)
                                pstrcat(tmp, "/");
-                       info->matches[info->count] = strdup(tmp);
+                       info->matches[info->count] = SMB_STRDUP(tmp);
                }
                if (info->matches[info->count] == NULL)
                        return;
@@ -2278,7 +3037,7 @@ static char **remote_completion(const char *text, int len)
        if (len >= PATH_MAX)
                return(NULL);
 
-       info.matches = (char **)malloc(sizeof(info.matches[0])*MAX_COMPLETIONS);
+       info.matches = SMB_MALLOC_ARRAY(char *,MAX_COMPLETIONS);
        if (!info.matches) return NULL;
        info.matches[0] = NULL;
 
@@ -2291,17 +3050,17 @@ static char **remote_completion(const char *text, int len)
        if (i > 0) {
                strncpy(info.dirmask, text, i+1);
                info.dirmask[i+1] = 0;
-               snprintf(dirmask, sizeof(dirmask), "%s%*s*", cur_dir, i-1, text);
+               pstr_sprintf(dirmask, "%s%*s*", cur_dir, i-1, text);
        } else
-               snprintf(dirmask, sizeof(dirmask), "%s*", cur_dir);
+               pstr_sprintf(dirmask, "%s*", cur_dir);
 
        if (cli_list(cli, dirmask, aDIR | aSYSTEM | aHIDDEN, completion_remote_filter, &info) < 0)
                goto cleanup;
 
        if (info.count == 2)
-               info.matches[0] = strdup(info.matches[1]);
+               info.matches[0] = SMB_STRDUP(info.matches[1]);
        else {
-               info.matches[0] = malloc(info.samelen+1);
+               info.matches[0] = SMB_MALLOC(info.samelen+1);
                if (!info.matches[0])
                        goto cleanup;
                strncpy(info.matches[0], info.matches[1], info.samelen);
@@ -2354,16 +3113,18 @@ static char **completion_fn(const char *text, int start, int end)
                        return NULL;
        } else {
                char **matches;
-               int i, len, samelen, count=1;
+               int i, len, samelen = 0, count=1;
 
-               matches = (char **)malloc(sizeof(matches[0])*MAX_COMPLETIONS);
-               if (!matches) return NULL;
+               matches = SMB_MALLOC_ARRAY(char *, MAX_COMPLETIONS);
+               if (!matches) {
+                       return NULL;
+               }
                matches[0] = NULL;
 
                len = strlen(text);
                for (i=0;commands[i].fn && count < MAX_COMPLETIONS-1;i++) {
                        if (strncmp(text, commands[i].name, len) == 0) {
-                               matches[count] = strdup(commands[i].name);
+                               matches[count] = SMB_STRDUP(commands[i].name);
                                if (!matches[count])
                                        goto cleanup;
                                if (count == 1)
@@ -2380,10 +3141,10 @@ static char **completion_fn(const char *text, int start, int end)
                case 1:
                        goto cleanup;
                case 2:
-                       matches[0] = strdup(matches[1]);
+                       matches[0] = SMB_STRDUP(matches[1]);
                        break;
                default:
-                       matches[0] = malloc(samelen+1);
+                       matches[0] = SMB_MALLOC(samelen+1);
                        if (!matches[0])
                                goto cleanup;
                        strncpy(matches[0], matches[1], samelen);
@@ -2393,18 +3154,18 @@ static char **completion_fn(const char *text, int start, int end)
                return matches;
 
 cleanup:
-               while (i >= 0) {
+               for (i = 0; i < count; i++)
                        free(matches[i]);
-                       i--;
-               }
+
                free(matches);
                return NULL;
        }
 }
 
 /****************************************************************************
-make sure we swallow keepalives during idle time
+ Make sure we swallow keepalives during idle time.
 ****************************************************************************/
+
 static void readline_callback(void)
 {
        fd_set fds;
@@ -2414,7 +3175,8 @@ static void readline_callback(void)
 
        t = time(NULL);
 
-       if (t - last_t < 5) return;
+       if (t - last_t < 5)
+               return;
 
        last_t = t;
 
@@ -2442,17 +3204,18 @@ static void readline_callback(void)
        cli_chkpath(cli, "\\");
 }
 
-
 /****************************************************************************
-process commands on stdin
+ Process commands on stdin.
 ****************************************************************************/
-static void process_stdin(void)
+
+static int process_stdin(void)
 {
        const char *ptr;
+       int rc = 0;
 
        while (1) {
-               fstring tok;
-               fstring the_prompt;
+               pstring tok;
+               pstring the_prompt;
                char *cline;
                pstring line;
                int i;
@@ -2476,139 +3239,25 @@ static void process_stdin(void)
                if (!next_token_nr(&ptr,tok,NULL,sizeof(tok))) continue;
 
                if ((i = process_tok(tok)) >= 0) {
-                       commands[i].fn();
+                       rc = commands[i].fn();
                } else if (i == -2) {
                        d_printf("%s: command abbreviation ambiguous\n",tok);
                } else {
                        d_printf("%s: command not found\n",tok);
                }
        }
+       return rc;
 }
 
-
-/***************************************************** 
-return a connection to a server
-*******************************************************/
-static struct cli_state *do_connect(const char *server, const char *share)
-{
-       struct cli_state *c;
-       struct nmb_name called, calling;
-       const char *server_n;
-       struct in_addr ip;
-       fstring servicename;
-       char *sharename;
-       
-       /* make a copy so we don't modify the global string 'service' */
-       fstrcpy(servicename, share);
-       sharename = servicename;
-       if (*sharename == '\\') {
-               server = sharename+2;
-               sharename = strchr_m(server,'\\');
-               if (!sharename) return NULL;
-               *sharename = 0;
-               sharename++;
-       }
-
-       server_n = server;
-       
-       zero_ip(&ip);
-
-       make_nmb_name(&calling, global_myname(), 0x0);
-       make_nmb_name(&called , server, name_type);
-
- again:
-       zero_ip(&ip);
-       if (have_ip) ip = dest_ip;
-
-       /* have to open a new connection */
-       if (!(c=cli_initialise(NULL)) || (cli_set_port(c, port) != port) ||
-           !cli_connect(c, server_n, &ip)) {
-               d_printf("Connection to %s failed\n", server_n);
-               return NULL;
-       }
-
-       c->protocol = max_protocol;
-       c->use_kerberos = use_kerberos;
-
-       if (!cli_session_request(c, &calling, &called)) {
-               char *p;
-               d_printf("session request to %s failed (%s)\n", 
-                        called.name, cli_errstr(c));
-               cli_shutdown(c);
-               if ((p=strchr_m(called.name, '.'))) {
-                       *p = 0;
-                       goto again;
-               }
-               if (strcmp(called.name, "*SMBSERVER")) {
-                       make_nmb_name(&called , "*SMBSERVER", 0x20);
-                       goto again;
-               }
-               return NULL;
-       }
-
-       DEBUG(4,(" session request ok\n"));
-
-       if (!cli_negprot(c)) {
-               d_printf("protocol negotiation failed\n");
-               cli_shutdown(c);
-               return NULL;
-       }
-
-       if (!got_pass) {
-               char *pass = getpass("Password: ");
-               if (pass) {
-                       pstrcpy(password, pass);
-               }
-       }
-
-       if (!cli_session_setup(c, username, 
-                              password, strlen(password),
-                              password, strlen(password),
-                              lp_workgroup())) {
-               /* if a password was not supplied then try again with a null username */
-               if (password[0] || !username[0] || use_kerberos ||
-                   !cli_session_setup(c, "", "", 0, "", 0, lp_workgroup())) { 
-                       d_printf("session setup failed: %s\n", cli_errstr(c));
-                       if (NT_STATUS_V(cli_nt_error(c)) == 
-                           NT_STATUS_V(NT_STATUS_MORE_PROCESSING_REQUIRED))
-                               d_printf("did you forget to run kinit?\n");
-                       cli_shutdown(c);
-                       return NULL;
-               }
-               d_printf("Anonymous login successful\n");
-       }
-
-       if (*c->server_domain) {
-               DEBUG(1,("Domain=[%s] OS=[%s] Server=[%s]\n",
-                       c->server_domain,c->server_os,c->server_type));
-       } else if (*c->server_os || *c->server_type){
-               DEBUG(1,("OS=[%s] Server=[%s]\n",
-                        c->server_os,c->server_type));
-       }               
-       
-       DEBUG(4,(" session setup ok\n"));
-
-       if (!cli_send_tconX(c, sharename, "?????",
-                           password, strlen(password)+1)) {
-               d_printf("tree connect failed: %s\n", cli_errstr(c));
-               cli_shutdown(c);
-               return NULL;
-       }
-
-       DEBUG(4,(" tconx ok\n"));
-
-       return c;
-}
-
-
 /****************************************************************************
-  process commands from the client
+ Process commands from the client.
 ****************************************************************************/
+
 static int process(char *base_directory)
 {
        int rc = 0;
 
-       cli = do_connect(desthost, service);
+       cli = cli_cm_connect(desthost, service, True);
        if (!cli) {
                return 1;
        }
@@ -2626,15 +3275,32 @@ static int process(char *base_directory)
 }
 
 /****************************************************************************
-handle a -L query
+ Handle a -L query.
 ****************************************************************************/
+
 static int do_host_query(char *query_host)
 {
-       cli = do_connect(query_host, "IPC$");
+       cli = cli_cm_connect(query_host, "IPC$", True);
        if (!cli)
                return 1;
 
        browse_host(True);
+
+       if (port != 139) {
+
+               /* Workgroups simply don't make sense over anything
+                  else but port 139... */
+
+               cli_shutdown(cli);
+               port = 139;
+               cli = cli_cm_connect(query_host, "IPC$", True);
+       }
+
+       if (cli == NULL) {
+               d_printf("NetBIOS over TCP disabled -- no workgroup available\n");
+               return 1;
+       }
+
        list_servers(lp_workgroup());
 
        cli_shutdown(cli);
@@ -2642,17 +3308,17 @@ static int do_host_query(char *query_host)
        return(0);
 }
 
-
 /****************************************************************************
-handle a tar operation
+ Handle a tar operation.
 ****************************************************************************/
+
 static int do_tar_op(char *base_directory)
 {
        int ret;
 
        /* do we already have a connection? */
        if (!cli) {
-               cli = do_connect(desthost, service);    
+               cli = cli_cm_connect(desthost, service, True);
                if (!cli)
                        return 1;
        }
@@ -2669,8 +3335,9 @@ static int do_tar_op(char *base_directory)
 }
 
 /****************************************************************************
-handle a message operation
+ Handle a message operation.
 ****************************************************************************/
+
 static int do_message_op(void)
 {
        struct in_addr ip;
@@ -2707,33 +3374,15 @@ static int do_message_op(void)
 }
 
 
-/**
- * Process "-L hostname" option.
- *
- * We don't actually do anything yet -- we just stash the name in a
- * global variable and do the query when all options have been read.
- **/
-static void remember_query_host(const char *arg,
-                               pstring query_host)
-{
-       char *slash;
-       
-       while (*arg == '\\' || *arg == '/')
-               arg++;
-       pstrcpy(query_host, arg);
-       if ((slash = strchr(query_host, '/'))
-           || (slash = strchr(query_host, '\\'))) {
-               *slash = 0;
-       }
-}
-
-
 /****************************************************************************
   main program
 ****************************************************************************/
+
  int main(int argc,char *argv[])
 {
-       fstring base_directory;
+       extern BOOL AllowDebugChange;
+       extern BOOL override_logfile;
+       pstring base_directory;
        int opt;
        pstring query_host;
        BOOL message = False;
@@ -2743,6 +3392,7 @@ static void remember_query_host(const char *arg,
        poptContext pc;
        char *p;
        int rc = 0;
+       fstring new_workgroup;
        struct poptOption long_options[] = {
                POPT_AUTOHELP
 
@@ -2758,6 +3408,7 @@ static void remember_query_host(const char *arg,
                { "command", 'c', POPT_ARG_STRING, &cmdstr, 'c', "Execute semicolon separated commands" }, 
                { "send-buffer", 'b', POPT_ARG_INT, &io_bufsize, 'b', "Changes the transmit/send buffer", "BYTES" },
                { "port", 'p', POPT_ARG_INT, &port, 'p', "Port to connect to", "PORT" },
+               { "grepable", 'g', POPT_ARG_NONE, NULL, 'g', "Produce grepable output" },
                POPT_COMMON_SAMBA
                POPT_COMMON_CONNECTION
                POPT_COMMON_CREDENTIALS
@@ -2773,14 +3424,18 @@ static void remember_query_host(const char *arg,
 
        *query_host = 0;
        *base_directory = 0;
+       
+       /* initialize the workgroup name so we can determine whether or 
+          not it was set by a command line option */
+          
+       set_global_myworkgroup( "" );
 
-       setup_logging(argv[0],True);
+        /* set default debug level to 0 regardless of what smb.conf sets */
+       setup_logging( "smbclient", True );
+       DEBUGLEVEL_CLASS[DBGC_ALL] = 1;
+       dbf = x_stderr;
+       x_setbuf( x_stderr, NULL );
 
-       if (!lp_load(dyn_CONFIGFILE,True,False,False)) {
-               fprintf(stderr, "%s: Can't load %s - run testparm to debug it\n",
-                       argv[0], dyn_CONFIGFILE);
-       }
-       
        pc = poptGetContext("smbclient", argc, (const char **) argv, long_options, 
                                POPT_CONTEXT_KEEP_FIRST);
        poptSetOtherOptionHelp(pc, "service <password>");
@@ -2796,7 +3451,8 @@ static void remember_query_host(const char *arg,
                         */
                        name_type = 0x03; 
                        pstrcpy(desthost,poptGetOptArg(pc));
-                       if( 0 == port ) port = 139;
+                       if( 0 == port )
+                               port = 139;
                        message = True;
                        break;
                case 'I':
@@ -2813,7 +3469,7 @@ static void remember_query_host(const char *arg,
                        break;
 
                case 'L':
-                       remember_query_host(poptGetOptArg(pc), query_host);
+                       pstrcpy(query_host, poptGetOptArg(pc));
                        break;
                case 't':
                        pstrcpy(term_code, poptGetOptArg(pc));
@@ -2822,20 +3478,64 @@ static void remember_query_host(const char *arg,
                        max_protocol = interpret_protocol(poptGetOptArg(pc), max_protocol);
                        break;
                case 'T':
-                       if (!tar_parseargs(argc, argv, poptGetOptArg(pc), optind)) {
-                               poptPrintUsage(pc, stderr, 0);
-                               exit(1);
+                       /* We must use old option processing for this. Find the
+                        * position of the -T option in the raw argv[]. */
+                       {
+                               int i, optnum;
+                               for (i = 1; i < argc; i++) {
+                                       if (strncmp("-T", argv[i],2)==0)
+                                               break;
+                               }
+                               i++;
+                               if (!(optnum = tar_parseargs(argc, argv, poptGetOptArg(pc), i))) {
+                                       poptPrintUsage(pc, stderr, 0);
+                                       exit(1);
+                               }
+                               /* Now we must eat (optnum - i) options - they have
+                                * been processed by tar_parseargs().
+                                */
+                               optnum -= i;
+                               for (i = 0; i < optnum; i++)
+                                       poptGetOptArg(pc);
                        }
                        break;
                case 'D':
-                       fstrcpy(base_directory,poptGetOptArg(pc));
+                       pstrcpy(base_directory,poptGetOptArg(pc));
+                       break;
+               case 'g':
+                       grepable=True;
                        break;
                }
        }
 
        poptGetArg(pc);
        
+       /*
+        * Don't load debug level from smb.conf. It should be
+        * set by cmdline arg or remain default (0)
+        */
+       AllowDebugChange = False;
+       
+       /* save the workgroup...
+       
+          FIXME!! do we need to do this for other options as well 
+          (or maybe a generic way to keep lp_load() from overwriting 
+          everything)?  */
+       
+       fstrcpy( new_workgroup, lp_workgroup() );
+       
+       if ( override_logfile )
+               setup_logging( lp_logfile(), False );
+       
+       if (!lp_load(dyn_CONFIGFILE,True,False,False)) {
+               fprintf(stderr, "%s: Can't load %s - run testparm to debug it\n",
+                       argv[0], dyn_CONFIGFILE);
+       }
+       
        load_interfaces();
+       
+       if ( strlen(new_workgroup) != 0 )
+               set_global_myworkgroup( new_workgroup );
 
        if(poptPeekArg(pc)) {
                pstrcpy(service,poptGetArg(pc));  
@@ -2849,7 +3549,7 @@ static void remember_query_host(const char *arg,
                }
        }
 
-       if (poptPeekArg(pc)) { 
+       if (poptPeekArg(pc) && !cmdline_auth_info.got_pass) { 
                cmdline_auth_info.got_pass = True;
                pstrcpy(cmdline_auth_info.password,poptGetArg(pc));  
        }
@@ -2872,7 +3572,7 @@ static void remember_query_host(const char *arg,
        use_kerberos = cmdline_auth_info.use_kerberos;
        got_pass = cmdline_auth_info.got_pass;
 
-       DEBUG( 3, ( "Client started (version %s).\n", VERSION ) );
+       DEBUG(3,("Client started (version %s).\n", SAMBA_VERSION_STRING));
 
        if (tar_type) {
                if (cmdstr)
@@ -2880,14 +3580,25 @@ static void remember_query_host(const char *arg,
                return do_tar_op(base_directory);
        }
 
-       if ((p=strchr_m(query_host,'#'))) {
-               *p = 0;
-               p++;
-               sscanf(p, "%x", &name_type);
-       }
-  
        if (*query_host) {
-               return do_host_query(query_host);
+               char *qhost = query_host;
+               char *slash;
+
+               while (*qhost == '\\' || *qhost == '/')
+                       qhost++;
+
+               if ((slash = strchr_m(qhost, '/'))
+                   || (slash = strchr_m(qhost, '\\'))) {
+                       *slash = 0;
+               }
+
+               if ((p=strchr_m(qhost, '#'))) {
+                       *p = 0;
+                       p++;
+                       sscanf(p, "%x", &name_type);
+               }
+  
+               return do_host_query(qhost);
        }
 
        if (message) {