From: Volker Lendecke <vl@samba.org>
Date: Thu, 6 Dec 2018 18:12:07 +0000 (+0100)
Subject: idmap_tdb: Use dom_sid_str_buf
X-Git-Url: http://git.samba.org/samba.git/?p=amitay%2Fsamba.git;a=commitdiff_plain;h=70b9477922ec2de81876f40bf1c8b75b085a0c3a;hp=263edf7fe96ab7b072bd3733074e44e6ab60a80b

idmap_tdb: Use dom_sid_str_buf

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/winbindd/idmap_tdb.c b/source3/winbindd/idmap_tdb.c
index b1f908e2d62..c3215c4dd9b 100644
--- a/source3/winbindd/idmap_tdb.c
+++ b/source3/winbindd/idmap_tdb.c
@@ -63,7 +63,7 @@ static int convert_fn(struct db_record *rec, void *private_data)
 	NTSTATUS status;
 	struct dom_sid sid;
 	uint32_t rid;
-	fstring keystr;
+	struct dom_sid_buf keystr;
 	fstring dom_name;
 	TDB_DATA key;
 	TDB_DATA key2;
@@ -104,8 +104,7 @@ static int convert_fn(struct db_record *rec, void *private_data)
 
 	sid_compose(&sid, &domain->sid, rid);
 
-	sid_to_fstring(keystr, &sid);
-	key2 = string_term_tdb_data(keystr);
+	key2 = string_term_tdb_data(dom_sid_str_buf(&sid, &keystr));
 
 	value = dbwrap_record_get_value(rec);