sync_passwords: Remove dirsync cookie logging for continuous operation
authorGarming Sam <garming@catalyst.net.nz>
Sun, 18 Nov 2018 22:05:59 +0000 (11:05 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 20 Nov 2018 21:14:16 +0000 (22:14 +0100)
Under normal operation, users shouldn't see giant cookies in their logs.
We still log the initial cookie retrieved from the cache database, which
should still be helpful for identifying corrupt cookies.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13686

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python/samba/netcmd/user.py

index 447f1a3..b3af8ff 100644 (file)
@@ -2121,7 +2121,8 @@ samba-tool user syncpasswords --terminate \\
             assert res_controls[0].oid == "1.2.840.113556.1.4.841"
             res_controls[0].critical = True
             self.dirsync_controls = [str(res_controls[0]), "extended_dn:1:0"]
-            log_msg("dirsyncControls: %r\n" % self.dirsync_controls)
+            # This cookie can be extremely long
+            # log_msg("dirsyncControls: %r\n" % self.dirsync_controls)
 
             modify_ldif = "dn: %s\n" % (self.cache_dn)
             modify_ldif += "changetype: modify\n"