PY3: wrap filter calls with list where list is expected
authorNoel Power <noel.power@suse.com>
Fri, 3 Aug 2018 17:45:35 +0000 (18:45 +0100)
committerAndrew Bartlett <abartlet@samba.org>
Sun, 16 Sep 2018 04:16:20 +0000 (06:16 +0200)
filter in PY2 returns list in PY3 it returns an iterator

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
selftest/selftesthelpers.py
source4/selftest/tests.py

index ab34563cc48db54dc5542b17e84a97627a35d767..7d469e3f35af284a2f180051ade4d8dd415fbc90 100644 (file)
@@ -187,7 +187,7 @@ def plansmbtorture4testsuite(name, env, options, target, modname=None):
 
 
 def smbtorture4_testsuites(prefix):
-    return filter(lambda x: x.startswith(prefix), smbtorture4_testsuite_list)
+    return list(filter(lambda x: x.startswith(prefix), smbtorture4_testsuite_list))
 
 
 smbclient3 = binpath('smbclient')
index be3ee689608e8e743fb1ce101fb2499fa40afae2..18037524627f480ee30b77c4e26efe858f1c0e2b 100755 (executable)
@@ -323,7 +323,7 @@ smb2_s3only = [
 smb2 = [x for x in smbtorture4_testsuites("smb2.") if x not in smb2_s3only]
 
 # The QFILEINFO-IPC test needs to be on ipc$
-raw = filter(lambda x: "raw.qfileinfo.ipc" not in x, smbtorture4_testsuites("raw."))
+raw = list(filter(lambda x: "raw.qfileinfo.ipc" not in x, smbtorture4_testsuites("raw.")))
 base = smbtorture4_testsuites("base.")
 
 netapi = smbtorture4_testsuites("netapi.")