vfs_fruit: use ADEDOFF_RFORK_DOT_UND offset macro in ad_convert_move_reso()
authorRalph Boehme <slow@samba.org>
Fri, 5 Oct 2018 17:15:04 +0000 (19:15 +0200)
committerRalph Boehme <slow@samba.org>
Wed, 10 Oct 2018 20:22:14 +0000 (22:22 +0200)
We really want the fixed size offset here, not a calculated one. Note
that "ad_getentryoff(ad, ADEID_FINDERI) + ADEDLEN_FINDERI" is equal to
ADEDOFF_RFORK_DOT_UND.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/modules/vfs_fruit.c

index 0aeed3a66bbba4752cf0499339e61b2966193bf3..4c710bd2f9984d031ab81842d92e17817a81621b 100644 (file)
@@ -1178,12 +1178,11 @@ static bool ad_convert_move_reso(struct adouble *ad,
                return true;
        }
 
-       memmove(map + ad_getentryoff(ad, ADEID_FINDERI) + ADEDLEN_FINDERI,
+       memmove(map + ADEDOFF_RFORK_DOT_UND,
                map + ad_getentryoff(ad, ADEID_RFORK),
                ad_getentrylen(ad, ADEID_RFORK));
 
-       ad_setentryoff(ad, ADEID_RFORK,
-                      ad_getentryoff(ad, ADEID_FINDERI) + ADEDLEN_FINDERI);
+       ad_setentryoff(ad, ADEID_RFORK, ADEDOFF_RFORK_DOT_UND);
 
        return true;
 }