Replace random() and related calls with generate_random_buffer()

Result: better seeded random numbers that are cryptographically secure
(not that it matters in this case)

Please let it be right this time...

Signed-off-by: Robin McCorkell <rmccorkell@karoshi.org.uk>
Reviewed-by: Volker Lendecke <Volker.Lendecke@SerNet.DE>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/dfs_server/dfs_server_ad.c b/dfs_server/dfs_server_ad.c
index 3d93e19c9898fb53dca8be5db66b9982289b1cad..61466329eafd66cdb8235cf5b0319d793c0bfe35 100644 (file)
--- a/dfs_server/dfs_server_ad.c
+++ b/dfs_server/dfs_server_ad.c
@@ -42,13 +42,11 @@ static void shuffle_dc_set(struct dc_set *list)
 {
        uint32_t i;
 
-       srandom(time(NULL));
-
        for (i = list->count; i > 1; i--) {
                uint32_t r;
                const char *tmp;
 
-               r = random() % i;
+               r = generate_random() % i;
 
                tmp = list->names[i - 1];
                list->names[i - 1] = list->names[r];

diff --git a/source3/smbd/msdfs.c b/source3/smbd/msdfs.c
index a39efce0689554fdc3a02ae9059fd0da24250834..e895c1f7accf4a83e74dde13705dc52cb948df5e 100644 (file)
--- a/source3/smbd/msdfs.c
+++ b/source3/smbd/msdfs.c
@@ -431,13 +431,12 @@ NTSTATUS create_conn_struct_cwd(TALLOC_CTX *ctx,
 
 static void shuffle_strlist(char **list, int count)
 {
-       int i, r;
+       int i;
+       uint32_t r;
        char *tmp;
 
-       srandom(time(NULL));
-
        for (i = count; i > 1; i--) {
-               r = random() % i;
+               r = generate_random() % i;
 
                tmp = list[i-1];
                list[i-1] = list[r];