git.samba.org
/
amitay
/
samba.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
e895b6c
)
credentials: Fix CID 1414796 Explicit null dereferenced
author
Volker Lendecke
<vl@samba.org>
Wed, 4 Apr 2018 08:26:14 +0000
(10:26 +0200)
committer
Jeremy Allison
<jra@samba.org>
Wed, 4 Apr 2018 23:10:09 +0000
(
01:10
+0200)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
auth/credentials/credentials_secrets.c
patch
|
blob
|
history
diff --git
a/auth/credentials/credentials_secrets.c
b/auth/credentials/credentials_secrets.c
index ae1d23b51c12a2210ab92fa673eeb0edfa8ab786..25c1fddf2ec8fe0cef04af0d3167811a765812bf 100644
(file)
--- a/
auth/credentials/credentials_secrets.c
+++ b/
auth/credentials/credentials_secrets.c
@@
-106,6
+106,11
@@
static NTSTATUS cli_credentials_set_secrets_lct(struct cli_credentials *cred,
}
password = ldb_msg_find_attr_as_string(msg, "secret", NULL);
+ if (password == NULL) {
+ /* This attribute is mandatory */
+ talloc_free(mem_ctx);
+ return NT_STATUS_NOT_FOUND;
+ }
whenChanged = ldb_msg_find_ldb_val(msg, "whenChanged");
if (!whenChanged || ldb_val_to_time(whenChanged, &lct) != LDB_SUCCESS) {