s3/libsmb: clang: Fix 'Value stored during its initialization is never read'
authorNoel Power <noel.power@suse.com>
Fri, 6 Sep 2019 14:59:51 +0000 (14:59 +0000)
committerJeremy Allison <jra@samba.org>
Thu, 26 Sep 2019 18:41:27 +0000 (18:41 +0000)
Fixes:

source3/libsmb/dsgetdcname.c:1012:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
        NTSTATUS status = NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND;
                 ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

source3/libsmb/dsgetdcname.c:1099:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
        NTSTATUS status = NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND;
                 ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/libsmb/dsgetdcname.c

index 08477065f349ae7fe627f9a78c30b73ebfddfc8d..06119471c2b5d2a593e8443512e57b0bf1092c36 100644 (file)
@@ -1009,7 +1009,7 @@ static NTSTATUS dsgetdcname_rediscover(TALLOC_CTX *mem_ctx,
                                       const char *site_name,
                                       struct netr_DsRGetDCNameInfo **info)
 {
-       NTSTATUS status = NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND;
+       NTSTATUS status;
        struct ip_service_name *dclist = NULL;
        int num_dcs;
 
@@ -1096,7 +1096,7 @@ static NTSTATUS dsgetdcname_internal(TALLOC_CTX *mem_ctx,
                     uint32_t flags,
                     struct netr_DsRGetDCNameInfo **info)
 {
-       NTSTATUS status = NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND;
+       NTSTATUS status;
        struct netr_DsRGetDCNameInfo *myinfo = NULL;
        bool first = true;
        struct netr_DsRGetDCNameInfo *first_info = NULL;